@needle-tools/engine 3.5.5-alpha → 3.5.6-alpha

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@needle-tools/engine",
-    "version": "3.5.5-alpha",
+    "version": "3.5.6-alpha",
     "description": "Needle Engine is a web-based runtime for 3D apps. It runs on your machine for development with great integrations into editors like Unity or Blender - and can be deployed onto any device! It is flexible, extensible and networking and XR are built-in",
     "main": "dist/needle-engine.umd.cjs",
     "type": "module",
@@ -20,8 +20,9 @@
     "scripts": {
         "dev": "npm-watch",
         "font:generate": "node plugins/generate-font.js",
-        "build": "npm run build:dist && npm run build:src",
+        "build": "npm run build:dist && npm run build:dist:light && npm run build:src",
         "build:dist": "vite build",
+        "build:dist:light": "vite build -- --light --noclear",
         "build:src": "tsc --outDir ./lib --noEmit false --declaration",
         "build:license": "node plugins/publish/create-license.mjs",
         "test:circular-imports": "node plugins/check-circular-imports.js",

package/plugins/vite/defines.js

@@ -1,20 +1,26 @@
 import { loadConfig } from "./config.js";
 import { tryGetNeedleEngineVersion } from "./utils.js";
 
+// NOTE: ALL DEFINES MUST BE SET HERE! NEVER ADD OR RELY ON DEFINES IN ANY OTHER PLUGIN
+
 /** used to pass config variables into vite.config.define
  * for example "useRapier"
  */
+
+// https://vitejs.dev/config/#using-environment-variables-in-config
+
 export const needleDefines = (command, needleEngineConfig, userSettings) => {
 
     if (!userSettings) userSettings = {};
 
     let useRapier = true;
-    if (needleEngineConfig.useRapier === false || userSettings?.useRapier === false) useRapier = false;
+    if (needleEngineConfig?.useRapier === false || userSettings?.useRapier === false) useRapier = false;
 
     return {
         name: 'needle-defines',
         enforce: 'pre',
         config(viteConfig) {
+            // console.log("Update vite defines -------------------------------------------");
             if (!viteConfig.define) viteConfig.define = {};
             viteConfig.define.NEEDLE_ENGINE_META = {
                 version: tryGetNeedleEngineVersion(),
@@ -27,7 +33,7 @@ export const needleDefines = (command, needleEngineConfig, userSettings) => {
                     useRapier = false;
                 }
             }
-            console.log("UseRapier?", useRapier);
+            // console.log("UseRapier?", useRapier);
             if (viteConfig.define.NEEDLE_USE_RAPIER === undefined) {
                 viteConfig.define.NEEDLE_USE_RAPIER = useRapier;
             }

package/src/engine/engine_components.ts

@@ -75,20 +75,25 @@ export function addNewComponent<T extends IComponent>(obj: Object3D, componentIn
 }
 
 export function moveComponentInstance(obj: Object3D, componentInstance: IComponent) {
-    if (componentInstance.gameObject === obj) return;
+    if (componentInstance.gameObject === obj) return componentInstance;
     // TODO: update raycast array
     if (componentInstance.gameObject && componentInstance.gameObject.userData.components) {
         const index = componentInstance.gameObject.userData.components.indexOf(componentInstance);
         componentInstance.gameObject.userData.components.splice(index, 1);
     }
     if (!obj.userData.components) obj.userData.components = [];
-    else if (obj.userData.components.includes(componentInstance)) return;
+    else if (obj.userData.components.includes(componentInstance)) return componentInstance;
     // TODO: do we want to disable and enable when moving?
     // componentInstance.__internalDisable();
     obj.userData.components.push(componentInstance);
     componentInstance.gameObject = obj as IGameObject;
     // componentInstance.__internalEnable();
     // componentInstance.transform = obj;
+    if (componentInstance.guid === undefined || componentInstance.guid === "invalid") {
+        componentInstance.guid = idProvider.generateUUID();
+    }
+    registerComponent(componentInstance);
+    return componentInstance;
 }
 
 

package/src/engine-components/Component.ts

@@ -273,8 +273,10 @@ export abstract class GameObject extends Object3D implements Object3D, IGameObje
 
     // these are implemented via threejs object extensions
     abstract activeSelf: boolean;
+    /** creates a new component on this gameObject */
     abstract addNewComponent<T>(type: Constructor<T>): T | null;
-    // TODO: add method for addExisting component
+    /** adds an existing component to this gameObject */
+    abstract addComponent(comp: IComponent): void;
     abstract removeComponent(comp: Component): Component;
     abstract getOrAddComponent<T>(typeName: Constructor<T> | null): T;
     abstract getComponent<T>(type: Constructor<T>): T | null;