@needle-tools/engine 3.26.1-beta → 3.26.2-beta

package/src/engine/codegen/register_types.ts

@@ -1,5 +1,5 @@
 import { TypeStore } from "./../engine_typestore.js"
-
+
 // Import types
 import { __Ignore } from "../../engine-components/codegen/components.js";
 import { ActionBuilder } from "../../engine-components/export/usdz/extensions/behavior/BehavioursBuilder.js";
@@ -219,7 +219,7 @@ import { XRGrabModel } from "../../engine-components/webxr/WebXRGrabRendering.js
 import { XRGrabRendering } from "../../engine-components/webxr/WebXRGrabRendering.js";
 import { XRRig } from "../../engine-components/webxr/WebXRRig.js";
 import { XRState } from "../../engine-components/XRFlag.js";
-
+
 // Register types
 TypeStore.add("__Ignore", __Ignore);
 TypeStore.add("ActionBuilder", ActionBuilder);

package/src/engine/engine_context.ts

@@ -930,19 +930,25 @@ export class Context implements IContext {
 		return true;
 	}
 
+	private _renderlooperrors = 0;
+
 	/** Performs a full update step including script callbacks, rendering (unless isManagedExternally is set to false) and post render callbacks */
 	public update(timestamp: DOMHighResTimeStamp, frame?: XRFrame | null) {
 		if (frame === undefined) frame = null;
 		if (isDevEnvironment() || debug || looputils.hasNewScripts()) {
 			try {
 				this.internalStep(timestamp, frame);
+				this._renderlooperrors = 0;
 			}
 			catch (err) {
-				if ((isDevEnvironment() || debug) && err instanceof Error)
-					showBalloonMessage("Exception during render-loop.<br/>See console for details.", LogType.Error);
+				this._renderlooperrors += 1;
+				if ((isDevEnvironment() || debug) && (err instanceof Error || err instanceof TypeError))
+					showBalloonMessage("Caught unhandled exception during render-loop.<br/>Stopping renderloop...<br/>See console for details.", LogType.Error);
 				console.error(err);
-				console.warn("Stopping render loop due to error")
-				this.renderer.setAnimationLoop(null);
+				if (this._renderlooperrors > 10) {
+					console.warn("Stopping render loop due to error")
+					this.renderer.setAnimationLoop(null);
+				}
 				this.domElement.dispatchEvent(new CustomEvent("error", { detail: err }));
 			}
 		}
@@ -1171,11 +1177,8 @@ export class Context implements IContext {
 		}
 		this._isRendering = true;
 		this.renderRequiredTextures();
-		// if (camera === this.mainCameraComponent?.cam) {
-		// 	if (this.mainCameraComponent.activeTexture) {
+		
 
-		// 	}
-		// }
 		if (this.composer && !this.isInXR) {
 			this.composer.render(this.time.deltaTime);
 		}

package/src/engine/engine_physics_rapier.ts

@@ -1003,6 +1003,14 @@ export class RapierPhysics implements IPhysicsEngine {
             // sync
             const pos = body.translation();
             const rot = body.rotation();
+            if (Number.isNaN(pos.x) || Number.isNaN(rot.x)) {
+                if (!col["__COLLIDER_NAN"] && isDevEnvironment()) {
+                    console.warn("Collider has NaN values", col.name, col.gameObject, body);
+                    col["__COLLIDER_NAN"] = true;
+                }
+                continue;
+            }
+            
             // make sure to keep the collider offset
             const center = obj["center"] as Vector3;
             if (center && center.isVector3) {

package/src/engine-components/OrbitControls.ts

@@ -552,6 +552,13 @@ export class OrbitControls extends Behaviour implements ICameraController {
                 // Temporary override children
                 const children_length = obj.children;
                 obj.children = emptyChildren;
+                // TODO: validate that object doesn't contain NaN values
+                const pos = obj.position;
+                const scale = obj.scale;
+                if (Number.isNaN(pos.x) || Number.isNaN(pos.y) || Number.isNaN(pos.z)) {
+                    console.warn(`Object \"${obj.name}\" has NaN values in position or scale.... will ignore it`, pos, scale);
+                    return;
+                }
                 box.expandByObject(obj, true);
                 obj.children = children_length;
             }
@@ -573,6 +580,10 @@ export class OrbitControls extends Behaviour implements ICameraController {
 
         box.getSize(size);
         box.setFromCenterAndSize(center, size);
+        if( Number.isNaN(size.x) || Number.isNaN(size.y) || Number.isNaN(size.z)){
+            console.warn("Camera fit size resultet in NaN", camera, box, [...objects]);
+            return;
+        }
         if (size.length() <= 0.0000000001) {
             if (debugCameraFit) console.warn("Camera fit size is zero", box, [...objects]);
             return;