@needle-tools/engine 3.2.10-alpha → 3.2.11-alpha

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@needle-tools/engine",
-    "version": "3.2.10-alpha",
+    "version": "3.2.11-alpha",
     "description": "Needle Engine is a web-based runtime for 3D apps. It runs on your machine for development with great integrations into editors like Unity or Blender - and can be deployed onto any device! It is flexible, extensible and networking and XR are built-in",
     "main": "dist/needle-engine.umd.cjs",
     "type": "module",

package/src/engine/engine_mainloop_utils.ts

@@ -167,11 +167,14 @@ export function processStart(context: IContext, object?: Object3D) {
             // keep them in queue until script has started
             // call awake if the script was inactive before
             utils.safeInvoke(script.__internalAwake.bind(script));
-            utils.safeInvoke(script.__internalEnable.bind(script));
-            // now call start
-            utils.safeInvoke(script.__internalStart.bind(script));
-            context.new_script_start.splice(i, 1);
-            i--;
+            if(script.enabled)
+            {
+                utils.safeInvoke(script.__internalEnable.bind(script));
+                // now call start
+                utils.safeInvoke(script.__internalStart.bind(script));
+                context.new_script_start.splice(i, 1);
+                i--;
+            }
         }
         catch (err) {
             console.error(err);
@@ -274,7 +277,7 @@ function updateIsActiveInHierarchyRecursiveRuntime(go: Object3D, activeInHierarc
                     }
                 }
                 else {
-                    if (comp["__didAwake"]) {
+                    if (comp["__didAwake"] && comp.enabled) {
                         comp["__didEnable"] = false;
                         comp.onDisable();
                     }

package/src/engine/extensions/NEEDLE_lighting_settings.ts

@@ -75,7 +75,7 @@ export class NEEDLE_lighting_settings implements GLTFLoaderPlugin {
 ContextRegistry.registerCallback(ContextEvent.ContextCreated, e => {
     const ctx = e.context as Context;
     const lightingSettings = GameObject.findObjectOfType(SceneLightSettings, ctx as Context);
-    if (lightingSettings?.sourceId) ctx.sceneLighting.enable(lightingSettings.sourceId);
+    if (lightingSettings?.sourceId) lightingSettings.enabled = true;
 })
 
 // exists once per gltf scene root (if it contains reflection)
@@ -130,7 +130,7 @@ export class SceneLightSettings extends Behaviour {
     }
 
     onEnable(): void {
-        if (debug) console.warn("💡🟡 >>> Enable lighting", this.sourceId, this);
+        if (debug) console.warn("💡🟡 >>> Enable lighting", this.sourceId, this.enabled, this);
 
         if (this.ambientMode == AmbientMode.Flat) {
             if (this.ambientLight && !this._ambientLightObj) {