@needle-tools/engine 3.19.3 → 3.19.4

package/src/engine-components/Animation.ts

@@ -41,12 +41,12 @@ export class Animation extends Behaviour {
     }
     set clip(val: AnimationClip | null) {
         if (!this.__didAwake) {
-            if (debug) console.log("Assign clip during serialization", val);
+            if (debug) console.warn("Assign clip during serialization", val);
             this._tempAnimationClipBeforeGameObjectExisted = val;
             return;
         }
         if (!val) return;
-        if (debug) console.log("Assign clip", val, Boolean(this.gameObject));
+        // if (debug) console.log("Assign clip", val, Boolean(this.gameObject));
         if (!this.gameObject.animations) this.gameObject.animations = [];
         if (this.animations.includes(val)) return;
         if (this.animations.length > 0) {
@@ -62,7 +62,8 @@ export class Animation extends Behaviour {
     }
 
     set animations(animations: AnimationClip[]) {
-        if (debug) console.log("assign animations", animations);
+        if(animations === null || animations === undefined || !Array.isArray(animations)) return;
+        // if (debug) console.warn("assign animations", this.name, animations, this.gameObject);
         this.gameObject.animations = animations;
     }
 
@@ -98,7 +99,7 @@ export class Animation extends Behaviour {
     private _handles: AnimationHandle[] = [];
 
     awake() {
-        if (debug) console.log(this);
+        if (debug) console.log("Animation Awake", this.name, this);
         if (this._tempAnimationClipBeforeGameObjectExisted) {
             this.clip = this._tempAnimationClipBeforeGameObjectExisted;
             this._tempAnimationClipBeforeGameObjectExisted = null;

package/src/engine-components/OrbitControls.ts

@@ -440,7 +440,8 @@ export class OrbitControls extends Behaviour implements ICameraController {
             // If we encountered some geometry that should be ignored
             // Then we don't want to use that for expanding the view
             if (allowExpanding) {
-                console.log(obj.name, obj.type, obj);
+                if (debugCameraFit)
+                    console.log(obj.name, obj.type, obj);
                 // Temporary override children
                 const children_length = obj.children;
                 obj.children = emptyChildren;

package/src/engine-components/VideoPlayer.ts

@@ -45,8 +45,6 @@ export enum VideoRenderMode {
 
 export class VideoPlayer extends Behaviour {
 
-    @serializable(Object3D)
-    renderer: Object3D | null = null;
     @serializable()
     playOnAwake: boolean = true;
 
@@ -166,8 +164,8 @@ export class VideoPlayer extends Behaviour {
 
     private _crossOrigin: string | null = "anonymous";
 
-
-    private source!: VideoSource;
+    // set a default src, this should not be undefined
+    private source: VideoSource = VideoSource.Url;
     private url?: string | null = null;
 
     private _videoElement: HTMLVideoElement | null = null;
@@ -207,6 +205,7 @@ export class VideoPlayer extends Behaviour {
     }
 
     onEnable(): void {
+        if(debug) console.log("VideoPlayer.onEnable", this)
         window.addEventListener('visibilitychange', this.visibilityChanged);
 
         if (this.playOnAwake === true) {
@@ -316,7 +315,10 @@ export class VideoPlayer extends Behaviour {
                 break;
         }
 
-        if (!src) return;
+        if (!src) {
+            if(debug) console.warn("No video source set", this);
+            return;
+        }
 
 
         if (!this._videoElement) {

package/src/engine-components/timeline/PlayableDirector.ts

@@ -325,9 +325,11 @@ export class PlayableDirector extends Behaviour {
                         const binding = track.outputs[i];
                         if (typeof binding === "object") {
                             let isActive: boolean = false;
-                            for (const clip of track.clips) {
-                                if (clip.start <= time && time <= clip.end) {
-                                    isActive = true;
+                            if (track.clips) {
+                                for (const clip of track.clips) {
+                                    if (clip.start <= time && time <= clip.end) {
+                                        isActive = true;
+                                    }
                                 }
                             }
                             const obj = binding as THREE.Object3D;
@@ -411,20 +413,22 @@ export class PlayableDirector extends Behaviour {
                 }
             }
             if (track.type === Models.TrackType.Control) {
-                for (let i = 0; i < track.clips.length; i++) {
-                    const clip = track.clips[i];
-                    let binding = clip.asset.sourceObject;
-                    if (typeof binding === "string") {
-                        if (this._guidsMap && this._guidsMap[binding])
-                            binding = this._guidsMap[binding];
-                        const obj = GameObject.findByGuid(binding, root);
-                        if (obj === null || typeof obj !== "object") {
-                            console.warn("Failed to resolve sourceObject binding", binding, track.name, clip);
-                        }
-                        else {
-                            if (debug)
-                                console.log("Resolved binding", binding, "to", obj);
-                            clip.asset.sourceObject = obj;
+                if (track.clips) {
+                    for (let i = 0; i < track.clips.length; i++) {
+                        const clip = track.clips[i];
+                        let binding = clip.asset.sourceObject;
+                        if (typeof binding === "string") {
+                            if (this._guidsMap && this._guidsMap[binding])
+                                binding = this._guidsMap[binding];
+                            const obj = GameObject.findByGuid(binding, root);
+                            if (obj === null || typeof obj !== "object") {
+                                console.warn("Failed to resolve sourceObject binding", binding, track.name, clip);
+                            }
+                            else {
+                                if (debug)
+                                    console.log("Resolved binding", binding, "to", obj);
+                                clip.asset.sourceObject = obj;
+                            }
                         }
                     }
                 }
@@ -443,11 +447,15 @@ export class PlayableDirector extends Behaviour {
         if (!this.playableAsset || !this.playableAsset.tracks) return;
         for (const track of this.playableAsset.tracks) {
             if (track.muted === true) continue;
-            for (const clip of track.clips) {
-                if (clip.end > this._duration) this._duration = clip.end;
+            if (track.clips) {
+                for (const clip of track.clips) {
+                    if (clip.end > this._duration) this._duration = clip.end;
+                }
             }
-            for (const marker of track.markers) {
-                if (marker.time > this._duration) this._duration = marker.time + .001;
+            if (track.markers) {
+                for (const marker of track.markers) {
+                    if (marker.time > this._duration) this._duration = marker.time + .001;
+                }
             }
         }
         // console.log("timeline duration", this._duration, this.playableAsset);
@@ -474,7 +482,7 @@ export class PlayableDirector extends Behaviour {
             }
             // only handle animation tracks
             if (track.type === Models.TrackType.Animation) {
-                if (track.clips.length <= 0) {
+                if (!track.clips || track.clips.length <= 0) {
                     if (debug) console.warn("Animation track has no clips", track);
                     continue;
                 }
@@ -533,7 +541,7 @@ export class PlayableDirector extends Behaviour {
                 }
             }
             else if (track.type === Models.TrackType.Audio) {
-                if (track.clips.length <= 0) continue;
+                if (!track.clips || track.clips.length <= 0) continue;
                 const audio = new Tracks.AudioTrackHandler();
                 audio.director = this;
                 audio.track = track;
@@ -549,12 +557,14 @@ export class PlayableDirector extends Behaviour {
                 const signalHandler: Tracks.SignalTrackHandler = new Tracks.SignalTrackHandler();
                 signalHandler.director = this;
                 signalHandler.track = track;
-                for (const marker of track.markers) {
-                    switch (marker.type) {
-                        case Models.MarkerType.Signal:
-                            signalHandler.models.push(marker as Models.SignalMarkerModel);
-                            signalHandler.didTrigger.push(false);
-                            break;
+                if (track.markers) {
+                    for (const marker of track.markers) {
+                        switch (marker.type) {
+                            case Models.MarkerType.Signal:
+                                signalHandler.models.push(marker as Models.SignalMarkerModel);
+                                signalHandler.didTrigger.push(false);
+                                break;
+                        }
                     }
                 }
                 if (signalHandler !== null && signalHandler.models.length > 0) {
@@ -569,9 +579,11 @@ export class PlayableDirector extends Behaviour {
                 const handler = new Tracks.SignalTrackHandler();
                 handler.director = this;
                 handler.track = track;
-                for (const marker of track.markers) {
-                    handler.models.push(marker as Models.SignalMarkerModel);
-                    handler.didTrigger.push(false);
+                if (track.markers) {
+                    for (const marker of track.markers) {
+                        handler.models.push(marker as Models.SignalMarkerModel);
+                        handler.didTrigger.push(false);
+                    }
                 }
                 for (const bound of track.outputs) {
                     handler.receivers.push(bound as SignalReceiver);
@@ -582,8 +594,10 @@ export class PlayableDirector extends Behaviour {
                 const handler = new Tracks.ControlTrackHandler();
                 handler.director = this;
                 handler.track = track;
-                for (const clip of track.clips) {
-                    handler.models.push(clip);
+                if (track.clips) {
+                    for (const clip of track.clips) {
+                        handler.models.push(clip);
+                    }
                 }
                 handler.resolveSourceObjects(this.context);
                 this._controlTracks.push(handler);

package/src/engine-components/timeline/TimelineModels.ts

@@ -28,8 +28,8 @@ export declare type TrackModel = {
     type: TrackType;
     muted: boolean;
     outputs: Array<null | string | object>;
-    clips: Array<ClipModel>;
-    markers: Array<MarkerModel>;
+    clips?: Array<ClipModel>;
+    markers?: Array<MarkerModel>;
     trackOffset?: TrackOffset;
 }