@needle-tools/engine 2.67.16-pre → 2.67.16

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@needle-tools/engine",
-    "version": "2.67.16-pre",
+    "version": "2.67.16",
     "description": "Needle Engine is a web-based runtime for 3D apps. It runs on your machine for development, and can be deployed anywhere. It is flexible, extensible, and collaboration and XR come naturally.",
     "main": "dist/needle-engine.umd.cjs",
     "module": "lib/needle-engine.js",

package/src/engine/codegen/register_types.js

@@ -1,5 +1,5 @@
 import { TypeStore } from "./../engine_typestore"
-
+
 // Import types
 import { __Ignore } from "../../engine-components/codegen/components";
 import { AlignmentConstraint } from "../../engine-components/AlignmentConstraint";
@@ -179,7 +179,7 @@ import { XRGrabModel } from "../../engine-components/WebXRGrabRendering";
 import { XRGrabRendering } from "../../engine-components/WebXRGrabRendering";
 import { XRRig } from "../../engine-components/WebXRRig";
 import { XRState } from "../../engine-components/XRFlag";
-
+
 // Register types
 TypeStore.add("__Ignore", __Ignore);
 TypeStore.add("AlignmentConstraint", AlignmentConstraint);

package/src/engine-components/postprocessing/Effects/DepthOfField.ts

@@ -1,11 +1,10 @@
 import { DepthOfFieldEffect } from "postprocessing";
-import { PerspectiveCamera, Vector3 } from "three";
-import { getWorldPosition } from "../../../engine/engine_three_utils";
 import { serializable } from "../../../engine/engine_serialization";
 import { Mathf } from "../../../engine/engine_math";
 import { PostProcessingEffect } from "../PostProcessingEffect";
 import { VolumeParameter } from "../VolumeParameter";
 import { registerCustomEffectType } from "../VolumeProfile";
+import { isMobileDevice } from "../../../engine/engine_utils";
 
 export enum DepthOfFieldMode {
     Off = 0,
@@ -20,7 +19,7 @@ export class DepthOfField extends PostProcessingEffect {
     }
 
     @serializable()
-    mode! : DepthOfFieldMode;
+    mode!: DepthOfFieldMode;
 
     @serializable(VolumeParameter)
     focusDistance!: VolumeParameter;
@@ -34,13 +33,16 @@ export class DepthOfField extends PostProcessingEffect {
     @serializable(VolumeParameter)
     gaussianMaxRadius!: VolumeParameter;
 
+    @serializable(VolumeParameter)
+    resolutionScale?: VolumeParameter;
+
     init() {
         this.focalLength.valueProcessor = v => {
             const t = v / 300;
             const max = 2;// this.context.mainCameraComponent?.farClipPlane ?? 10;
             return Mathf.lerp(max, .01, t);
         };
-        
+
         const maxBokehScale = 20;
         this.aperture.valueProcessor = v => {
             const t = 1 - v / 32;
@@ -49,7 +51,16 @@ export class DepthOfField extends PostProcessingEffect {
     }
 
     onCreateEffect() {
-        if(this.mode === DepthOfFieldMode.Off) return undefined;
+        if (this.mode === DepthOfFieldMode.Off) return undefined;
+
+        const factor = 1 / window.devicePixelRatio;
+
+        if (this.resolutionScale === undefined) {
+            let defaultValue = 1;
+            if(isMobileDevice()) defaultValue = .6;
+            this.resolutionScale = new VolumeParameter(defaultValue * factor);
+        }
+
         // console.log(this.focusDistance.overrideState, this.focusDistance.value);
         // const depth = new DepthEffect({
         //     inverted: true,
@@ -59,7 +70,7 @@ export class DepthOfField extends PostProcessingEffect {
             worldFocusRange: .2,
             focalLength: 1,
             bokehScale: 20,
-            resolutionScale: 1,
+            resolutionScale: this.resolutionScale.value,
         });
 
         this.focusDistance.onValueChanged = v => {
@@ -68,6 +79,7 @@ export class DepthOfField extends PostProcessingEffect {
         this.focalLength.onValueChanged = v => dof.circleOfConfusionMaterial.worldFocusRange = v;
         this.aperture.onValueChanged = v => dof.bokehScale = v;
 
+        if (this.resolutionScale) this.resolutionScale.onValueChanged = v => dof.resolution.scale = v;
 
         return [dof];
     }

package/src/engine-components/postprocessing/VolumeParameter.ts

@@ -5,6 +5,11 @@ export declare type VolumeParameterValueProcessor = (value: any) => any;
 
 export class VolumeParameter {
 
+    constructor(value?: any) {
+        this._value = value;
+        this._defaultValue = value;
+    }
+
     @serializable()
     get overrideState(): boolean {
         return this._active;