@neat.is/core 0.4.4 → 0.4.5

package/dist/cli.cjs

@@ -301,12 +301,15 @@ function parseOtlpRequest(body) {
   const out = [];
   for (const rs of body.resourceSpans ?? []) {
     const resourceAttrs = attrsToRecord(rs.resource?.attributes);
-    const service = typeof resourceAttrs["service.name"] === "string" ? resourceAttrs["service.name"] : "unknown";
+    const rawServiceName = resourceAttrs["service.name"];
+    const resourceServiceNamePresent = typeof rawServiceName === "string" && rawServiceName.length > 0;
+    const service = resourceServiceNamePresent ? rawServiceName : "unidentified";
     for (const ss of rs.scopeSpans ?? []) {
       for (const span of ss.spans ?? []) {
         const attrs = attrsToRecord(span.attributes);
         const parsed = {
           service,
+          resourceServiceNamePresent,
           traceId: span.traceId ?? "",
           spanId: span.spanId ?? "",
           parentSpanId: span.parentSpanId || void 0,
@@ -1620,6 +1623,14 @@ function thresholdForEdgeType(edgeType, overrides) {
 function nowIso(ctx) {
   return new Date(ctx.now ? ctx.now() : Date.now()).toISOString();
 }
+var unidentifiedWarnedProjects = /* @__PURE__ */ new Set();
+function warnUnidentifiedSpan(project) {
+  if (unidentifiedWarnedProjects.has(project)) return;
+  unidentifiedWarnedProjects.add(project);
+  console.warn(
+    `[neatd] span lacked service.name; routed to 'unidentified' in project ${project}; check your OTel SDK config.`
+  );
+}
 function pickAttr(span, ...keys) {
   for (const k of keys) {
     const v = span.attributes[k];
@@ -1874,6 +1885,9 @@ async function handleSpan(ctx, span) {
   const ts = span.startTimeIso ?? nowIso(ctx);
   const nowMs = ctx.now ? ctx.now() : Date.now();
   const env = span.env ?? "unknown";
+  if (span.resourceServiceNamePresent === false) {
+    warnUnidentifiedSpan(ctx.project ?? DEFAULT_PROJECT);
+  }
   const sourceId = ensureServiceNode(ctx.graph, span.service, env);
   const isError = span.statusCode === 2;
   cacheSpanService(span, nowMs);
@@ -6559,22 +6573,40 @@ var OTEL_INIT_CJS = `${OTEL_INIT_HEADER}
 process.env.OTEL_SERVICE_NAME ||= '__SERVICE_NAME__'
 process.env.OTEL_EXPORTER_OTLP_TRACES_ENDPOINT ||= 'http://localhost:4318/projects/__PROJECT__/v1/traces'
 
-require('@opentelemetry/auto-instrumentations-node/register')
+const { NodeSDK } = require('@opentelemetry/sdk-node')
+const { getNodeAutoInstrumentations } = require('@opentelemetry/auto-instrumentations-node')
+
+const instrumentations = [getNodeAutoInstrumentations()]
+__INSTRUMENTATION_BLOCK__
+new NodeSDK({ instrumentations }).start()
 `;
 var OTEL_INIT_ESM = `${OTEL_INIT_HEADER}
 process.env.OTEL_SERVICE_NAME ||= '__SERVICE_NAME__'
 process.env.OTEL_EXPORTER_OTLP_TRACES_ENDPOINT ||= 'http://localhost:4318/projects/__PROJECT__/v1/traces'
 
-await import('@opentelemetry/auto-instrumentations-node/register')
+import { NodeSDK } from '@opentelemetry/sdk-node'
+import { getNodeAutoInstrumentations } from '@opentelemetry/auto-instrumentations-node'
+
+const instrumentations = [getNodeAutoInstrumentations()]
+__INSTRUMENTATION_BLOCK__
+new NodeSDK({ instrumentations }).start()
 `;
 var OTEL_INIT_TS = `${OTEL_INIT_HEADER}
 process.env.OTEL_SERVICE_NAME ||= '__SERVICE_NAME__'
 process.env.OTEL_EXPORTER_OTLP_TRACES_ENDPOINT ||= 'http://localhost:4318/projects/__PROJECT__/v1/traces'
 
-await import('@opentelemetry/auto-instrumentations-node/register')
+import { NodeSDK } from '@opentelemetry/sdk-node'
+import { getNodeAutoInstrumentations } from '@opentelemetry/auto-instrumentations-node'
+
+const instrumentations = [getNodeAutoInstrumentations()]
+__INSTRUMENTATION_BLOCK__
+new NodeSDK({ instrumentations }).start()
 `;
-function renderNodeOtelInit(template, serviceName, projectName) {
-  return template.replace(/__SERVICE_NAME__/g, serviceName).replace(/__PROJECT__/g, projectName);
+function renderNodeOtelInit(template, serviceName, projectName, registrations = []) {
+  const block = registrations.length === 0 ? "" : `
+${registrations.join("\n")}
+`;
+  return template.replace(/__SERVICE_NAME__/g, serviceName).replace(/__PROJECT__/g, projectName).replace(/__INSTRUMENTATION_BLOCK__\n?/g, block);
 }
 function renderEnvNeat(serviceName, projectName) {
   return [
@@ -6606,7 +6638,9 @@ process.env.OTEL_EXPORTER_OTLP_TRACES_ENDPOINT ||= 'http://localhost:4318/projec
 import { NodeSDK } from '@opentelemetry/sdk-node'
 import { getNodeAutoInstrumentations } from '@opentelemetry/auto-instrumentations-node'
 
-new NodeSDK({ instrumentations: [getNodeAutoInstrumentations()] }).start()
+const instrumentations = [getNodeAutoInstrumentations()]
+__INSTRUMENTATION_BLOCK__
+new NodeSDK({ instrumentations }).start()
 `;
 var NEXT_INSTRUMENTATION_NODE_JS = `${NEXT_INSTRUMENTATION_HEADER}
 process.env.OTEL_SERVICE_NAME ||= '__SERVICE_NAME__'
@@ -6615,10 +6649,15 @@ process.env.OTEL_EXPORTER_OTLP_TRACES_ENDPOINT ||= 'http://localhost:4318/projec
 const { NodeSDK } = require('@opentelemetry/sdk-node')
 const { getNodeAutoInstrumentations } = require('@opentelemetry/auto-instrumentations-node')
 
-new NodeSDK({ instrumentations: [getNodeAutoInstrumentations()] }).start()
+const instrumentations = [getNodeAutoInstrumentations()]
+__INSTRUMENTATION_BLOCK__
+new NodeSDK({ instrumentations }).start()
 `;
-function renderNextInstrumentationNode(template, serviceName, projectName) {
-  return template.replace(/__SERVICE_NAME__/g, serviceName).replace(/__PROJECT__/g, projectName);
+function renderNextInstrumentationNode(template, serviceName, projectName, registrations = []) {
+  const block = registrations.length === 0 ? "" : `
+${registrations.join("\n")}
+`;
+  return template.replace(/__SERVICE_NAME__/g, serviceName).replace(/__PROJECT__/g, projectName).replace(/__INSTRUMENTATION_BLOCK__\n?/g, block);
 }
 var FRAMEWORK_OTEL_INIT_HEADER = "// Generated by `neat init --apply` (ADR-074). OpenTelemetry SDK hook.";
 var FRAMEWORK_OTEL_INIT_TS_BODY = `${FRAMEWORK_OTEL_INIT_HEADER}
@@ -6714,6 +6753,18 @@ var SDK_PACKAGES = [
   { name: "@opentelemetry/sdk-node", version: "^0.57.0" },
   { name: "@opentelemetry/auto-instrumentations-node", version: "^0.55.0" }
 ];
+function detectNonBundledInstrumentations(pkg) {
+  const deps = allDeps(pkg);
+  const out = [];
+  if ("@prisma/client" in deps) {
+    out.push({
+      pkg: "@prisma/instrumentation",
+      version: "^5.0.0",
+      registration: "instrumentations.push(new (require('@prisma/instrumentation').PrismaInstrumentation)())"
+    });
+  }
+  return out;
+}
 var OTEL_ENV = {
   // ADR-069 §4 — endpoint moves into the per-package .env.neat (written
   // by the apply phase). The envEdits surface stays for the dry-run
@@ -7004,8 +7055,19 @@ async function planNext(serviceDir, pkg, manifestPath, nextConfigPath, project)
       version: sdk.version
     });
   }
+  const nonBundled = detectNonBundledInstrumentations(pkg);
+  for (const inst of nonBundled) {
+    if (inst.pkg in existingDeps) continue;
+    dependencyEdits.push({
+      file: manifestPath,
+      kind: "add",
+      name: inst.pkg,
+      version: inst.version
+    });
+  }
   const svcName = serviceNodeName(pkg, serviceDir);
   const projectName = projectToken(pkg, serviceDir, project);
+  const registrations = nonBundled.map((i) => i.registration);
   const generatedFiles = [];
   if (!await exists2(instrumentationFile)) {
     generatedFiles.push({
@@ -7020,7 +7082,8 @@ async function planNext(serviceDir, pkg, manifestPath, nextConfigPath, project)
       contents: renderNextInstrumentationNode(
         useTs ? NEXT_INSTRUMENTATION_NODE_TS : NEXT_INSTRUMENTATION_NODE_JS,
         svcName,
-        projectName
+        projectName,
+        registrations
       ),
       skipIfExists: true
     });
@@ -7370,55 +7433,73 @@ async function planAstro(serviceDir, pkg, manifestPath, project) {
     framework: "astro"
   };
 }
-async function plan(serviceDir, opts) {
-  const pkg = await readPackageJson(serviceDir);
-  const manifestPath = import_node_path40.default.join(serviceDir, "package.json");
-  const project = opts?.project;
-  const empty = {
-    language: "javascript",
-    serviceDir,
-    dependencyEdits: [],
-    entrypointEdits: [],
-    envEdits: [],
-    generatedFiles: []
-  };
-  if (!pkg) return empty;
+async function findFrameworkDispatch(serviceDir, pkg, manifestPath, project) {
   if (hasNextDependency(pkg)) {
     const nextConfig = await findNextConfig(serviceDir);
     if (nextConfig) {
-      return planNext(serviceDir, pkg, manifestPath, nextConfig, project);
+      return () => planNext(serviceDir, pkg, manifestPath, nextConfig, project);
     }
   }
   if (hasRemixDependency(pkg)) {
     const remixEntry = await findRemixEntry(serviceDir);
     if (remixEntry) {
-      return planRemix(serviceDir, pkg, manifestPath, remixEntry, project);
+      return () => planRemix(serviceDir, pkg, manifestPath, remixEntry, project);
     }
   }
   if (hasSvelteKitDependency(pkg)) {
     const hooks = await findSvelteKitHooks(serviceDir);
     const config = await findSvelteKitConfig(serviceDir);
     if (hooks || config) {
-      return planSvelteKit(serviceDir, pkg, manifestPath, hooks, project);
+      return () => planSvelteKit(serviceDir, pkg, manifestPath, hooks, project);
     }
   }
   if (hasNuxtDependency(pkg)) {
     const nuxtConfig = await findNuxtConfig(serviceDir);
     if (nuxtConfig) {
-      return planNuxt(serviceDir, pkg, manifestPath, project);
+      return () => planNuxt(serviceDir, pkg, manifestPath, project);
     }
   }
   if (hasAstroDependency(pkg)) {
     const astroConfig = await findAstroConfig(serviceDir);
     if (astroConfig) {
-      return planAstro(serviceDir, pkg, manifestPath, project);
+      return () => planAstro(serviceDir, pkg, manifestPath, project);
+    }
+  }
+  return null;
+}
+async function plan(serviceDir, opts) {
+  const pkg = await readPackageJson(serviceDir);
+  const manifestPath = import_node_path40.default.join(serviceDir, "package.json");
+  const project = opts?.project;
+  const empty = {
+    language: "javascript",
+    serviceDir,
+    dependencyEdits: [],
+    entrypointEdits: [],
+    envEdits: [],
+    generatedFiles: []
+  };
+  if (!pkg) return empty;
+  const frameworkDispatch = await findFrameworkDispatch(
+    serviceDir,
+    pkg,
+    manifestPath,
+    project
+  );
+  let entryFile = null;
+  if (!frameworkDispatch) {
+    entryFile = await resolveEntry(serviceDir, pkg);
+    if (!entryFile) {
+      return { ...empty, libOnly: true };
     }
   }
+  if (frameworkDispatch) {
+    return frameworkDispatch();
+  }
   const runtimeKind = await detectRuntimeKind(serviceDir, pkg);
   if (runtimeKind !== "node") {
     return { ...empty, runtimeKind };
   }
-  const entryFile = await resolveEntry(serviceDir, pkg);
   if (!entryFile) {
     return { ...empty, libOnly: true };
   }
@@ -7436,6 +7517,16 @@ async function plan(serviceDir, opts) {
       version: sdk.version
     });
   }
+  const nonBundled = detectNonBundledInstrumentations(pkg);
+  for (const inst of nonBundled) {
+    if (inst.pkg in existingDeps) continue;
+    dependencyEdits.push({
+      file: manifestPath,
+      kind: "add",
+      name: inst.pkg,
+      version: inst.version
+    });
+  }
   const entrypointEdits = [];
   try {
     const raw = await import_node_fs25.promises.readFile(entryFile, "utf8");
@@ -7454,11 +7545,17 @@ async function plan(serviceDir, opts) {
   }
   const svcName = serviceNodeName(pkg, serviceDir);
   const projectName = projectToken(pkg, serviceDir, project);
+  const registrations = nonBundled.map((i) => i.registration);
   const generatedFiles = [];
   if (!await exists2(otelInitFile)) {
     generatedFiles.push({
       file: otelInitFile,
-      contents: renderNodeOtelInit(otelInitContents(flavor), svcName, projectName),
+      contents: renderNodeOtelInit(
+        otelInitContents(flavor),
+        svcName,
+        projectName,
+        registrations
+      ),
       skipIfExists: true
     });
   }
@@ -7993,6 +8090,7 @@ function renderPatch(sections) {
 init_cjs_shims();
 var import_node_fs27 = require("fs");
 var import_node_http = __toESM(require("http"), 1);
+var import_node_net = __toESM(require("net"), 1);
 var import_node_path42 = __toESM(require("path"), 1);
 var import_node_child_process2 = require("child_process");
 var import_node_readline = __toESM(require("readline"), 1);
@@ -8159,6 +8257,28 @@ async function waitForDaemonReady(restPort, timeoutMs) {
     stillBootstrapping: projects.filter((p) => p.status === "bootstrapping").map((p) => p.name)
   };
 }
+var NEAT_PORTS = [8080, 4318, 6328];
+async function isPortFree(port) {
+  return new Promise((resolve) => {
+    const server = import_node_net.default.createServer();
+    server.once("error", () => resolve(false));
+    server.once("listening", () => server.close(() => resolve(true)));
+    server.listen(port, "127.0.0.1");
+  });
+}
+async function probePortsFree() {
+  for (const port of NEAT_PORTS) {
+    if (!await isPortFree(port)) return { free: false, held: port };
+  }
+  return { free: true };
+}
+function formatPortCollisionMessage(port) {
+  return [
+    `neat: port ${port} is in use; the NEAT daemon needs it.`,
+    `      run \`neatd stop\` to release the previous daemon, or`,
+    `      \`lsof -i :${port}\` to find the holding process.`
+  ];
+}
 function spawnDaemonDetached() {
   const here = import_node_path42.default.dirname(new URL(importMetaUrl).pathname);
   const candidates = [
@@ -8295,6 +8415,14 @@ async function runOrchestrator(opts) {
   if (await checkDaemonHealth(restPort)) {
     result.steps.daemon = "already-running";
   } else {
+    const probe = await probePortsFree();
+    if (!probe.free) {
+      for (const line of formatPortCollisionMessage(probe.held)) {
+        console.error(line);
+      }
+      result.exitCode = 3;
+      return result;
+    }
     try {
       spawnDaemonDetached();
     } catch (err) {
@@ -9102,7 +9230,8 @@ function usage() {
   console.log("  0  success");
   console.log("  1  server error (4xx/5xx body printed to stderr)");
   console.log("  2  misuse (missing args, bad flags) \u2014 handled before any network call");
-  console.log("  3  daemon not reachable (connection refused / timeout)");
+  console.log("  3  environmental \u2014 daemon unreachable, or one of ports 8080 / 4318 / 6328");
+  console.log("     is held by another process when `neat <path>` tries to spawn the daemon");
   console.log("");
   console.log("environment:");
   console.log("  NEAT_API_URL    base URL for the core REST API (default http://localhost:8080)");