@ncontiero/eslint-config 8.3.2 → 8.4.0

package/dist/index.mjs

@@ -75,7 +75,7 @@ async function interopDefault(m) {
 	return resolved.default || resolved;
 }
 function ensurePackages(packages) {
-	if (process.env.CI || !process.stdout.isTTY || !isCwdInScope) return;
+	if (!isCwdInScope || process.env.CI || !process.stdout.isTTY) return;
 	const nonExistingPackages = packages.filter((i) => i && !isPackageExists(i));
 	if (nonExistingPackages.length === 0) return;
 	throw new Error(`This package(s) are required for this config: ${nonExistingPackages.join(", ")}. Please install them.`);
@@ -164,6 +164,7 @@ async function e18e(options = {}) {
 //#endregion
 //#region src/globs.ts
 const GLOB_SRC_EXT = "?([cm])[jt]s?(x)";
+const GLOB_EXT_TS_TSX = "?([cm])ts?(x)";
 const GLOB_SRC = "**/*.?([cm])[jt]s?(x)";
 const GLOB_JS = "**/*.?([cm])js";
 const GLOB_JSX = "**/*.?([cm])jsx";
@@ -183,6 +184,20 @@ const GLOB_YAML = "**/*.y?(a)ml";
 const GLOB_TOML = "**/*.toml";
 const GLOB_HTML = "**/*.htm?(l)";
 const GLOB_MARKDOWN_CODE = `${GLOB_MARKDOWN}/${GLOB_SRC}`;
+const GLOB_TESTS = [
+	`**/__tests__/**/*.${GLOB_SRC_EXT}`,
+	`**/*.spec.${GLOB_SRC_EXT}`,
+	`**/*.test.${GLOB_SRC_EXT}`,
+	`**/*.bench.${GLOB_SRC_EXT}`,
+	`**/*.benchmark.${GLOB_SRC_EXT}`
+];
+const GLOB_TS_TESTS = [
+	`**/__tests__/**/*.${GLOB_EXT_TS_TSX}`,
+	`**/*.spec.${GLOB_EXT_TS_TSX}`,
+	`**/*.test.${GLOB_EXT_TS_TSX}`,
+	`**/*.bench.${GLOB_EXT_TS_TSX}`,
+	`**/*.benchmark.${GLOB_EXT_TS_TSX}`
+];
 const GLOB_ALL_SRC = [
 	GLOB_SRC,
 	GLOB_STYLE,
@@ -558,6 +573,7 @@ async function jsonc(options = {}) {
 		GLOB_JSONC
 	], overrides = {}, style = true } = options;
 	const { indent = 2 } = typeof style === "boolean" ? {} : style;
+	const quotes = options.quotes ?? "double";
 	const [pluginJsonc] = await Promise.all([interopDefault(import("eslint-plugin-jsonc"))]);
 	return [...pluginJsonc.configs["recommended-with-jsonc"].map((config) => ({
 		...config,
@@ -579,8 +595,8 @@ async function jsonc(options = {}) {
 			}],
 			"jsonc/object-curly-spacing": ["error", "always"],
 			"jsonc/object-property-newline": ["error", { allowAllPropertiesOnSameLine: true }],
-			"jsonc/quote-props": "off",
-			"jsonc/quotes": "off",
+			"jsonc/quote-props": "error",
+			"jsonc/quotes": ["error", quotes],
 			...overrides
 		}
 	}];
@@ -929,7 +945,7 @@ const TanstackRouterPackages = ["@tanstack/react-router"];
 const NextJsPackages = ["next"];
 async function react(options = {}) {
 	const { files = [GLOB_SRC], filesTypeAware = [GLOB_TS, GLOB_TSX], ignoresTypeAware = [`${GLOB_MARKDOWN}/**`], overrides = {}, tsconfigPath } = options;
-	const isTypeAware = !!tsconfigPath;
+	const isTypeAware = !!tsconfigPath || !!options.typeAware;
 	const typeAwareRules = {
 		"react/no-leaked-conditional-rendering": "error",
 		"react/no-unused-props": "warn"
@@ -1348,6 +1364,61 @@ async function tanstackQuery(options = {}) {
 	}];
 }
 //#endregion
+//#region src/configs/test.ts
+let _pluginTest;
+async function test(options = {}) {
+	const { files = GLOB_TESTS, overrides = {}, tsconfigPath, typescript = false } = options;
+	const filesTypeAware = [GLOB_TS_TESTS];
+	const isTypeAware = typescript && (!!tsconfigPath || !!options.typeAware);
+	const [pluginVitest, pluginNoOnlyTests] = await Promise.all([interopDefault(import("@vitest/eslint-plugin")), interopDefault(import("eslint-plugin-no-only-tests"))]);
+	_pluginTest = _pluginTest || {
+		...pluginVitest,
+		rules: {
+			...pluginVitest.rules,
+			...pluginNoOnlyTests.rules
+		}
+	};
+	const typeAwareRules = {
+		"test/unbound-method": "error",
+		"ts/unbound-method": "off"
+	};
+	return [
+		{
+			name: "ncontiero/test/setup",
+			plugins: { test: _pluginTest }
+		},
+		{
+			files,
+			name: "ncontiero/test/rules",
+			rules: {
+				"test/consistent-test-it": ["error", {
+					fn: "it",
+					withinDescribe: "it"
+				}],
+				"test/hoisted-apis-on-top": "warn",
+				"test/no-duplicate-hooks": "warn",
+				"test/no-identical-title": "error",
+				"test/no-import-node-test": "error",
+				"test/no-only-tests": "error",
+				"test/prefer-hooks-in-order": "error",
+				"test/prefer-lowercase-title": ["error", { ignore: ["describe"] }],
+				"antfu/no-top-level-await": "off",
+				"e18e/prefer-static-regex": "off",
+				"no-unused-expressions": "off",
+				"node/prefer-global/process": "off",
+				"ts/explicit-function-return-type": "off",
+				...overrides
+			}
+		},
+		...isTypeAware ? [{
+			files: filesTypeAware,
+			name: "ncontiero/test/rules-type-aware",
+			rules: typeAwareRules,
+			settings: { vitest: { typecheck: true } }
+		}] : []
+	];
+}
+//#endregion
 //#region src/configs/toml.ts
 async function toml(options = {}) {
 	const { files = [GLOB_TOML], overrides = {}, style = true } = options;
@@ -1393,7 +1464,7 @@ async function typescript(options = {}) {
 	const filesTypeAware = options.filesTypeAware ?? ["**/*.?([cm])ts", "**/*.?([cm])tsx"];
 	const ignoresTypeAware = options.ignoresTypeAware ?? [`**/*.md/**`];
 	const tsconfigPath = options?.tsconfigPath ? options.tsconfigPath : void 0;
-	const isTypeAware = !!tsconfigPath;
+	const isTypeAware = !!tsconfigPath || !!options.typeAware;
 	const typeAwareRules = {
 		"dot-notation": "off",
 		"no-implied-eval": "off",
@@ -1439,7 +1510,7 @@ async function typescript(options = {}) {
 					...typeAware ? {
 						projectService: {
 							allowDefaultProject: ["./*.js"],
-							defaultProject: tsconfigPath
+							...tsconfigPath ? { defaultProject: tsconfigPath } : {}
 						},
 						tsconfigRootDir: process.cwd()
 					} : {},
@@ -1539,8 +1610,11 @@ async function typescript(options = {}) {
 function unicorn(options = {}) {
 	const { allRecommended, overrides = {} } = options;
 	return [{
+		name: "ncontiero/unicorn/setup",
+		plugins: { unicorn: pluginUnicorn }
+	}, {
+		files: [GLOB_SRC],
 		name: "ncontiero/unicorn/rules",
-		plugins: { unicorn: pluginUnicorn },
 		rules: {
 			...allRecommended ? pluginUnicorn.configs.recommended.rules : {
 				"unicorn/better-dom-traversing": "error",
@@ -1563,7 +1637,6 @@ function unicorn(options = {}) {
 				"unicorn/no-blob-to-file": "error",
 				"unicorn/no-console-spaces": "error",
 				"unicorn/no-for-loop": "error",
-				"unicorn/no-hex-escape": "error",
 				"unicorn/no-incorrect-query-selector": "error",
 				"unicorn/no-instanceof-builtins": "error",
 				"unicorn/no-invalid-remove-event-listener": "error",
@@ -1616,6 +1689,7 @@ function unicorn(options = {}) {
 				"unicorn/prefer-string-starts-ends-with": "error",
 				"unicorn/prefer-string-trim-start-end": "error",
 				"unicorn/prefer-type-error": "error",
+				"unicorn/prefer-unicode-code-point-escapes": "error",
 				"unicorn/switch-case-break-position": "error",
 				"unicorn/throw-new-error": "error"
 			},
@@ -1720,7 +1794,8 @@ const flatConfigProps = [
 ];
 const defaultPluginRenaming = {
 	"@eslint-react": "react",
-	"@typescript-eslint": "ts"
+	"@typescript-eslint": "ts",
+	vitest: "test"
 };
 function resolveSubOptions(options, key) {
 	return typeof options[key] === "boolean" ? {} : options[key] || {};
@@ -1782,19 +1857,26 @@ function ncontiero(options = {}, ...userConfigs) {
 	}));
 	if (enableTanStackQuery) configs.push(tanstackQuery({ overrides: getOverrides(options, "tanstackQuery") }));
 	if (enableJsonc) configs.push(jsonc({
+		...resolveSubOptions(options, "jsonc"),
 		overrides: getOverrides(options, "jsonc"),
 		style: styleOptions
 	}), sortPackageJson(), sortTsconfig());
-	if (options.yaml ?? true) configs.push(yml({
+	if (options.yaml !== false) configs.push(yml({
 		overrides: getOverrides(options, "yaml"),
 		style: styleOptions
 	}));
-	if (options.toml ?? true) configs.push(toml({
+	if (options.toml !== false) configs.push(toml({
 		overrides: getOverrides(options, "toml"),
 		style: styleOptions
 	}));
 	if (enableMarkdown) configs.push(markdown({ overrides: getOverrides(options, "markdown") }));
 	if (enableRegexp) configs.push(regexp(typeof enableRegexp === "boolean" ? {} : enableRegexp));
+	if (options.test !== false) configs.push(test({
+		...typescriptOptions,
+		overrides: getOverrides(options, "test"),
+		tsconfigPath,
+		typescript: !!enableTypescript
+	}));
 	if (enableReact) configs.push(react({
 		...typescriptOptions,
 		overrides: getOverrides(options, "react"),
@@ -1823,4 +1905,4 @@ function ncontiero(options = {}, ...userConfigs) {
 	});
 }
 //#endregion
-export { GLOB_ALL_SRC, GLOB_CSS, GLOB_DIST, GLOB_EXCLUDE, GLOB_HTML, GLOB_JS, GLOB_JSON, GLOB_JSON5, GLOB_JSONC, GLOB_JSX, GLOB_LESS, GLOB_LOCKFILE, GLOB_MARKDOWN, GLOB_MARKDOWN_CODE, GLOB_MARKDOWN_IN_MARKDOWN, GLOB_NODE_MODULES, GLOB_POSTCSS, GLOB_SCSS, GLOB_SRC, GLOB_SRC_EXT, GLOB_STYLE, GLOB_TOML, GLOB_TS, GLOB_TSX, GLOB_YAML, combine, command, comments, composer, deMorgan, defaultPluginRenaming, e18e, ensurePackages, getOverrides, hasNextJs, hasReact, hasTailwind, hasTypeScript, html, ignores, imports, interopDefault, javascript, jsdoc, jsonc, jsx, markdown, ncontiero, nextJs, node, parserPlain, perfectionist, prettier, promise, react, regexp, renamePluginInConfigs, renameRules, resolveSubOptions, restrictedSyntaxJs, sortPackageJson, sortPnpmWorkspace, sortTsconfig, tailwindcss, tanstackQuery, toArray, toml, typescript, unicorn, yml };
+export { GLOB_ALL_SRC, GLOB_CSS, GLOB_DIST, GLOB_EXCLUDE, GLOB_EXT_TS_TSX, GLOB_HTML, GLOB_JS, GLOB_JSON, GLOB_JSON5, GLOB_JSONC, GLOB_JSX, GLOB_LESS, GLOB_LOCKFILE, GLOB_MARKDOWN, GLOB_MARKDOWN_CODE, GLOB_MARKDOWN_IN_MARKDOWN, GLOB_NODE_MODULES, GLOB_POSTCSS, GLOB_SCSS, GLOB_SRC, GLOB_SRC_EXT, GLOB_STYLE, GLOB_TESTS, GLOB_TOML, GLOB_TS, GLOB_TSX, GLOB_TS_TESTS, GLOB_YAML, combine, command, comments, composer, deMorgan, defaultPluginRenaming, e18e, ensurePackages, getOverrides, hasNextJs, hasReact, hasTailwind, hasTypeScript, html, ignores, imports, interopDefault, javascript, jsdoc, jsonc, jsx, markdown, ncontiero, nextJs, node, parserPlain, perfectionist, prettier, promise, react, regexp, renamePluginInConfigs, renameRules, resolveSubOptions, restrictedSyntaxJs, sortPackageJson, sortPnpmWorkspace, sortTsconfig, tailwindcss, tanstackQuery, test, toArray, toml, typescript, unicorn, yml };

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@ncontiero/eslint-config",
   "type": "module",
-  "version": "8.3.2",
+  "version": "8.4.0",
   "description": "Nicolas's ESLint config.",
   "author": {
     "name": "Nicolas Contiero",
@@ -37,61 +37,63 @@
     }
   },
   "dependencies": {
-    "@e18e/eslint-plugin": "^0.5.0",
+    "@e18e/eslint-plugin": "^0.5.1",
     "@eslint-community/eslint-plugin-eslint-comments": "^4.7.2",
-    "@eslint-react/eslint-plugin": "^5.9.0",
-    "@eslint/markdown": "^8.0.2",
-    "@html-eslint/eslint-plugin": "^0.62.0",
-    "@html-eslint/parser": "^0.62.0",
-    "@next/eslint-plugin-next": "^16.2.9",
-    "@typescript-eslint/eslint-plugin": "^8.61.0",
-    "@typescript-eslint/parser": "^8.61.0",
+    "@eslint-react/eslint-plugin": "^5.14.10",
+    "@eslint/markdown": "^8.0.3",
+    "@html-eslint/eslint-plugin": "^0.64.0",
+    "@html-eslint/parser": "^0.64.0",
+    "@next/eslint-plugin-next": "^16.2.10",
+    "@typescript-eslint/eslint-plugin": "^8.64.0",
+    "@typescript-eslint/parser": "^8.64.0",
+    "@vitest/eslint-plugin": "^1.6.23",
     "eslint-config-flat-gitignore": "^2.3.0",
     "eslint-merge-processors": "^2.0.0",
     "eslint-plugin-antfu": "^3.2.3",
-    "eslint-plugin-better-tailwindcss": "4.6.0",
-    "eslint-plugin-command": "^3.5.2",
-    "eslint-plugin-de-morgan": "^2.1.2",
-    "eslint-plugin-import-x": "^4.16.2",
-    "eslint-plugin-jsdoc": "^63.0.2",
-    "eslint-plugin-jsonc": "^3.2.0",
+    "eslint-plugin-better-tailwindcss": "4.6.1",
+    "eslint-plugin-command": "^3.5.3",
+    "eslint-plugin-de-morgan": "^2.1.3",
+    "eslint-plugin-import-x": "^4.17.1",
+    "eslint-plugin-jsdoc": "^63.0.13",
+    "eslint-plugin-jsonc": "^3.3.0",
     "eslint-plugin-jsx-a11y": "^6.10.2",
-    "eslint-plugin-n": "^18.1.0",
-    "eslint-plugin-perfectionist": "^5.9.0",
+    "eslint-plugin-n": "^18.2.2",
+    "eslint-plugin-no-only-tests": "^3.4.0",
+    "eslint-plugin-perfectionist": "^5.10.0",
     "eslint-plugin-prettier": "^5.5.6",
     "eslint-plugin-promise": "^7.3.0",
-    "eslint-plugin-react-refresh": "^0.5.2",
-    "eslint-plugin-regexp": "^3.1.0",
+    "eslint-plugin-react-refresh": "^0.5.3",
+    "eslint-plugin-regexp": "^3.1.1",
     "eslint-plugin-toml": "^1.4.0",
-    "eslint-plugin-unicorn": "^65.0.1",
+    "eslint-plugin-unicorn": "^72.0.0",
     "eslint-plugin-unused-imports": "^4.4.1",
-    "eslint-plugin-yml": "^3.4.0",
-    "globals": "^17.6.0",
+    "eslint-plugin-yml": "^3.6.0",
+    "globals": "^17.7.0",
     "local-pkg": "^1.2.1",
-    "prettier": "^3.8.4",
+    "prettier": "^3.9.5",
     "toml-eslint-parser": "^1.0.3",
-    "yaml-eslint-parser": "^2.0.0"
+    "yaml-eslint-parser": "^2.1.0"
   },
   "devDependencies": {
-    "@changesets/cli": "^2.31.0",
-    "@commitlint/cli": "^21.0.2",
-    "@commitlint/config-conventional": "^21.0.2",
-    "@eslint/config-inspector": "^3.0.4",
-    "@ncontiero/changelog-github": "^2.1.4",
-    "@ncontiero/prettier-config": "^1.0.0",
-    "@tanstack/eslint-plugin-query": "^5.101.0",
-    "@types/eslint-plugin-jsx-a11y": "^6.10.1",
-    "@types/node": "^25.9.3",
-    "eslint": "^10.5.0",
-    "eslint-typegen": "^2.3.1",
-    "husky": "^9.1.7",
-    "nano-staged": "^1.0.2",
-    "tinyexec": "^1.2.4",
-    "tinyglobby": "^0.2.17",
-    "tsdown": "^0.22.2",
-    "tsx": "^4.22.4",
-    "typescript": "^6.0.3",
-    "vitest": "^4.1.8"
+    "@changesets/cli": "2.31.0",
+    "@commitlint/cli": "21.2.1",
+    "@commitlint/config-conventional": "21.2.0",
+    "@eslint/config-inspector": "3.1.0",
+    "@ncontiero/changelog-github": "2.1.4",
+    "@ncontiero/prettier-config": "1.0.0",
+    "@tanstack/eslint-plugin-query": "5.101.2",
+    "@types/eslint-plugin-jsx-a11y": "6.10.1",
+    "@types/node": "26.1.1",
+    "eslint": "10.7.0",
+    "eslint-typegen": "2.3.1",
+    "husky": "9.1.7",
+    "nano-staged": "1.0.2",
+    "tinyexec": "1.2.4",
+    "tinyglobby": "0.2.17",
+    "tsdown": "0.22.7",
+    "tsx": "4.23.1",
+    "typescript": "6.0.3",
+    "vitest": "4.1.10"
   },
   "engines": {
     "node": ">=20.19.0"
@@ -111,6 +113,7 @@
     "lint:fix": "pnpm lint --fix",
     "typecheck": "tsc --noEmit",
     "check": "pnpm lint && pnpm typecheck",
-    "release": "changeset publish"
+    "release": "pnpm build && changeset publish",
+    "postinstall": "pnpm typegen"
   }
 }