npm - @nbakka/mcp-appium - Versions diffs - 3.0.3 → 3.0.5 - Mend

@nbakka/mcp-appium 3.0.3 → 3.0.5

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (2) hide show

package/lib/server.js +134 -48
package/package.json +1 -1

package/lib/server.js CHANGED Viewed

@@ -18,7 +18,9 @@ const { google } = require('googleapis');
 const axios = require('axios');
 const OpenAI = require("openai");
 const express = require('express');
-const open = require('open');
+// Fixed: support ESM default export of 'open'
+const openImport = require('open');
+const openBrowser = openImport.default || openImport;
 const getAgentVersion = () => {
     const json = require("../package.json");
     return json.version;
@@ -816,21 +818,33 @@ tool(
       app.use(express.json({ limit: '10mb' })); // Increase JSON limit
       app.use(express.urlencoded({ extended: true, limit: '10mb' }));
-      // Main review page with fixed JSON handling
-      app.get('/', (req, res) => {
-        // Safely stringify testCases to avoid JSON issues
-        const safeTestCases = testCases.map((testCase, index) => {
-          // Ensure each test case is an array with at least 3 elements
-          const safeCase = Array.isArray(testCase) ? testCase : [testCase];
-          return [
-            String(safeCase[0] || `Test Case ${index + 1}`), // Title
-            String(safeCase[1] || ''), // Description/Steps
-            String(safeCase[2] || 'New'), // Status
-            String(safeCase[3] || '') // Original case (for modifications)
-          ];
-        });
+      // Process test cases - handle the specific format properly
+      const processedTestCases = testCases.map((testCase, index) => {
+        // Each testCase is an array like ["title", "description", "status", "originalCase"]
+        if (Array.isArray(testCase)) {
+          return {
+            title: testCase[0] || `Test Case ${index + 1}`,
+            description: testCase[1] || '',
+            status: testCase[2] || 'New',
+            originalCase: testCase[3] || '',
+            index: index
+          };
+        } else {
+          // Fallback for unexpected format
+          return {
+            title: String(testCase) || `Test Case ${index + 1}`,
+            description: '',
+            status: 'New',
+            originalCase: '',
+            index: index
+          };
+        }
+      });
-        res.send(`
+      // Main review page with proper handling
+      app.get('/', (req, res) => {
+        try {
+          res.send(`
 <!DOCTYPE html>
 <html lang="en">
 <head>
@@ -980,7 +994,7 @@ tool(
             padding: 10px;
             font-size: 1rem;
             transition: border-color 0.3s ease;
-            min-height: 100px;
+            min-height: 120px;
             resize: vertical;
             font-family: inherit;
         }
@@ -991,8 +1005,18 @@ tool(
             box-shadow: 0 0 0 3px rgba(79, 172, 254, 0.1);
         }
-        .original-case, .remove-case {
-            background: #f8f9fa;
+        .original-case {
+            background: #fff3cd;
+            border: 1px solid #ffeaa7;
+            padding: 10px;
+            border-radius: 6px;
+            margin-bottom: 15px;
+            font-size: 0.9rem;
+        }
+        .remove-case {
+            background: #f8d7da;
+            border: 1px solid #f5c6cb;
             padding: 10px;
             border-radius: 6px;
             margin-bottom: 15px;
@@ -1096,11 +1120,11 @@ tool(
         <div class="stats">
             <div class="stat-item">
-                <div class="stat-number" id="totalCount">${safeTestCases.length}</div>
+                <div class="stat-number" id="totalCount">${processedTestCases.length}</div>
                 <div class="stat-label">Total Test Cases</div>
             </div>
             <div class="stat-item">
-                <div class="stat-number" id="activeCount">${safeTestCases.length}</div>
+                <div class="stat-number" id="activeCount">${processedTestCases.length}</div>
                 <div class="stat-label">Active</div>
             </div>
             <div class="stat-item">
@@ -1111,26 +1135,49 @@ tool(
         <div class="content">
             <div id="testCases">
-                ${safeTestCases.map((testCase, index) => {
-                  const escapedContent = testCase[0].replace(/"/g, '&quot;').replace(/'/g, '&#39;').replace(/\n/g, '\\n');
+                ${processedTestCases.map((testCase, index) => {
+                  // Safely escape HTML characters
+                  const safeTitle = testCase.title
+                    .replace(/&/g, '&amp;')
+                    .replace(/</g, '&lt;')
+                    .replace(/>/g, '&gt;')
+                    .replace(/"/g, '&quot;')
+                    .replace(/'/g, '&#39;');
+                  const safeDescription = testCase.description
+                    .replace(/&/g, '&amp;')
+                    .replace(/</g, '&lt;')
+                    .replace(/>/g, '&gt;')
+                    .replace(/"/g, '&quot;')
+                    .replace(/'/g, '&#39;');
+                  const safeOriginal = testCase.originalCase
+                    .replace(/&/g, '&amp;')
+                    .replace(/</g, '&lt;')
+                    .replace(/>/g, '&gt;')
+                    .replace(/"/g, '&quot;')
+                    .replace(/'/g, '&#39;');
                   return `
                 <div class="test-case" data-index="${index}">
                     <div class="test-case-header">
                         <span class="test-case-id">Test Case #${index + 1}</span>
-                        <span class="test-case-status status-${testCase[2].toLowerCase()}">${testCase[2]}</span>
+                        <span class="test-case-status status-${testCase.status.toLowerCase()}">${testCase.status}</span>
                     </div>
                     <div class="test-case-content">
                         <div class="test-case-title">
-                            <textarea data-index="${index}" placeholder="Enter test case title and steps...">${escapedContent}</textarea>
+                            <textarea data-index="${index}" placeholder="Enter test case title and steps...">${safeTitle}${safeDescription ? '\n\nSteps:\n' + safeDescription : ''}</textarea>
                         </div>
-                        ${testCase[2] === 'Modify' && testCase[3] ? `
+                        ${testCase.status === 'Modify' && testCase.originalCase ? `
                         <div class="original-case">
-                            <small><strong>Original:</strong> ${testCase[3]}</small>
+                            <strong>Original Test Case:</strong><br>
+                            ${safeOriginal}
                         </div>
                         ` : ''}
-                        ${testCase[2] === 'Remove' ? `
+                        ${testCase.status === 'Remove' ? `
                         <div class="remove-case">
-                            <small><strong>Marked for Removal</strong></small>
+                            <strong>⚠️ Marked for Removal</strong><br>
+                            This test case is scheduled to be removed. You can restore it using the button below.
                         </div>
                         ` : ''}
                         <div class="test-case-actions">
@@ -1152,7 +1199,7 @@ tool(
     <div class="notification" id="notification"></div>
     <script>
-        let testCases = ${JSON.stringify(safeTestCases)};
+        let testCases = ${JSON.stringify(processedTestCases)};
         let deletedIndices = new Set();
         function updateStats() {
@@ -1190,7 +1237,9 @@ tool(
                 // Reset textarea value
                 const textarea = el.querySelector('textarea');
-                textarea.value = testCases[index][0];
+                const originalTestCase = testCases[index];
+                const resetValue = originalTestCase.title + (originalTestCase.description ? '\n\nSteps:\n' + originalTestCase.description : '');
+                textarea.value = resetValue;
             });
             updateStats();
         }
@@ -1213,9 +1262,17 @@ tool(
                 document.querySelectorAll('.test-case').forEach((el, index) => {
                     if (!deletedIndices.has(index)) {
                         const textarea = el.querySelector('textarea');
-                        const originalTestCase = [...testCases[index]];
-                        originalTestCase[0] = textarea.value;
-                        updatedTestCases.push(originalTestCase);
+                        const originalTestCase = testCases[index];
+                        // Create the updated test case array in the original format
+                        const updatedCase = [
+                            textarea.value.trim(), // Updated title/content
+                            originalTestCase.description, // Keep original description
+                            originalTestCase.status, // Keep original status
+                            originalTestCase.originalCase // Keep original case reference
+                        ];
+                        updatedTestCases.push(updatedCase);
                     }
                 });
@@ -1235,7 +1292,7 @@ tool(
                     if (data.success) {
                         showNotification('Test cases approved successfully!');
                         setTimeout(() => {
-                            window.close();
+                          window.close();
                         }, 2000);
                     } else {
                         showNotification('Error approving test cases', 'error');
@@ -1256,14 +1313,22 @@ tool(
             if (e.target.tagName === 'TEXTAREA') {
                 const index = parseInt(e.target.getAttribute('data-index'));
                 if (!isNaN(index) && testCases[index]) {
-                    testCases[index][0] = e.target.value;
+                    testCases[index].title = e.target.value.split('\n\nSteps:\n')[0];
+                    const stepsIndex = e.target.value.indexOf('\n\nSteps:\n');
+                    if (stepsIndex !== -1) {
+                        testCases[index].description = e.target.value.substring(stepsIndex + 9);
+                    }
                 }
             }
         });
     </script>
 </body>
 </html>
-        `);
+          `);
+        } catch (error) {
+          console.error('Error rendering page:', error);
+          res.status(500).send('Error rendering page');
+        }
       });
       // Approval endpoint with better error handling
@@ -1298,9 +1363,25 @@ tool(
         }
       });
-      // Start server
-      const server = app.listen(port, () => {
-        console.log(`Test case review server running at http://localhost:${port}`);
+      // Error handling middleware
+      app.use((err, req, res, next) => {
+        console.error('Express error:', err);
+        res.status(500).json({ error: 'Internal server error' });
+      });
+      // 404 handler
+      app.use((req, res) => {
+        res.status(404).json({ error: 'Not found' });
+      });
+      // Start server with better error handling
+      const server = app.listen(port, (err) => {
+        if (err) {
+          console.error('Failed to start server:', err);
+          return;
+        }
+        console.log(`✅ Test case review session started. Session ID: ${sessionId}.`);
+        console.log(`Server running at http://localhost:${port}`);
       });
       // Handle server errors
@@ -1308,19 +1389,26 @@ tool(
         if (error.code === 'EADDRINUSE') {
           // Try a different port
           const newPort = port + Math.floor(Math.random() * 100);
-          return app.listen(newPort, () => {
+          const newServer = app.listen(newPort, () => {
             console.log(`Test case review server running at http://localhost:${newPort}`);
-            open(`http://localhost:${newPort}`).catch(err => console.error('Failed to open browser:', err));
+            try {
+              openBrowser(`http://localhost:${newPort}`).catch(err => console.error('Failed to open browser:', err));
+            } catch (e) {
+              console.error('Failed to open browser automatically:', e.message);
+            }
           });
+          return newServer;
         }
         throw error;
       });
       // Open browser with proper error handling
+      let openAttemptFailed = false;
       try {
-        await open(`http://localhost:${port}`);
-      } catch (openError) {
-        console.error('Failed to open browser automatically:', openError.message);
+        await openBrowser(`http://localhost:${port}`);
+      } catch (err) {
+        openAttemptFailed = true;
+        console.error('Failed to open browser automatically:', err.message);
         // Continue without opening browser - user can manually navigate to the URL
       }
@@ -1328,13 +1416,11 @@ tool(
       global.approvalSessions = global.approvalSessions || {};
       global.approvalSessions[sessionId] = {
         status: 'pending',
-        testCases: testCases,
+        testCases: processedTestCases,
         timestamp: Date.now()
       };
-      return `✅ Test case review session started. Session ID: ${sessionId}.
-Server running at http://localhost:${port}
-${openError ? 'Please manually open the URL in your browser.' : 'Browser should open automatically.'}`;
+      return `✅ Test case review session started. Session ID: ${sessionId}.\nServer running at http://localhost:${port}\n${openAttemptFailed ? 'Please manually open the URL in your browser.' : 'Browser should open automatically.'}`;
     } catch (err) {
       console.error('Review tool error:', err);

package/package.json CHANGED Viewed

@@ -1,6 +1,6 @@
 {
   "name": "@nbakka/mcp-appium",
-  "version": "3.0.3",
+  "version": "3.0.5",
   "description": "Appium MCP",
   "engines": {
     "node": ">=18"