npm - @nbakka/mcp-appium - Versions diffs - 2.0.87 → 2.0.89 - Mend

@nbakka/mcp-appium 2.0.87 → 2.0.89

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (3) hide show

package/lib/review-ui/index.html +123 -26
package/lib/server.js +56 -52
package/package.json +1 -1

package/lib/review-ui/index.html CHANGED Viewed

@@ -1,38 +1,135 @@
 <!DOCTYPE html>
-<html>
+<html lang="en">
 <head>
-    <title>Test Case Review & Approval</title>
-    <link rel="stylesheet" href="/styles.css">
+    <meta charset="UTF-8">
+    <meta name="viewport" content="width=device-width, initial-scale=1.0">
+    <title>Test Case Review</title>
+    <style>
+        body { font-family: Arial, sans-serif; margin: 20px; background-color: #f5f5f5; }
+        .container { max-width: 1200px; margin: 0 auto; background: white; padding: 20px; border-radius: 8px; }
+        .section { margin-bottom: 30px; padding: 20px; border: 1px solid #ddd; border-radius: 5px; }
+        .new { background-color: #e7f5e7; border-color: #4caf50; }
+        .modify { background-color: #fff3cd; border-color: #ffc107; }
+        .remove { background-color: #f8d7da; border-color: #dc3545; }
+        .test-case { margin: 10px 0; padding: 10px; background: white; border-radius: 3px; }
+        button { padding: 10px 20px; margin: 10px; border: none; border-radius: 5px; cursor: pointer; }
+        .approve { background-color: #4caf50; color: white; }
+        .cancel { background-color: #dc3545; color: white; }
+        h2 { margin-top: 0; }
+        .original { color: #666; text-decoration: line-through; }
+        .modified { color: #000; font-weight: bold; }
+    </style>
 </head>
 <body>
 <div class="container">
-    <h1>Review Test Cases</h1>
-    <!-- New Test Cases Section -->
-    <div class="section" id="new-testcases-section">
-        <h2>New Test Cases</h2>
-        <div id="new-testcases"></div>
+    <h1>Test Case Review</h1>
+    <div id="loading">Loading test cases...</div>
+    <div id="content" style="display: none;">
+        <div id="new-section" class="section new">
+            <h2>New Test Cases</h2>
+            <div id="new-cases"></div>
+        </div>
+        <div id="modify-section" class="section modify">
+            <h2>Modified Test Cases</h2>
+            <div id="modify-cases"></div>
+        </div>
+        <div id="remove-section" class="section remove">
+            <h2>Test Cases to Remove</h2>
+            <div id="remove-cases"></div>
+        </div>
+        <div style="text-align: center; margin-top: 30px;">
+            <button class="approve" onclick="approve()">Approve All</button>
+            <button class="cancel" onclick="cancel()">Cancel</button>
+        </div>
     </div>
+</div>
-    <!-- Modified Test Cases Section -->
-    <div class="section" id="modified-testcases-section">
-        <h2>Modified Test Cases</h2>
-        <div id="modified-testcases"></div>
-    </div>
+<script>
+    let sessionId;
+    let testCases;
-    <!-- Test Cases to Remove Section -->
-    <div class="section" id="remove-testcases-section">
-        <h2>Test Cases to Remove</h2>
-        <div id="remove-testcases"></div>
-    </div>
+    async function loadTestCases() {
+        try {
+            const response = await fetch('/api/testcases');
+            const data = await response.json();
+            sessionId = data.sessionId;
+            testCases = data.testCases;
-    <div class="button-container">
-        <button id="approve-btn" onclick="approveTestCases()">✓ Approve Test Cases</button>
-        <button id="cancel-btn" onclick="cancelReview()">✗ Cancel Review</button>
-        <div id="status" class="status"></div>
-    </div>
-</div>
+            document.getElementById('loading').style.display = 'none';
+            document.getElementById('content').style.display = 'block';
+            renderTestCases();
+        } catch (error) {
+            document.getElementById('loading').innerHTML = 'Error loading test cases: ' + error.message;
+        }
+    }
+    function renderTestCases() {
+        // Render new test cases
+        const newCases = document.getElementById('new-cases');
+        if (testCases.new && testCases.new.length > 0) {
+            newCases.innerHTML = testCases.new.map(tc =>
+                `<div class="test-case"><strong>ID:</strong> ${tc.id}<br><strong>Description:</strong> ${tc.description}</div>`
+            ).join('');
+        } else {
+            newCases.innerHTML = '<p>No new test cases</p>';
+        }
+        // Render modified test cases
+        const modifyCases = document.getElementById('modify-cases');
+        if (testCases.modify && testCases.modify.length > 0) {
+            modifyCases.innerHTML = testCases.modify.map(tc =>
+                `<div class="test-case">
+                    <strong>ID:</strong> ${tc.id}<br>
+                    <strong>Original:</strong> <span class="original">${tc.original}</span><br>
+                    <strong>Modified:</strong> <span class="modified">${tc.modified}</span>
+                </div>`
+            ).join('');
+        } else {
+            modifyCases.innerHTML = '<p>No modified test cases</p>';
+        }
+        // Render remove test cases
+        const removeCases = document.getElementById('remove-cases');
+        if (testCases.remove && testCases.remove.length > 0) {
+            removeCases.innerHTML = testCases.remove.map(tc =>
+                `<div class="test-case"><strong>ID:</strong> ${tc.id}<br><strong>Description:</strong> ${tc.description}</div>`
+            ).join('');
+        } else {
+            removeCases.innerHTML = '<p>No test cases to remove</p>';
+        }
+    }
+    async function approve() {
+        try {
+            const response = await fetch(`/approve/${sessionId}`, {
+                method: 'POST',
+                headers: { 'Content-Type': 'application/json' },
+                body: JSON.stringify(testCases)
+            });
+            const result = await response.json();
+            alert(result.message);
+            window.close();
+        } catch (error) {
+            alert('Error approving test cases: ' + error.message);
+        }
+    }
+    async function cancel() {
+        try {
+            const response = await fetch(`/cancel/${sessionId}`, {
+                method: 'POST'
+            });
+            const result = await response.json();
+            alert(result.message);
+            window.close();
+        } catch (error) {
+            alert('Error cancelling review: ' + error.message);
+        }
+    }
-<script src="/script.js"></script>
+    // Load test cases when page loads
+    window.onload = loadTestCases;
+</script>
 </body>
 </html>

package/lib/server.js CHANGED Viewed

@@ -754,7 +754,7 @@ ${guidelines}`
         await fs.writeFile(testCasesFilePath, `Error generating test cases: ${error.message}`);
       });
-      return "✅ Test case generation started. Use 'check_testcases_status' tool to check if generation is complete.";
+      return "✅ Test case generation started. Use 'check_testcases_status' tool to check if generation is complete. Try max 10 times";
     } catch (err) {
       return `❌ Error starting test case generation: ${err.message}`;
     }
@@ -768,7 +768,7 @@ tool(
   async () => {
     try {
       // Wait for 20 seconds before checking
-      await new Promise(resolve => setTimeout(resolve, 20000));
+      await new Promise(resolve => setTimeout(resolve, 25000));
       const testCasesFilePath = path.join(__dirname, 'generated-testcases.txt');
@@ -816,36 +816,46 @@ tool(
                 remove: []
             };
-            testCases.forEach(tc => {
-                if (!tc || tc.length < 2) return; // Skip invalid entries
+            testCases.forEach((tc, index) => {
+                if (!tc || !Array.isArray(tc) || tc.length < 2) {
+                    console.log(`Skipping invalid test case at index ${index}:`, tc);
+                    return;
+                }
+                const lastElement = tc[tc.length - 1];
+                const secondLastElement = tc.length > 1 ? tc[tc.length - 2] : null;
-                if (tc.length === 2 && tc[1].toLowerCase() === 'new') {
+                if (lastElement?.toLowerCase() === 'new') {
                     // Format: [description, "New"]
-                    parsedTestCases.new.push(tc[0]);
-                } else if (tc.length === 4) {
-                    const type = tc[2]?.toLowerCase();
-                    if (type === 'modify') {
-                        // Format: [originalDescription, newDescription, "Modify", testCaseId]
-                        parsedTestCases.modify.push({
-                            id: tc[3] || 'N/A',
-                            original: tc[0], // Original description
-                            modified: tc[1]  // New/modified description
-                        });
-                    } else if (type === 'remove') {
-                        // Format: [description, "", "Remove", testCaseId]
-                        parsedTestCases.remove.push({
-                            id: tc[3] || 'N/A',
-                            description: tc[0]
-                        });
-                    }
+                    parsedTestCases.new.push({
+                        description: tc[0],
+                        id: `NEW-${index + 1}`
+                    });
+                } else if (secondLastElement?.toLowerCase() === 'modify' && tc.length === 4) {
+                    // Format: [originalDescription, newDescription, "Modify", testCaseId]
+                    parsedTestCases.modify.push({
+                        id: tc[3],
+                        original: tc[0],
+                        modified: tc[1]
+                    });
+                } else if (secondLastElement?.toLowerCase() === 'remove' && tc.length === 3) {
+                    // Format: [description, "Remove", testCaseId]
+                    parsedTestCases.remove.push({
+                        id: tc[2],
+                        description: tc[0]
+                    });
+                } else {
+                    console.log(`Unrecognized test case format at index ${index}:`, tc);
                 }
             });
+            console.log('Parsed test cases:', JSON.stringify(parsedTestCases, null, 2));
             // Initialize session state
             approvalSessions.set(sessionId, {
                 status: 'pending',
                 testCases: parsedTestCases,
-                originalTestCases: JSON.parse(JSON.stringify(parsedTestCases)), // Deep copy
+                originalTestCases: JSON.parse(JSON.stringify(parsedTestCases)),
                 server: null,
                 startTime: Date.now()
             });
@@ -853,25 +863,24 @@ tool(
             const app = express();
             const port = 3001;
-            // Middleware for JSON parsing
             app.use(express.json());
             app.use(express.static(path.join(__dirname, 'review-ui')));
-            // Main page
             app.get("/", (req, res) => {
                 res.sendFile(path.join(__dirname, 'review-ui', 'index.html'));
             });
-            // API to get test cases data
             app.get("/api/testcases", (req, res) => {
                 const session = approvalSessions.get(sessionId);
+                if (!session) {
+                    return res.status(404).json({ error: 'Session not found' });
+                }
                 res.json({
                     sessionId: sessionId,
-                    testCases: session ? session.testCases : {}
+                    testCases: session.testCases
                 });
             });
-            // Approval endpoint
             app.post(`/approve/${sessionId}`, (req, res) => {
                 const session = approvalSessions.get(sessionId);
                 if (session) {
@@ -879,38 +888,32 @@ tool(
                     session.finalTestCases = req.body;
                     approvalSessions.set(sessionId, session);
                 }
-                res.send("✓ Test cases approved successfully!");
+                res.json({ status: 'approved', message: 'Test cases approved successfully!' });
             });
-            // Cancel endpoint
             app.post(`/cancel/${sessionId}`, (req, res) => {
                 const session = approvalSessions.get(sessionId);
                 if (session) {
                     session.status = 'cancelled';
                     approvalSessions.set(sessionId, session);
                 }
-                res.send("Review cancelled");
+                res.json({ status: 'cancelled', message: 'Review cancelled' });
             });
-            // Start server
             const server = app.listen(port, async () => {
                 console.log(`Test case review server started on http://localhost:${port}`);
                 try {
                     const { default: open } = await import('open');
                     await open(`http://localhost:${port}`);
-                    console.log('Browser opened successfully');
                 } catch (openError) {
                     console.log('Failed to open browser automatically:', openError.message);
                 }
             });
-            // Store server reference in session
             const session = approvalSessions.get(sessionId);
             session.server = server;
             approvalSessions.set(sessionId, session);
-            // Auto cleanup after 5 minutes
             setTimeout(() => {
                 const session = approvalSessions.get(sessionId);
                 if (session && session.status === 'pending') {
@@ -920,22 +923,25 @@ tool(
                     }
                     approvalSessions.set(sessionId, session);
                 }
-            }, 300000); // 5 minutes
+            }, 300000);
-            return JSON.stringify({
+            const response = {
                 status: "review_started",
                 sessionId: sessionId,
                 message: "Test case review interface opened in browser. Use check_approval_status tool to poll for approval.",
                 testCasesCount: testCases.length,
                 browserUrl: `http://localhost:${port}`,
                 instructions: "Poll every 25 seconds using check_approval_status tool until approved or timeout (5 minutes)"
-            });
+            };
+            return JSON.stringify(response);
         } catch (err) {
-            return JSON.stringify({
+            const errorResponse = {
                 status: "error",
                 message: `Error setting up review interface: ${err.message}`
-            });
+            };
+            return JSON.stringify(errorResponse);
         }
     }
 );
@@ -948,11 +954,12 @@ tool(
     },
     async ({ sessionId }) => {
         await new Promise(resolve => setTimeout(resolve, 25000));
         const session = approvalSessions.get(sessionId);
         if (!session) {
             return JSON.stringify({
                 status: "error",
-                message: "Session not found. Invalid session ID."
+                message: `Session not found. Invalid session ID: ${sessionId}`
             });
         }
@@ -962,7 +969,6 @@ tool(
         if (session.status === 'approved') {
             const approvedTestCases = session.finalTestCases || session.testCases;
-            // Clean up session and close server
             if (session.server) {
                 session.server.close();
             }
@@ -970,12 +976,11 @@ tool(
             return JSON.stringify({
                 status: "approved",
-                message: "Test cases have been approved by the user.",
-                approvedTestCases: approvedTestCases,
-                elapsedTime: elapsedTime
+                message: "Test cases approved successfully!",
+                elapsedTime: elapsedTime,
+                approvedTestCases: approvedTestCases
             });
         } else if (session.status === 'cancelled') {
-            // Clean up session and close server
             if (session.server) {
                 session.server.close();
             }
@@ -983,11 +988,10 @@ tool(
             return JSON.stringify({
                 status: "cancelled",
-                message: "Review was cancelled by the user.",
+                message: "Review was cancelled by the user",
                 elapsedTime: elapsedTime
             });
-        } else if (session.status === 'timeout' || elapsedTime > 300) { // 5 minutes
-            // Clean up session and close server
+        } else if (session.status === 'timeout' || elapsedTime > 300) {
             if (session.server) {
                 session.server.close();
             }
@@ -995,13 +999,13 @@ tool(
             return JSON.stringify({
                 status: "timeout",
-                message: `Review session timed out. Elapsed time: ${elapsedTime} seconds`,
+                message: "Review session timed out",
                 elapsedTime: elapsedTime
             });
         } else {
             return JSON.stringify({
                 status: "pending",
-                message: "Test cases are still pending approval. Continue polling.",
+                message: "Test cases are still pending approval",
                 elapsedTime: elapsedTime,
                 remainingTime: Math.max(0, 300 - elapsedTime)
             });

package/package.json CHANGED Viewed

@@ -1,6 +1,6 @@
 {
   "name": "@nbakka/mcp-appium",
-  "version": "2.0.87",
+  "version": "2.0.89",
   "description": "Appium MCP",
   "engines": {
     "node": ">=18"