@navels/neal 0.1.0 → 0.2.0

package/dist/neal/adjudicator/planning.js

@@ -39,6 +39,54 @@ export function resolvePlanningAdjudicationContext(state) {
         derivedFromScopeNumber: derivedPlanReview && derivedPlan ? derivedPlan.parentScopeNumber : null,
     };
 }
+// Mirrors resolveExecuteReviewDisposition in adjudicator/execute.ts: one resolver derives every
+// disposition-dependent value runPlanReviewPhase persists (plus the transition signal it asserts)
+// from the same condition set, so the five outcomes can never drift apart.
+export function resolvePlanReviewDisposition(args) {
+    if (args.shouldBlockForConvergence) {
+        return {
+            planningSignal: 'block_for_operator',
+            phase: 'blocked',
+            status: 'blocked',
+            derivedPlanStatus: args.currentDerivedPlanStatus,
+            blockedFromPhase: 'reviewer_plan',
+        };
+    }
+    if (args.hasBlockingFindings) {
+        return {
+            planningSignal: args.reachedMaxRounds ? 'block_for_operator' : 'request_revision',
+            phase: args.reachedMaxRounds ? 'blocked' : 'coder_plan_response',
+            status: args.reachedMaxRounds ? 'blocked' : 'running',
+            derivedPlanStatus: args.currentDerivedPlanStatus,
+            blockedFromPhase: args.reachedMaxRounds ? 'reviewer_plan' : null,
+        };
+    }
+    if (args.hasOpenNonBlockingFindings) {
+        return {
+            planningSignal: 'optional_revision',
+            phase: 'coder_plan_optional_response',
+            status: 'running',
+            derivedPlanStatus: args.currentDerivedPlanStatus,
+            blockedFromPhase: null,
+        };
+    }
+    if (args.derivedPlanReview) {
+        return {
+            planningSignal: 'accept_derived_plan',
+            phase: 'awaiting_derived_plan_execution',
+            status: 'running',
+            derivedPlanStatus: 'accepted',
+            blockedFromPhase: null,
+        };
+    }
+    return {
+        planningSignal: 'accept_plan',
+        phase: 'done',
+        status: 'done',
+        derivedPlanStatus: args.currentDerivedPlanStatus,
+        blockedFromPhase: null,
+    };
+}
 async function buildPlanReviewerInlineContext(args) {
     const planContent = await readTextForInlineSection(resolve(args.state.cwd, args.reviewedPlanPath));
     const sections = [

package/dist/neal/agents/prompts.js

@@ -2,6 +2,7 @@ import { assertNoReadPromptInstructionText, renderInlineReviewerContext, } from
 import { renderReviewerContextMarkdown } from '../context/reviewer-context.js';
 import { AUTONOMY_BLOCKED as SHARED_AUTONOMY_BLOCKED, AUTONOMY_CHUNK_DONE as SHARED_AUTONOMY_CHUNK_DONE, AUTONOMY_DONE as SHARED_AUTONOMY_DONE, AUTONOMY_SCOPE_DONE as SHARED_AUTONOMY_SCOPE_DONE, AUTONOMY_SPLIT_PLAN as SHARED_AUTONOMY_SPLIT_PLAN, buildProgressSection, getCanonicalPlanContractLines, getProtocolMarkerArtifactProhibitionLines, getStandalonePlanPayloadSourceOfTruthLines, } from '../prompts/shared.js';
 import { getUserGuidanceLines } from '../prompts/guidance.js';
+import { assertPromptBuilder, resolvePrimaryVariant } from '../prompts/assert-builder.js';
 export { buildCoderResponsePrompt, buildLegacyScopePrompt, buildReviewerPrompt, buildScopePrompt } from '../prompts/execute.js';
 export { buildCoderPlanResponsePrompt, buildLegacyPlanningPrompt, buildPlanReviewerPrompt, buildPlanningPrompt, } from '../prompts/planning.js';
 export { buildFinalCompletionReviewerPrompt, buildFinalCompletionSummaryPrompt, } from '../prompts/specialized.js';
@@ -18,6 +19,8 @@ export const AUTONOMY_SPLIT_PLAN = SHARED_AUTONOMY_SPLIT_PLAN;
 // present. The static Neal-authored instructions must never reference
 // repository/file/shell access, so they pass through the shared no-read guard.
 export function buildBlockedAdjudicatorPrompt(args) {
+    const spec = assertPromptBuilder('blocked_adjudicator', 'buildBlockedAdjudicatorPrompt', 'src/neal/agents/prompts.ts');
+    resolvePrimaryVariant(spec, 'blocked_adjudicator');
     const staticInstructionLines = [
         'You are a read-only adjudicator for a blocked neal run. The run has stopped because a coder or reviewer turn reported a blocker it could not resolve on its own.',
         'Judge entirely from the inlined context sections below. You make no changes, run nothing, and look at nothing outside this prompt.',

package/dist/neal/agents/rounds.js

@@ -373,6 +373,14 @@ export async function runReviewerFinalCompletionRound(args) {
         }),
         logger: args.logger,
     });
+    // Trust-boundary policy: rounds-level validation calls like this one are
+    // the authoritative trust boundary for agent payloads, not redundant dead
+    // code. The json-block protocol validator never runs on native
+    // structured-output paths, and cross-field rules are enforced only here on
+    // those paths; test/orchestrator.test.ts deliberately drives this wrap
+    // (FinalCompletionReviewerVerdictError, subtype
+    // final_completion_verdict_invalid) with a non-conforming fake adapter.
+    // Do not remove rounds-level validation calls.
     let verdict;
     try {
         verdict = parseFinalCompletionReviewerPayload(structured);