@naturalcycles/firestore-lib 1.1.11 → 1.2.1

package/dist/firestore.db.d.ts

@@ -7,20 +7,20 @@ export interface FirestoreDBCfg {
 }
 export interface FirestoreDBOptions extends CommonDBOptions {
 }
-export interface FirestoreDBSaveOptions<ROW extends ObjectWithId = AnyObjectWithId> extends CommonDBSaveOptions<ROW> {
+export interface FirestoreDBSaveOptions<ROW extends Partial<ObjectWithId> = AnyObjectWithId> extends CommonDBSaveOptions<ROW> {
 }
 export declare class FirestoreDB extends BaseCommonDB implements CommonDB {
     cfg: FirestoreDBCfg;
     constructor(cfg: FirestoreDBCfg);
-    getByIds<ROW extends ObjectWithId>(table: string, ids: string[], opt?: FirestoreDBOptions): Promise<ROW[]>;
-    getById<ROW extends ObjectWithId>(table: string, id: string, _opt?: FirestoreDBOptions): Promise<ROW | undefined>;
+    getByIds<ROW extends ObjectWithId>(table: string, ids: ROW['id'][], opt?: FirestoreDBOptions): Promise<ROW[]>;
+    getById<ROW extends ObjectWithId>(table: string, id: ROW['id'], _opt?: FirestoreDBOptions): Promise<ROW | null>;
     runQuery<ROW extends ObjectWithId>(q: DBQuery<ROW>, opt?: FirestoreDBOptions): Promise<RunQueryResult<ROW>>;
     runFirestoreQuery<ROW extends ObjectWithId>(q: Query, _opt?: FirestoreDBOptions): Promise<ROW[]>;
     runQueryCount<ROW extends ObjectWithId>(q: DBQuery<ROW>, opt?: FirestoreDBOptions): Promise<number>;
     streamQuery<ROW extends ObjectWithId>(q: DBQuery<ROW>, _opt?: CommonDBStreamOptions): ReadableTyped<ROW>;
-    saveBatch<ROW extends ObjectWithId>(table: string, rows: ROW[], _opt?: FirestoreDBSaveOptions<ROW>): Promise<void>;
+    saveBatch<ROW extends Partial<ObjectWithId>>(table: string, rows: ROW[], opt?: FirestoreDBSaveOptions<ROW>): Promise<void>;
     deleteByQuery<ROW extends ObjectWithId>(q: DBQuery<ROW>, opt?: FirestoreDBOptions): Promise<number>;
-    deleteByIds(table: string, ids: string[], _opt?: FirestoreDBOptions): Promise<number>;
+    deleteByIds<ROW extends ObjectWithId>(table: string, ids: ROW['id'][], _opt?: FirestoreDBOptions): Promise<number>;
     private querySnapshotToArray;
     commitTransaction(_tx: DBTransaction, _opt?: CommonDBSaveOptions): Promise<void>;
     ping(): Promise<void>;

package/dist/firestore.db.js

@@ -6,6 +6,11 @@ const js_lib_1 = require("@naturalcycles/js-lib");
 const nodejs_lib_1 = require("@naturalcycles/nodejs-lib");
 const firestore_util_1 = require("./firestore.util");
 const query_util_1 = require("./query.util");
+const methodMap = {
+    insert: 'create',
+    update: 'update',
+    upsert: 'set',
+};
 class FirestoreDB extends db_lib_1.BaseCommonDB {
     constructor(cfg) {
         super();
@@ -21,7 +26,7 @@ class FirestoreDB extends db_lib_1.BaseCommonDB {
         const doc = await this.cfg.firestore.collection(table).doc((0, firestore_util_1.escapeDocId)(id)).get();
         const data = doc.data();
         if (data === undefined)
-            return;
+            return null;
         return {
             id,
             ...data,
@@ -54,12 +59,14 @@ class FirestoreDB extends db_lib_1.BaseCommonDB {
         }));
     }
     // SAVE
-    async saveBatch(table, rows, _opt) {
+    async saveBatch(table, rows, opt = {}) {
+        const method = methodMap[opt.saveMethod] || 'set';
         // Firestore allows max 500 items in one batch
         await (0, js_lib_1.pMap)((0, js_lib_1._chunk)(rows, 500), async (chunk) => {
             const batch = this.cfg.firestore.batch();
             chunk.forEach(row => {
-                batch.set(this.cfg.firestore.collection(table).doc((0, firestore_util_1.escapeDocId)(row.id)), (0, js_lib_1._filterUndefinedValues)(row));
+                (0, js_lib_1._assert)(row.id, `firestore-db doesn't support id auto-generation, but empty id was provided in saveBatch`);
+                batch[method](this.cfg.firestore.collection(table).doc((0, firestore_util_1.escapeDocId)(row.id)), (0, js_lib_1._filterUndefinedValues)(row));
             });
             await batch.commit();
         }, { concurrency: 1 });

package/dist/firestore.util.d.ts

@@ -1,2 +1,2 @@
-export declare function escapeDocId(docId: string): string;
+export declare function escapeDocId(docId: string | number): string;
 export declare function unescapeDocId(docId: string): string;

package/dist/firestore.util.js

@@ -4,10 +4,13 @@ exports.unescapeDocId = exports.escapeDocId = void 0;
 const js_lib_1 = require("@naturalcycles/js-lib");
 const SLASH = '_SLASH_';
 function escapeDocId(docId) {
+    if (typeof docId === 'number')
+        return String(docId);
     return (0, js_lib_1._replaceAll)(docId, '/', SLASH);
 }
 exports.escapeDocId = escapeDocId;
 function unescapeDocId(docId) {
+    // if (typeof docId === 'number') return docId
     return (0, js_lib_1._replaceAll)(docId, SLASH, '/');
 }
 exports.unescapeDocId = unescapeDocId;

package/package.json

@@ -4,18 +4,18 @@
     "prepare": "husky install"
   },
   "dependencies": {
-    "@google-cloud/firestore": "^4.5.0",
+    "@google-cloud/firestore": "^5.0.2",
     "@naturalcycles/db-lib": "^8.2.0",
     "@naturalcycles/js-lib": "^14.6.0",
     "@naturalcycles/nodejs-lib": "^12.4.0",
-    "firebase-admin": "^10.0.0"
+    "firebase-admin": "^11.0.0"
   },
   "devDependencies": {
-    "@naturalcycles/dev-lib": "^12.1.2",
+    "@naturalcycles/dev-lib": "^13.0.1",
     "@naturalcycles/test-lib": "^1.0.3",
-    "@types/node": "^17.0.22",
+    "@types/node": "^18.0.0",
     "dotenv": "^16.0.0",
-    "jest": "^27.0.6"
+    "jest": "^28.1.0"
   },
   "files": [
     "dist",
@@ -37,7 +37,7 @@
   "engines": {
     "node": ">=14.15.0"
   },
-  "version": "1.1.11",
+  "version": "1.2.1",
   "description": "Firestore implementation of CommonDB interface",
   "author": "Natural Cycles Team",
   "license": "MIT"

package/src/firestore.db.ts

@@ -3,6 +3,7 @@ import {
   BaseCommonDB,
   CommonDB,
   CommonDBOptions,
+  CommonDBSaveMethod,
   CommonDBSaveOptions,
   CommonDBStreamOptions,
   DBQuery,
@@ -17,6 +18,7 @@ import {
   _filterUndefinedValues,
   ObjectWithId,
   AnyObjectWithId,
+  _assert,
 } from '@naturalcycles/js-lib'
 import { ReadableTyped, transformMapSimple } from '@naturalcycles/nodejs-lib'
 import { escapeDocId, unescapeDocId } from './firestore.util'
@@ -27,9 +29,15 @@ export interface FirestoreDBCfg {
 }
 
 export interface FirestoreDBOptions extends CommonDBOptions {}
-export interface FirestoreDBSaveOptions<ROW extends ObjectWithId = AnyObjectWithId>
+export interface FirestoreDBSaveOptions<ROW extends Partial<ObjectWithId> = AnyObjectWithId>
   extends CommonDBSaveOptions<ROW> {}
 
+const methodMap: Record<CommonDBSaveMethod, string> = {
+  insert: 'create',
+  update: 'update',
+  upsert: 'set',
+}
+
 export class FirestoreDB extends BaseCommonDB implements CommonDB {
   constructor(public cfg: FirestoreDBCfg) {
     super()
@@ -38,7 +46,7 @@ export class FirestoreDB extends BaseCommonDB implements CommonDB {
   // GET
   override async getByIds<ROW extends ObjectWithId>(
     table: string,
-    ids: string[],
+    ids: ROW['id'][],
     opt?: FirestoreDBOptions,
   ): Promise<ROW[]> {
     // Oj, doesn't look like a very optimal implementation!
@@ -50,13 +58,13 @@ export class FirestoreDB extends BaseCommonDB implements CommonDB {
 
   async getById<ROW extends ObjectWithId>(
     table: string,
-    id: string,
+    id: ROW['id'],
     _opt?: FirestoreDBOptions,
-  ): Promise<ROW | undefined> {
+  ): Promise<ROW | null> {
     const doc = await this.cfg.firestore.collection(table).doc(escapeDocId(id)).get()
 
     const data = doc.data()
-    if (data === undefined) return
+    if (data === undefined) return null
 
     return {
       id,
@@ -116,11 +124,13 @@ export class FirestoreDB extends BaseCommonDB implements CommonDB {
   }
 
   // SAVE
-  override async saveBatch<ROW extends ObjectWithId>(
+  override async saveBatch<ROW extends Partial<ObjectWithId>>(
     table: string,
     rows: ROW[],
-    _opt?: FirestoreDBSaveOptions<ROW>,
+    opt: FirestoreDBSaveOptions<ROW> = {},
   ): Promise<void> {
+    const method = methodMap[opt.saveMethod!] || 'set'
+
     // Firestore allows max 500 items in one batch
     await pMap(
       _chunk(rows, 500),
@@ -128,7 +138,11 @@ export class FirestoreDB extends BaseCommonDB implements CommonDB {
         const batch = this.cfg.firestore.batch()
 
         chunk.forEach(row => {
-          batch.set(
+          _assert(
+            row.id,
+            `firestore-db doesn't support id auto-generation, but empty id was provided in saveBatch`,
+          )
+          ;(batch as any)[method](
             this.cfg.firestore.collection(table).doc(escapeDocId(row.id)),
             _filterUndefinedValues(row),
           )
@@ -156,9 +170,9 @@ export class FirestoreDB extends BaseCommonDB implements CommonDB {
     return ids.length
   }
 
-  override async deleteByIds(
+  override async deleteByIds<ROW extends ObjectWithId>(
     table: string,
-    ids: string[],
+    ids: ROW['id'][],
     _opt?: FirestoreDBOptions,
   ): Promise<number> {
     await pMap(_chunk(ids, 500), async chunk => {

package/src/firestore.util.ts

@@ -2,10 +2,12 @@ import { _replaceAll } from '@naturalcycles/js-lib'
 
 const SLASH = '_SLASH_'
 
-export function escapeDocId(docId: string): string {
+export function escapeDocId(docId: string | number): string {
+  if (typeof docId === 'number') return String(docId)
   return _replaceAll(docId, '/', SLASH)
 }
 
 export function unescapeDocId(docId: string): string {
+  // if (typeof docId === 'number') return docId
   return _replaceAll(docId, SLASH, '/')
 }