@naturalcycles/dev-lib 20.70.0 → 20.72.0

package/cfg/oxlint.config.js

@@ -72,7 +72,7 @@ export const sharedConfig = {
       { blankLine: 'always', prev: '*', next: 'class' },
     ],
     '@stylistic/lines-between-class-members': [2, 'always', { exceptAfterSingleLine: true }],
-    'nc/prefer-assert': 0, // opt-in (set to 2): flags `if (cond) throw new Error(...)` that could be `_assert(...)`
+    'nc/prefer-assert': 2,
     complexity: [2, { max: 40 }],
     'logical-assignment-operators': [
       2,
@@ -96,8 +96,10 @@ export const sharedConfig = {
     'object-shorthand': 2,
     'valid-expect': 0,
     'valid-title': 0,
-    'vitest/valid-title': 0,
+    'vitest/valid-title': [2, { mustMatch: { it: '^should ' } }],
     'valid-describe-callback': 0,
+    // Options arguments and variables are `opt`, never `opts`
+    'id-denylist': [2, 'opts'],
     // 'id-denylist': [
     //   0, // actually not useful
     //   'any',
@@ -146,11 +148,14 @@ export const sharedConfig = {
         name: 'Intl',
         message: 'Use Intl2 instead.',
       },
+      { name: 'Date', message: 'Use localTime / localDate from @naturalcycles/js-lib/datetime.' },
     ],
     'no-unused-expressions': 2,
     'no-var': 2,
     'unicode-bom': 2,
     'no-extend-native': 2,
+    'no-prototype-builtins': 2,
+    'prefer-object-has-own': 2,
     'no-extra-bind': 2,
     'no-duplicate-imports': [
       0, // disabled until auto-fix is there
@@ -462,13 +467,7 @@ export const sharedConfig = {
     'vitest/prefer-called-exactly-once-with': 2,
     'vitest/consistent-test-filename': 2,
     'vitest/warn-todo': 0,
-    'vitest/consistent-test-it': [
-      2,
-      {
-        fn: 'test',
-        withinDescribe: 'test',
-      },
-    ],
+    'vitest/consistent-test-it': [2, { fn: 'it', withinDescribe: 'it' }],
     'vitest/max-nested-describe': [0, { max: 4 }], // not good
     'vitest/no-alias-methods': 2,
     'vitest/no-restricted-vi-methods': [

package/dist/check.util.js

@@ -4,7 +4,7 @@ import { findPackageJSON } from 'node:module';
 import path from 'node:path';
 import { _isTruthy } from '@naturalcycles/js-lib';
 import { _uniq } from '@naturalcycles/js-lib/array';
-import { _since } from '@naturalcycles/js-lib/datetime/time.util.js';
+import { _since, nowUnixMillis } from '@naturalcycles/js-lib/datetime/time.util.js';
 import { _assert } from '@naturalcycles/js-lib/error/assert.js';
 import { _filterFalsyValues } from '@naturalcycles/js-lib/object/object.util.js';
 import { semver2 } from '@naturalcycles/js-lib/semver';
@@ -24,7 +24,7 @@ const { CI } = process.env;
  */
 export async function runCheck(opt = {}) {
     const { fastLinters = true, eslint = true, stylelint = true, oxfmt = true, ktlint = true, typecheck = false, test = true, } = opt;
-    const started = Date.now();
+    const started = nowUnixMillis();
     let s;
     const timings = {};
     // const { commitOnChanges, failOnChanges } = _yargs().options({
@@ -49,52 +49,52 @@ export async function runCheck(opt = {}) {
     const fix = !CI;
     if (fastLinters) {
         // Fast linters (that run in <1 second) go first
-        s = Date.now();
+        s = nowUnixMillis();
         if (runActionLint()) {
-            timings['actionlint'] = Date.now() - s;
+            timings['actionlint'] = nowUnixMillis() - s;
         }
-        s = Date.now();
+        s = nowUnixMillis();
         if (runOxlint(fix)) {
-            timings['oxlint'] = Date.now() - s;
+            timings['oxlint'] = nowUnixMillis() - s;
         }
     }
     // From this point we start the "slow" linters, with ESLint leading the way
     if (eslint) {
         // We run eslint BEFORE Prettier, because eslint can delete e.g unused imports.
-        s = Date.now();
+        s = nowUnixMillis();
         if (eslintAll({ fix })) {
-            timings['eslint'] = Date.now() - s;
+            timings['eslint'] = nowUnixMillis() - s;
         }
     }
     if (stylelint &&
         hasDependencyInNodeModules('stylelint') &&
         hasDependencyInNodeModules('stylelint-config-standard-scss')) {
-        s = Date.now();
+        s = nowUnixMillis();
         if (stylelintAll(fix)) {
-            timings['stylelint'] = Date.now() - s;
+            timings['stylelint'] = nowUnixMillis() - s;
         }
     }
     if (oxfmt) {
-        s = Date.now();
+        s = nowUnixMillis();
         if (runOxfmt(fix)) {
-            timings['oxfmt'] = Date.now() - s;
+            timings['oxfmt'] = nowUnixMillis() - s;
         }
     }
     if (ktlint) {
-        s = Date.now();
+        s = nowUnixMillis();
         if (await runKTLint(fix)) {
-            timings['ktlint'] = Date.now() - s;
+            timings['ktlint'] = nowUnixMillis() - s;
         }
     }
     if (typecheck) {
-        s = Date.now();
+        s = nowUnixMillis();
         await runTypecheck();
-        timings['tsc'] = Date.now() - s;
+        timings['tsc'] = nowUnixMillis() - s;
     }
     if (test) {
-        s = Date.now();
+        s = nowUnixMillis();
         if (runTest()) {
-            timings['test'] = Date.now() - s;
+            timings['test'] = nowUnixMillis() - s;
         }
     }
     console.log(`${check(true)}${white(`check`)} ${dimGrey(`took ` + _since(started))}`);

package/dist/release/notes.util.js

@@ -1,3 +1,4 @@
+import { localDate } from '@naturalcycles/js-lib/datetime/localDate.js';
 /**
  * Generate release notes markdown for a GitHub Release,
  * following the format of `@semantic-release/release-notes-generator` (angular preset):
@@ -5,7 +6,7 @@
  */
 export function generateReleaseNotes(input) {
     const { repo, commits, lastTag, nextTag } = input;
-    const date = input.date || new Date().toISOString().slice(0, 10);
+    const date = input.date || localDate.todayInUTC().toISODate();
     const header = lastTag
         ? `## [${nextTag}](${repo.url}/compare/${lastTag}...${nextTag}) (${date})`
         : `## ${nextTag} (${date})`;

package/dist/testing/mockAllKindsOfThings.js

@@ -44,6 +44,7 @@ export const mockAllKindsOfThings = () => {
             k1: 'v1',
         }),
         Symbol('a_am_symbol'),
+        // oxlint-disable-next-line no-restricted-globals -- a native Date is one of the kinds of things
         new Date(1984, 5, 21),
     ];
 };

package/dist/vendor/mitm.d.ts

@@ -11,7 +11,7 @@ export interface BypassableSocket extends NetType.Socket {
     bypass: () => void;
     bypassed?: boolean;
 }
-export type ConnectCallback = (socket: BypassableSocket, opts: SocketOptions) => void;
+export type ConnectCallback = (socket: BypassableSocket, opt: SocketOptions) => void;
 export interface Mitm {
     on: (event: 'connect', callback: ConnectCallback) => void;
     disable: () => void;

package/dist/vendor/mitm.js

@@ -18,7 +18,7 @@ export function createMitm() {
             s[0][s[1]] = s[2];
         }
     }
-    function connect(orig, opts, done) {
+    function connect(orig, opt, done) {
         // Create a bypassable socket that we'll pass to listeners
         const socket = new Net.Socket();
         socket.bypassed = false;
@@ -27,11 +27,11 @@ export function createMitm() {
         };
         // Emit connect event to all listeners
         for (const listener of listeners) {
-            listener(socket, opts);
+            listener(socket, opt);
         }
         // If bypassed, call the original connect function
         if (socket.bypassed) {
-            return orig.call(Net, opts, done);
+            return orig.call(Net, opt, done);
         }
         // Not bypassed - return the socket that will never actually connect.
         // testOffline throws an error before we get here, so this is just a fallback.
@@ -43,12 +43,12 @@ export function createMitm() {
         // connect(options, callback?)
         // connect(path, callback?) - Unix socket
         if (typeof args[0] === 'number') {
-            const opts = { port: args[0] };
+            const opt = { port: args[0] };
             if (typeof args[1] === 'string') {
-                opts.host = args[1];
-                return [opts, args[2]];
+                opt.host = args[1];
+                return [opt, args[2]];
             }
-            return [opts, args[1]];
+            return [opt, args[1]];
         }
         if (typeof args[0] === 'object' && args[0] !== null) {
             return [args[0], args[1]];
@@ -58,14 +58,14 @@ export function createMitm() {
     }
     function createNetConnect(orig) {
         return function (...args) {
-            const [opts, done] = normalizeArgs(args);
-            return connect(orig, opts, done);
+            const [opt, done] = normalizeArgs(args);
+            return connect(orig, opt, done);
         };
     }
     function createTlsConnect(orig) {
         return function (...args) {
-            const [opts, done] = normalizeArgs(args);
-            return connect(orig, opts, done);
+            const [opt, done] = normalizeArgs(args);
+            return connect(orig, opt, done);
         };
     }
     // Stub network functions

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@naturalcycles/dev-lib",
   "type": "module",
-  "version": "20.70.0",
+  "version": "20.72.0",
   "dependencies": {
     "prompts": "^2",
     "@naturalcycles/js-lib": "^15",

package/readme.md

@@ -17,11 +17,6 @@
 - actionlint
 - lint-staged
 
-The shared oxlint config ships an opt-in `nc/prefer-assert` rule, off by default. It flags an `if`
-whose only statement is `throw new Error(...)` (or `AppError`, `AssertionError`) that reads better
-as `_assert(condition, message, data)` from `@naturalcycles/js-lib/error`. Test files are exempt.
-Turn it on in your `oxlint.config.ts` with `rules: { 'nc/prefer-assert': 2 }`.
-
 ## How to use
 
 Install it: