@naturalcycles/dev-lib 20.64.0 → 20.65.1

package/cfg/vitest.config.d.ts

@@ -15,30 +15,43 @@ import type { InlineConfig } from 'vitest/node'
  */
 export function defineVitestConfig(config?: Partial<ViteUserConfig>, cwd?: string): ViteUserConfig
 
+/**
+ * For the ROOT vitest.config.ts of a monorepo (Vitest `projects` mode):
+ *
+ * export default defineVitestMonorepoConfig({
+ *   test: {
+ *     projects: ['./packages/*'],
+ *     // overrides here, e.g:
+ *     // coverage: { enabled: false },
+ *   },
+ * })
+ *
+ * Sets the root-only options (reporters, outputFile, coverage, silent, watch,
+ * slowTestThreshold, sequence.sequencer), which Vitest reads from the root config only and
+ * ignores on the per-project configs (defineVitestConfig in each package).
+ */
+export function defineVitestMonorepoConfig(config: Partial<ViteUserConfig>): ViteUserConfig
+
 /**
  * Pass `import.meta.dirname` as cwd if running from a monorepo.
  */
 export function getSharedConfig(cwd?: string): InlineConfig
 
 /**
- * Reporters for the monorepo root config (Vitest `projects` mode), where
- * `reporters` is a root-only option. Returns the compact 'agent' reporter for
- * agents, otherwise the default reporters plus a monorepo-wide SummaryReporter.
+ * @deprecated Use defineVitestMonorepoConfig for the monorepo root config instead. It sets
+ * `reporters` together with all the other root-only options.
  */
 export function getRootReporters(): InlineConfig['reporters']
 
 /**
- * `outputFile` for the junit/json reporters at the monorepo root config (Vitest
- * `projects` mode), where `outputFile` is a root-only option. Pair it with
- * getRootReporters so the junit/json report is written in the aggregate root run.
+ * @deprecated Use defineVitestMonorepoConfig for the monorepo root config instead. It sets
+ * `outputFile` together with all the other root-only options.
  */
 export function getRootOutputFile(): InlineConfig['outputFile']
 
 /**
- * `coverage` for the monorepo root config (Vitest `projects` mode), where
- * `coverage` is a root-only option. Without it on the root config no coverage
- * report is produced when running via `projects`. Produces a single unified
- * report spanning all projects.
+ * @deprecated Use defineVitestMonorepoConfig for the monorepo root config instead. It sets
+ * `coverage` together with all the other root-only options.
  */
 export function getRootCoverage(): InlineConfig['coverage']
 

package/cfg/vitest.config.js

@@ -9,7 +9,7 @@ export { CollectReporter } from './collectReporter.js'
 
 const runsInIDE = doesItRunInIDE()
 const testType = getTestType(runsInIDE)
-const silent = shouldBeSilent(runsInIDE)
+const silent = getSilent(runsInIDE)
 const { include, exclude } = getIncludeAndExclude(testType)
 const isCI = !!process.env.CI
 const coverageEnabled = isCI && testType === 'unit'
@@ -27,6 +27,9 @@ if (testType === 'unit') {
 }
 
 if (silent) {
+  // Tells the tests that vitest is suppressing console output, so they keep the output vitest
+  // can't intercept quiet too: child process stdio (see exec2.test.ts) and dev-lib's testLogger,
+  // which writes to process.stdout directly.
   process.env.TEST_SILENT = 'true'
 }
 
@@ -37,6 +40,9 @@ if (silent) {
  *   // overrides here, e.g:
  *   // bail: 1,
  * })
+ *
+ * In a monorepo: use it in the vitest.config.ts of each package (passing `import.meta.dirname`
+ * as cwd), and defineVitestMonorepoConfig in the root vitest.config.ts.
  */
 export function defineVitestConfig(config, cwd) {
   const mergedConfig = defineConfig({
@@ -67,26 +73,84 @@ export function defineVitestConfig(config, cwd) {
 }
 
 /**
- * Shared config for Vitest.
+ * Use it in the ROOT vitest.config.ts of a monorepo (Vitest `projects` mode):
+ *
+ * export default defineVitestMonorepoConfig({
+ *   test: {
+ *     projects: ['./packages/*'],
+ *     // overrides here, e.g:
+ *     // coverage: { enabled: false },
+ *   },
+ * })
+ *
+ * In `projects` mode Vitest has two kinds of config: the root config (this one) and the
+ * per-project configs (defineVitestConfig in each package). A set of options is root-only:
+ * Vitest reads them from the root config only and silently IGNORES the per-project values
+ * (see `NonProjectOptions` in Vitest's types): `reporters`, `outputFile`, `coverage`, `silent`,
+ * `watch`, `slowTestThreshold`, `sequence.sequencer`, etc.
+ *
+ * This helper sets the root-only part of the shared config (see getRootConfig) on the root
+ * config, where it takes effect. So the junit/json/coverage reports are written, the
+ * SummaryReporter reports the slowest tests across ALL projects, and the
+ * VitestAlphabeticSequencer is actually used, monorepo-wide.
+ */
+export function defineVitestMonorepoConfig(config) {
+  return defineConfig({
+    ...config,
+    test: {
+      ...getRootConfig(),
+      ...config?.test,
+    },
+  })
+}
+
+/**
+ * Shared config for Vitest: for a single-package repo, or for one project (package) of a
+ * monorepo (pass `import.meta.dirname` as cwd).
  */
 export function getSharedConfig(cwd) {
   return {
+    // Root-only options. In a single-package repo this config IS the root, so they apply.
+    // In a monorepo they are IGNORED here (Vitest reads them from the root config only), so
+    // defineVitestMonorepoConfig sets them on the root config instead.
+    ...getRootConfig(),
+    // Per-project options
     pool,
     maxWorkers,
     isolate: false,
-    watch: false,
     // dir: 'src',
     restoreMocks: true,
     // restoreMocks does not cover vi.stubEnv/vi.stubGlobal
     unstubEnvs: true,
     unstubGlobals: true,
-    silent,
     setupFiles: getSetupFiles(testType, cwd),
     logHeapUsage: true,
     testTimeout: 60_000,
     hookTimeout: 60_000,
-    slowTestThreshold: isCI ? 500 : 300, // higher threshold in CI
     injectCjsGlobals: false,
+    deps: {
+      // Disable CJS/ESM interop to match production Node.js behavior.
+      // Without this, vitest auto-promotes default exports to named exports,
+      // which can mask import bugs (e.g., ejs v4 renderFile issue).
+      // Vitest's own default is `true`.
+      interopDefault: false,
+    },
+    include,
+    exclude,
+  }
+}
+
+/**
+ * The root-only subset of the shared config: the options Vitest reads from the root config
+ * only (`NonProjectOptions` in Vitest's types, plus `sequence.sequencer`), hence the ones that
+ * must be set on the root config of a monorepo to take effect there. Shared by getSharedConfig
+ * (where they apply in a single-package repo) and defineVitestMonorepoConfig.
+ */
+function getRootConfig() {
+  return {
+    watch: false,
+    silent,
+    slowTestThreshold: isCI ? 500 : 300, // higher threshold in CI
     sequence: {
       sequencer: VitestAlphabeticSequencer,
       // shuffle: {
@@ -95,46 +159,46 @@ export function getSharedConfig(cwd) {
       // },
       // seed: 1, // this makes the order of tests deterministic (but still not alphabetic)
     },
-    include,
-    exclude,
     reporters: getReporters(junitReporterEnabled, testType),
     outputFile: getOutputFile(),
     coverage: getCoverageConfig(),
   }
 }
 
-function getReporters(junitReporterEnabled, testType) {
-  const override = getReporterOverride()
-  if (override) return override
+/**
+ * @deprecated Use defineVitestMonorepoConfig for the monorepo root config instead. It sets
+ * `reporters` together with all the other root-only options (see getRootConfig).
+ */
+export function getRootReporters() {
+  return getReporters(junitReporterEnabled, testType)
+}
 
-  const { GITHUB_ACTIONS } = process.env
-  return [
-    'default',
-    GITHUB_ACTIONS && 'github-actions',
-    new SummaryReporter(),
-    ...getJunitReporters(junitReporterEnabled, testType),
-  ].filter(Boolean)
+/**
+ * @deprecated Use defineVitestMonorepoConfig for the monorepo root config instead. It sets
+ * `outputFile` together with all the other root-only options (see getRootConfig).
+ */
+export function getRootOutputFile() {
+  return getOutputFile()
 }
 
 /**
- * Reporters for the monorepo root config (Vitest `projects` mode).
- *
- * `reporters` is a root-only Vitest option: per-project reporters are ignored
- * when running via `projects`. So the per-package SummaryReporter never runs in
- * the aggregate root run, and - crucially - a root-level SummaryReporter sees
- * the test modules of ALL projects at once, letting it report the slowest tests
- * across the entire monorepo.
- *
- * Use it in the root vitest.config.ts:
+ * @deprecated Use defineVitestMonorepoConfig for the monorepo root config instead. It sets
+ * `coverage` together with all the other root-only options (see getRootConfig).
+ */
+export function getRootCoverage() {
+  return getCoverageConfig()
+}
+
+/**
+ * The reporters, shared by the per-package (getSharedConfig) and the monorepo root
+ * (defineVitestMonorepoConfig) configs.
  *
- * export default defineConfig({
- *   test: {
- *     projects: ['./packages/*'],
- *     reporters: getRootReporters(),
- *   },
- * })
+ * In a monorepo (`projects` mode) `reporters` is root-only: per-project reporters are ignored.
+ * So the per-package SummaryReporter never runs in the aggregate root run, and - crucially -
+ * a root-level SummaryReporter sees the test modules of ALL projects at once, letting it report
+ * the slowest tests across the entire monorepo.
  */
-export function getRootReporters() {
+function getReporters(junitReporterEnabled, testType) {
   const override = getReporterOverride()
   if (override) return override
 
@@ -148,60 +212,19 @@ export function getRootReporters() {
 }
 
 /**
- * `outputFile` for the junit/json reporters at the monorepo root config.
- *
- * Like `reporters`, `outputFile` is a root-only Vitest option: per-project
- * `outputFile` is ignored when running via `projects`. So the root config must
- * set it (alongside getRootReporters) for the junit/json report to be written
- * in the aggregate root run.
- *
- * Use it in the root vitest.config.ts:
- *
- * export default defineConfig({
- *   test: {
- *     projects: ['./packages/*'],
- *     reporters: getRootReporters(),
- *     outputFile: getRootOutputFile(),
- *   },
- * })
- */
-export function getRootOutputFile() {
-  return getOutputFile()
-}
-
-/**
- * `coverage` config for the monorepo root config (Vitest `projects` mode).
+ * The coverage config, shared by the per-package (getSharedConfig) and the monorepo root
+ * (defineVitestMonorepoConfig) configs. Only enabled for CI unit-test runs.
  *
- * Like `reporters` and `outputFile`, `coverage` is a root-only Vitest option:
- * it is read from the root project only (see Vitest's `getRootProject().
- * serializedConfig.coverage`), so the per-package `coverage` set in
- * getSharedConfig is IGNORED when running via `projects`. Without this on the
+ * In a monorepo (`projects` mode) `coverage` is root-only: it is read from the root project
+ * only (see Vitest's `getRootProject().serializedConfig.coverage`), so the per-package
+ * `coverage` set in getSharedConfig is IGNORED when running via `projects`. Without it on the
  * root config no coverage report is produced at all (e.g. the CI upload of
  * ./coverage/coverage-summary.json finds nothing).
  *
- * The report is a single, unified one spanning all projects: Vitest tracks
- * coverage per-project internally but emits one report under `./coverage`.
- * Per-project coverage `include` globs are matched unanchored against absolute
- * paths, so executed files under `packages/<pkg>/src/**` are still included.
- *
- * Use it in the root vitest.config.ts:
- *
- * export default defineConfig({
- *   test: {
- *     projects: ['./packages/*'],
- *     reporters: getRootReporters(),
- *     outputFile: getRootOutputFile(),
- *     coverage: getRootCoverage(),
- *   },
- * })
- */
-export function getRootCoverage() {
-  return getCoverageConfig()
-}
-
-/**
- * The coverage config, shared by the per-package (getSharedConfig) and root
- * (getRootCoverage) configs. Only enabled for CI unit-test runs.
+ * The report is a single, unified one spanning all projects: Vitest tracks coverage per-project
+ * internally but emits one report under `./coverage`. Per-project coverage `include` globs are
+ * matched unanchored against absolute paths, so executed files under `packages/<pkg>/src/**`
+ * are still included.
  */
 function getCoverageConfig() {
   return {
@@ -240,7 +263,7 @@ function getCoverageConfig() {
 
 /**
  * The junit + json reporters, enabled in CI (except for manual tests).
- * Shared by the per-package (getReporters) and root (getRootReporters) configs.
+ * Used (via getReporters) by both the per-package and the monorepo root configs.
  */
 function getJunitReporters(junitReporterEnabled, testType) {
   if (!junitReporterEnabled) return []
@@ -310,32 +333,20 @@ function getTestType(runsInIDE) {
   return process.env.TEST_TYPE || 'unit'
 }
 
-function shouldBeSilent(runsInIDE) {
-  if (runsInIDE) {
-    return false
-  }
-  return isRunningAllTests()
-}
-
 /**
- * Detects if vitest is run with all tests, or with selected individual tests.
+ * Console output of failed tests only, in every CLI run - whether it runs all tests or a single
+ * file. Pass `--silent=false` to see the output of passing tests too.
+ * In the IDE everything is printed, as IDE runs are interactive debugging.
  */
-function isRunningAllTests() {
-  let vitestArg = false
-  let hasPositionalArgs = false
-  process.argv.forEach(a => {
-    if (a.includes('.bin/vitest')) {
-      vitestArg = true
-      return
-    }
-    if (!vitestArg) return
-    if (!a.startsWith('-')) {
-      hasPositionalArgs = true
-    }
-  })
-  // console.log({vitestArg, hasPositionalArgs}, process.argv)
-
-  return !hasPositionalArgs
+function getSilent(runsInIDE) {
+  if (runsInIDE) return false
+  // Vitest applies `--silent=false` to `silent` by itself; mirroring it here keeps TEST_SILENT
+  // (see above) in sync, so the output vitest can't intercept is shown as well.
+  const silentFalse = process.argv.some(
+    (a, i) => a === '--silent=false' || (a === '--silent' && process.argv[i + 1] === 'false'),
+  )
+  if (silentFalse) return false
+  return 'passed-only'
 }
 
 function getSetupFiles(testType, cwd = process.cwd()) {

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@naturalcycles/dev-lib",
   "type": "module",
-  "version": "20.64.0",
+  "version": "20.65.1",
   "dependencies": {
     "prompts": "^2",
     "@naturalcycles/js-lib": "^15",