@naturalcycles/dev-lib 20.61.0 → 20.63.0

package/cfg/oxlint.config.js

@@ -467,6 +467,18 @@ export const sharedConfig = {
     ],
     'vitest/max-nested-describe': [0, { max: 4 }], // not good
     'vitest/no-alias-methods': 2,
+    'vitest/no-restricted-vi-methods': [
+      2,
+      {
+        mock: 'vi.mock() is never cleared (isolate: false) and leaks into other test files on the same worker. Spy on the module namespace instead: vi.spyOn(ns, "fn") or vi.spyOn(ns, "constName", "get").',
+        doMock:
+          'vi.doMock() is never cleared (isolate: false) and leaks into other test files on the same worker. Use vi.spyOn() on the module namespace instead.',
+        hoisted:
+          'vi.hoisted() only exists to feed vi.mock() factories, which are banned. Use vi.spyOn() instead.',
+        resetModules:
+          'vi.resetModules() clears the shared module cache for every later test file on this worker (isolate: false).',
+      },
+    ],
     'vue/no-multiple-slot-args': 2,
     'vue/no-deprecated-destroyed-lifecycle': 2,
     'vue/define-emits-declaration': [2, 'type-based'],

package/cfg/vitest.config.js

@@ -77,6 +77,9 @@ export function getSharedConfig(cwd) {
     watch: false,
     // dir: 'src',
     restoreMocks: true,
+    // restoreMocks does not cover vi.stubEnv/vi.stubGlobal
+    unstubEnvs: true,
+    unstubGlobals: true,
     silent,
     setupFiles: getSetupFiles(testType, cwd),
     logHeapUsage: true,

package/dist/testing/testOffline.d.ts

@@ -1,4 +1,9 @@
 /**
+ * Forbids network requests to anything but local hosts for the rest of the test run.
+ *
+ * A forbidden request throws into the code under test and also fails the test that made it,
+ * so the failure survives the code under test catching the error.
+ *
  * Based on: https://github.com/palmerj3/jest-offline/blob/master/index.js
  */
 export declare function testOffline(opt?: TestOfflineOptions): void;

package/dist/testing/testOffline.js

@@ -6,6 +6,11 @@ const LOCAL_HOSTS = new Set(['localhost', '127.0.0.1']);
 const detectLeaks = process.argv.some(a => a.includes('detectLeaks'));
 let mitm;
 /**
+ * Forbids network requests to anything but local hosts for the rest of the test run.
+ *
+ * A forbidden request throws into the code under test and also fails the test that made it,
+ * so the failure survives the code under test catching the error.
+ *
  * Based on: https://github.com/palmerj3/jest-offline/blob/master/index.js
  */
 export function testOffline(opt) {
@@ -22,9 +27,11 @@ export function testOffline(opt) {
             const testInfo = getCurrentTestInfo(host);
             process.stderr.write(red(`Network request forbidden by testOffline: ${testInfo}\n`));
             opt?.onForbiddenRequest?.(host);
-            throw new AppError(`Network request forbidden by testOffline: ${host}`, {
+            const error = new AppError(`Network request forbidden by testOffline: ${host}`, {
                 backendResponseStatusCode: 410,
             });
+            failCurrentTest(error);
+            throw error;
         }
         socket.bypass();
     });
@@ -49,7 +56,7 @@ export function testOnline() {
  */
 function getCurrentTestInfo(host) {
     const tokens = [host];
-    const state = globalThis['__vitest_worker__'];
+    const state = getWorkerState();
     if (state) {
         if (state.filepath) {
             tokens.push(`file: ${path.relative(process.cwd(), state.filepath)}`);
@@ -60,6 +67,27 @@ function getCurrentTestInfo(host) {
     }
     return tokens.filter(Boolean).join('\n');
 }
+/**
+ * Records the error on the running test the way `expect.soft` does: vitest only marks a test
+ * passed if nothing set its state to `fail` first. This is what makes the test fail even when the
+ * code under test catches the error thrown from the `connect` listener (a `pTry`, a fetcher that
+ * swallows failures) — otherwise such a test passes with nothing but the alert on stderr.
+ */
+function failCurrentTest(error) {
+    const result = getCurrentTest()?.result;
+    if (!result)
+        return;
+    result.state = 'fail';
+    result.errors ||= [];
+    result.errors.push({ name: error.name, message: error.message, stack: error.stack });
+}
+function getCurrentTest() {
+    const current = getWorkerState()?.current;
+    return current?.type === 'test' ? current : undefined;
+}
+function getWorkerState() {
+    return globalThis['__vitest_worker__'];
+}
 /**
  * Test name prefixed with the names of its parent suites (same as `expect.getState().currentTestName`),
  * e.g. `describe name > nested describe name > test name`.

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@naturalcycles/dev-lib",
   "type": "module",
-  "version": "20.61.0",
+  "version": "20.63.0",
   "dependencies": {
     "prompts": "^2",
     "@naturalcycles/js-lib": "^15",