@naturalcycles/dev-lib 20.31.2 → 20.33.0

package/cfg/eslint-rules.js

@@ -33,7 +33,7 @@ export default {
       },
     ],
     '@typescript-eslint/consistent-type-imports': 0, // ox
-    '@typescript-eslint/consistent-type-exports': 2,
+    '@typescript-eslint/consistent-type-exports': 0, // ox
     '@typescript-eslint/consistent-type-assertions': 2,
     '@typescript-eslint/consistent-type-definitions': [0, 'interface'], // ox
     '@typescript-eslint/consistent-generic-constructors': [0, 'constructor'], // ox

package/cfg/eslint.config.js

@@ -8,7 +8,6 @@ import eslint from '@eslint/js'
 import eslintPluginOxlint from 'eslint-plugin-oxlint'
 import globals from 'globals'
 import tseslint from 'typescript-eslint'
-import eslintBiomeRules from './eslint-biome-rules.js'
 import eslintPrettierRules from './eslint-prettier-rules.js'
 import eslintRules from './eslint-rules.js'
 
@@ -122,7 +121,7 @@ function getConfig(_tsconfigPath) {
       ...eslintRules.rules,
       // ...eslintVueRules.rules,
       ...eslintPrettierRules.rules, // disable eslint rules already covered by prettier
-      ...eslintBiomeRules.rules, // disable eslint rules already covered by biome
+      // ...eslintBiomeRules.rules, // disable eslint rules already covered by biome
       ...eslintPluginOxlint.configs['flat/all'][0].rules, // disable eslint rules already covered by oxlint
       // rules that are disabled, but shouldn't yet be disabled
       '@typescript-eslint/return-await': [2, 'always'],

package/cfg/lint-staged.config.js

@@ -70,13 +70,10 @@ const stylelintExists =
   fs.existsSync('node_modules/stylelint-config-standard-scss')
 const stylelintCmd = stylelintExists ? `stylelint --fix --config ${stylelintConfigPath}` : undefined
 
-const biomeConfigPath = ['biome.jsonc'].find(p => fs.existsSync(p))
-const biomeCmd = biomeConfigPath && `biome lint --write --unsafe --no-errors-on-unmatched`
-
 const linters = {
-  // biome, oxlint, eslint, stylelint, oxfmt
+  // oxlint, eslint, stylelint, oxfmt
   [`./{src,scripts,e2e}/**/*.{${prettierExtensionsAll}}`]: match =>
-    runBiomeEslintStylelintOxfmt(match),
+    runOxlintEslintStylelintOxfmt(match),
 
   // Files in root dir: oxfmt
   [`./*.{${prettierExtensionsAll}}`]: runOxfmt,
@@ -87,21 +84,15 @@ const linters = {
   './.github/**/*.{yml,yaml}': runActionlintOxfmt,
 }
 
-export function runBiomeEslintStylelintOxfmt(match) {
+export function runOxlintEslintStylelintOxfmt(match) {
   const filesList = getFilesList(match)
   if (!filesList) return []
 
-  return [biomeCmd, oxlintCmd, eslintCmd, stylelintCmd, oxfmtCmd]
+  return [oxlintCmd, eslintCmd, stylelintCmd, oxfmtCmd]
     .filter(Boolean)
     .map(s => `${s} ${filesList}`)
 }
 
-export function runBiomeOxlintOxfmt(match) {
-  const filesList = getFilesList(match)
-  if (!filesList) return []
-  return [biomeCmd, oxlintCmd, oxfmtCmd].filter(Boolean).map(s => `${s} ${filesList}`)
-}
-
 export function runOxlintOxfmt(match) {
   const filesList = getFilesList(match)
   if (!filesList) return []

package/cfg/oxlint.config.json

@@ -13,6 +13,14 @@
   ],
   "jsPlugins": ["./oxlint-plugin-stylistic.mjs"],
   "rules": {
+    "no-unused-vars": [
+      "error",
+      {
+        "varsIgnorePattern": "^(_$|__)",
+        "argsIgnorePattern": "^_",
+        "destructuredArrayIgnorePattern": "^_"
+      }
+    ],
     "@stylistic/padding-line-between-statements": [
       2,
       { "blankLine": "always", "prev": "function", "next": "*" },

package/dist/bin/dev-lib.js

@@ -3,7 +3,7 @@ import { _by } from '@naturalcycles/js-lib/array/array.util.js';
 import { _assert } from '@naturalcycles/js-lib/error/assert.js';
 import { fs2 } from '@naturalcycles/nodejs-lib/fs2';
 import { runScript } from '@naturalcycles/nodejs-lib/runScript';
-import { buildCopy, buildProd, eslintAll, lintStagedCommand, requireOxlintConfig, runBiome, runCheck, runOxfmt, runOxlint, runTest, stylelintAll, typecheckWithTS, typecheckWithTSC, typecheckWithTSGO, } from '../check.util.js';
+import { buildCopy, buildProd, eslintAll, lintStagedCommand, runCheck, runOxfmt, runOxlint, runTest, stylelintAll, typecheckWithTS, typecheckWithTSC, typecheckWithTSGO, } from '../check.util.js';
 import { runCommitlint } from '../commitlint.js';
 const commands = [
     { name: 'check', fn: runCheck, desc: '"Run all possible checks": lint, typecheck, then test.' },
@@ -59,11 +59,11 @@ const commands = [
         fn: () => runTest({ manual: true }),
         desc: 'Run vitest for *.manual.test.ts files.',
     },
-    {
-        name: 'test-leaks',
-        fn: () => runTest({ leaks: true }),
-        desc: 'Run vitest --detectLeaks for *.test.ts files.',
-    },
+    // {
+    //   name: 'test-leaks',
+    //   fn: () => runTest({ leaks: true }),
+    //   desc: 'Run vitest --detectLeaks for *.test.ts files.',
+    // },
     {
         name: 'lint',
         fn: () => runCheck({
@@ -93,18 +93,6 @@ const commands = [
         desc: 'Run oxlint on all files with "auto-fix" disabled. Useful for debugging.',
         interactiveOnly: true,
     },
-    {
-        name: 'biome',
-        fn: () => runBiome(),
-        desc: 'Run biome linter on all files.',
-    },
-    { name: 'biome-no-fix', cliOnly: true, fn: () => runBiome(false) },
-    {
-        name: 'biome --no-fix',
-        fn: () => runBiome(false),
-        desc: 'Run biome linter on all files with "auto-fix" disabled. Useful for debugging.',
-        interactiveOnly: true,
-    },
     { name: 'oxfmt', fn: runOxfmt, desc: 'Run oxfmt on all files.' },
     { name: 'stylelint', fn: stylelintAll, desc: 'Run stylelint on all files.' },
     {
@@ -175,11 +163,11 @@ async function bt() {
     await typecheckWithTS();
     runTest();
 }
-async function _typecheckWithOxlint() {
-    requireOxlintConfig();
-    const fix = !CI;
-    runOxlint(fix);
-}
+// async function _typecheckWithOxlint(): Promise<void> {
+//   requireOxlintConfig()
+//   const fix = !CI
+//   runOxlint(fix)
+// }
 async function cleanBuild() {
     cleanDist();
     buildProd();

package/dist/check.util.d.ts

@@ -52,10 +52,6 @@ export declare function stylelintAll(fix?: boolean): boolean;
 export declare function lintStagedCommand(): Promise<void>;
 export declare function requireActionlintVersion(): void;
 export declare function getActionLintVersion(): SemVerString | undefined;
-/**
- * Returns true if it ran.
- */
-export declare function runBiome(fix?: boolean): boolean;
 export declare function buildProd(): void;
 /**
  * Uses tsgo if it's installed, otherwise tsc

package/dist/check.util.js

@@ -49,10 +49,9 @@ export async function runCheck(opt = {}) {
     const fix = !CI;
     if (fastLinters) {
         // Fast linters (that run in <1 second) go first
-        runActionLint();
         s = Date.now();
-        if (runBiome(fix)) {
-            timings['biome'] = Date.now() - s;
+        if (runActionLint()) {
+            timings['actionlint'] = Date.now() - s;
         }
         s = Date.now();
         if (runOxlint(fix)) {
@@ -322,24 +321,6 @@ export function getActionLintVersion() {
         return;
     return exec2.exec('actionlint --version').split('\n')[0];
 }
-/**
- * Returns true if it ran.
- */
-export function runBiome(fix = true) {
-    const configPath = `biome.jsonc`;
-    if (!existsSync(configPath)) {
-        console.log(`biome is skipped, because ./biome.jsonc is not present`);
-        return false;
-    }
-    const biomePath = findPackageBinPath('@biomejs/biome', 'biome');
-    const dirs = [`src`, `scripts`, `e2e`].filter(d => existsSync(d));
-    exec2.spawn(biomePath, {
-        name: fix ? 'biome' : 'biome --no-fix',
-        args: [`lint`, fix && '--write', fix && '--unsafe', '--no-errors-on-unmatched', ...dirs].filter(_isTruthy),
-        shell: false,
-    });
-    return true;
-}
 export function buildProd() {
     // fs2.emptyDir('./dist') // it doesn't delete the dir itself, to prevent IDE jumping
     buildCopy();

package/package.json

@@ -1,9 +1,8 @@
 {
   "name": "@naturalcycles/dev-lib",
   "type": "module",
-  "version": "20.31.2",
+  "version": "20.33.0",
   "dependencies": {
-    "@biomejs/biome": "^2",
     "prompts": "^2",
     "@naturalcycles/js-lib": "^15",
     "@naturalcycles/nodejs-lib": "^15",
@@ -57,7 +56,6 @@
   },
   "exports": {
     "./cfg/": "./cfg/",
-    "./cfg/biome.jsonc": "./cfg/biome.jsonc",
     "./cfg/eslint.config.js": "./cfg/eslint.config.js",
     "./cfg/oxlint.config.json": "./cfg/oxlint.config.json",
     "./cfg/stylelint.config.js": "./cfg/stylelint.config.js",
@@ -115,7 +113,6 @@
     "lint": "tsx scripts/eslintPrintConfig.script.ts && tsx scripts/oxlintPrintConfig.script.ts && tsx ./src/bin/dev-lib.ts lint",
     "eslint": "tsx ./src/bin/dev-lib.ts eslint",
     "eslint-no-fix": "tsx ./src/bin/dev-lib.ts eslint-no-fix",
-    "biome-no-fix": "tsx ./src/bin/dev-lib.ts biome-no-fix",
     "oxlint": "tsx ./src/bin/dev-lib.ts oxlint",
     "oxlint-no-fix": "tsx ./src/bin/dev-lib.ts oxlint-no-fix",
     "lint-staged-debug": "tsx ./src/bin/dev-lib.ts lint-staged"

package/cfg/biome.jsonc

@@ -1,138 +0,0 @@
-{
-  "$schema": "https://biomejs.dev/schemas/2.3.10/schema.json",
-  "root": false,
-  "files": {
-    "includes": [
-      "**/*.ts",
-      "**/*.tsx",
-      "**/*.js",
-      "**/*.jsx",
-      "!**/__exclude",
-      "!tmp",
-      "!coverage",
-      "!deploy",
-      "!dist",
-      "!**/try.ts",
-    ],
-  },
-  "formatter": {
-    "enabled": true,
-    "formatWithErrors": false,
-    "indentStyle": "space",
-    "indentWidth": 2,
-    "lineEnding": "lf",
-    "lineWidth": 100,
-    "attributePosition": "auto",
-  },
-  "assist": { "actions": { "source": { "organizeImports": "off" } } },
-  "linter": {
-    "enabled": true,
-    "rules": {
-      "recommended": true,
-      "performance": {
-        "noAccumulatingSpread": "off", // oxlint
-        // "useTopLevelRegex": "error" // consider
-        "noDelete": "off", // oxlint
-      },
-      "correctness": {
-        "useImportExtensions": "off", // oxlint
-        "useParseIntRadix": "off",
-        "noUnusedFunctionParameters": "off", // oxlint
-        "noConstantCondition": "off", // ox
-        "noUnusedPrivateClassMembers": "off", // buggy in 2.3.6
-        // noUnusedImports + noUnusedVariables can replace eslint-plugin-unused-vars!
-        "noUnusedImports": "error", // oxlint ignoreVars ^_ pattern also applies to imports named with _ prefix. Support for no-unused-imports tracked here https://github.com/oxc-project/oxc/issues/1117
-        "noUnusedVariables": {
-          "fix": "none",
-          "level": "off", // oxlint
-          "options": {},
-        },
-      },
-      "style": {
-        // "useDefaultSwitchClause": "error", // consider`
-        "useThrowNewError": "error",
-        "useThrowOnlyError": "error",
-        "useConsistentBuiltinInstantiation": "off", // disallows Array()
-        "noDoneCallback": "error",
-        "useShorthandFunctionType": "error",
-        "useShorthandAssign": "error",
-        "useForOf": "off", // oxlint
-        "useConsistentArrayType": "error",
-        "noDefaultExport": "off", // oxlint
-        "noNonNullAssertion": "off",
-        "useImportType": "error",
-        "noParameterAssign": "off",
-        "useTemplate": "off",
-        "useNumberNamespace": "off",
-        "noUnusedTemplateLiteral": "off",
-        "useAsConstAssertion": "error",
-        "useDefaultParameterLast": "error",
-        "useEnumInitializers": "error",
-        "useSelfClosingElements": "error",
-        "useSingleVarDeclarator": "error",
-        "noInferrableTypes": "error",
-        "noUselessElse": "error",
-        "useArrayLiterals": "error",
-        // "noCommonJs": "error" // oxlint
-      },
-      "suspicious": {
-        "useNumberToFixedDigitsArgument": "error",
-        "useIterableCallbackReturn": "off",
-        "useErrorMessage": "off", // ox
-        "noControlCharactersInRegex": "off", // ox
-        "noExtraNonNullAssertion": "off", // ox
-        "noEvolvingTypes": "error",
-        "noExplicitAny": "off",
-        "noAssignInExpressions": "off",
-        "noPrototypeBuiltins": "off",
-        "noGlobalIsNan": "off", // todo,
-        "noThenProperty": "off",
-        "noImportAssign": "off",
-        "noDoubleEquals": "off", // oxlint
-        "noDocumentCookie": "off", // ox
-        "noEmptyInterface": "off",
-      },
-      "complexity": {
-        "useDateNow": "error",
-        "useArrowFunction": "off", // ox
-        "noUselessUndefinedInitialization": "error",
-        "noUselessEscapeInRegex": "off", // ox
-        "noUselessStringConcat": "error",
-        "noForEach": "off",
-        "noUselessThisAlias": "off",
-        "useLiteralKeys": "off",
-        "noBannedTypes": "off",
-        "noCommaOperator": "off", // ox
-        "noArguments": "error",
-      },
-      "nursery": {},
-    },
-  },
-  "javascript": {
-    "formatter": {
-      "jsxQuoteStyle": "double",
-      "quoteProperties": "asNeeded",
-      "trailingCommas": "all",
-      "semicolons": "asNeeded",
-      "arrowParentheses": "asNeeded",
-      "bracketSpacing": true,
-      "bracketSameLine": false,
-      "quoteStyle": "single",
-      "attributePosition": "auto",
-    },
-  },
-  "overrides": [
-    {
-      "includes": ["**/*.vue"],
-      "linter": {
-        "rules": {
-          "correctness": {
-            // doesn't work well with *.vue files
-            "noUnusedImports": "off",
-            "noUnusedVariables": "off",
-          },
-        },
-      },
-    },
-  ],
-}

package/cfg/eslint-biome-rules.js

@@ -1,179 +0,0 @@
-// Copy-pasted from https://github.com/SrBrahma/eslint-config-biome/blob/main/index.js
-export default {
-  rules: {
-    'constructor-super': 0,
-    'default-case-last': 0,
-    'default-param-last': 0,
-    'dot-notation': 0,
-    eqeqeq: 0,
-    'for-direction': 0,
-    'getter-return': 0,
-    'no-async-promise-executor': 0,
-    'no-case-declarations': 0,
-    'no-class-assign': 0,
-    'no-compare-neg-zero': 0,
-    'no-cond-assign': 0,
-    'no-const-assign': 0,
-    'no-constant-condition': 0,
-    'no-constructor-return': 0,
-    'no-control-regex': 0,
-    'no-debugger': 0,
-    'no-delete-var': 0,
-    'no-dupe-args': 0,
-    'no-dupe-class-members': 0,
-    'no-dupe-keys': 0,
-    'no-duplicate-case': 0,
-    'no-else-return': 0,
-    'no-empty': 0,
-    'no-empty-character-class': 0,
-    'no-empty-pattern': 0,
-    'no-eval': 0,
-    'no-ex-assign': 0,
-    'no-extra-boolean-cast': 0,
-    'no-extra-label': 0,
-    'no-fallthrough': 0,
-    'no-func-assign': 0,
-    'no-global-assign': 0,
-    'no-import-assign': 0,
-    'no-inner-declarations': 0,
-    'no-label-var': 0,
-    'no-labels': 0,
-    'no-lone-blocks': 0,
-    'no-loss-of-precision': 0,
-    'no-misleading-character-class': 0,
-    'no-new-native-nonconstructor': 0,
-    'no-new-symbol': 0,
-    'no-nonoctal-decimal-escape': 0,
-    'no-obj-calls': 0,
-    'no-param-reassign': 0,
-    'no-prototype-builtins': 0,
-    'no-redeclare': 0,
-    'no-regex-spaces': 0,
-    'no-return-assign': 0,
-    'no-self-assign': 0,
-    'no-self-compare': 0,
-    'no-sequences': 0,
-    'no-setter-return': 0,
-    'no-shadow-restricted-names': 0,
-    'no-sparse-array': 0,
-    'no-this-before-super': 0,
-    'no-undef-init': 0,
-    'no-unneeded-ternary': 0,
-    'no-unreachable': 0,
-    'no-unsafe-finally': 0,
-    'no-unsafe-negation': 0,
-    'no-unsafe-optional-chaining': 0,
-    'no-unused-labels': 0,
-    'no-use-before-define': 0,
-    'no-useless-catch': 0,
-    'no-useless-computed-key': 0,
-    'no-useless-constructor': 0,
-    'no-useless-rename': 0,
-    'no-var': 0,
-    'no-with': 0,
-    'one-var': 0,
-    'prefer-arrow-callback': 0,
-    'prefer-const': 0,
-    'prefer-exponentiation-operator': 0,
-    'prefer-numeric-literals': 0,
-    'prefer-regex-literals': 0,
-    'prefer-rest-params': 0,
-    'prefer-template': 0,
-    'require-yield': 0,
-    'use-isnan': 0,
-    'valid-typeof': 0,
-    // "@mysticatea/eslint-plugin/no-this-in-static": 0,
-    '@typescript-eslint/ban-types': 0,
-    '@typescript-eslint/consistent-type-exports': 0,
-    // '@typescript-eslint/consistent-type-imports': 0, // `useImportType` is currently disabled
-    '@typescript-eslint/default-param-last': 0,
-    '@typescript-eslint/dot-notation': 0,
-    '@typescript-eslint/no-dupe-class-members': 0,
-    '@typescript-eslint/no-empty-interface': 0,
-    '@typescript-eslint/no-explicit-any': 0,
-    '@typescript-eslint/no-extra-non-null-assertion': 0,
-    '@typescript-eslint/no-extraneous-class': 0,
-    '@typescript-eslint/no-import-type-side-effects': 0,
-    '@typescript-eslint/no-inferrable-types': 0,
-    '@typescript-eslint/no-invalid-void-type': 0,
-    '@typescript-eslint/no-loss-of-precision': 0,
-    '@typescript-eslint/no-misused-new': 0,
-    '@typescript-eslint/no-non-null-assertion': 0,
-    '@typescript-eslint/no-redeclare': 0,
-    '@typescript-eslint/no-this-alias': 0,
-    '@typescript-eslint/no-unnecessary-type-arguments': 0,
-    '@typescript-eslint/no-unnecessary-type-constraint': 0,
-    '@typescript-eslint/no-unsafe-declaration-merging': 0,
-    '@typescript-eslint/no-use-before-define': 0,
-    '@typescript-eslint/no-useless-constructor': 0,
-    '@typescript-eslint/no-useless-empty-export': 0,
-    '@typescript-eslint/no-useless-template-literals': 0,
-    '@typescript-eslint/prefer-as-const': 0,
-    '@typescript-eslint/prefer-enum-initializers': 0,
-    '@typescript-eslint/prefer-function-type': 0,
-    '@typescript-eslint/prefer-literal-enum-member': 0,
-    '@typescript-eslint/prefer-namespace-keyword': 0,
-    '@typescript-eslint/prefer-optional-chain': 0,
-    'jest/max-nested-describe': 0,
-    'jest/no-duplicate-hooks': 0,
-    'jest/no-export': 0,
-    'jest/no-focused-tests': 0,
-    'jsx-a11y/alt-text': 0,
-    'jsx-a11y/anchor-has-content': 0,
-    'jsx-a11y/anchor-is-valid': 0,
-    'jsx-a11y/aria-activedescendant-has-tabindex': 0,
-    'jsx-a11y/aria-props': 0,
-    'jsx-a11y/aria-proptypes': 0,
-    'jsx-a11y/aria-role': 0,
-    'jsx-a11y/aria-unsupported-elements': 0,
-    'jsx-a11y/click-events-have-key-events': 0,
-    'jsx-a11y/heading-has-content': 0,
-    'jsx-a11y/html-has-lang': 0,
-    'jsx-a11y/iframe-has-title': 0,
-    'jsx-a11y/img-redundant-alt': 0,
-    'jsx-a11y/interactive-supports-focus': 0,
-    'jsx-a11y/label-has-associated-control': 0,
-    'jsx-a11y/lang': 0,
-    'jsx-a11y/media-has-caption': 0,
-    'jsx-a11y/mouse-events-have-key-events': 0,
-    'jsx-a11y/no-access-key': 0,
-    'jsx-a11y/no-aria-hidden-on-focusable': 0,
-    'jsx-a11y/no-autofocus': 0,
-    'jsx-a11y/no-distracting-elements': 0,
-    'jsx-a11y/no-interactive-element-to-noninteractive-role': 0,
-    'jsx-a11y/no-noninteractive-element-to-interactive-role': 0,
-    'jsx-a11y/no-noninteractive-tabindex': 0,
-    'jsx-a11y/no-redundant-roles': 0,
-    'jsx-a11y/role-has-required-aria-props': 0,
-    'jsx-a11y/scope': 0,
-    'jsx-a11y/tabindex-no-positive': 0,
-    'react/button-has-type': 0,
-    'react/jsx-key': 0,
-    'react/jsx-no-comment-textnodes': 0,
-    'react/jsx-no-duplicate-props': 0,
-    'react/jsx-no-target-blank': 0,
-    'react/jsx-no-useless-fragment': 0,
-    'react/no-array-index-key': 0,
-    'react/no-children-prop': 0,
-    'react/no-danger': 0,
-    'react/no-danger-with-children': 0,
-    'react/void-dom-elements-no-children': 0,
-    'react-hooks/exhaustive-deps': 0,
-    // "simple-import-sort/imports": 0, // we need it
-    'stylistic/jsx-self-closing-comp': 0,
-    'unicorn/error-message': 0,
-    'unicorn/new-for-builtins': 0,
-    'unicorn/no-array-for-each': 0,
-    'unicorn/no-instanceof-array': 0,
-    'unicorn/no-static-only-class': 0,
-    'unicorn/no-thenable': 0,
-    'unicorn/no-typeof-undefined': 0,
-    'unicorn/no-useless-switch-case': 0,
-    'unicorn/prefer-array-flat-map': 0,
-    'unicorn/prefer-date-now': 0,
-    'unicorn/prefer-node-protocol': 0,
-    'unicorn/prefer-number-properties': 0,
-    'unicorn/require-number-to-fixed-digits-argument': 0,
-    'unicorn/throw-new-error': 0,
-  },
-}