@naturalcycles/dev-lib 20.31.1 → 20.32.0

package/cfg/biome.jsonc

@@ -2,7 +2,18 @@
   "$schema": "https://biomejs.dev/schemas/2.3.10/schema.json",
   "root": false,
   "files": {
-    "includes": ["**/*.ts", "**/*.tsx", "**/*.js", "**/*.jsx", "!**/__exclude", "!**/try.ts"],
+    "includes": [
+      "**/*.ts",
+      "**/*.tsx",
+      "**/*.js",
+      "**/*.jsx",
+      "!**/__exclude",
+      "!tmp",
+      "!coverage",
+      "!deploy",
+      "!dist",
+      "!**/try.ts",
+    ],
   },
   "formatter": {
     "enabled": true,

package/cfg/eslint-rules.js

@@ -33,7 +33,7 @@ export default {
       },
     ],
     '@typescript-eslint/consistent-type-imports': 0, // ox
-    '@typescript-eslint/consistent-type-exports': 2,
+    '@typescript-eslint/consistent-type-exports': 0, // ox
     '@typescript-eslint/consistent-type-assertions': 2,
     '@typescript-eslint/consistent-type-definitions': [0, 'interface'], // ox
     '@typescript-eslint/consistent-generic-constructors': [0, 'constructor'], // ox

package/cfg/eslint.config.js

@@ -8,7 +8,6 @@ import eslint from '@eslint/js'
 import eslintPluginOxlint from 'eslint-plugin-oxlint'
 import globals from 'globals'
 import tseslint from 'typescript-eslint'
-import eslintBiomeRules from './eslint-biome-rules.js'
 import eslintPrettierRules from './eslint-prettier-rules.js'
 import eslintRules from './eslint-rules.js'
 
@@ -122,7 +121,7 @@ function getConfig(_tsconfigPath) {
       ...eslintRules.rules,
       // ...eslintVueRules.rules,
       ...eslintPrettierRules.rules, // disable eslint rules already covered by prettier
-      ...eslintBiomeRules.rules, // disable eslint rules already covered by biome
+      // ...eslintBiomeRules.rules, // disable eslint rules already covered by biome
       ...eslintPluginOxlint.configs['flat/all'][0].rules, // disable eslint rules already covered by oxlint
       // rules that are disabled, but shouldn't yet be disabled
       '@typescript-eslint/return-await': [2, 'always'],

package/cfg/lint-staged.config.js

@@ -7,7 +7,6 @@ const {
   platform,
   arch,
   versions: { node },
-  // env: { ESLINT_CONCURRENCY },
 } = process
 
 console.log(`lint-staged.config.js runs on node ${node} ${platform} ${arch}`)
@@ -43,9 +42,6 @@ if (eslintConfigPath) {
     `--config ${eslintConfigPath}`,
     '--cache',
     '--cache-location node_modules/.cache/eslint',
-    // concurrency is disabled here, as it's not expected to help,
-    // since we're running on a limited set of files already
-    // ESLINT_CONCURRENCY && `--concurrency=${ESLINT_CONCURRENCY}`,
   ]
     .filter(Boolean)
     .join(' ')
@@ -88,7 +84,7 @@ const linters = {
   // ktlint
   '**/*.{kt,kts}': runKtlint,
 
-  './.github/**/*.{yml,yaml}': runActionlint,
+  './.github/**/*.{yml,yaml}': runActionlintOxfmt,
 }
 
 export function runBiomeEslintStylelintOxfmt(match) {
@@ -131,20 +127,26 @@ export function runKtlint(match) {
   return [`${dir}/resources/ktlint -F ${filesList}`]
 }
 
-export function runActionlint(match) {
+export function runActionlintOxfmt(match) {
   if (!match.length) return []
 
-  if (!canRunBinary('actionlint')) {
+  const tools = []
+
+  if (canRunBinary('actionlint')) {
+    requireActionlintVersion()
+    // run actionlint on all files at once, as it's fast anyway
+    tools.push('actionlint')
+  } else {
     console.log(
       `actionlint is not installed and won't be run.\nThis is how to install it: https://github.com/rhysd/actionlint/blob/main/docs/install.md`,
     )
-    return []
   }
 
-  requireActionlintVersion()
+  if (oxfmtCmd) {
+    tools.push(oxfmtCmd)
+  }
 
-  // run actionlint on all files at once, as it's fast anyway
-  return [`actionlint`]
+  return tools
 }
 
 function getFilesList(match) {

package/cfg/oxlint.config.json

@@ -13,6 +13,14 @@
   ],
   "jsPlugins": ["./oxlint-plugin-stylistic.mjs"],
   "rules": {
+    "no-unused-vars": [
+      "error",
+      {
+        "varsIgnorePattern": "^(_$|__)",
+        "argsIgnorePattern": "^_",
+        "destructuredArrayIgnorePattern": "^_"
+      }
+    ],
     "@stylistic/padding-line-between-statements": [
       2,
       { "blankLine": "always", "prev": "function", "next": "*" },

package/dist/bin/dev-lib.js

@@ -3,7 +3,7 @@ import { _by } from '@naturalcycles/js-lib/array/array.util.js';
 import { _assert } from '@naturalcycles/js-lib/error/assert.js';
 import { fs2 } from '@naturalcycles/nodejs-lib/fs2';
 import { runScript } from '@naturalcycles/nodejs-lib/runScript';
-import { buildCopy, buildProd, eslintAll, lintStagedCommand, requireOxlintConfig, runBiome, runCheck, runOxfmt, runOxlint, runTest, stylelintAll, typecheckWithTS, typecheckWithTSC, typecheckWithTSGO, } from '../check.util.js';
+import { buildCopy, buildProd, eslintAll, lintStagedCommand, runBiome, runCheck, runOxfmt, runOxlint, runTest, stylelintAll, typecheckWithTS, typecheckWithTSC, typecheckWithTSGO, } from '../check.util.js';
 import { runCommitlint } from '../commitlint.js';
 const commands = [
     { name: 'check', fn: runCheck, desc: '"Run all possible checks": lint, typecheck, then test.' },
@@ -175,11 +175,11 @@ async function bt() {
     await typecheckWithTS();
     runTest();
 }
-async function _typecheckWithOxlint() {
-    requireOxlintConfig();
-    const fix = !CI;
-    runOxlint(fix);
-}
+// async function _typecheckWithOxlint(): Promise<void> {
+//   requireOxlintConfig()
+//   const fix = !CI
+//   runOxlint(fix)
+// }
 async function cleanBuild() {
     cleanDist();
     buildProd();

package/dist/check.util.js

@@ -16,7 +16,7 @@ import { kpySync } from '@naturalcycles/nodejs-lib/kpy';
 import { _yargs } from '@naturalcycles/nodejs-lib/yargs';
 import { eslintExtensions, lintExclude, minActionlintVersion, prettierDirs, stylelintExtensions, } from '../cfg/_cnst.js';
 import { cfgDir } from './paths.js';
-const { CI, ESLINT_CONCURRENCY } = process.env;
+const { CI } = process.env;
 /**
  * Run all linters.
  *
@@ -178,7 +178,6 @@ function runESLint(extensions = eslintExtensions.split(','), fix = true) {
             // `--parser-options=project:${tsconfigPath}`,
             // The next line fixes the `typescript-eslint` 8.37 bug of resolving tsconfig.json
             // `--parser-options=tsconfigRootDir:${tsconfigRootDir}`,
-            ESLINT_CONCURRENCY && `--concurrency=${ESLINT_CONCURRENCY}`,
             '--cache',
             '--cache-location',
             cacheLocation,

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@naturalcycles/dev-lib",
   "type": "module",
-  "version": "20.31.1",
+  "version": "20.32.0",
   "dependencies": {
     "@biomejs/biome": "^2",
     "prompts": "^2",