@naturalcycles/dev-lib 20.1.0 → 20.1.2

package/cfg/biome.jsonc

@@ -33,17 +33,17 @@
       "recommended": true,
       "performance": {
         // "useTopLevelRegex": "error" // consider
-        "noDelete": "off" // todo
+        "noDelete": "off" // oxlint
       },
       "correctness": {
-        "useImportExtensions": "error",
+        "useImportExtensions": "off", // oxlint
         "useParseIntRadix": "off",
-        "noUnusedFunctionParameters": "error",
+        "noUnusedFunctionParameters": "off", // oxlint
         // noUnusedImports + noUnusedVariables can replace eslint-plugin-unused-vars!
-        "noUnusedImports": "error",
+        "noUnusedImports": "off", // oxlint
         "noUnusedVariables": {
           "fix": "none",
-          "level": "error",
+          "level": "off", // oxlint
           "options": {}
         }
       },
@@ -55,9 +55,9 @@
         "noDoneCallback": "error",
         "useShorthandFunctionType": "error",
         "useShorthandAssign": "error",
-        "useForOf": "error",
+        "useForOf": "off", // oxlint
         "useConsistentArrayType": "error",
-        "noDefaultExport": "error",
+        "noDefaultExport": "off", // oxlint
         "noNonNullAssertion": "off",
         "useImportType": "error",
         "noParameterAssign": "off",
@@ -71,8 +71,8 @@
         "useSingleVarDeclarator": "error",
         "noInferrableTypes": "error",
         "noUselessElse": "error",
-        "useArrayLiterals": "error",
-        "noCommonJs": "error"
+        "useArrayLiterals": "error"
+        // "noCommonJs": "error" // oxlint
       },
       "suspicious": {
         "useNumberToFixedDigitsArgument": "error",
@@ -85,6 +85,7 @@
         "noGlobalIsNan": "off", // todo,
         "noThenProperty": "off",
         "noImportAssign": "off",
+        "noDoubleEquals": "off", // oxlint
         "noEmptyInterface": "off"
       },
       "complexity": {

package/cfg/eslint-rules.js

@@ -140,9 +140,9 @@ export default {
     '@typescript-eslint/no-misused-new': 2,
     '@typescript-eslint/no-misused-spread': 2,
     '@typescript-eslint/no-non-null-asserted-optional-chain': 2,
-    '@typescript-eslint/no-unused-expressions': 2,
+    '@typescript-eslint/no-unused-expressions': 0, // oxlint
     '@typescript-eslint/prefer-as-const': 2,
-    '@typescript-eslint/prefer-for-of': 2,
+    '@typescript-eslint/prefer-for-of': 0, // oxlint
     '@typescript-eslint/prefer-function-type': 2,
     '@typescript-eslint/prefer-namespace-keyword': 2,
     '@typescript-eslint/promise-function-async': [
@@ -162,7 +162,7 @@ export default {
       },
     ],
     'constructor-super': 2,
-    eqeqeq: [2, 'smart'],
+    // eqeqeq: [2, 'smart'], // oxlint
     'for-direction': 2,
     'getter-return': 2,
     'id-blacklist': [
@@ -189,10 +189,10 @@ export default {
     // 'import-x/order': 0, // disabled in favor of `simple-import-sort`
     // 'import-x/namespace': 0, // issues with e.g globby
     // 'import-x/no-unresolved': 0, // breaks for type-aliases, e.g '@/store'
-    'import-x/no-anonymous-default-export': 2,
-    'import-x/no-duplicates': [2, { 'prefer-inline': false }],
-    'import-x/export': 2,
-    'import-x/no-empty-named-blocks': 2,
+    'import-x/no-anonymous-default-export': 0, // oxlint
+    'import-x/no-duplicates': [0, { 'prefer-inline': false }], // oxlint
+    'import-x/export': 2, // todo: oxlint when it matures
+    'import-x/no-empty-named-blocks': 0, // oxlint
     // Disabling no-cycle as the slowest rule. Oxlint is to be adopted instead
     // 'import-x/no-cycle': [
     //   2,
@@ -203,12 +203,9 @@ export default {
     //   },
     // ],
     'import-x/no-useless-path-segments': 2,
-    'import-x/no-default-export': 0, // biome
+    'import-x/no-default-export': 0, // biome, oxlint
     // 'import-x/no-commonjs': 2, // biome `noCommonJs`
     // 'import-x/extensions': [2, 'always'], // biome useImportExtensions
-    'jsdoc/check-alignment': 2,
-    // "jsdoc/check-indentation": "error",
-    // 'jsdoc/newline-after-description': 2,
     'no-array-constructor': 0,
     'no-async-promise-executor': 2,
     'no-bitwise': 2,
@@ -298,7 +295,7 @@ export default {
     'no-useless-catch': 2,
     'no-useless-escape': 2,
     'no-useless-assignment': 2,
-    'no-unneeded-ternary': 2,
+    'no-unneeded-ternary': 0, // oxlint
     'no-duplicate-imports': 0, // too many false-positives (with e.g import type + import on next line)
     'no-var': 2,
     'no-with': 2,
@@ -321,7 +318,7 @@ export default {
     'use-isnan': 2,
     'valid-typeof': 2,
     'no-await-in-loop': 0, // it's actually often ok
-    'no-extend-native': 2,
+    'no-extend-native': 0, // oxlint
     'guard-for-in': 2,
     '@typescript-eslint/no-namespace': [
       2,
@@ -348,7 +345,7 @@ export default {
     '@typescript-eslint/no-empty-function': 0,
     '@typescript-eslint/no-var-requires': 0,
     '@typescript-eslint/no-require-imports': 0,
-    '@typescript-eslint/no-explicit-any': 0,
+    '@typescript-eslint/no-explicit-any': 0, // oxlint
     '@typescript-eslint/no-non-null-assertion': 0,
     '@typescript-eslint/explicit-module-boundary-types': [
       2,
@@ -384,9 +381,13 @@ export default {
     'unicorn/prefer-spread': 0, // fails on joiSchema.concat() which is not an array!
     'unicorn/prefer-structured-clone': 0, // no real advantage, plus in most of the cases we want JSON to remove undefined, etc.
     'unicorn/better-regex': 0, // we still believe that [0-9] is clearer than [\d]
+    'unicorn/no-for-loop': 0, // oxlint has similar
+    'unicorn/no-array-reduce': 0, // oxlint
+    'unicorn/no-accessor-recursion': 0, // oxlint
+    'unicorn/no-anonymous-default-export': 0, // oxlint
     'unicorn/no-object-as-default-parameter': 0, // doesn't allow e.g method (opt = { skipValidation: true })
     'unicorn/catch-error-name': [
-      2,
+      0, // oxlint
       {
         name: 'err',
         ignore: [/^err\d*$/, /^_/],
@@ -448,7 +449,7 @@ export default {
     'max-params': [2, { max: 5 }],
     'no-else-return': 2,
     'no-sequences': 2,
-    'no-useless-concat': 2,
+    'no-useless-concat': 0, // oxlint
     '@typescript-eslint/ban-tslint-comment': 2,
     '@typescript-eslint/explicit-function-return-type': [
       2,

package/cfg/eslint.config.js

@@ -9,10 +9,10 @@ import eslint from '@eslint/js'
 import tseslint from 'typescript-eslint'
 import eslintPluginUnicorn from 'eslint-plugin-unicorn'
 import eslintPluginVue from 'eslint-plugin-vue'
+import eslintPluginOxlint from 'eslint-plugin-oxlint'
 import eslintPluginVitest from '@vitest/eslint-plugin'
 import eslintPluginImportX from 'eslint-plugin-import-x'
 import eslintPluginSimpleImportSort from 'eslint-plugin-simple-import-sort'
-import eslintPluginJsdoc from 'eslint-plugin-jsdoc'
 import eslintPluginStylistic from '@stylistic/eslint-plugin'
 import eslintRules from './eslint-rules.js'
 import eslintVueRules from './eslint-vue-rules.js'
@@ -105,7 +105,7 @@ function getConfig(tsconfigPath) {
       'import-x': eslintPluginImportX,
       // 'unused-imports': require('eslint-plugin-unused-imports'), // disabled in favor of biome rules
       'simple-import-sort': eslintPluginSimpleImportSort,
-      jsdoc: eslintPluginJsdoc,
+      // jsdoc: eslintPluginJsdoc, // oxlint
       '@stylistic': eslintPluginStylistic,
     },
     languageOptions: {
@@ -131,6 +131,7 @@ function getConfig(tsconfigPath) {
       ...eslintVueRules.rules,
       ...eslintPrettierRules.rules, // disable eslint rules already covered by prettier
       ...eslintBiomeRules.rules, // disable eslint rules already covered by biome
+      ...eslintPluginOxlint.configs['flat/all'].rules, // disable eslint rules already covered by oxlint
     },
   }
 }

package/cfg/lint-staged.config.js

@@ -65,7 +65,7 @@ if (eslintConfigPath) {
 let oxlintCmd = undefined
 
 if (oxlintConfigPath) {
-  oxlintCmd = ['oxlint', '--fix', '--max-warnings=1'].filter(Boolean).join(' ')
+  oxlintCmd = ['oxlint', '--fix', '--fix-suggestions', '--max-warnings=1'].filter(Boolean).join(' ')
 }
 
 const stylelintExists =

package/cfg/oxlint.config.json

@@ -1,4 +1,5 @@
 {
+  "$schema": "../node_modules/oxlint/configuration_schema.json",
   "plugins": [
     "oxc",
     "eslint",
@@ -32,14 +33,33 @@
     "no-unused-expressions": 2,
     "no-var": 2,
     "unicode-bom": 2,
+    "no-extend-native": 2,
+    "no-extra-bind": 2,
+    "no-new": 2,
+    "no-unexpected-multiline": 2,
+    "no-unneeded-ternary": 2,
+    "no-useless-concat": 2,
+    "no-useless-constructor": 2,
+    "preserve-caught-error": 2,
+    "eqeqeq": [2, "smart"],
     "import/extensions": [2, "always"],
     "import/no-amd": 2,
     "import/no-commonjs": 2,
     "import/no-cycle": 2,
     "import/no-default-export": 2,
     "import/no-webpack-loader-syntax": 2,
+    "import/no-duplicates": [2, { "prefer-inline": false }],
+    // "import/export": 2, // todo: adopt when it graduates
+    "import/no-empty-named-blocks": 2,
+    "import/no-absolute-path": 2,
+    "import/no-named-as-default": 2,
+    "import/no-named-as-default-member": 0,
+    "import/no-self-import": 2,
+    "import/no-unassigned-import": 0,
     "oxc/bad-bitwise-operator": 2,
     "oxc/no-const-enum": 2,
+    "oxc/approx-constant": 2,
+    "oxc/misrefactored-assign-op": 2,
     "promise/spec-only": 2,
     "typescript/explicit-function-return-type": [2, { "allowExpressions": true }],
     // "typescript/explicit-module-boundary-types": [2, {"allowArgumentsExplicitlyTypedAsAny": true}]
@@ -60,18 +80,22 @@
         "checkMethodDeclarations": true
       }
     ],
+    "typescript/prefer-for-of": 2,
     "unicorn/no-anonymous-default-export": 2,
-    "unicorn/no-array-reduce": [
-      2,
-      {
-        "allowSimpleOperations": true
-      }
-    ],
+    "unicorn/no-array-reduce": 2,
     "unicorn/no-document-cookie": 2,
     "unicorn/no-length-as-slice-end": 2,
     "unicorn/no-magic-array-flat-depth": 2,
     "unicorn/prefer-modern-math-apis": 2,
     "unicorn/prefer-node-protocol": 2,
+    "unicorn/catch-error-name": [
+      2,
+      {
+        "name": "err",
+        "ignore": ["^err\\d*$", "^_"]
+      }
+    ],
+    "unicorn/no-accessor-recursion": 2,
     "vue/no-multiple-slot-args": 2
   },
   "settings": {

package/dist/lint.util.js

@@ -138,13 +138,12 @@ export function runOxlint(fix = true) {
     }
     const oxlintPath = findPackageBinPath('oxlint', 'oxlint');
     exec2.spawn(oxlintPath, {
-        name: ['oxlintPath', !fix && '--no-fix'].filter(Boolean).join(' '),
+        name: ['oxlint', !fix && '--no-fix'].filter(Boolean).join(' '),
         args: [
             // '--report-unused-disable-directives',
             '--max-warnings=1',
-            fix ? '--fix' : '--no-fix',
+            fix && '--fix --fix-suggestions',
         ].filter(_isTruthy),
-        logFinish: false,
         shell: false,
     });
 }
@@ -281,7 +280,6 @@ export function runBiome(fix = true) {
     exec2.spawn(biomePath, {
         name: fix ? 'biome' : 'biome --no-fix',
         args: [`lint`, fix && '--write', fix && '--unsafe', '--no-errors-on-unmatched', ...dirs].filter(_isTruthy),
-        logFinish: false,
         shell: false,
     });
 }

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@naturalcycles/dev-lib",
   "type": "module",
-  "version": "20.1.0",
+  "version": "20.1.2",
   "dependencies": {
     "@biomejs/biome": "^2",
     "@commitlint/cli": "^20",
@@ -15,7 +15,7 @@
     "@vitest/eslint-plugin": "^1",
     "eslint": "^9",
     "eslint-plugin-import-x": "^4",
-    "eslint-plugin-jsdoc": "^60",
+    "eslint-plugin-oxlint": "^1",
     "eslint-plugin-simple-import-sort": "^12",
     "eslint-plugin-unicorn": "^61",
     "eslint-plugin-vue": "^10",