@naturalcycles/dev-lib 12.4.1 → 12.7.1

package/CHANGELOG.md

@@ -1,3 +1,32 @@
+## [12.7.1](https://github.com/NaturalCycles/dev-lib/compare/v12.7.0...v12.7.1) (2021-10-02)
+
+
+### Bug Fixes
+
+* eslint typeParameter to allow UPPER_CASE ([5972be3](https://github.com/NaturalCycles/dev-lib/commit/5972be3a9d78877d3a52c9087eb87db456b473a5))
+
+# [12.7.0](https://github.com/NaturalCycles/dev-lib/compare/v12.6.0...v12.7.0) (2021-10-02)
+
+
+### Features
+
+* adopt `@typescript-eslint/naming-convention` ([de2d0a6](https://github.com/NaturalCycles/dev-lib/commit/de2d0a6c2b9c2119a909ac4c8f4378289ac16c38))
+* finally remove tslint in favor of eslint ([39451c9](https://github.com/NaturalCycles/dev-lib/commit/39451c96ba4844468d178af680a02a108d148c7f))
+
+# [12.6.0](https://github.com/NaturalCycles/dev-lib/compare/v12.5.0...v12.6.0) (2021-09-22)
+
+
+### Features
+
+* exclude `src/vendor` from test coverage ([75fe084](https://github.com/NaturalCycles/dev-lib/commit/75fe0849306225915d25faf392f9e516113c6fe9))
+
+# [12.5.0](https://github.com/NaturalCycles/dev-lib/compare/v12.4.1...v12.5.0) (2021-09-18)
+
+
+### Features
+
+* support `--fix=false` to debug behaving linters ([4fa996b](https://github.com/NaturalCycles/dev-lib/commit/4fa996b9bd40ee1ee7fd793997367167cd365a90))
+
 ## [12.4.1](https://github.com/NaturalCycles/dev-lib/compare/v12.4.0...v12.4.1) (2021-09-18)
 
 

package/cfg/eslint-rules.js

@@ -26,12 +26,71 @@ module.exports = {
     ],
     '@typescript-eslint/consistent-type-assertions': 2,
     '@typescript-eslint/consistent-type-definitions': 2,
+    // Doc: https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/naming-convention.md
+    // Loosely based on this: https://github.com/xojs/eslint-config-xo-typescript/blob/main/index.js
     '@typescript-eslint/naming-convention': [
-      0,
+      2,
       {
-        // todo: clarify later, currently disabled
         selector: 'default',
+        format: ['camelCase'],
+      },
+      {
+        selector: ['function', 'parameter', 'property', 'method', 'memberLike'],
+        format: ['camelCase'],
+        leadingUnderscore: 'allowSingleOrDouble',
+        trailingUnderscore: 'forbid',
+        // Ignore `{'Retry-After': retryAfter}` type properties.
+        filter: {
+          regex: '[- ]',
+          match: false,
+        },
+      },
+      {
+        selector: ['variable', 'classProperty'],
         format: ['camelCase', 'UPPER_CASE'],
+        leadingUnderscore: 'allowSingleOrDouble',
+        trailingUnderscore: 'allow',
+      },
+      {
+        selector: ['objectLiteralProperty', 'objectLiteralMethod', 'typeProperty', 'enumMember'],
+        format: [
+          'camelCase',
+          'UPPER_CASE',
+          // only for 3rd-party code/api compatibility! Try to avoid in our code
+          'PascalCase',
+          'snake_case',
+        ],
+        leadingUnderscore: 'allow',
+        trailingUnderscore: 'forbid',
+      },
+      // Allow destructured variables to not follow the rules
+      {
+        selector: ['variable', 'parameter'],
+        modifiers: ['destructured'],
+        format: null,
+      },
+      {
+        selector: 'typeLike',
+        format: ['PascalCase'],
+      },
+      {
+        selector: 'typeParameter',
+        format: ['PascalCase', 'UPPER_CASE'],
+      },
+      // Allow these in non-camel-case when quoted.
+      {
+        selector: [
+          'classProperty',
+          'objectLiteralProperty',
+          'typeProperty',
+          'classMethod',
+          'objectLiteralMethod',
+          'typeMethod',
+          'accessor',
+          'enumMember',
+        ],
+        format: null,
+        modifiers: ['requiresQuotes'],
       },
     ],
     '@typescript-eslint/no-array-constructor': 2,
@@ -88,7 +147,7 @@ module.exports = {
       'undefined',
     ],
     'id-match': 2,
-    // "import/order": "error",
+    'import/order': 2,
     'jsdoc/check-alignment': 2,
     // "jsdoc/check-indentation": "error",
     'jsdoc/newline-after-description': 2,
@@ -176,7 +235,6 @@ module.exports = {
     'no-unsafe-finally': 2,
     'no-unsafe-negation': 2,
     'no-unused-labels': 2,
-    'no-unused-vars': 0, // replaced by `unused-imports/no-unused-vars`
     'no-useless-catch': 2,
     'no-useless-escape': 2,
     'no-unneeded-ternary': 2,
@@ -215,6 +273,7 @@ module.exports = {
         allowDeclarations: true, // allows `namespace NodeJS {}` augmentations
       },
     ],
+    'no-unused-vars': 0, // replaced by `unused-imports/no-unused-vars`
     '@typescript-eslint/no-unused-vars': [
       0, // replaced by `unused-imports/no-unused-vars`
       {

package/cfg/eslint.config.js

@@ -28,6 +28,10 @@ module.exports = {
         // 'plugin:jest/recommended', // add manually if needed!
         // https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/configs/recommended.js
         'plugin:unicorn/recommended',
+        // https://github.com/import-js/eslint-plugin-import/blob/main/config/recommended.js
+        'plugin:import/recommended',
+        // https://github.com/import-js/eslint-plugin-import/blob/main/config/typescript.js
+        'plugin:import/typescript',
         './eslint-rules.js',
         'prettier', // must be last! it only turns off eslint rules that conflict with prettier
       ],
@@ -42,6 +46,7 @@ module.exports = {
         'jsdoc',
         'import',
         '@typescript-eslint',
+        // https://github.com/sweepline/eslint-plugin-unused-imports
         'unused-imports',
         // 'jest', // add manually if needed!
         'unicorn',

package/cfg/jest.config.js

@@ -96,6 +96,7 @@ module.exports = {
     '!src/environments/**',
     '!src/env/**',
     '!src/bin/**',
+    '!src/vendor/**',
     '!public/**',
     '!**/*.test.ts',
     '!**/*.script.ts',

package/cfg/lint-staged.config.js

@@ -1,7 +1,7 @@
 /*
   Default config for `lint-staged`.
   Extendable.
-  Supports default configs for `prettier`, `stylelint`, `tslint`, `eslint`, if they are not found in target project.
+  Supports default configs for `prettier`, `stylelint`, `eslint`, if they are not found in target project.
 */
 
 const micromatch = require('micromatch')
@@ -18,40 +18,31 @@ const cfgDir = __dirname
 const prettierConfigPath =
   [`prettier.config.js`].find(fs.existsSync) || `${cfgDir}/prettier.config.js`
 
-const tslintConfigPath = [`tslint.json`].find(fs.existsSync) || `${cfgDir}/tslint.config.js`
-
 const stylelintConfigPath =
   [`stylelint.config.js`].find(fs.existsSync) || `${cfgDir}/stylelint.config.js`
 
 // this is to support "Solution style tsconfig.json" (as used in Angular10, for example)
 // const tsconfigPathRoot = ['tsconfig.base.json'].find(p => fs.existsSync(p)) || 'tsconfig.json'
-const tsconfigPathRoot = 'tsconfig.json'
+// const tsconfigPathRoot = 'tsconfig.json'
 
 const eslintConfigPathRoot =
   ['.eslintrc.js'].find(p => fs.existsSync(p)) || `${cfgDir}/eslint.config.js`
 
 const prettierCmd = `prettier --write --config ${prettierConfigPath}`
-const tslintCmd = `tslint -t stylish --fix --config ${tslintConfigPath}`
 const eslintCmd = `eslint --fix`
 const styleLintCmd = `stylelint --fix --config ${stylelintConfigPath}`
 
 const linters = {
-  // *.ts files: eslint, tslint, prettier
-  // There are 2 tslint tasks, one without `-p` and the second is with `-p` - it is a speed optimization
+  // *.{ts,tsx,vue} files: eslint, prettier
   './src/**/*.{ts,tsx,vue}': match => {
-    const files = micromatch.not(match, lintExclude)
-    if (!files) return []
-    const filesList = files.join(' ')
-    const filesListTSLint = micromatch(files, ['**/*.{ts,tsx}']).join(' ')
-    return [
-      `${eslintCmd} --config ${eslintConfigPathRoot} ${filesList}`,
-      filesListTSLint && `${tslintCmd} ${filesListTSLint}`,
-      filesListTSLint && `${tslintCmd} -p ${tsconfigPathRoot} ${filesListTSLint}`,
-      `${prettierCmd} ${filesList}`,
-    ].filter(Boolean)
+    const filesList = micromatch.not(match, lintExclude).join(' ')
+    if (!filesList) return []
+    return [`${eslintCmd} --config ${eslintConfigPathRoot}`, prettierCmd].map(
+      s => `${s} ${filesList}`,
+    )
   },
 
-  // For all other files we run only Prettier (because e.g TSLint screws *.scss files)
+  // For all other files we run only Prettier (because e.g eslint screws *.scss files)
   [`./{${prettierDirs}}/**/*.{${prettierExtensionsExclusive}}`]: match => {
     const filesList = micromatch.not(match, lintExclude).join(' ')
     if (!filesList) return []
@@ -93,14 +84,12 @@ if (fs.existsSync(`./scripts`)) {
     `${cfgDir}/eslint.config.js`
 
   Object.assign(linters, {
-    // eslint, tslint, Prettier
+    // eslint, Prettier
     './scripts/**/*.{ts,tsx}': match => {
       const filesList = micromatch.not(match, lintExclude).join(' ')
       if (!filesList) return []
       return [
         `${eslintCmd} --config ${eslintConfigPathScripts} --parser-options=project:./scripts/tsconfig.json`,
-        tslintCmd,
-        `${tslintCmd} -p ./scripts/tsconfig.json`,
         prettierCmd,
       ].map(s => `${s} ${filesList}`)
     },
@@ -114,14 +103,12 @@ if (fs.existsSync(`./e2e`)) {
     `${cfgDir}/eslint.config.js`
 
   Object.assign(linters, {
-    // eslint, tslint, Prettier
+    // eslint, Prettier
     './e2e/**/*.{ts,tsx}': match => {
       const filesList = micromatch.not(match, lintExclude).join(' ')
       if (!filesList) return []
       return [
         `${eslintCmd} --config ${eslintConfigPathE2e} --parser-options=project:./e2e/tsconfig.json`,
-        tslintCmd,
-        `${tslintCmd} -p ./e2e/tsconfig.json`,
         prettierCmd,
       ].map(s => `${s} ${filesList}`)
     },

package/cfg/overwrite/.codeclimate.yml

@@ -47,6 +47,7 @@ exclude_patterns:
   - 'src/test/'
   - 'src/environments/'
   - 'src/env/'
+  - 'src/vendor/'
   - 'scripts/'
   - 'other/'
   - 'patch/'

package/dist/bin/bt.js

@@ -1,8 +1,8 @@
 #!/usr/bin/env node
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-const script_1 = require("@naturalcycles/nodejs-lib/dist/script");
 const fs = require("fs");
+const script_1 = require("@naturalcycles/nodejs-lib/dist/script");
 const tsc_scripts_command_1 = require("../cmd/tsc-scripts.command");
 const jest_util_1 = require("../util/jest.util");
 const tsc_util_1 = require("../util/tsc.util");

package/dist/bin/build.js

@@ -1,8 +1,8 @@
 #!/usr/bin/env node
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-const script_1 = require("@naturalcycles/nodejs-lib/dist/script");
 const fs = require("fs");
+const script_1 = require("@naturalcycles/nodejs-lib/dist/script");
 const tsc_scripts_command_1 = require("../cmd/tsc-scripts.command");
 const tsc_util_1 = require("../util/tsc.util");
 (0, script_1.runScript)(async () => {

package/dist/bin/commitlint-def.js

@@ -1,9 +1,9 @@
 #!/usr/bin/env node
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
+const fs = require("fs");
 const exec_1 = require("@naturalcycles/nodejs-lib/dist/exec");
 const script_1 = require("@naturalcycles/nodejs-lib/dist/script");
-const fs = require("fs");
 const paths_cnst_1 = require("../cnst/paths.cnst");
 const git_util_1 = require("../util/git.util");
 (0, script_1.runScript)(async () => {

package/dist/bin/lint-staged-def.js

@@ -1,8 +1,8 @@
 #!/usr/bin/env node
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-const script_1 = require("@naturalcycles/nodejs-lib/dist/script");
 const fs = require("fs");
+const script_1 = require("@naturalcycles/nodejs-lib/dist/script");
 const paths_cnst_1 = require("../cnst/paths.cnst");
 (0, script_1.runScript)(async () => {
     // const cwd = process.cwd()

package/dist/cmd/build-prod-esm-cjs.command.js

@@ -1,8 +1,8 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.buildProdESMCJSCommand = void 0;
-const exec_1 = require("@naturalcycles/nodejs-lib/dist/exec");
 const fs = require("fs");
+const exec_1 = require("@naturalcycles/nodejs-lib/dist/exec");
 // You cannot have a shared `tsconfig.prod.json` because of relative paths for `include`
 const TSCONF_CJS_PATH = `./tsconfig.cjs.prod.json`;
 const TSCONF_ESM_PATH = `./tsconfig.esm.prod.json`;

package/dist/cmd/eslint-all.command.js

@@ -4,16 +4,20 @@ exports.eslintAllCommand = void 0;
 const fs = require("fs");
 const yargs = require("yargs");
 const paths_cnst_1 = require("../cnst/paths.cnst");
-const tslint_util_1 = require("../util/tslint.util");
+const lint_util_1 = require("../util/lint.util");
 /**
  * Runs `eslint` command for all predefined paths (e.g /src, /scripts, etc).
  */
 async function eslintAllCommand() {
-    const { ext } = yargs.options({
+    const { ext, fix } = yargs.options({
         ext: {
             type: 'string',
             default: 'ts,tsx,vue',
         },
+        fix: {
+            type: 'boolean',
+            default: true,
+        },
     }).argv;
     const extensions = ext.split(',');
     const eslintConfigPathRoot = ['./.eslintrc.js'].find(p => fs.existsSync(p)) || `${paths_cnst_1.cfgDir}/eslint.config.js`;
@@ -22,14 +26,14 @@ async function eslintAllCommand() {
     const eslintConfigPathE2e = ['./e2e/.eslintrc.js', './.eslintrc.js'].find(p => fs.existsSync(p)) ||
         `${paths_cnst_1.cfgDir}/eslint.config.js`;
     // const tsconfigPath = getTSConfigPath()
-    const tsconfigPathScripts = (0, tslint_util_1.getTSConfigPathScripts)();
+    const tsconfigPathScripts = (0, lint_util_1.getTSConfigPathScripts)();
     const tsconfigPathE2e = `./e2e/tsconfig.json`;
     // /src
     // await runESLint(`./src`, eslintConfigPathRoot, tsconfigPath, extensions)
-    await (0, tslint_util_1.runESLint)(`./src`, eslintConfigPathRoot, undefined, extensions);
+    await (0, lint_util_1.runESLint)(`./src`, eslintConfigPathRoot, undefined, extensions, fix);
     // /scripts
-    await (0, tslint_util_1.runESLint)(`./scripts`, eslintConfigPathScripts, tsconfigPathScripts);
+    await (0, lint_util_1.runESLint)(`./scripts`, eslintConfigPathScripts, tsconfigPathScripts, undefined, fix);
     // /e2e
-    await (0, tslint_util_1.runESLint)(`./e2e`, eslintConfigPathE2e, tsconfigPathE2e);
+    await (0, lint_util_1.runESLint)(`./e2e`, eslintConfigPathE2e, tsconfigPathE2e, undefined, fix);
 }
 exports.eslintAllCommand = eslintAllCommand;

package/dist/cmd/lint-all.command.d.ts

@@ -1,8 +1,4 @@
 /**
- * Due to "slowness issue" we run TSLint twice - first without project, secondly - with project.
- *
- * We run tslint BEFORE Prettier, because tslint can delete e.g unused imports.
- *
- * We run TSLint separately for /src and /scripts dir, because they might have a different tsconfig.json file.
+ * We run eslint BEFORE Prettier, because eslint can delete e.g unused imports.
  */
 export declare function lintAllCommand(): Promise<void>;

package/dist/cmd/lint-all.command.js

@@ -6,13 +6,8 @@ const git_util_1 = require("../util/git.util");
 const prettier_util_1 = require("../util/prettier.util");
 const stylelint_util_1 = require("../util/stylelint.util");
 const eslint_all_command_1 = require("./eslint-all.command");
-const tslint_all_command_1 = require("./tslint-all.command");
 /**
- * Due to "slowness issue" we run TSLint twice - first without project, secondly - with project.
- *
- * We run tslint BEFORE Prettier, because tslint can delete e.g unused imports.
- *
- * We run TSLint separately for /src and /scripts dir, because they might have a different tsconfig.json file.
+ * We run eslint BEFORE Prettier, because eslint can delete e.g unused imports.
  */
 async function lintAllCommand() {
     const { commitOnChanges, failOnChanges } = yargs.options({
@@ -28,7 +23,6 @@ async function lintAllCommand() {
     const hadChangesBefore = await (0, git_util_1.gitHasUncommittedChanges)();
     // Currently we position ESLint before TSLint, but let's monitor if it's ok
     await (0, eslint_all_command_1.eslintAllCommand)();
-    await (0, tslint_all_command_1.tslintAllCommand)();
     await (0, stylelint_util_1.stylelintAll)();
     await (0, prettier_util_1.runPrettier)();
     if (commitOnChanges || failOnChanges) {

package/dist/cmd/tsc-scripts.command.js

@@ -1,10 +1,10 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.tscScriptsCommand = void 0;
+const fs = require("fs");
 const js_lib_1 = require("@naturalcycles/js-lib");
 const colors_1 = require("@naturalcycles/nodejs-lib/dist/colors");
 const exec_1 = require("@naturalcycles/nodejs-lib/dist/exec");
-const fs = require("fs");
 const tsc_util_1 = require("../util/tsc.util");
 async function tscScriptsCommand() {
     if (!fs.existsSync('./scripts')) {

package/dist/jestOffline.util.js

@@ -12,8 +12,8 @@ function jestOffline() {
         return;
     }
     console.log('jest offline mode');
-    const Mitm = require('mitm');
-    const mitm = Mitm();
+    const createMitm = require('mitm');
+    const mitm = createMitm();
     mitm.on('connect', (socket, opts) => {
         const { host } = opts;
         if (!LOCAL_HOSTS.includes(host)) {

package/dist/testing/mockAllKindsOfThings.js

@@ -2,7 +2,7 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.mockAllKindsOfThings = void 0;
 const js_lib_1 = require("@naturalcycles/js-lib");
-/* eslint-disable @typescript-eslint/explicit-module-boundary-types */
+/* eslint-disable @typescript-eslint/explicit-module-boundary-types, @typescript-eslint/naming-convention */
 const mockAllKindsOfThings = () => {
     const errorWithCode = new Error('Error with code');
     Object.assign(errorWithCode, {

package/dist/util/git.util.js

@@ -1,9 +1,9 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.gitCurrentRepoName = exports.gitCurrentBranchName = exports.gitCurrentCommitTimestamp = exports.gitCurrentCommitSha = exports.gitPush = exports.gitPull = exports.gitIsAhead = exports.gitCommitAll = exports.gitHasUncommittedChanges = exports.commitMessageToTitleMessage = exports.getLastGitCommitMsg = void 0;
+const path = require("path");
 const exec_util_1 = require("@naturalcycles/nodejs-lib/dist/exec/exec.util");
 const execa = require("execa");
-const path = require("path");
 async function getLastGitCommitMsg() {
     // git log -1 --pretty=%B
     const cmd = 'git';

package/dist/util/jest.util.js

@@ -1,10 +1,10 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.runJest = exports.isRunningAllTests = exports.getJestManualConfigPath = exports.getJestIntegrationConfigPath = exports.getJestConfigPath = void 0;
+const fs = require("fs");
 const js_lib_1 = require("@naturalcycles/js-lib");
 const colors_1 = require("@naturalcycles/nodejs-lib/dist/colors");
 const exec_1 = require("@naturalcycles/nodejs-lib/dist/exec");
-const fs = require("fs");
 const paths_cnst_1 = require("../cnst/paths.cnst");
 const test_util_1 = require("./test.util");
 function getJestConfigPath() {

package/dist/util/{tslint.util.d.ts → lint.util.d.ts}

@@ -1,5 +1,3 @@
-export declare function runTSLint(dir: string, excludePaths: string[] | undefined, tslintConfigPath: string, tsconfigPath?: string): Promise<void>;
-export declare function getTSLintConfigPath(): string;
 export declare function getTSConfigPath(): string;
 export declare function getTSConfigPathScripts(): string;
-export declare function runESLint(dir: string, eslintConfigPath: string, tsconfigPath: string | undefined, extensions?: string[]): Promise<void>;
+export declare function runESLint(dir: string, eslintConfigPath: string, tsconfigPath: string | undefined, extensions?: string[], fix?: boolean): Promise<void>;

package/dist/util/{tslint.util.js → lint.util.js}

@@ -1,32 +1,9 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.runESLint = exports.getTSConfigPathScripts = exports.getTSConfigPath = exports.getTSLintConfigPath = exports.runTSLint = void 0;
-const js_lib_1 = require("@naturalcycles/js-lib");
-const exec_1 = require("@naturalcycles/nodejs-lib/dist/exec");
+exports.runESLint = exports.getTSConfigPathScripts = exports.getTSConfigPath = void 0;
 const fs = require("fs");
+const exec_1 = require("@naturalcycles/nodejs-lib/dist/exec");
 const paths_cnst_1 = require("../cnst/paths.cnst");
-async function runTSLint(dir, excludePaths = [], tslintConfigPath, tsconfigPath) {
-    if (!fs.existsSync(dir))
-        return; // faster like this
-    const args = [
-        `--config`,
-        tslintConfigPath,
-        `${dir}/**/*.{ts,tsx}`,
-        ...(0, js_lib_1._flatten)(excludePaths.map(p => [`-e`, p])),
-        ...(tsconfigPath ? [`-p`, tsconfigPath] : []),
-        `-t`,
-        `stylish`,
-        `--fix`,
-    ];
-    await (0, exec_1.execWithArgs)('tslint', args);
-}
-exports.runTSLint = runTSLint;
-function getTSLintConfigPath() {
-    const localTSLintConfig = `./tslint.json`;
-    const sharedTSLintConfig = `${paths_cnst_1.cfgDir}/tslint.config.js`;
-    return fs.existsSync(localTSLintConfig) ? localTSLintConfig : sharedTSLintConfig;
-}
-exports.getTSLintConfigPath = getTSLintConfigPath;
 function getTSConfigPath() {
     // this is to support "Solution style tsconfig.json" (as used in Angular10, for example)
     // return [`./tsconfig.base.json`].find(p => fs.existsSync(p)) || `./tsconfig.json`
@@ -37,7 +14,7 @@ function getTSConfigPathScripts() {
     return [`./scripts/tsconfig.json`].find(p => fs.existsSync(p)) || `${paths_cnst_1.scriptsDir}/tsconfig.json`;
 }
 exports.getTSConfigPathScripts = getTSConfigPathScripts;
-async function runESLint(dir, eslintConfigPath, tsconfigPath, extensions = ['ts', 'tsx', 'vue']) {
+async function runESLint(dir, eslintConfigPath, tsconfigPath, extensions = ['ts', 'tsx', 'vue'], fix = true) {
     if (!fs.existsSync(dir))
         return; // faster to bail-out like this
     const args = [
@@ -46,8 +23,8 @@ async function runESLint(dir, eslintConfigPath, tsconfigPath, extensions = ['ts'
         `${dir}/**/*.{${extensions.join(',')}}`,
         ...(tsconfigPath ? [`--parser-options=project:${tsconfigPath}`] : []),
         `--no-error-on-unmatched-pattern`,
-        `--fix`,
-    ];
+        fix ? `--fix` : '',
+    ].filter(Boolean);
     await (0, exec_1.execWithArgs)('eslint', args);
 }
 exports.runESLint = runESLint;

package/dist/util/prettier.util.js

@@ -1,8 +1,8 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.runPrettier = void 0;
-const exec_1 = require("@naturalcycles/nodejs-lib/dist/exec");
 const fs = require("fs");
+const exec_1 = require("@naturalcycles/nodejs-lib/dist/exec");
 const paths_cnst_1 = require("../cnst/paths.cnst");
 const { prettierDirs, prettierExtensionsAll, lintExclude } = require('../../cfg/_cnst');
 const prettierPaths = [

package/dist/util/stylelint.util.js

@@ -1,8 +1,9 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.stylelintAll = exports.stylelintPaths = void 0;
-const exec_1 = require("@naturalcycles/nodejs-lib/dist/exec");
 const fs = require("fs");
+const exec_1 = require("@naturalcycles/nodejs-lib/dist/exec");
+const yargs = require("yargs");
 const paths_cnst_1 = require("../cnst/paths.cnst");
 const { prettierDirs, stylelintExtensions, lintExclude } = require('../../cfg/_cnst');
 exports.stylelintPaths = [
@@ -12,8 +13,20 @@ exports.stylelintPaths = [
     ...lintExclude.map((s) => `!${s}`),
 ];
 async function stylelintAll() {
+    const { fix } = yargs.options({
+        fix: {
+            type: 'boolean',
+            default: true,
+        },
+    }).argv;
     const config = [`./stylelint.config.js`, `${paths_cnst_1.cfgDir}/stylelint.config.js`].find(f => fs.existsSync(f));
-    const args = [`--fix`, `--allow-empty-input`, `--config`, config, ...exports.stylelintPaths];
+    const args = [
+        fix ? `--fix` : '',
+        `--allow-empty-input`,
+        `--config`,
+        config,
+        ...exports.stylelintPaths,
+    ].filter(Boolean);
     await (0, exec_1.execWithArgs)('stylelint', args);
 }
 exports.stylelintAll = stylelintAll;

package/dist/util/tsc.util.js

@@ -1,11 +1,11 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.ensureProjectTsconfigScripts = exports.tsc = void 0;
+const fs = require("fs");
 const js_lib_1 = require("@naturalcycles/js-lib");
 const colors_1 = require("@naturalcycles/nodejs-lib/dist/colors");
 const exec_1 = require("@naturalcycles/nodejs-lib/dist/exec");
 const fs_1 = require("@naturalcycles/nodejs-lib/dist/fs");
-const fs = require("fs");
 const paths_cnst_1 = require("../cnst/paths.cnst");
 async function tsc() {
     const started = Date.now();

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@naturalcycles/dev-lib",
-  "version": "12.4.1",
+  "version": "12.7.1",
   "scripts": {
     "prepare": "husky install",
     "tsn-debug": "tsn testScript.ts",
@@ -22,7 +22,6 @@
     "commitlint-def": "tsn ./src/bin/commitlint-def.ts",
     "prettier-all": "tsn ./src/bin/prettier-all.ts",
     "stylelint-all": "tsn ./src/bin/stylelint-all.ts",
-    "tslint-all": "tsn ./src/bin/tslint-all.ts",
     "lint-all": "tsn ./src/bin/lint-all.ts",
     "lint-circleci": "tsn ./src/bin/lint-circleci.ts",
     "eslint-all": "tsn ./src/bin/eslint-all.ts",
@@ -63,7 +62,6 @@
     "stylelint-scss": "^3.19.0",
     "timekeeper": "^2.2.0",
     "ts-jest": "^27.0.0",
-    "tslint": "^6.0.0",
     "typescript": "^4.0.2",
     "yargs": "^17.0.0"
   },
@@ -101,7 +99,6 @@
     "test-manual": "dist/bin/test-manual.js",
     "tsc-prod": "dist/bin/tsc-prod.js",
     "tsc-scripts": "dist/bin/tsc-scripts.js",
-    "tslint-all": "dist/bin/tslint-all.js",
     "update-from-dev-lib": "dist/bin/update-from-dev-lib.js"
   },
   "engines": {

package/readme.md

@@ -22,9 +22,9 @@ This unlocks all commands listed below, e.g:
     yarn test
     yarn lint-all
 
-By default, it uses default configs for Prettier, TSLint (to be replaced by ESLint soon), Stylelint,
-that are included in this package (for convenience). You can override them by putting your own
-`prettier.config.js`, `tslint.json`, `stylelint.config.json` in the root folder of your project.
+By default, it uses default configs for Prettier, ESLint, Stylelint, that are included in this
+package (for convenience). You can override them by putting your own `prettier.config.js`,
+`.eslintrc.js`, `stylelint.config.json` in the root folder of your project.
 
 ## Conventions
 
@@ -127,18 +127,24 @@ variable to disable it.
 
 #### Lint commands
 
-- `lint-all`: runs TSLint, Stylelint, Prettier, in the right order.
+- `lint-all`: runs ESLint, Stylelint, Prettier, in the right order.
 
   - `--commitOnChanges` will commit lint-modified changes and push them
   - `--failOnChanges` will exit with status 1 in the end (will fail the command)
 
-- `tslint-all`: runs `tslint` on needed paths
 - `eslint-all`: runs `eslint` on needed paths
 - `stylelint-all`: runs `stylelint` on needed paths
 - `prettier-all`: runs just Prettier on needed paths
 - `lint-circleci`: fails if `.circleci/config.yml` is invalid
   ([CircleCI CLI](https://circleci.com/docs/2.0/local-cli/) must be installed before)
 
+Pass `--no-fix` (or `--fix=false`) to disable the default `--fix` flag on linters. Useful to debug a
+linter, or when linter behaves badly and corrupts your files (just happened to me with
+`eslint-plugin-vue`).
+
+Pass `--ext` (e.g `--ext ts,html`) to override the list of ESLint extensions (default is
+`ts,tsx,vue` right now).
+
 #### Other commands
 
 - `init-from-dev-lib`: copy config files from `dev-lib/cfg/init` to the project
@@ -167,7 +173,6 @@ These files are meant to be extended in target project, so act as _recommended d
 - `husky.config.js`
 - `lint-staged.config.js`
 - `prettier.config.js`
-- `tslint.json`
 - `eslint.config.json`
 - `jest.config.js`
 

package/cfg/init/tslint.json

@@ -1,6 +0,0 @@
-{
-  "extends": ["./node_modules/@naturalcycles/dev-lib/cfg/tslint.config.js"],
-  "linterOptions": {
-    "exclude": ["src/**/__exclude/**/*"]
-  }
-}

package/cfg/tslint.config.js

@@ -1,36 +0,0 @@
-// formatting rules still have value that IDEs will infer their setting from them
-module.exports = {
-  rules: {
-    'class-name': true,
-    // 'interface-name': [false, 'never-prefix'],
-    // 'no-console': [false, 'debug', 'info', 'time', 'timeEnd', 'trace'],
-    // 'no-duplicate-imports': false,
-    'no-floating-promises': true,
-    // 'no-implicit-dependencies': [false, 'dev', ['@app']],
-    'no-invalid-this': [true, 'check-function-in-method'],
-    // 'no-null-keyword': false,
-    // 'no-require-imports': false,
-    // 'no-shadowed-variable': false,
-    // 'no-string-literal': false,
-    'no-unused-variable': [true, { 'ignore-pattern': '^_' }], // todo: check it
-    'ordered-imports': true, // todo
-    'promise-function-async': [
-      true,
-      'check-function-declaration',
-      'check-function-expression',
-      'check-method-declaration',
-    ],
-    typedef: [true, 'property-declaration'], // todo
-    // 'unified-signatures': false,
-    'variable-name': [
-      true,
-      'ban-keywords',
-      'check-format',
-      'allow-pascal-case',
-      'allow-leading-underscore',
-    ],
-  },
-  linterOptions: {
-    exclude: ['src/**/__exclude/**/*'],
-  },
-}

package/dist/bin/tslint-all.d.ts

@@ -1,2 +0,0 @@
-#!/usr/bin/env node
-export {};

package/dist/bin/tslint-all.js

@@ -1,6 +0,0 @@
-#!/usr/bin/env node
-"use strict";
-Object.defineProperty(exports, "__esModule", { value: true });
-const script_1 = require("@naturalcycles/nodejs-lib/dist/script");
-const tslint_all_command_1 = require("../cmd/tslint-all.command");
-(0, script_1.runScript)(tslint_all_command_1.tslintAllCommand);

package/dist/cmd/tslint-all.command.d.ts

@@ -1,4 +0,0 @@
-/**
- * Runs `tslint` command for all predefined paths (e.g /src, etc).
- */
-export declare function tslintAllCommand(): Promise<void>;

package/dist/cmd/tslint-all.command.js

@@ -1,27 +0,0 @@
-"use strict";
-Object.defineProperty(exports, "__esModule", { value: true });
-exports.tslintAllCommand = void 0;
-const tslint_util_1 = require("../util/tslint.util");
-const { lintExclude } = require('../../cfg/_cnst');
-/**
- * Runs `tslint` command for all predefined paths (e.g /src, etc).
- */
-async function tslintAllCommand() {
-    const projectSrcDir = `./src`;
-    const projectScriptsDir = `./scripts`;
-    const projectE2eDir = `./e2e`;
-    const tslintConfigPath = (0, tslint_util_1.getTSLintConfigPath)();
-    const tsconfigPath = (0, tslint_util_1.getTSConfigPath)();
-    const tsconfigPathScripts = (0, tslint_util_1.getTSConfigPathScripts)();
-    const tsconfigPathE2e = `./e2e/tsconfig.json`;
-    // /src
-    await (0, tslint_util_1.runTSLint)(projectSrcDir, lintExclude, tslintConfigPath);
-    await (0, tslint_util_1.runTSLint)(projectSrcDir, lintExclude, tslintConfigPath, tsconfigPath);
-    // /scripts
-    await (0, tslint_util_1.runTSLint)(projectScriptsDir, lintExclude, tslintConfigPath);
-    await (0, tslint_util_1.runTSLint)(projectScriptsDir, lintExclude, tslintConfigPath, tsconfigPathScripts);
-    // /e2e
-    await (0, tslint_util_1.runTSLint)(projectE2eDir, lintExclude, tslintConfigPath);
-    await (0, tslint_util_1.runTSLint)(projectE2eDir, lintExclude, tslintConfigPath, tsconfigPathE2e);
-}
-exports.tslintAllCommand = tslintAllCommand;