@naturalcycles/db-lib 9.24.2 → 9.26.0

package/dist/commondao/common.dao.js

@@ -494,7 +494,12 @@ class CommonDao {
             return await this.patchByIdInTransaction(id, patch, opt);
         }
         let patched;
-        const loaded = await this.getById(id, opt);
+        const loaded = await this.getById(id, {
+            // Skipping validation here for performance reasons.
+            // Validation is going to happen on save anyway, just down below.
+            skipValidation: true,
+            ...opt,
+        });
         if (loaded) {
             patched = { ...loaded, ...patch };
             if ((0, js_lib_1._deepJsonEquals)(loaded, patched)) {
@@ -545,7 +550,12 @@ class CommonDao {
             Object.assign(bm, patch);
         }
         else {
-            const loaded = await this.getById(bm.id, opt);
+            const loaded = await this.getById(bm.id, {
+                // Skipping validation here for performance reasons.
+                // Validation is going to happen on save anyway, just down below.
+                skipValidation: true,
+                ...opt,
+            });
             if (loaded) {
                 const loadedWithPatch = {
                     ...loaded,
@@ -968,7 +978,19 @@ class CommonDao {
         }
         else {
             // Joi
+            const start = performance.now();
             const vr = (0, nodejs_lib_1.getValidationResult)(obj, schema, objectName);
+            const end = performance.now();
+            const tookMillis = end - start;
+            if (this.cfg.debugValidationTimeThreshhold &&
+                tookMillis >= this.cfg.debugValidationTimeThreshhold) {
+                this.cfg.onValidationTimeThreshold?.({
+                    tookMillis,
+                    error: !!vr.error,
+                    table,
+                    obj,
+                });
+            }
             error = vr.error;
             convertedValue = vr.value;
         }

package/dist/commondao/common.dao.model.d.ts

@@ -1,4 +1,4 @@
-import { BaseDBEntity, CommonLogger, ErrorMode, Promisable, UnixTimestamp, ZodError, ZodSchema } from '@naturalcycles/js-lib';
+import { AnyObject, BaseDBEntity, CommonLogger, ErrorMode, NumberOfMilliseconds, Promisable, UnixTimestamp, ZodError, ZodSchema } from '@naturalcycles/js-lib';
 import { AjvSchema, AjvValidationError, JoiValidationError, ObjectSchema, TransformLogProgressOptions, TransformMapOptions } from '@naturalcycles/nodejs-lib';
 import { CommonDB } from '../common.db';
 import { CommonDBCreateOptions, CommonDBOptions, CommonDBSaveOptions } from '../db.model';
@@ -111,6 +111,15 @@ export interface CommonDaoCfg<BM extends BaseDBEntity, DBM extends BaseDBEntity
      * If set to false - save (write) operations will skip validation (and conversion).
      */
     validateOnSave?: boolean;
+    /**
+     * Defaults to undefined == disabled.
+     * If set - enable the monitoring of validation time and will alert on crossing the threshold.
+     */
+    debugValidationTimeThreshhold?: NumberOfMilliseconds;
+    /**
+     * Called when debugValidationTimeThreshhold is crossed.
+     */
+    onValidationTimeThreshold?: (info: AnyObject) => void;
     /**
      * Defaults to false.
      * Setting it to true will set saveMethod to `insert` for save/saveBatch, which will

package/package.json

@@ -43,9 +43,9 @@
     "url": "https://github.com/NaturalCycles/db-lib"
   },
   "engines": {
-    "node": ">=20.13"
+    "node": ">=22.10.0"
   },
-  "version": "9.24.2",
+  "version": "9.26.0",
   "description": "Lowest Common Denominator API to supported Databases",
   "keywords": [
     "db",

package/src/commondao/common.dao.model.ts

@@ -1,7 +1,9 @@
 import {
+  AnyObject,
   BaseDBEntity,
   CommonLogger,
   ErrorMode,
+  NumberOfMilliseconds,
   Promisable,
   UnixTimestamp,
   ZodError,
@@ -146,6 +148,17 @@ export interface CommonDaoCfg<
    */
   validateOnSave?: boolean
 
+  /**
+   * Defaults to undefined == disabled.
+   * If set - enable the monitoring of validation time and will alert on crossing the threshold.
+   */
+  debugValidationTimeThreshhold?: NumberOfMilliseconds
+
+  /**
+   * Called when debugValidationTimeThreshhold is crossed.
+   */
+  onValidationTimeThreshold?: (info: AnyObject) => void
+
   /**
    * Defaults to false.
    * Setting it to true will set saveMethod to `insert` for save/saveBatch, which will

package/src/commondao/common.dao.ts

@@ -663,7 +663,12 @@ export class CommonDao<BM extends BaseDBEntity, DBM extends BaseDBEntity = BM, I
     }
 
     let patched: BM
-    const loaded = await this.getById(id, opt)
+    const loaded = await this.getById(id, {
+      // Skipping validation here for performance reasons.
+      // Validation is going to happen on save anyway, just down below.
+      skipValidation: true,
+      ...opt,
+    })
 
     if (loaded) {
       patched = { ...loaded, ...patch }
@@ -723,7 +728,12 @@ export class CommonDao<BM extends BaseDBEntity, DBM extends BaseDBEntity = BM, I
       }
       Object.assign(bm, patch)
     } else {
-      const loaded = await this.getById(bm.id as ID, opt)
+      const loaded = await this.getById(bm.id as ID, {
+        // Skipping validation here for performance reasons.
+        // Validation is going to happen on save anyway, just down below.
+        skipValidation: true,
+        ...opt,
+      })
 
       if (loaded) {
         const loadedWithPatch: BM = {
@@ -1257,7 +1267,23 @@ export class CommonDao<BM extends BaseDBEntity, DBM extends BaseDBEntity = BM, I
       })
     } else {
       // Joi
+      const start = performance.now()
       const vr = getValidationResult(obj, schema, objectName)
+      const end = performance.now()
+      const tookMillis = end - start
+
+      if (
+        this.cfg.debugValidationTimeThreshhold &&
+        tookMillis >= this.cfg.debugValidationTimeThreshhold
+      ) {
+        this.cfg.onValidationTimeThreshold?.({
+          tookMillis,
+          error: !!vr.error,
+          table,
+          obj,
+        })
+      }
+
       error = vr.error
       convertedValue = vr.value
     }