@naturalcycles/db-lib 8.34.1 → 8.34.2

package/dist/commondao/common.dao.d.ts

@@ -85,7 +85,7 @@ export declare class CommonDao<BM extends Partial<ObjectWithId>, DBM extends Obj
      * Mutates with id, created, updated
      */
     save(bm: BM, opt?: CommonDaoSaveOptions<DBM>): Promise<Saved<BM>>;
-    private ensureImmutableDoesntExist;
+    private ensureImmutableDontExist;
     private ensureUniqueId;
     private throwIfObjectExists;
     /**

package/dist/commondao/common.dao.js

@@ -442,7 +442,7 @@ class CommonDao {
         if (opt.ensureUniqueId && idWasGenerated)
             await this.ensureUniqueId(table, dbm);
         if (this.cfg.immutable)
-            await this.ensureImmutableDoesntExist(table, dbm);
+            await this.ensureImmutableDontExist(table, [dbm.id]);
         const op = `save(${dbm.id})`;
         const started = this.logSaveStarted(op, bm, table);
         await this.cfg.db.saveBatch(table, [dbm], {
@@ -452,31 +452,29 @@ class CommonDao {
         this.logSaveResult(started, op, table);
         return bm;
     }
-    async ensureImmutableDoesntExist(table, dbm) {
-        await this.throwIfObjectExists(table, dbm, [
+    async ensureImmutableDontExist(table, ids) {
+        await this.throwIfObjectExists(table, ids, [
             cnst_1.DBLibError.OBJECT_IS_IMMUTABLE,
             {
                 code: cnst_1.DBLibError.OBJECT_IS_IMMUTABLE,
-                id: dbm.id,
                 table,
             },
         ]);
     }
     async ensureUniqueId(table, dbm) {
         // todo: retry N times
-        await this.throwIfObjectExists(table, dbm, [
+        await this.throwIfObjectExists(table, [dbm.id], [
             cnst_1.DBLibError.OBJECT_IS_IMMUTABLE,
             {
                 code: cnst_1.DBLibError.OBJECT_IS_IMMUTABLE,
-                id: dbm.id,
                 table,
             },
         ]);
     }
-    async throwIfObjectExists(table, dbm, errorMeta) {
-        const [existing] = await this.cfg.db.getByIds(table, [dbm.id]);
-        if (existing)
-            throw new js_lib_1.AppError(errorMeta[0], errorMeta[1]);
+    async throwIfObjectExists(table, ids, errorMeta) {
+        const existing = await this.cfg.db.getByIds(table, ids);
+        if (existing.length > 0)
+            throw new js_lib_1.AppError(errorMeta[0], { ...errorMeta[1], ids: existing.map(i => i.id) });
     }
     /**
      * Loads the row by id.
@@ -512,7 +510,7 @@ class CommonDao {
             if (opt.ensureUniqueId && idWasGenerated)
                 await this.ensureUniqueId(table, dbm);
             if (this.cfg.immutable)
-                await this.ensureImmutableDoesntExist(table, dbm);
+                await this.ensureImmutableDontExist(table, [dbm.id]);
         }
         const op = `saveAsDBM(${dbm.id})`;
         const started = this.logSaveStarted(op, dbm, table);
@@ -531,7 +529,7 @@ class CommonDao {
         if (opt.ensureUniqueId)
             throw new js_lib_1.AppError('ensureUniqueId is not supported in saveBatch');
         if (this.cfg.immutable)
-            throw new js_lib_1.AppError('immutable DB entries are not supported in saveBatch');
+            await this.ensureImmutableDontExist(table, dbms.map(dbm => dbm.id));
         const op = `saveBatch ${dbms.length} row(s) (${(0, js_lib_1._truncate)(dbms
             .slice(0, 10)
             .map(bm => bm.id)
@@ -553,7 +551,7 @@ class CommonDao {
             if (opt.ensureUniqueId)
                 throw new js_lib_1.AppError('ensureUniqueId is not supported in saveBatch');
             if (this.cfg.immutable)
-                throw new js_lib_1.AppError('immutable objects are not supported in saveBatch');
+                await this.ensureImmutableDontExist(table, dbms.map(dbm => dbm.id));
         }
         const op = `saveBatchAsDBM ${dbms.length} row(s) (${(0, js_lib_1._truncate)(dbms
             .slice(0, 10)

package/package.json

@@ -43,7 +43,7 @@
   "engines": {
     "node": ">=14.15"
   },
-  "version": "8.34.1",
+  "version": "8.34.2",
   "description": "Lowest Common Denominator API to supported Databases",
   "keywords": [
     "db",

package/src/commondao/common.dao.ts

@@ -601,7 +601,7 @@ export class CommonDao<
     const dbm = await this.bmToDBM(bm, opt)
     const table = opt.table || this.cfg.table
     if (opt.ensureUniqueId && idWasGenerated) await this.ensureUniqueId(table, dbm)
-    if (this.cfg.immutable) await this.ensureImmutableDoesntExist(table, dbm)
+    if (this.cfg.immutable) await this.ensureImmutableDontExist(table, [dbm.id])
     const op = `save(${dbm.id})`
     const started = this.logSaveStarted(op, bm, table)
     await this.cfg.db.saveBatch(table, [dbm], {
@@ -613,12 +613,11 @@ export class CommonDao<
     return bm as any
   }
 
-  private async ensureImmutableDoesntExist(table: string, dbm: DBM): Promise<void> {
-    await this.throwIfObjectExists(table, dbm, [
+  private async ensureImmutableDontExist(table: string, ids: string[]): Promise<void> {
+    await this.throwIfObjectExists(table, ids, [
       DBLibError.OBJECT_IS_IMMUTABLE,
       {
         code: DBLibError.OBJECT_IS_IMMUTABLE,
-        id: dbm.id,
         table,
       },
     ])
@@ -626,23 +625,27 @@ export class CommonDao<
 
   private async ensureUniqueId(table: string, dbm: DBM): Promise<void> {
     // todo: retry N times
-    await this.throwIfObjectExists(table, dbm, [
-      DBLibError.OBJECT_IS_IMMUTABLE,
-      {
-        code: DBLibError.OBJECT_IS_IMMUTABLE,
-        id: dbm.id,
-        table,
-      },
-    ])
+    await this.throwIfObjectExists(
+      table,
+      [dbm.id],
+      [
+        DBLibError.OBJECT_IS_IMMUTABLE,
+        {
+          code: DBLibError.OBJECT_IS_IMMUTABLE,
+          table,
+        },
+      ],
+    )
   }
 
   private async throwIfObjectExists(
     table: string,
-    dbm: DBM,
+    ids: string[],
     errorMeta: [DBLibError, any],
   ): Promise<void> {
-    const [existing] = await this.cfg.db.getByIds<DBM>(table, [dbm.id])
-    if (existing) throw new AppError(errorMeta[0], errorMeta[1])
+    const existing = await this.cfg.db.getByIds<DBM>(table, ids)
+    if (existing.length > 0)
+      throw new AppError(errorMeta[0], { ...errorMeta[1], ids: existing.map(i => i.id) })
   }
 
   /**
@@ -696,7 +699,7 @@ export class CommonDao<
       this.assignIdCreatedUpdated(dbm, opt) // mutates
       dbm = this.anyToDBM(dbm, opt)
       if (opt.ensureUniqueId && idWasGenerated) await this.ensureUniqueId(table, dbm)
-      if (this.cfg.immutable) await this.ensureImmutableDoesntExist(table, dbm)
+      if (this.cfg.immutable) await this.ensureImmutableDontExist(table, [dbm.id])
     }
     const op = `saveAsDBM(${dbm.id})`
     const started = this.logSaveStarted(op, dbm, table)
@@ -715,7 +718,11 @@ export class CommonDao<
     const dbms = await this.bmsToDBM(bms, opt)
     if (opt.ensureUniqueId) throw new AppError('ensureUniqueId is not supported in saveBatch')
     if (this.cfg.immutable)
-      throw new AppError('immutable DB entries are not supported in saveBatch')
+      await this.ensureImmutableDontExist(
+        table,
+        dbms.map(dbm => dbm.id),
+      )
+
     const op = `saveBatch ${dbms.length} row(s) (${_truncate(
       dbms
         .slice(0, 10)
@@ -742,7 +749,11 @@ export class CommonDao<
       dbms.forEach(dbm => this.assignIdCreatedUpdated(dbm, opt)) // mutates
       dbms = this.anyToDBMs(dbms, opt)
       if (opt.ensureUniqueId) throw new AppError('ensureUniqueId is not supported in saveBatch')
-      if (this.cfg.immutable) throw new AppError('immutable objects are not supported in saveBatch')
+      if (this.cfg.immutable)
+        await this.ensureImmutableDontExist(
+          table,
+          dbms.map(dbm => dbm.id),
+        )
     }
     const op = `saveBatchAsDBM ${dbms.length} row(s) (${_truncate(
       dbms