@naturalcycles/db-lib 10.14.0 → 10.15.1

package/dist/commondao/common.dao.js

@@ -346,8 +346,9 @@ export class CommonDao {
         const stream = this.cfg.db.streamQuery(q, opt);
         if (partialQuery)
             return stream;
-        return stream
-            .on('error', err => stream.emit('error', err))
+        return (stream
+            // the commented out line was causing RangeError: Maximum call stack size exceeded
+            // .on('error', err => stream.emit('error', err))
             .pipe(transformMap(async (dbm) => {
             if (this.cfg.hooks.afterLoad) {
                 dbm = (await this.cfg.hooks.afterLoad(dbm));
@@ -357,7 +358,7 @@ export class CommonDao {
             return this.anyToDBM(dbm, opt);
         }, {
             errorMode: opt.errorMode,
-        }));
+        })));
     }
     /**
      * Stream as Readable, to be able to .pipe() it further with support of backpressure.
@@ -392,7 +393,8 @@ export class CommonDao {
             // optimization: 1 validation is enough
             // .pipe(transformMap<any, DBM>(dbm => this.anyToDBM(dbm, opt), safeOpt))
             // .pipe(transformMap<DBM, BM>(dbm => this.dbmToBM(dbm, opt), safeOpt))
-            .on('error', err => stream.emit('error', err))
+            // the commented out line was causing RangeError: Maximum call stack size exceeded
+            // .on('error', err => stream.emit('error', err))
             .pipe(transformMap(async (dbm) => {
             if (this.cfg.hooks.afterLoad) {
                 dbm = (await this.cfg.hooks.afterLoad(dbm));

package/dist/inmemory/inMemory.db.js

@@ -77,7 +77,7 @@ export class InMemoryDB {
     async saveBatch(_table, rows, opt = {}) {
         const table = this.cfg.tablesPrefix + _table;
         this.data[table] ||= {};
-        rows.forEach(r => {
+        for (const r of rows) {
             if (!r.id) {
                 this.cfg.logger.warn({ rows });
                 throw new Error(`InMemoryDB doesn't support id auto-generation in saveBatch, row without id was given`);
@@ -92,7 +92,7 @@ export class InMemoryDB {
             // 1. Not store values "by reference" (avoid mutation bugs)
             // 2. Simulate real DB that would do something like that in a transport layer anyway
             this.data[table][r.id] = JSON.parse(JSON.stringify(r), bufferReviver);
-        });
+        }
     }
     async deleteByQuery(q, _opt) {
         const table = this.cfg.tablesPrefix + q.table;
@@ -106,12 +106,12 @@ export class InMemoryDB {
         if (!this.data[table])
             return 0;
         let count = 0;
-        ids.forEach(id => {
+        for (const id of ids) {
             if (!this.data[table][id])
-                return;
+                continue;
             delete this.data[table][id];
             count++;
-        });
+        }
         return count;
     }
     async patchByQuery(q, patch) {
@@ -119,7 +119,9 @@ export class InMemoryDB {
             return 0;
         const table = this.cfg.tablesPrefix + q.table;
         const rows = queryInMemory(q, Object.values(this.data[table] || {}));
-        rows.forEach(row => Object.assign(row, patch));
+        for (const row of rows) {
+            Object.assign(row, patch);
+        }
         return rows.length;
     }
     async runQuery(q, _opt) {

package/dist/inmemory/inMemoryKeyValueDB.js

@@ -14,7 +14,9 @@ export class InMemoryKeyValueDB {
     async createTable(_table, _opt) { }
     async deleteByIds(table, ids) {
         this.data[table] ||= {};
-        ids.forEach(id => delete this.data[table][id]);
+        for (const id of ids) {
+            delete this.data[table][id];
+        }
     }
     async getByIds(table, ids) {
         this.data[table] ||= {};
@@ -22,7 +24,9 @@ export class InMemoryKeyValueDB {
     }
     async saveBatch(table, entries) {
         this.data[table] ||= {};
-        entries.forEach(([id, v]) => (this.data[table][id] = v));
+        for (const [id, v] of entries) {
+            this.data[table][id] = v;
+        }
     }
     streamIds(table, limit) {
         return Readable.from(Object.keys(this.data[table] || {}).slice(0, limit));

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@naturalcycles/db-lib",
   "type": "module",
-  "version": "10.14.0",
+  "version": "10.15.1",
   "dependencies": {
     "@naturalcycles/js-lib": "^15",
     "@naturalcycles/nodejs-lib": "^15"

package/src/commondao/common.dao.ts

@@ -457,23 +457,26 @@ export class CommonDao<BM extends BaseDBEntity, DBM extends BaseDBEntity = BM, I
     const stream = this.cfg.db.streamQuery<DBM>(q, opt)
     if (partialQuery) return stream
 
-    return stream
-      .on('error', err => stream.emit('error', err))
-      .pipe(
-        transformMap<any, DBM>(
-          async dbm => {
-            if (this.cfg.hooks!.afterLoad) {
-              dbm = (await this.cfg.hooks!.afterLoad(dbm))!
-              if (dbm === null) return SKIP
-            }
-
-            return this.anyToDBM(dbm, opt)
-          },
-          {
-            errorMode: opt.errorMode,
-          },
-        ),
-      )
+    return (
+      stream
+        // the commented out line was causing RangeError: Maximum call stack size exceeded
+        // .on('error', err => stream.emit('error', err))
+        .pipe(
+          transformMap<any, DBM>(
+            async dbm => {
+              if (this.cfg.hooks!.afterLoad) {
+                dbm = (await this.cfg.hooks!.afterLoad(dbm))!
+                if (dbm === null) return SKIP
+              }
+
+              return this.anyToDBM(dbm, opt)
+            },
+            {
+              errorMode: opt.errorMode,
+            },
+          ),
+        )
+    )
   }
 
   /**
@@ -512,7 +515,8 @@ export class CommonDao<BM extends BaseDBEntity, DBM extends BaseDBEntity = BM, I
         // optimization: 1 validation is enough
         // .pipe(transformMap<any, DBM>(dbm => this.anyToDBM(dbm, opt), safeOpt))
         // .pipe(transformMap<DBM, BM>(dbm => this.dbmToBM(dbm, opt), safeOpt))
-        .on('error', err => stream.emit('error', err))
+        // the commented out line was causing RangeError: Maximum call stack size exceeded
+        // .on('error', err => stream.emit('error', err))
         .pipe(
           transformMap<DBM, BM>(
             async dbm => {

package/src/inmemory/inMemory.db.ts

@@ -153,7 +153,7 @@ export class InMemoryDB implements CommonDB {
     const table = this.cfg.tablesPrefix + _table
     this.data[table] ||= {}
 
-    rows.forEach(r => {
+    for (const r of rows) {
       if (!r.id) {
         this.cfg.logger!.warn({ rows })
         throw new Error(
@@ -161,19 +161,19 @@ export class InMemoryDB implements CommonDB {
         )
       }
 
-      if (opt.saveMethod === 'insert' && this.data[table]![r.id]) {
+      if (opt.saveMethod === 'insert' && this.data[table][r.id]) {
         throw new Error(`InMemoryDB: INSERT failed, entity exists: ${table}.${r.id}`)
       }
 
-      if (opt.saveMethod === 'update' && !this.data[table]![r.id]) {
+      if (opt.saveMethod === 'update' && !this.data[table][r.id]) {
         throw new Error(`InMemoryDB: UPDATE failed, entity doesn't exist: ${table}.${r.id}`)
       }
 
       // JSON parse/stringify (deep clone) is to:
       // 1. Not store values "by reference" (avoid mutation bugs)
       // 2. Simulate real DB that would do something like that in a transport layer anyway
-      this.data[table]![r.id] = JSON.parse(JSON.stringify(r), bufferReviver)
-    })
+      this.data[table][r.id] = JSON.parse(JSON.stringify(r), bufferReviver)
+    }
   }
 
   async deleteByQuery<ROW extends ObjectWithId>(
@@ -191,11 +191,11 @@ export class InMemoryDB implements CommonDB {
     if (!this.data[table]) return 0
 
     let count = 0
-    ids.forEach(id => {
-      if (!this.data[table]![id]) return
-      delete this.data[table]![id]
+    for (const id of ids) {
+      if (!this.data[table][id]) continue
+      delete this.data[table][id]
       count++
-    })
+    }
 
     return count
   }
@@ -207,7 +207,9 @@ export class InMemoryDB implements CommonDB {
     if (_isEmptyObject(patch)) return 0
     const table = this.cfg.tablesPrefix + q.table
     const rows = queryInMemory(q, Object.values(this.data[table] || {}) as ROW[])
-    rows.forEach(row => Object.assign(row, patch))
+    for (const row of rows) {
+      Object.assign(row, patch)
+    }
     return rows.length
   }
 

package/src/inmemory/inMemoryKeyValueDB.ts

@@ -23,7 +23,9 @@ export class InMemoryKeyValueDB implements CommonKeyValueDB {
 
   async deleteByIds(table: string, ids: string[]): Promise<void> {
     this.data[table] ||= {}
-    ids.forEach(id => delete this.data[table]![id])
+    for (const id of ids) {
+      delete this.data[table][id]
+    }
   }
 
   async getByIds(table: string, ids: string[]): Promise<KeyValueDBTuple[]> {
@@ -33,7 +35,9 @@ export class InMemoryKeyValueDB implements CommonKeyValueDB {
 
   async saveBatch(table: string, entries: KeyValueDBTuple[]): Promise<void> {
     this.data[table] ||= {}
-    entries.forEach(([id, v]) => (this.data[table]![id] = v))
+    for (const [id, v] of entries) {
+      this.data[table][id] = v
+    }
   }
 
   streamIds(table: string, limit?: number): ReadableTyped<string> {