@naturalcycles/backend-lib 4.21.0 → 4.22.0

package/dist/admin/base.admin.service.js

@@ -186,7 +186,7 @@ class BaseAdminService {
             res
                 .cookie(this.cfg.adminTokenKey, token, {
                 maxAge,
-                sameSite: 'lax',
+                sameSite: 'lax', // can be: none, lax, strict
                 // comment these 2 lines to debug on localhost
                 httpOnly: true,
                 secure: true,

package/dist/deploy/deploy.util.js

@@ -55,6 +55,9 @@ async function createDeployInfo(backendCfg) {
         ].join('-');
     }
     const versionUrl = `https://${[gaeVersion, gaeService, gaeProject].join('-dot-')}.appspot.com`;
+    // Check the 63-char limit
+    const versionUrlString = [gaeVersion, gaeService, gaeProject].join('-dot-');
+    (0, js_lib_1._assert)(versionUrlString.length <= 63, `versionUrl length should be <= 63 characters, but it's ${versionUrlString.length} instead: ${versionUrlString}`);
     const serviceUrl = `https://${[gaeService, gaeProject].join('-dot-')}.appspot.com`;
     const deployInfo = {
         gaeProject,
@@ -138,12 +141,10 @@ function redactedAppYaml(appYaml) {
 }
 function validateGAEServiceName(serviceName) {
     // May only contain lowercase letters, digits, and hyphens. Must begin and end with a letter or digit. Must not exceed 63 characters.
-    return replaceAll(serviceName, '_', '-')
+    return serviceName
+        .replaceAll('_', '-')
         .toLowerCase()
         .replaceAll(/[^0-9a-z-]/gi, '')
         .slice(0, 40);
 }
 exports.validateGAEServiceName = validateGAEServiceName;
-function replaceAll(str, search, replacement) {
-    return str.split(search).join(replacement);
-}

package/dist/deploy/deployPrepare.js

@@ -30,7 +30,7 @@ const DEFAULT_FILES = [
     // '!dist/**/*.test.*',
     // '!dist/**/*.mock.*',
     '!dist/**/*.script.*',
-    'src',
+    'src', // For Sentry
     '!src/test',
     '!src/**/*.test.*',
     '!src/**/*.mock.*',
@@ -38,15 +38,15 @@ const DEFAULT_FILES = [
     '!**/__snapshots__',
     '!**/__exclude',
     'static',
-    'secret/**/*.enc',
+    'secret/**/*.enc', // encrypted secrets
     'package.json',
     'yarn.lock',
     '.yarnrc',
-    'tsconfig.json',
+    'tsconfig.json', // for path-mapping to work!
     'tsconfig.dist.json',
     '.gcloudignore',
     'app.yaml',
-    'patches',
+    'patches', // to allow patch-package
     'resources',
 ];
 const defaultFilesDir = `${paths_cnst_1.srcDir}/deploy/files-default`;

package/dist/sentry/sentry.shared.service.js

@@ -35,7 +35,7 @@ class SentrySharedService {
             console.log('SentryService init...');
         }
         sentry.init({
-            maxValueLength: 2000,
+            maxValueLength: 2000, // default is 250 characters
             ...this.sentryServiceCfg,
         });
         return sentry;
@@ -113,8 +113,8 @@ class SentrySharedService {
      */
     getCommonLogger() {
         return {
-            log: () => { },
-            warn: () => { },
+            log: () => { }, // noop
+            warn: () => { }, // noop
             error: (...args) => {
                 const message = args.map(arg => (0, nodejs_lib_1._inspect)(arg, INSPECT_OPT)).join(' ');
                 this.sentry().addBreadcrumb({

package/dist/testing/express.test.service.js

@@ -31,8 +31,8 @@ class ExpressTestService {
             retry: { count: 0 },
             logRequest: true,
             logResponse: true,
-            logWithBaseUrl: false,
-            fetchFn: nativeFetchFn,
+            logWithBaseUrl: false, // for stable error snapshots
+            fetchFn: nativeFetchFn, // this is to make it NOT mockable
             ...opt,
         }).onAfterResponse(async () => {
             // This "empty" hook exists to act like `await pDelay`,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@naturalcycles/backend-lib",
-  "version": "4.21.0",
+  "version": "4.22.0",
   "scripts": {
     "prepare": "husky install",
     "serve": "APP_ENV=dev nodemon",
@@ -29,7 +29,7 @@
     "ejs": "^3.0.1",
     "express": "^4.16.4",
     "express-promise-router": "^4.0.0",
-    "firebase-admin": "^11.0.0",
+    "firebase-admin": "^12.0.0",
     "helmet": "^7.0.0",
     "js-yaml": "^4.0.0",
     "on-finished": "^2.3.0",

package/src/deploy/deploy.util.ts

@@ -1,5 +1,5 @@
 import fs from 'node:fs'
-import { _mapValues, _merge, _truncate, localTimeNow } from '@naturalcycles/js-lib'
+import { _assert, _mapValues, _merge, _truncate, localTimeNow } from '@naturalcycles/js-lib'
 import { dimGrey, white } from '@naturalcycles/nodejs-lib'
 import yaml from 'js-yaml'
 import { BackendCfg } from './backend.cfg.util'
@@ -79,6 +79,13 @@ export async function createDeployInfo(backendCfg: BackendCfg): Promise<DeployIn
 
   const versionUrl = `https://${[gaeVersion, gaeService, gaeProject].join('-dot-')}.appspot.com`
 
+  // Check the 63-char limit
+  const versionUrlString = [gaeVersion, gaeService, gaeProject].join('-dot-')
+  _assert(
+    versionUrlString.length <= 63,
+    `versionUrl length should be <= 63 characters, but it's ${versionUrlString.length} instead: ${versionUrlString}`,
+  )
+
   const serviceUrl = `https://${[gaeService, gaeProject].join('-dot-')}.appspot.com`
 
   const deployInfo: DeployInfo = {
@@ -198,12 +205,9 @@ function redactedAppYaml(appYaml: AppYaml): AppYaml {
 
 export function validateGAEServiceName(serviceName: string): string {
   // May only contain lowercase letters, digits, and hyphens. Must begin and end with a letter or digit. Must not exceed 63 characters.
-  return replaceAll(serviceName, '_', '-')
+  return serviceName
+    .replaceAll('_', '-')
     .toLowerCase()
     .replaceAll(/[^0-9a-z-]/gi, '')
     .slice(0, 40)
 }
-
-function replaceAll(str: string, search: string, replacement: string): string {
-  return str.split(search).join(replacement)
-}