@naturalcycles/abba 1.2.0 → 1.3.0

package/src/prisma-output/schema.prisma

@@ -4,8 +4,8 @@ generator client {
 }
 
 datasource db {
-  provider = "postgresql"
-  url      = env("EXPERIMENT_MANAGER_DB_URL")
+  provider = "mysql"
+  url      = env("ABBA_DB_URL")
 }
 
 model Bucket {

package/src/util.ts

@@ -1,5 +1,5 @@
 import { satisfies } from 'semver'
-import { Bucket, Experiment } from './prisma-output'
+import { Bucket } from './prisma-output'
 import { BucketInput, SegmentationData, SegmentationRule } from '.'
 
 /**
@@ -7,7 +7,7 @@ import { BucketInput, SegmentationData, SegmentationRule } from '.'
  *
  * @returns
  */
-export function rollDie(): number {
+export const rollDie = (): number => {
   return Math.random() * 100
 }
 
@@ -18,10 +18,9 @@ export function rollDie(): number {
  * @param buckets
  * @returns
  */
-export function determineAssignment(sampling: number, buckets: Bucket[]): number | null {
+export const determineAssignment = (sampling: number, buckets: Bucket[]): number | null => {
   // Should this person be considered for the experiment?
-  const isIncludedInSample = rollDie() <= sampling
-  if (!isIncludedInSample) {
+  if (rollDie() > sampling) {
     return null
   }
 
@@ -29,23 +28,13 @@ export function determineAssignment(sampling: number, buckets: Bucket[]): number
   return determineBucket(buckets)
 }
 
-/**
- * Determines whether a user will be considered for a bucket assignment based on the experiment sampling rate
- *
- * @param experiment
- * @returns
- */
-export function determineExperiment(experiment: Experiment): boolean {
-  return rollDie() <= experiment.sampling // between 0 and 100
-}
-
 /**
  * Determines which bucket a user assignment will recieve
  *
  * @param buckets
  * @returns
  */
-export function determineBucket(buckets: Bucket[]): number {
+export const determineBucket = (buckets: Bucket[]): number => {
   const bucketRoll = rollDie()
   let range: [number, number] | undefined
   const bucket = buckets.find(b => {
@@ -73,7 +62,7 @@ export function determineBucket(buckets: Bucket[]): number {
  * @param buckets
  * @returns
  */
-export function validateBuckets(buckets: BucketInput[]): void {
+export const validateTotalBucketRatio = (buckets: BucketInput[]): void => {
   const bucketSum = buckets.reduce((sum, current) => sum + current.ratio, 0)
   if (bucketSum !== 100) {
     throw new Error('Total bucket ratio must be 100 before you can activate an experiment')
@@ -87,10 +76,10 @@ export function validateBuckets(buckets: BucketInput[]): void {
  * @param segmentationData
  * @returns
  */
-export function validateSegmentationRules(
+export const validateSegmentationRules = (
   rules: SegmentationRule[],
   segmentationData: SegmentationData,
-): boolean {
+): boolean => {
   for (const rule of rules) {
     if (!validateSegmentationRule(rule, segmentationData)) return false
   }
@@ -104,7 +93,10 @@ export function validateSegmentationRules(
  * @param segmentationData
  * @returns
  */
-export function validateSegmentationRule(rule: SegmentationRule, data: SegmentationData): boolean {
+export const validateSegmentationRule = (
+  rule: SegmentationRule,
+  data: SegmentationData,
+): boolean => {
   const { key, value, operator } = rule
   if (operator === '==') {
     return data[key] === value