@naturalcycles/abba 1.17.0 → 1.17.1

package/dist/abba.js

@@ -110,10 +110,13 @@ class Abba {
      * @param segmentationData Required if existingOnly is false
      */
     async getUserAssignment(experimentKey, userId, existingOnly, segmentationData) {
-        const existingAssignments = await this.getAllExistingUserAssignments(userId);
         const experiment = await this.experimentDao.getOneBy('key', experimentKey);
         (0, js_lib_1._assert)(experiment, `Experiment does not exist: ${experimentKey}`);
+        // Inactive experiments should never return an assignment
+        if (experiment.status === types_1.AssignmentStatus.Inactive)
+            return null;
         const buckets = await this.bucketDao.getBy('experimentId', experiment.id);
+        const existingAssignments = await this.getAllExistingUserAssignments(userId);
         const existing = existingAssignments.find(a => a.experimentId === experiment.id);
         if (existing) {
             return {
@@ -122,7 +125,8 @@ class Abba {
                 bucketKey: buckets.find(b => b.id === existing.bucketId)?.key || null,
             };
         }
-        if (existingOnly)
+        // No existing assignment, but we don't want to generate a new one
+        if (existingOnly || experiment.status === types_1.AssignmentStatus.Paused)
             return null;
         const experiments = await this.getAllExperiments();
         const exclusionSet = (0, util_1.getUserExclusionSet)(experiments, existingAssignments);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@naturalcycles/abba",
-  "version": "1.17.0",
+  "version": "1.17.1",
   "scripts": {
     "prepare": "husky install",
     "build": "build",

package/src/abba.ts

@@ -157,13 +157,14 @@ export class Abba {
     existingOnly: boolean,
     segmentationData?: SegmentationData,
   ): Promise<GeneratedUserAssignment | null> {
-    const existingAssignments = await this.getAllExistingUserAssignments(userId)
-
     const experiment = await this.experimentDao.getOneBy('key', experimentKey)
     _assert(experiment, `Experiment does not exist: ${experimentKey}`)
 
-    const buckets = await this.bucketDao.getBy('experimentId', experiment.id)
+    // Inactive experiments should never return an assignment
+    if (experiment.status === AssignmentStatus.Inactive) return null
 
+    const buckets = await this.bucketDao.getBy('experimentId', experiment.id)
+    const existingAssignments = await this.getAllExistingUserAssignments(userId)
     const existing = existingAssignments.find(a => a.experimentId === experiment.id)
     if (existing) {
       return {
@@ -173,7 +174,8 @@ export class Abba {
       }
     }
 
-    if (existingOnly) return null
+    // No existing assignment, but we don't want to generate a new one
+    if (existingOnly || experiment.status === AssignmentStatus.Paused) return null
 
     const experiments = await this.getAllExperiments()
     const exclusionSet = getUserExclusionSet(experiments, existingAssignments)