@naturalcycles/abba 1.15.0 → 1.15.1

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (5) hide show
  1. package/dist/abba.js +2 -2
  2. package/dist/dao/experiment.dao.js +0 -1
  3. package/package.json +1 -1
  4. package/src/abba.ts +2 -2
  5. package/src/dao/experiment.dao.ts +1 -2
package/dist/abba.js CHANGED
@@ -62,7 +62,7 @@ class Abba {
62
62
  if (experiment.status === types_1.AssignmentStatus.Active) {
63
63
  (0, util_1.validateTotalBucketRatio)(buckets);
64
64
  }
65
- const updatedExperiment = await this.experimentDao.save(experiment);
65
+ const updatedExperiment = await this.experimentDao.save(experiment, { saveMethod: 'update' });
66
66
  const updatedBuckets = await this.bucketDao.saveBatch(buckets.map(b => ({ ...b, experimentId: experiment.id })));
67
67
  await this.updateExclusions(updatedExperiment.id, updatedExperiment.exclusions);
68
68
  return {
@@ -90,7 +90,7 @@ class Abba {
90
90
  requiresUpdating.push(experiment);
91
91
  }
92
92
  });
93
- await this.experimentDao.saveBatch(requiresUpdating);
93
+ await this.experimentDao.saveBatch(requiresUpdating, { saveMethod: 'update' });
94
94
  }
95
95
  /**
96
96
  * Delete an experiment. Removes all user assignments and buckets.
package/dist/dao/experiment.dao.js CHANGED
@@ -11,7 +11,6 @@ const experimentDao = (db) => new ExperimentDao({
11
11
  table: 'Experiment',
12
12
  createId: false,
13
13
  idType: 'number',
14
- assignGeneratedIds: true,
15
14
  hooks: {
16
15
  beforeBMToDBM: bm => ({
17
16
  ...bm,
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@naturalcycles/abba",
3
- "version": "1.15.0",
3
+ "version": "1.15.1",
4
4
  "scripts": {
5
5
  "prepare": "husky install",
6
6
  "build": "build",
package/src/abba.ts CHANGED
@@ -92,7 +92,7 @@ export class Abba {
92
92
  validateTotalBucketRatio(buckets)
93
93
  }
94
94
 
95
- const updatedExperiment = await this.experimentDao.save(experiment)
95
+ const updatedExperiment = await this.experimentDao.save(experiment, { saveMethod: 'update' })
96
96
  const updatedBuckets = await this.bucketDao.saveBatch(
97
97
  buckets.map(b => ({ ...b, experimentId: experiment.id })),
98
98
  )
@@ -132,7 +132,7 @@ export class Abba {
132
132
  }
133
133
  })
134
134
 
135
- await this.experimentDao.saveBatch(requiresUpdating)
135
+ await this.experimentDao.saveBatch(requiresUpdating, { saveMethod: 'update' })
136
136
  }
137
137
 
138
138
  /**
package/src/dao/experiment.dao.ts CHANGED
@@ -13,9 +13,8 @@ export const experimentDao = (db: CommonDB): ExperimentDao =>
13
13
  new ExperimentDao({
14
14
  db,
15
15
  table: 'Experiment',
16
- createId: false, // mysql auto_increment is used instead
16
+ createId: false, // Always provided on create
17
17
  idType: 'number',
18
- assignGeneratedIds: true,
19
18
  hooks: {
20
19
  beforeBMToDBM: bm => ({
21
20
  ...bm,