@naturalcycles/abba 1.11.0 → 1.12.0

package/dist/abba.d.ts

@@ -54,10 +54,10 @@ export declare class Abba {
     getAllExistingUserAssignments(userId: string): Promise<Saved<UserAssignment>[]>;
     /**
      * Generate user assignments for all active experiments.
-     * Will return any existing and attempt to generate any new assignments.
+     * Will return any existing and attempt to generate any new assignments if existingOnly is false.
      * Hot method.
      */
-    generateUserAssignments(userId: string, segmentationData: SegmentationData): Promise<GeneratedUserAssignment[]>;
+    generateUserAssignments(userId: string, segmentationData: SegmentationData, existingOnly?: boolean): Promise<GeneratedUserAssignment[]>;
     /**
      * Get assignment statistics for an experiment.
      * Cold method.

package/dist/abba.js

@@ -133,33 +133,35 @@ class Abba {
     }
     /**
      * Generate user assignments for all active experiments.
-     * Will return any existing and attempt to generate any new assignments.
+     * Will return any existing and attempt to generate any new assignments if existingOnly is false.
      * Hot method.
      */
-    async generateUserAssignments(userId, segmentationData) {
+    async generateUserAssignments(userId, segmentationData, existingOnly = false) {
         const experiments = await this.getActiveExperiments(); // cached
-        const existingAssignments = await this.getAllExistingUserAssignments(userId);
-        const newAssignments = [];
-        for (const experiment of experiments) {
-            const existing = existingAssignments.find(ua => ua.experimentId === experiment.id);
-            if (!existing) {
-                const assignment = this.generateUserAssignmentData(experiment, userId, segmentationData);
-                if (assignment) {
-                    newAssignments.push(assignment);
-                }
-            }
-        }
-        existingAssignments.push(...(await this.userAssignmentDao.saveBatch(newAssignments)));
         const assignments = [];
+        const newAssignments = [];
+        const existingAssignments = await this.getAllExistingUserAssignments(userId);
         for (const experiment of experiments) {
             const existing = existingAssignments.find(ua => ua.experimentId === experiment.id);
             if (existing) {
                 assignments.push({
                     ...existing,
-                    bucketKey: experiment.buckets.find(i => i.id === existing.bucketId)?.key || null,
+                    bucketKey: experiment.buckets.find(b => b.id === existing.bucketId)?.key || null,
                 });
             }
+            else if (!existingOnly) {
+                const assignment = this.generateUserAssignmentData(experiment, userId, segmentationData);
+                if (assignment) {
+                    const created = this.userAssignmentDao.create(assignment);
+                    newAssignments.push(created);
+                    assignments.push({
+                        ...created,
+                        bucketKey: experiment.buckets.find(b => b.id === created.bucketId)?.key || null,
+                    });
+                }
+            }
         }
+        await this.userAssignmentDao.saveBatch(newAssignments);
         return assignments;
     }
     /**

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@naturalcycles/abba",
-  "version": "1.11.0",
+  "version": "1.12.0",
   "scripts": {
     "prepare": "husky install",
     "build": "build",

package/src/abba.ts

@@ -193,39 +193,41 @@ export class Abba {
 
   /**
    * Generate user assignments for all active experiments.
-   * Will return any existing and attempt to generate any new assignments.
+   * Will return any existing and attempt to generate any new assignments if existingOnly is false.
    * Hot method.
    */
   async generateUserAssignments(
     userId: string,
     segmentationData: SegmentationData,
+    existingOnly = false,
   ): Promise<GeneratedUserAssignment[]> {
     const experiments = await this.getActiveExperiments() // cached
-    const existingAssignments = await this.getAllExistingUserAssignments(userId)
 
+    const assignments: GeneratedUserAssignment[] = []
     const newAssignments: UserAssignment[] = []
-    for (const experiment of experiments) {
-      const existing = existingAssignments.find(ua => ua.experimentId === experiment.id)
-      if (!existing) {
-        const assignment = this.generateUserAssignmentData(experiment, userId, segmentationData)
-        if (assignment) {
-          newAssignments.push(assignment)
-        }
-      }
-    }
-
-    existingAssignments.push(...(await this.userAssignmentDao.saveBatch(newAssignments)))
+    const existingAssignments = await this.getAllExistingUserAssignments(userId)
 
-    const assignments: GeneratedUserAssignment[] = []
     for (const experiment of experiments) {
       const existing = existingAssignments.find(ua => ua.experimentId === experiment.id)
       if (existing) {
         assignments.push({
           ...existing,
-          bucketKey: experiment.buckets.find(i => i.id === existing.bucketId)?.key || null,
+          bucketKey: experiment.buckets.find(b => b.id === existing.bucketId)?.key || null,
         })
+      } else if (!existingOnly) {
+        const assignment = this.generateUserAssignmentData(experiment, userId, segmentationData)
+        if (assignment) {
+          const created = this.userAssignmentDao.create(assignment)
+          newAssignments.push(created)
+          assignments.push({
+            ...created,
+            bucketKey: experiment.buckets.find(b => b.id === created.bucketId)?.key || null,
+          })
+        }
       }
     }
+
+    await this.userAssignmentDao.saveBatch(newAssignments)
     return assignments
   }