@natlibfi/marc-record-validators-melinda 9.0.6 → 9.0.7

package/src/punctuation.spec.js

@@ -1,151 +1,52 @@
-/**
- *
- * @licstart  The following is the entire license notice for the JavaScript code in this file.
- *
- * MARC record validators used in Melinda
- *
- * Copyright (c) 2014-2020 University Of Helsinki (The National Library Of Finland)
- *
- * This file is part of marc-record-validators-melinda
- *
- * marc-record-validators-melinda program is free software: you can redistribute it and/or modify
- * it under the terms of the GNU Lesser General Public License as
- * published by the Free Software Foundation, either version 3 of the
- * License, or (at your option) any later version.
- *
- * marc-record-validators-melinda is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public License
- * along with this program.  If not, see <http://www.gnu.org/licenses/>.
- *
- * @licend  The above is the entire license notice
- * for the JavaScript code in this file.
- *
- */
-
-
 import {expect} from 'chai';
 import {MarcRecord} from '@natlibfi/marc-record';
 import validatorFactory from './punctuation/';
-
-describe('punctuation', () => {
-  it('Creates a validator', async () => {
-    const validator = await validatorFactory();
-
-    expect(validator)
-      .to.be.an('object')
-      .that.has.any.keys('description', 'validate');
-
-    expect(validator.description).to.be.a('string');
-    expect(validator.validate).to.be.a('function');
-  });
-
-  describe('#validate', () => {
-    it('Finds the record valid', async () => {
-      const validator = await validatorFactory();
-      const record = new MarcRecord({
-        fields: [
-          {
-            tag: '100',
-            ind2: ' ',
-            subfields: [
-              {code: 'a', value: 'Sukunimi, Etunimi,'},
-              {code: 'c', value: 'kirjoittaja.'}
-            ]
-          }
-        ]
-      });
-      const result = await validator.validate(record);
-
-      expect(result).to.eql({valid: true});
-    });
-
-    it('Finds the record invalid', async () => {
-      const validator = await validatorFactory();
-      const record = new MarcRecord({
-        fields: [
-          {
-            tag: '100',
-            ind2: ' ',
-            subfields: [
-              {code: 'a', value: 'Sukunimi, Etunimi'},
-              {code: 'c', value: 'kirjoittaja.'}
-            ]
-          }
-        ]
-      });
-      const result = await validator.validate(record);
-
-      expect(result).to.eql({valid: false});
-    });
-  });
-
-  describe('#fix', () => {
-    it('Creates punctuation for field 100', async () => {
-      const validator = await validatorFactory();
-      const record = new MarcRecord({
-        fields: [
-          {
-            tag: '100',
-            ind1: ' ',
-            ind2: ' ',
-            subfields: [
-              {code: 'a', value: 'Sukunimi, Etunimi'},
-              {code: 'c', value: 'kirjoittaja'}
-            ]
-          }
-        ]
-      });
-
-      await validator.fix(record);
-
-      expect(record.fields).to.eql([
-        {
-          tag: '100',
-          ind1: ' ',
-          ind2: ' ',
-          subfields: [
-            {code: 'a', value: 'Sukunimi, Etunimi,'},
-            {code: 'c', value: 'kirjoittaja.'}
-          ]
-        }
-      ]);
-    });
-  });
-
-  /*
-  Describe('#fix', () => {
-    it('Creates punctuation for field 264', async () => {
-      const validator = await validatorFactory();
-      const record = new MarcRecord({
-        fields: [
-          {
-            tag: '264',
-            ind1: ' ',
-            ind2: ' ',
-            subfields: [
-              {code: 'b', value: 'Julkaisija'},
-              {code: 'c', value: '2019'}
-            ]
-          }
-        ]
-      });
-      await validator.fix(record);
-      expect(record.fields).to.eql([
-        {
-          tag: '264',
-          ind1: ' ',
-          ind2: ' ',
-          subfields: [
-            {code: 'b', value: 'Julkaisija,'},
-            {code: 'c', value: '2019.'}
-          ]
-        }
-      ]);
-    });
-  });
-  */
+import {READERS} from '@natlibfi/fixura';
+import generateTests from '@natlibfi/fixugen';
+import createDebugLogger from 'debug';
+
+generateTests({
+  callback,
+  path: [__dirname, '..', 'test-fixtures', 'punctuation'],
+  useMetadataFile: true,
+  recurse: false,
+  fixura: {
+    reader: READERS.JSON
+  },
+  mocha: {
+    before: () => testValidatorFactory()
+  }
 });
+const debug = createDebugLogger('@natlibfi/marc-record-validators-melinda/punctuation:test');
+
+async function testValidatorFactory() {
+  const validator = await validatorFactory();
+
+  expect(validator)
+    .to.be.an('object')
+    .that.has.any.keys('description', 'validate');
+
+  expect(validator.description).to.be.a('string');
+  expect(validator.validate).to.be.a('function');
+}
+
+async function callback({getFixture, enabled = true, fix = false}) {
+  if (enabled === false) {
+    debug('TEST SKIPPED!');
+    return;
+  }
+
+  const validator = await validatorFactory();
+  const record = new MarcRecord(getFixture('record.json'));
+  const expectedResult = getFixture('expectedResult.json');
+  // console.log(expectedResult); // eslint-disable-line
+
+  if (!fix) {
+    const result = await validator.validate(record);
+    expect(result).to.eql(expectedResult);
+    return;
+  }
+
+  await validator.fix(record);
+  expect(record).to.eql(expectedResult);
+}

package/src/resolvable-ext-references-melinda.js

@@ -1,31 +1,3 @@
-/**
- *
- * @licstart  The following is the entire license notice for the JavaScript code in this file.
- *
- * MARC record validators used in Melinda
- *
- * Copyright (c) 2014-2020 University Of Helsinki (The National Library Of Finland)
- *
- * This file is part of marc-record-validators-melinda
- *
- * marc-record-validators-melinda program is free software: you can redistribute it and/or modify
- * it under the terms of the GNU Lesser General Public License as
- * published by the Free Software Foundation, either version 3 of the
- * License, or (at your option) any later version.
- *
- * marc-record-validators-melinda is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public License
- * along with this program.  If not, see <http://www.gnu.org/licenses/>.
- *
- * @licend  The above is the entire license notice
- * for the JavaScript code in this file.
- *
- */
-
 import {parseString} from 'xml2js';
 import fetch from 'node-fetch';
 

package/src/resolvable-ext-references-melinda.spec.js

@@ -1,32 +1,3 @@
-/**
- *
- * @licstart  The following is the entire license notice for the JavaScript code in this file.
- *
- * MARC record validators used in Melinda
- *
- * Copyright (c) 2014-2020 University Of Helsinki (The National Library Of Finland)
- *
- * This file is part of marc-record-validators-melinda
- *
- * marc-record-validators-melinda program is free software: you can redistribute it and/or modify
- * it under the terms of the GNU Lesser General Public License as
- * published by the Free Software Foundation, either version 3 of the
- * License, or (at your option) any later version.
- *
- * marc-record-validators-melinda is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public License
- * along with this program.  If not, see <http://www.gnu.org/licenses/>.
- *
- * @licend  The above is the entire license notice
- * for the JavaScript code in this file.
- *
- */
-
-
 import chai from 'chai';
 import chaiAsPromised from 'chai-as-promised';
 import {MarcRecord} from '@natlibfi/marc-record';
@@ -63,7 +34,8 @@ describe('resolvable-ext-references-melinda', () => {
 
   it('Throws an error when prefixPattern not provided', async () => {
     const validator = await testContext.default({endpoint, prefixPattern, fields});
-    await expect(validator.validate()).to.be.rejectedWith(Error, 'Cannot read property \'fields\' of undefined');
+    // Cannot read property 'fields' of undefined or Cannot read properties of undefined (reading 'fields')'
+    await expect(validator.validate()).to.be.rejectedWith(Error, /^Cannot read propert/u);
   });
 
   describe('#validate', () => {

package/src/sort-tags.js

@@ -1,32 +1,3 @@
-/**
- *
- * @licstart  The following is the entire license notice for the JavaScript code in this file.
- *
- * MARC record validators used in Melinda
- *
- * Copyright (c) 2014-2020 University Of Helsinki (The National Library Of Finland)
- *
- * This file is part of marc-record-validators-melinda
- *
- * marc-record-validators-melinda program is free software: you can redistribute it and/or modify
- * it under the terms of the GNU Lesser General Public License as
- * published by the Free Software Foundation, either version 3 of the
- * License, or (at your option) any later version.
- *
- * marc-record-validators-melinda is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public License
- * along with this program.  If not, see <http://www.gnu.org/licenses/>.
- *
- * @licend  The above is the entire license notice
- * for the JavaScript code in this file.
- *
- */
-
-
 import {MarcRecord} from '@natlibfi/marc-record';
 
 export default function (tagPattern) {

package/src/sort-tags.spec.js

@@ -1,32 +1,3 @@
-/**
- *
- * @licstart  The following is the entire license notice for the JavaScript code in this file.
- *
- * MARC record validators used in Melinda
- *
- * Copyright (c) 2014-2020 University Of Helsinki (The National Library Of Finland)
- *
- * This file is part of marc-record-validators-melinda
- *
- * marc-record-validators-melinda program is free software: you can redistribute it and/or modify
- * it under the terms of the GNU Lesser General Public License as
- * published by the Free Software Foundation, either version 3 of the
- * License, or (at your option) any later version.
- *
- * marc-record-validators-melinda is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public License
- * along with this program.  If not, see <http://www.gnu.org/licenses/>.
- *
- * @licend  The above is the entire license notice
- * for the JavaScript code in this file.
- *
- */
-
-
 import {expect} from 'chai';
 import {MarcRecord} from '@natlibfi/marc-record';
 import validatorFactory from '../src/sort-tags';

package/src/subfield-exclusion.js

@@ -1,32 +1,3 @@
-/**
- *
- * @licstart  The following is the entire license notice for the JavaScript code in this file.
- *
- * MARC record validators used in Melinda
- *
- * Copyright (c) 2014-2022 University Of Helsinki (The National Library Of Finland)
- *
- * This file is part of marc-record-validators-melinda
- *
- * marc-record-validators-melinda program is free software: you can redistribute it and/or modify
- * it under the terms of the GNU Lesser General Public License as
- * published by the Free Software Foundation, either version 3 of the
- * License, or (at your option) any later version.
- *
- * marc-record-validators-melinda is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public License
- * along with this program.  If not, see <http://www.gnu.org/licenses/>.
- *
- * @licend  The above is the entire license notice
- * for the JavaScript code in this file.
- *
- */
-
-
 // Tag (RegExp): Pattern to match the field's tags Mandatory
 // ind1 (RegExp): Pattern to match the field's ind1 property
 // ind2 (RegExp): Pattern to match the field's ind2 property

package/src/subfield-exclusion.spec.js

@@ -1,32 +1,3 @@
-/**
- *
- * @licstart  The following is the entire license notice for the JavaScript code in this file.
- *
- * MARC record validators used in Melinda
- *
- * Copyright (c) 2014-2022 University Of Helsinki (The National Library Of Finland)
- *
- * This file is part of marc-record-validators-melinda
- *
- * marc-record-validators-melinda program is free software: you can redistribute it and/or modify
- * it under the terms of the GNU Lesser General Public License as
- * published by the Free Software Foundation, either version 3 of the
- * License, or (at your option) any later version.
- *
- * marc-record-validators-melinda is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public License
- * along with this program.  If not, see <http://www.gnu.org/licenses/>.
- *
- * @licend  The above is the entire license notice
- * for the JavaScript code in this file.
- *
- */
-
-
 import {expect} from 'chai';
 //import chaiAsPromised from 'chai-as-promised';
 import {MarcRecord} from '@natlibfi/marc-record';

package/src/unicode-decomposition.js

@@ -1,31 +1,3 @@
-/**
- *
- * @licstart  The following is the entire license notice for the JavaScript code in this file.
- *
- * Melinda-related validators for @natlibfi/marc-record-validate
- *
- * Copyright (c) 2014-2017 University Of Helsinki (The National Library Of Finland)
- *
- * This file is part of marc-record-validators-melinda
- *
- * marc-record-validators-melinda is free software: you can redistribute it and/or modify
- * it under the terms of the GNU Lesser General Public License as
- * published by the Free Software Foundation, either version 3 of the
- * License, or (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public License
- * along with this program.  If not, see <http://www.gnu.org/licenses/>.
- *
- * @licend  The above is the entire license notice
- * for the JavaScript code in this file.
- *
- **/
-
 const MAP_CONVERSION = {
 
   /**

package/src/unicode-decomposition.spec.js

@@ -1,32 +1,3 @@
-/**
- *
- * @licstart  The following is the entire license notice for the JavaScript code in this file.
- *
- * MARC record validators used in Melinda
- *
- * Copyright (c) 2014-2020 University Of Helsinki (The National Library Of Finland)
- *
- * This file is part of marc-record-validators-melinda
- *
- * marc-record-validators-melinda program is free software: you can redistribute it and/or modify
- * it under the terms of the GNU Lesser General Public License as
- * published by the Free Software Foundation, either version 3 of the
- * License, or (at your option) any later version.
- *
- * marc-record-validators-melinda is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public License
- * along with this program.  If not, see <http://www.gnu.org/licenses/>.
- *
- * @licend  The above is the entire license notice
- * for the JavaScript code in this file.
- *
- */
-
-
 import chai from 'chai';
 import chaiAsPromised from 'chai-as-promised';
 import {MarcRecord} from '@natlibfi/marc-record';

package/src/urn.js

@@ -1,32 +1,3 @@
-/**
- *
- * @licstart  The following is the entire license notice for the JavaScript code in this file.
- *
- * MARC record validators used in Melinda
- *
- * Copyright (c) 2014-2020 University Of Helsinki (The National Library Of Finland)
- *
- * This file is part of marc-record-validators-melinda
- *
- * marc-record-validators-melinda program is free software: you can redistribute it and/or modify
- * it under the terms of the GNU Lesser General Public License as
- * published by the Free Software Foundation, either version 3 of the
- * License, or (at your option) any later version.
- *
- * marc-record-validators-melinda is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public License
- * along with this program.  If not, see <http://www.gnu.org/licenses/>.
- *
- * @licend  The above is the entire license notice
- * for the JavaScript code in this file.
- *
- */
-
-
 import fetch from 'node-fetch';
 
 const URN_GENERATOR_URL = 'http://generator.urn.fi/cgi-bin/urn_generator.cgi?type=nbn';

package/src/urn.spec.js

@@ -1,32 +1,3 @@
-/**
- *
- * @licstart  The following is the entire license notice for the JavaScript code in this file.
- *
- * MARC record validators used in Melinda
- *
- * Copyright (c) 2014-2020 University Of Helsinki (The National Library Of Finland)
- *
- * This file is part of marc-record-validators-melinda
- *
- * marc-record-validators-melinda program is free software: you can redistribute it and/or modify
- * it under the terms of the GNU Lesser General Public License as
- * published by the Free Software Foundation, either version 3 of the
- * License, or (at your option) any later version.
- *
- * marc-record-validators-melinda is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public License
- * along with this program.  If not, see <http://www.gnu.org/licenses/>.
- *
- * @licend  The above is the entire license notice
- * for the JavaScript code in this file.
- *
- */
-
-
 import {expect} from 'chai';
 import {MarcRecord} from '@natlibfi/marc-record';
 import validatorFactory from '../src/urn';

package/test-fixtures/punctuation/01/expectedResult.json

@@ -0,0 +1,3 @@
+{
+  "valid": true
+}

package/test-fixtures/punctuation/01/metadata.json

@@ -0,0 +1,4 @@
+{
+  "description": "Validate - Finds the record valid",
+  "enabled": true
+}

package/test-fixtures/punctuation/01/record.json

@@ -0,0 +1,18 @@
+{
+  "fields": [
+    {
+      "tag": "100",
+      "ind2": " ",
+      "subfields": [
+        {
+          "code": "a",
+          "value": "Sukunimi, Etunimi,"
+        },
+        {
+          "code": "c",
+          "value": "kirjoittaja."
+        }
+      ]
+    }
+  ]
+}

package/test-fixtures/punctuation/02/expectedResult.json

@@ -0,0 +1,3 @@
+{
+  "valid": false
+}

package/test-fixtures/punctuation/02/metadata.json

@@ -0,0 +1,4 @@
+{
+  "description": "Validate - Finds the record invalid",
+  "enabled": true
+}

package/test-fixtures/punctuation/02/record.json

@@ -0,0 +1,18 @@
+{
+  "fields": [
+    {
+      "tag": "100",
+      "ind2": " ",
+      "subfields": [
+        {
+          "code": "a",
+          "value": "Sukunimi, Etunimi"
+        },
+        {
+          "code": "c",
+          "value": "kirjoittaja."
+        }
+      ]
+    }
+  ]
+}

package/test-fixtures/punctuation/03/expectedResult.json

@@ -0,0 +1,21 @@
+{
+  "_validationOptions": {},
+  "leader": "",
+  "fields": [
+    {
+      "tag": "100",
+      "ind1": " ",
+      "ind2": " ",
+      "subfields": [
+        {
+          "code": "a",
+          "value": "Sukunimi, Etunimi,"
+        },
+        {
+          "code": "c",
+          "value": "kirjoittaja."
+        }
+      ]
+    }
+  ]
+}

package/test-fixtures/punctuation/03/metadata.json

@@ -0,0 +1,5 @@
+{
+  "description": "Fix - Creates punctuation for field 100",
+  "enabled": true,
+  "fix": true
+}

package/test-fixtures/punctuation/03/record.json

@@ -0,0 +1,19 @@
+{
+  "fields": [
+    {
+      "tag": "100",
+      "ind1": " ",
+      "ind2": " ",
+      "subfields": [
+        {
+          "code": "a",
+          "value": "Sukunimi, Etunimi"
+        },
+        {
+          "code": "c",
+          "value": "kirjoittaja"
+        }
+      ]
+    }
+  ]
+}

package/test-fixtures/punctuation/04/expectedResult.json

@@ -0,0 +1,21 @@
+{
+  "_validationOptions": {},
+  "leader": "",
+  "fields": [
+    {
+      "tag": "264",
+      "ind1": " ",
+      "ind2": " ",
+      "subfields": [
+        {
+          "code": "b",
+          "value": "Julkaisija,"
+        },
+        {
+          "code": "c",
+          "value": "2019."
+        }
+      ]
+    }
+  ]
+}

package/test-fixtures/punctuation/04/metadata.json

@@ -0,0 +1,5 @@
+{
+  "description": "Fix - Creates punctuation for field 264$bc",
+  "enabled": true,
+  "fix": true
+}