@natlibfi/marc-record-validators-melinda 11.6.6 → 11.6.7-alpha.1

package/src/normalizeFieldForComparison.js

@@ -28,10 +28,10 @@ export function isEnnakkotietoSubfieldG(subfield) {
 function debugFieldComparison(oldField, newField) { // NB: Debug-only function!
   /*
   // We may drop certain subfields:
-  if (oldField.subfields.length === newField.subfields.length) { // eslint-disable-line functional/no-conditional-statements
+  if (oldField.subfields.length === newField.subfields.length) {
     oldField.subfields.forEach((subfield, index) => {
       const newValue = newField.subfields[index].value;
-      if (subfield.value !== newValue) { // eslint-disable-line functional/no-conditional-statements
+      if (subfield.value !== newValue) {
         nvdebug(`NORMALIZE SUBFIELD: '${subfield.value}' => '${newValue}'`, debugDev);
       }
     });
@@ -116,7 +116,7 @@ function subfieldValueLowercase(value, subfieldCode, tag) {
 }
 
 function subfieldLowercase(sf, tag) {
-  sf.value = subfieldValueLowercase(sf.value, sf.code, tag); // eslint-disable-line functional/immutable-data
+  sf.value = subfieldValueLowercase(sf.value, sf.code, tag);
 }
 
 function fieldLowercase(field) {
@@ -124,7 +124,7 @@ function fieldLowercase(field) {
     return;
   }
 
-  field.subfields.forEach(sf => subfieldLowercase(sf, field.tag));
+  field.subfields.forEach(sf => subfieldLowercase(sf, field.tag)); // eslint-disable-line array-callback-return
 
   function skipFieldLowercase(field) {
     if (skipAllFieldNormalizations(field.tag)) {
@@ -144,7 +144,7 @@ function hack490SubfieldA(field) {
   if (field.tag !== '490') {
     return;
   }
-  field.subfields.forEach(sf => removeSarja(sf));
+  field.subfields.forEach(sf => removeSarja(sf)); // eslint-disable-line array-callback-return
 
   // NB! This won't work, if the punctuation has not been stripped beforehand!
   function removeSarja(subfield) {
@@ -153,7 +153,7 @@ function hack490SubfieldA(field) {
     }
     const tmp = subfield.value.replace(/ ?-(?:[a-z]|ä|ö)*sarja$/u, '');
     if (tmp.length > 0) {
-      subfield.value = tmp; // eslint-disable-line functional/immutable-data
+      subfield.value = tmp;
       return;
     }
   }
@@ -185,12 +185,12 @@ function normalizeISBN(field) {
 
   //nvdebug(`ISBN-field? ${fieldToString(field)}`);
   const relevantSubfields = field.subfields.filter(sf => tagAndSubfieldCodeReferToIsbn(field.tag, sf.code) && looksLikeIsbn(sf.value));
-  relevantSubfields.forEach(sf => normalizeIsbnSubfield(sf));
+  relevantSubfields.forEach(sf => normalizeIsbnSubfield(sf)); // eslint-disable-line array-callback-return
 
   function normalizeIsbnSubfield(sf) {
     //nvdebug(` ISBN-subfield? ${subfieldToString(sf)}`);
-    sf.value = sf.value.replace(/-/ug, ''); // eslint-disable-line functional/immutable-data
-    sf.value = sf.value.replace(/x/u, 'X'); // eslint-disable-line functional/immutable-data
+    sf.value = sf.value.replace(/-/ug, '');
+    sf.value = sf.value.replace(/x/u, 'X');
   }
 
 }
@@ -202,9 +202,9 @@ function fieldSpecificHacks(field) {
 
 export function fieldTrimSubfieldValues(field) {
   field.subfields?.forEach((sf) => {
-    sf.value = sf.value.replace(/^[ \t\n]+/u, ''); // eslint-disable-line functional/immutable-data
-    sf.value = sf.value.replace(/[ \t\n]+$/u, ''); // eslint-disable-line functional/immutable-data
-    sf.value = sf.value.replace(/[ \t\n]+/gu, ' '); // eslint-disable-line functional/immutable-data
+    sf.value = sf.value.replace(/^[ \t\n]+/u, '');
+    sf.value = sf.value.replace(/[ \t\n]+$/u, '');
+    sf.value = sf.value.replace(/[ \t\n]+/gu, ' ');
   });
 }
 
@@ -212,7 +212,7 @@ function fieldRemoveDecomposedDiacritics(field) {
   // Raison d'être/motivation: "Sirén" and diacriticless "Siren" might refer to a same surname, so this normalization
   // allows us to compare authors and avoid duplicate fields.
   field.subfields.forEach((sf) => {
-    sf.value = removeDecomposedDiacritics(sf.value); // eslint-disable-line functional/immutable-data
+    sf.value = removeDecomposedDiacritics(sf.value);
   });
 }
 
@@ -230,7 +230,7 @@ function normalizeSubfieldValue(value, subfieldCode, tag) {
 
   // Normalize: s. = sivut = pp.
   value = normalizePartData(value, subfieldCode, tag);
-  value = value.replace(/^\[([^[\]]+)\]/gu, '$1'); // eslint-disable-line functional/immutable-data, prefer-named-capture-group
+  value = value.replace(/^\[([^[\]]+)\]/gu, '$1'); // eslint-disable-line functional/immutable-data
 
   if (['130', '730'].includes(tag) && subfieldCode === 'a') {
     value = value.replace(' : ', ', '); // "Halloween ends (elokuva, 2022)" vs "Halloween ends (elokuva : 2023)"
@@ -268,7 +268,7 @@ function removeCharsThatDontCarryMeaning(value, tag, subfieldCode) {
   if (tag === '080') {
     return value;
   }
-  /* eslint-disable */
+
   // 3" refers to inches, but as this is for comparison only we don't mind...
   value = value.replace(/['‘’"„“”«»]/gu, ''); // MET-570 et al. Subset of https://hexdocs.pm/ex_unicode/Unicode.Category.QuoteMarks.html
   // MRA-273: Handle X00$a name initials.
@@ -277,12 +277,12 @@ function removeCharsThatDontCarryMeaning(value, tag, subfieldCode) {
   if (subfieldCode === 'a' && ['100', '400', '600', '700', '800'].includes(tag)) { // 400 is used in auth records. It's not a bib field at all.
     value = value.replace(/([A-Z]|Å|Ä|Ö)\. +/ugi, '$1.');
   }
-  /* eslint-enable */
+
   return value;
 }
 
 function normalizeField(field) {
-  //sf.value = removeDecomposedDiacritics(sf.value); // eslint-disable-line functional/immutable-data
+  //sf.value = removeDecomposedDiacritics(sf.value);
   fieldStripPunctuation(field);
   fieldLowercase(field);
   fieldNormalizeControlNumbers(field); // FIN11 vs FI-MELINDA etc.
@@ -297,11 +297,11 @@ export function cloneAndNormalizeFieldForComparison(field) {
     return clonedField;
   }
   clonedField.subfields.forEach((sf) => { // Do this for all fields or some fields?
-    sf.value = normalizeSubfieldValue(sf.value, sf.code, field.tag); // eslint-disable-line functional/immutable-data
-    sf.value = removeCharsThatDontCarryMeaning(sf.value, field.tag, sf.code);// eslint-disable-line functional/immutable-data
+    sf.value = normalizeSubfieldValue(sf.value, sf.code, field.tag);
+    sf.value = removeCharsThatDontCarryMeaning(sf.value, field.tag, sf.code);
   });
 
-  normalizeField(clonedField); // eslint-disable-line functional/immutable-data
+  normalizeField(clonedField);
   fieldRemoveDecomposedDiacritics(clonedField);
   fieldSpecificHacks(clonedField);
   fieldTrimSubfieldValues(clonedField);

package/src/normalizeSubfieldValueForComparison.js

@@ -21,7 +21,7 @@ export function subfieldContainsPartData(tag, subfieldCode) {
 function splitPartData(originalValue) {
   // This a very hacky function, but cand really help it, as the the data is very iffy as well...
   // Remove punctuation and brackets:
-  const value = originalValue.replace(/[-.,:; ]+$/ui, '').replace(/^\[([0-9]+)\]$/ui, '$1'); // eslint-disable-line prefer-named-capture-group
+  const value = originalValue.replace(/[-.,:; ]+$/ui, '').replace(/^\[([0-9]+)\]$/ui, '$1');
 
   const [year, rest] = extractYear(value);
 

package/src/prepublicationUtils.js

@@ -178,7 +178,7 @@ export function deleteAllPrepublicationNotesFromField500InNonPubRecord(record) {
 
 
   nvdebug(`Delete all ${f500.length} instance(s) of field 500`, debugDev);
-  f500.forEach(field => record.removeField(field));
+  f500.forEach(field => record.removeField(field)); // eslint-disable-line array-callback-return
 }
 
 
@@ -188,7 +188,7 @@ export function removeWorsePrepubField500s(record) {
   nvdebugFieldArray(fields, '  Candidates for non-best 500 b4 filtering: ', debugDev);
   const nonBest = fields.filter(field => fields.some(field2 => firstFieldHasBetterPrepubEncodingLevel(field2, field)));
   nvdebugFieldArray(nonBest, '  Remove non-best 500: ', debugDev);
-  nonBest.forEach(field => record.removeField(field));
+  nonBest.forEach(field => record.removeField(field)); // eslint-disable-line array-callback-return
 }
 
 
@@ -198,7 +198,7 @@ export function removeWorsePrepubField594s(record) {
   nvdebugFieldArray(fields594, '  Candidates for non-best 594 b4 filtering: ', debugDev);
   const nonBest = fields594.filter(field => fields594.some(field2 => firstFieldHasBetterPrepubEncodingLevel(field2, field)));
   nvdebugFieldArray(nonBest, '  Remove non-best 594: ', debugDev);
-  nonBest.forEach(field => record.removeField(field));
+  nonBest.forEach(field => record.removeField(field)); // eslint-disable-line array-callback-return
 }
 
 

package/src/punctuation/index.js

@@ -75,16 +75,16 @@ export default function () {
       return;
     }
 
-    let currentPortion; // eslint-disable-line functional/no-let
-    let preceedingField; // eslint-disable-line functional/no-let
-    let inNamePortion = true; // eslint-disable-line functional/no-let
+    let currentPortion;
+    let preceedingField;
+    let inNamePortion = true;
 
     debug(`Field subfields: ${field.subfields.map(sub => sub.code)}`);
     debug(`Field portions: ${field.subfields.map(sub => getPortion(sub, rulesForField))}`);
 
     field.subfields.forEach(subfield => {
       debug(`Handling subfield ${subfield.code}`);
-      let portion = getPortion(subfield, rulesForField); // eslint-disable-line functional/no-let
+      let portion = getPortion(subfield, rulesForField);
 
       if (portion === false) {
         return;
@@ -94,28 +94,28 @@ export default function () {
         return;
       }
 
-      if (inNamePortion && portion.includes('T', 'S')) { // eslint-disable-line functional/no-conditional-statements
+      if (inNamePortion && portion.includes('T', 'S')) {
         debug(`Portion changed to ${portion}. Not in name portion anymore`);
         inNamePortion = false;
       }
 
-      if (inNamePortion && portion === 'NT') { // eslint-disable-line functional/no-conditional-statements
+      if (inNamePortion && portion === 'NT') {
         portion = 'N';
       }
 
-      if (!inNamePortion && portion === 'NT') { // eslint-disable-line functional/no-conditional-statements
+      if (!inNamePortion && portion === 'NT') {
         portion = 'T';
       }
 
       debug(`Current portion is ${portion}.`);
 
       if (currentPortion) {
-        if (currentPortion === portion) { // eslint-disable-line functional/no-conditional-statements
+        if (currentPortion === portion) {
           debug(`Current stayed as ${portion}. Adding punctuation for subfield.`);
           addSubfieldPunctuation(preceedingField, subfield, rulesForField);
         } else {
           debug(`Current portion changed to ${portion}.`);
-          if (portion !== 'S') { // eslint-disable-line functional/no-conditional-statements
+          if (portion !== 'S') {
             debug('Adding punctuation for portion.');
             addNamePortionPunctuation(preceedingField);
           }
@@ -126,7 +126,7 @@ export default function () {
       preceedingField = subfield;
     });
 
-    if (recordType !== 'z') { // eslint-disable-line functional/no-conditional-statements
+    if (recordType !== 'z') {
       addNamePortionPunctuation(preceedingField);
     }
 
@@ -152,10 +152,10 @@ export default function () {
 
   function addNamePortionPunctuation(preceedingSubfield) {
     const subfieldContainsPunctuation = (/[?")\].\-!,]$/u).test(preceedingSubfield.value);
-    if (!subfieldContainsPunctuation) { // eslint-disable-line functional/no-conditional-statements
+    if (!subfieldContainsPunctuation) {
       const nextValue = `${preceedingSubfield.value}.`;
       debug(`Updated subfield ${preceedingSubfield.code} from '${preceedingSubfield.value}' to '${nextValue}'`);
-      preceedingSubfield.value = nextValue; // eslint-disable-line functional/immutable-data
+      preceedingSubfield.value = nextValue;
     }
   }
 
@@ -173,41 +173,41 @@ export default function () {
     debug(`addSubfieldPunctuation -- punctType: ${punctType} endsInPunctuation: ${endsInPunctuation}`);
 
     if (!endsInPunctuation) {
-      if (punctType === 'PERIOD' && !(/\.$/u).test(preceedingSubfield.value)) { // eslint-disable-line functional/no-conditional-statements
+      if (punctType === 'PERIOD' && !(/\.$/u).test(preceedingSubfield.value)) {
         const nextValue = `${preceedingSubfield.value}.`;
         debug(`Updated subfield ${preceedingSubfield.code} from '${preceedingSubfield.value}' to '${nextValue}'`);
-        preceedingSubfield.value = nextValue; // eslint-disable-line functional/immutable-data
+        preceedingSubfield.value = nextValue;
       }
     }
 
     if (punctType === 'COMMA') {
       if (!(/,$/u).test(preceedingSubfield.value)) {
-        if (!(/^[[(]/u).test(currentSubfield.value)) { // eslint-disable-line functional/no-conditional-statements
+        if (!(/^[[(]/u).test(currentSubfield.value)) {
           const nextValue = `${preceedingSubfield.value},`;
           debug(`Updated subfield ${preceedingSubfield.code} from '${preceedingSubfield.value}' to '${nextValue}'`);
-          preceedingSubfield.value = nextValue; // eslint-disable-line functional/immutable-data
+          preceedingSubfield.value = nextValue;
         }
       }
     }
 
     if (punctType === 'COND_COMMA') {
-      if (!(/[-,]$/u).test(preceedingSubfield.value)) { // eslint-disable-line functional/no-conditional-statements
+      if (!(/[-,]$/u).test(preceedingSubfield.value)) {
         const nextValue = `${preceedingSubfield.value},`;
         debug(`Updated subfield ${preceedingSubfield.code} from '${preceedingSubfield.value}' to '${nextValue}'`);
-        preceedingSubfield.value = nextValue; // eslint-disable-line functional/immutable-data
+        preceedingSubfield.value = nextValue;
       }
     }
 
     if (punctType === 'SPACECOLON') {
-      if (!(/:$/u).test(preceedingSubfield.value)) { // eslint-disable-line functional/no-conditional-statements
+      if (!(/:$/u).test(preceedingSubfield.value)) {
         const nextValue = `${preceedingSubfield.value} :`;
         debug(`Updated subfield ${preceedingSubfield.code} from '${preceedingSubfield.value}' to '${nextValue}'`);
-        preceedingSubfield.value = nextValue; // eslint-disable-line functional/immutable-data
+        preceedingSubfield.value = nextValue;
       }
-      if ((/[^ ]:$/u).test(preceedingSubfield.value)) { // eslint-disable-line functional/no-conditional-statements
+      if ((/[^ ]:$/u).test(preceedingSubfield.value)) {
         const nextValue = `${preceedingSubfield.value.slice(0, -1)} :`;
         debug(`Updated subfield ${preceedingSubfield.code} from '${preceedingSubfield.value}' to '${nextValue}'`);
-        preceedingSubfield.value = nextValue; // eslint-disable-line functional/immutable-data
+        preceedingSubfield.value = nextValue;
       }
 
     }
@@ -240,12 +240,12 @@ export default function () {
     const exceptionFuncs = [];
 
     exceptionRules.forEach(exceptionRule => {
-      const match = (/- (.*) if preceded by (.*)/u).exec(exceptionRule); // eslint-disable-line prefer-named-capture-group
-      if (match) { // eslint-disable-line functional/no-conditional-statements
+      const match = (/- (.*) if preceded by (.*)/u).exec(exceptionRule);
+      if (match) {
         const [, type, preceededCode] = match;
         const normalizedType = type.trim().toUpperCase().trim();
         const normalizedCode = preceededCode.replace(/\$/ug, '').trim();
-        exceptionFuncs.push(ifPrecededByException(normalizedCode, normalizedType)); // eslint-disable-line functional/immutable-data
+        exceptionFuncs.push(ifPrecededByException(normalizedCode, normalizedType));
       }
     });
 
@@ -256,16 +256,16 @@ export default function () {
     return preceedingSubfield => {
       if (code === preceedingSubfield.code) {
         debug(`Adding ${type} to ${preceedingSubfield.code}`);
-        if (type === 'SEMICOLON' && !(/;$/u).test(preceedingSubfield.value)) { // eslint-disable-line functional/no-conditional-statements
+        if (type === 'SEMICOLON' && !(/;$/u).test(preceedingSubfield.value)) {
           const nextValue = `${preceedingSubfield.value} ;`;
           debug(`Updated subfield ${preceedingSubfield.code} from '${preceedingSubfield.value}' to '${nextValue}'`);
-          preceedingSubfield.value = nextValue; // eslint-disable-line functional/immutable-data
+          preceedingSubfield.value = nextValue;
         }
 
-        if (type === 'COLON' && !(/:$/u).test(preceedingSubfield.value)) { // eslint-disable-line functional/no-conditional-statements
+        if (type === 'COLON' && !(/:$/u).test(preceedingSubfield.value)) {
           const nextValue = `${preceedingSubfield.value} :`;
           debug(`Updated subfield ${preceedingSubfield.code} from '${preceedingSubfield.value}' to '${nextValue}'`);
-          preceedingSubfield.value = nextValue; // eslint-disable-line functional/immutable-data
+          preceedingSubfield.value = nextValue;
         }
 
         return true;

package/src/punctuation2.js

@@ -27,7 +27,7 @@ export default function () {
   function fix(record) {
     nvdebug(`${descriptionString}: fixer`);
     const res = {message: [], fix: [], valid: true};
-    record.fields.forEach(f => fieldFixPunctuation(f));
+    record.fields.forEach(f => fieldFixPunctuation(f)); // eslint-disable-line array-callback-return
     return res;
   }
 
@@ -44,7 +44,7 @@ export default function () {
 
     const res = {message: messages};
 
-    res.valid = res.message.length < 1; // eslint-disable-line functional/immutable-data
+    res.valid = res.message.length < 1;
     return res;
   }
 }
@@ -390,13 +390,13 @@ function debugRule(rule) {
   //nvdebug('');
   nvdebug(`NAME ${rule.name ? rule.name : '<unnamed>'}`);
   nvdebug(`SUBFIELD CODE '${rule.code}' FOLLOWED BY SUBFIELD CODE '${rule.followedBy}'`);
-  if ('add' in rule) { // eslint-disable-line functional/no-conditional-statements
+  if ('add' in rule) {
     nvdebug(`ADD '${rule.add}'`);
   }
-  if ('remove' in rule) { // eslint-disable-line functional/no-conditional-statements
+  if ('remove' in rule) {
     nvdebug(`REMOVE '${rule.remove}'`);
   }
-  if ('context' in rule) { // eslint-disable-line functional/no-conditional-statements
+  if ('context' in rule) {
     nvdebug(`CONTEXT '${rule.context.toString()}'`);
   }
   //nvdebug('');
@@ -517,19 +517,19 @@ function applyPunctuationRules(field, subfield1, subfield2, ruleArray = null, op
     //const originalValue = subfield1.value;
     if (rule.remove && [REMOVE, REMOVE_AND_ADD].includes(operation) && subfield1.value.match(rule.remove)) {
       //nvdebug(`    PUNC REMOVAL TO BE PERFORMED FOR $${subfield1.code} '${subfield1.value}'`, debug);
-      subfield1.value = subfield1.value.replace(rule.remove, ''); // eslint-disable-line functional/immutable-data
+      subfield1.value = subfield1.value.replace(rule.remove, '');
       //nvdebug(`    PUNC REMOVAL PERFORMED FOR '${subfield1.value}'`);
       return false;
     }
     if (rule.add && [ADD, REMOVE_AND_ADD].includes(operation)) {
-      subfield1.value += rule.add; // eslint-disable-line functional/immutable-data
+      subfield1.value += rule.add;
       //nvdebug(`    ADDED '${rule.add}' TO FORM '${subfield1.value}' USING RULE ${rule.name}`);
       return false;
     }
 
     /*
-    if (subfield1.value !== originalValue) { // eslint-disable-line functional/no-conditional-statements
-      nvdebug(` PROCESS PUNC: '‡${subfield1.code} ${originalValue}' => '‡${subfield1.code} ${subfield1.value}'`, debug); // eslint-disable-line functional/immutable-data
+    if (subfield1.value !== originalValue) {
+      nvdebug(` PROCESS PUNC: '‡${subfield1.code} ${originalValue}' => '‡${subfield1.code} ${subfield1.value}'`, debug);
     }
     */
 
@@ -579,7 +579,7 @@ export function fieldFixPunctuation(field) {
   });
 
   // Use shared code for final punctuation (sadly this does not fix intermediate punc):
-  if (field.useExternalEndPunctuation) { // eslint-disable-line functional/no-conditional-statements
+  if (field.useExternalEndPunctuation) {
     // addFinalPunctuation(field); // local version. use shared code instead.
     validateSingleField(field, false, true); // NB! Don't use field.tag as second argument! It's a string, not an int. 3rd arg must be true (=fix)
   }

package/src/reindexSubfield6OccurenceNumbers.js

@@ -22,14 +22,14 @@ export default function () {
   function fix(record) {
     nvdebug('Fix SF6 occurrence numbers', debug);
     const res = {message: [], fix: [], valid: true};
-    //message.fix = []; // eslint-disable-line functional/immutable-data
+    //message.fix = [];
 
     // This can not really fail...
 
     recordDisambiguateSharedSubfield6OccurrenceNumbers(record);
     recordResetSubfield6OccurrenceNumbers(record);
 
-    // message.valid = !(message.message.length >= 1); // eslint-disable-line functional/immutable-data
+    // message.valid = !(message.message.length >= 1);
     return res;
   }
 
@@ -37,8 +37,8 @@ export default function () {
     const res = {message: []};
 
     nvdebug('Validate SF6 occurrence number multiuses', debug);
-    if (recordGetSharedOccurrenceNumbers(record).length) { // eslint-disable-line functional/no-conditional-statements
-      res.message.push(`Multi-use of occurrence number(s) detected`); // eslint-disable-line functional/immutable-data
+    if (recordGetSharedOccurrenceNumbers(record).length) {
+      res.message.push(`Multi-use of occurrence number(s) detected`);
     }
 
     // Check max, and check number of different indexes
@@ -47,10 +47,10 @@ export default function () {
     const size = recordGetNumberOfUniqueSubfield6OccurrenceNumbers(record);
 
 
-    if (max !== size) { // eslint-disable-line functional/no-conditional-statements
-      res.message.push(`Gaps detected in occurrence numbers: found ${size}, seen max ${max}`); // eslint-disable-line functional/immutable-data
+    if (max !== size) {
+      res.message.push(`Gaps detected in occurrence numbers: found ${size}, seen max ${max}`);
     }
-    res.valid = res.message.length < 1; // eslint-disable-line functional/immutable-data
+    res.valid = res.message.length < 1;
     return res;
   }
 }
@@ -91,7 +91,7 @@ function recordDisambiguateSharedSubfield6OccurrenceNumbers(record) {
     return;
   }
   nvdebug(`Disambiguate occurrence numbers (N=${sharedOccurrenceNumberFields.length}) in...`, debug);
-  sharedOccurrenceNumberFields.forEach(field => disambiguateOccurrenceNumber(field));
+  sharedOccurrenceNumberFields.forEach(field => disambiguateOccurrenceNumber(field)); // eslint-disable-line array-callback-return
 
   function disambiguateable(field) {
     if (field.tag === '880') { // Not needed, already filtered...
@@ -131,7 +131,7 @@ function recordDisambiguateSharedSubfield6OccurrenceNumbers(record) {
     nvdebug(` Reindex '${fieldToString(field)}' occurrence number and it's ${pairedFields.length} pair(s) using '${newOccurrenceNumber}'`, debug);
 
     fieldResetOccurrenceNumber(field, newOccurrenceNumber, occurrenceNumber);
-    pairedFields.forEach(pairedField => fieldResetOccurrenceNumber(pairedField, newOccurrenceNumber, occurrenceNumber));
+    pairedFields.forEach(pairedField => fieldResetOccurrenceNumber(pairedField, newOccurrenceNumber, occurrenceNumber)); // eslint-disable-line array-callback-return
 
   }
 

package/src/removeDuplicateDataFields.js

@@ -37,11 +37,11 @@ export default function () {
     const res = {message: duplicates};
 
     /*
-    if (orphanedFields.length > 0) { // eslint-disable-line functional/no-conditional-statements
-      res.message = [`${orphanedFields.length} orphaned occurrence number field(s) detected`]; // eslint-disable-line functional/immutable-data
+    if (orphanedFields.length > 0) {
+      res.message = [`${orphanedFields.length} orphaned occurrence number field(s) detected`];
     }
     */
-    res.valid = res.message.length < 1; // eslint-disable-line functional/immutable-data
+    res.valid = res.message.length < 1;
     return res;
   }
 }
@@ -56,7 +56,7 @@ function numberOfLinkageSubfields(field) {
 */
 
 function removeLinkNotes(record) {
-  record.fields.forEach(f => delete f.linkNote); // eslint-disable-line functional/immutable-data
+  record.fields.forEach(f => delete f.linkNote); // eslint-disable-line array-callback-return
 }
 
 
@@ -109,19 +109,19 @@ function recordRemoveFieldOrSubfield8(record, field, currLinkingNumber) {
     return;
   }
   const subfields = field.subfields.filter(sf => getSubfield8LinkingNumber(sf) === currLinkingNumber);
-  subfields.forEach(sf => record.removeSubfield(sf, field));
+  subfields.forEach(sf => record.removeSubfield(sf, field)); // eslint-disable-line array-callback-return
 }
 
 function newRecordRemoveFieldOrSubfield8(record, field, currLinkingNumber, fix) {
   const eights = field.subfields.filter(sf => sf.code === '8');
   if (eights.length < 2) {
-    field.deleted = 1; // eslint-disable-line functional/immutable-data
+    field.deleted = 1;
     return;
   }
   const subfields = field.subfields.filter(sf => getSubfield8LinkingNumber(sf) === currLinkingNumber);
   subfields.forEach(sf => {
-    field.modified = 1; // eslint-disable-line functional/immutable-data
-    if (fix) { // eslint-disable-line functional/no-conditional-statements
+    field.modified = 1;
+    if (fix) {
       record.removeSubfield(sf, field);
     }
   });
@@ -232,7 +232,7 @@ function markIdenticalSubfield6Chains(chain, record) {
   const chainAsString = fieldsToNormalizedString(chain, 0, normalizeOccurrenceNumber, normalizeTag);
 
   nvdebug(`markIdenticalSubfield6Chains: ${chainAsString}`);
-  record.fields.forEach(f => compareWithChain(f));
+  record.fields.forEach(f => compareWithChain(f)); // eslint-disable-line array-callback-return
 
 
   function compareWithChain(f) {
@@ -248,7 +248,7 @@ function markIdenticalSubfield6Chains(chain, record) {
     if (chainAsString === otherChainAsString) {
       otherChain.forEach(f => {
         nvdebug(` mark ${fieldToString(f)} as deleted ($6-chain)...`);
-        f.deleted = 1; // eslint-disable-line functional/immutable-data
+        f.deleted = 1;
       });
       return;
     }
@@ -269,7 +269,7 @@ function markIdenticalLoneFieldsAsDeletable(field, record) {
   // Mark fields as deleted:
   identicalLoneFields.forEach(f => {
     nvdebug(` mark ${fieldToString(f)} as deleted (lone field)...`);
-    f.deleted = 1; // eslint-disable-line functional/immutable-data
+    f.deleted = 1;
   });
 
 }
@@ -324,11 +324,9 @@ function acceptFieldsWithSubfield8(fieldsWithSubfield8, requireSingleTag = false
 
 
 export function sameField(field1, field2) {
-  /* eslint-disable */
-    field1.tmpMyId = 666;
-    const result = field2.tmpMyId === 666 ? true : false;
-    delete field1.tmpMyId;
-    /* eslint-enable */
+  field1.tmpMyId = 666;
+  const result = field2.tmpMyId === 666 ? true : false;
+  delete field1.tmpMyId;
   return result;
 }
 
@@ -423,24 +421,24 @@ export function removeDuplicateDatafields(record, fix = true) {
 
   const dataFields = record.fields.filter(f => f.subfields !== undefined);
 
-  dataFields.forEach(f => fieldHandleDuplicateDatafields(f, record));
+  dataFields.forEach(f => fieldHandleDuplicateDatafields(f, record)); // eslint-disable-line array-callback-return
 
   const deletableFields = dataFields.filter(f => f.deleted);
   const modifiedFields = dataFields.filter(f => f.modified && !f.deleted);
 
   const result = deletableFields.map(f => `DEL: ${fieldToString(f)}`);
-  if (modifiedFields.length) { // eslint-disable-line functional/no-conditional-statements
-    modifiedFields.forEach(f => delete f.modified); // eslint-disable-line functional/immutable-data
-    result.push(modifiedFields.map(f => `MOD: ${fieldToString(f)}`)); // eslint-disable-line functional/immutable-data
+  if (modifiedFields.length) {
+    modifiedFields.forEach(f => delete f.modified); // eslint-disable-line array-callback-return
+    result.push(modifiedFields.map(f => `MOD: ${fieldToString(f)}`));
   }
 
   if (fix) {
-    deletableFields.forEach(f => record.removeField(f));
+    deletableFields.forEach(f => record.removeField(f)); // eslint-disable-line array-callback-return
     return result;
   }
 
-  deletableFields.forEach(f => delete f.deleted); // eslint-disable-line functional/immutable-data
-  deletableFields.forEach(f => delete f.modified); // eslint-disable-line functional/immutable-data
+  deletableFields.forEach(f => delete f.deleted); // eslint-disable-line array-callback-return
+  deletableFields.forEach(f => delete f.modified); // eslint-disable-line array-callback-return
 
 
   return result;