@natlibfi/marc-record-validators-melinda 11.0.0 → 11.1.0-alpha.1

package/src/punctuation2.js

@@ -338,7 +338,7 @@ const addPairedPunctuationRules = {
     {'code': 'b', 'followedBy': 'c', 'add': ',', 'context': defaultNeedsPuncAfter2},
     // NB! The $c rule messes dotless exception "264 #4 $c p1983" up
     // We'll need to add a hacky postprocessor for this? Add 'hasInd1': '0123' etc?
-    {'code': 'c', 'followedBy': '#', 'add': '.', 'context': defaultNeedsPuncAfter2}
+    {'code': 'c', 'followedBy': '#', 'add': '.', 'context': defaultNeedsPuncAfter, 'ind2': ['0', '1', '2', '3']}
   ],
   '300': [
     {'code': 'a', 'followedBy': 'b', 'add': ' :', 'context': defaultNeedsPuncAfter2},
@@ -394,11 +394,11 @@ function ruleAppliesToSubfieldCode(targetSubfieldCodes, currSubfieldCode) {
 
 
 function ruleAppliesToField(rule, field) {
-  if ('ind1' in rule && field.ind1.includes(rule.ind1)) {
+  if ('ind1' in rule && !rule.ind1.includes(field.ind1)) {
     return false;
   }
 
-  if ('ind2' in rule && field.ind2.includes(rule.ind2)) {
+  if ('ind2' in rule && !rule.ind2.includes(field.ind2)) {
     return false;
   }
 

package/src/sanitize-vocabulary-source-codes.js

@@ -14,25 +14,26 @@ export default function () {
 
   function fix(record) {
     const res = {message: [], fix: [], valid: true};
-    record.fields.forEach(f => fieldSanitizeVocabularySourceCode(f));
+    const relevantFields = getRelevantFields(record);
+    relevantFields.forEach(f => fieldSanitizeVocabularySourceCode(f));
     return res;
   }
 
   function validate(record) {
     const res = {message: []};
+    const relevantFields = getRelevantFields(record);
 
-    record.fields.forEach(field => {
-      validateField(field, res);
-    });
+    relevantFields.forEach(field => validateField(field, res));
 
     res.valid = !(res.message.length >= 1); // eslint-disable-line functional/immutable-data
     return res;
   }
 
+  function getRelevantFields(record) {
+    return record.fields.filter(f => f.subfields && f.tag.match(/^(?:6..|257|370|38.)$/u));
+  }
+
   function validateField(field, res) {
-    if (!field.subfields) {
-      return;
-    }
     const orig = fieldToString(field);
 
     const normalizedField = fieldSanitizeVocabularySourceCode(clone(field));
@@ -49,11 +50,8 @@ export default function () {
     return;
   }
 
-  function fieldSanitizeVocabularySourceCode(field) {
-    if (!field.tag.match(/^(?:6..|257|370|38.)$/u)) {
-      return field;
-    }
 
+  function fieldSanitizeVocabularySourceCode(field) {
     field.subfields.forEach(sf => subfieldSanitizeVocabularySourceCode(sf));
     return field;
   }

package/src/utils.js

@@ -1,11 +1,7 @@
 export function isElectronicMaterial(record) {
   const f337s = record.get('337');
 
-  return f337s.some(field => {
-    const mediaTypeIsC = field.subfields.some(sub => sub.code === 'b' && sub.value === 'c');
-    const sourceIsRdamedia = field.subfields.some(sub => sub.code === '2' && sub.value === 'rdamedia');
-    return mediaTypeIsC && sourceIsRdamedia;
-  });
+  return f337s.length > 0 && f337s.some(f => fieldHasSubfield(f, 'b', 'c') && fieldHasSubfield(f, '2', 'rdamedia'));
 }
 
 export function nvdebug(message, func = undefined) {
@@ -26,6 +22,9 @@ export function fieldHasSubfield(field, subfieldCode, subfieldValue = null) {
 }
 
 export function subfieldToString(sf) {
+  if (!sf.value) {
+    return `‡${sf.code}`;
+  }
   return `‡${sf.code} ${sf.value}`;
 }
 
@@ -36,6 +35,12 @@ function normalizeIndicatorValue(val) {
   return val;
 }
 
+export function recordToString(record) {
+  const ldr = `LDR   ${record.leader}`;
+  const fields = record.fields.map(f => fieldToString(f));
+  return `${ldr}\n${fields.join('\n')}`;
+}
+
 export function fieldToString(f) {
   if ('subfields' in f) {
     return `${f.tag} ${normalizeIndicatorValue(f.ind1)}${normalizeIndicatorValue(f.ind2)}${formatSubfields(f)}`;
@@ -62,14 +67,14 @@ export function isControlSubfieldCode(subfieldCode) {
   return false;
 }
 
-export function getCatalogingLanguage(record) {
+export function getCatalogingLanguage(record, defaultCatalogingLanguage = undefined) {
   const [field040] = record.get(/^040$/u);
   if (!field040) {
-    return null;
+    return defaultCatalogingLanguage;
   }
   const [b] = field040.subfields.filter(sf => sf.code === 'b');
   if (!b) {
-    return null;
+    return defaultCatalogingLanguage;
   }
   return b.value;
 }

package/test-fixtures/addMissingField336/01/expectedResult.json

@@ -0,0 +1,6 @@
+{
+  "message": [
+    "Add missing 336 field(s): '336 ## ‡a teksti ‡b txt ‡2 rdacontent'"
+  ],
+  "valid": false
+}

package/test-fixtures/addMissingField336/01/metadata.json

@@ -0,0 +1,7 @@
+{
+  "description": "Validation: Add field 336",
+  "comment": "Create a 336",
+  "enabled": true,
+  "only": false,
+  "fix": false
+}

package/test-fixtures/addMissingField336/01/record.json

@@ -0,0 +1,8 @@
+{
+  "leader": "12345cam a22123454i 4500",
+  "fields": [
+    { "tag": "300", "ind1": " ", "ind2": " ", "subfields": [
+        { "code": "a", "value": "123 sivua" }
+    ]}
+  ]
+}

package/test-fixtures/addMissingField336/02/expectedResult.json

@@ -0,0 +1,4 @@
+{
+  "message": [],
+  "valid": true
+}

package/test-fixtures/addMissingField336/02/metadata.json

@@ -0,0 +1,7 @@
+{
+  "description": "Validation: Don't add field 336",
+  "comment": "Don't create a 336 as there's already one",
+  "enabled": true,
+  "only": false,
+  "fix": false
+}

package/test-fixtures/addMissingField336/02/record.json

@@ -0,0 +1,13 @@
+{
+  "leader": "12345cam a22123454i 4500",
+  "fields": [
+    { "tag": "300", "ind1": " ", "ind2": " ", "subfields": [
+        { "code": "a", "value": "123 sivua" }
+    ]},
+    { "tag": "336", "ind1": " ", "ind2": " ", "subfields": [
+      { "code": "a", "value": "teksti" },
+      { "code": "b", "value": "txt" },
+      { "code": "2", "value": "rdacontent" }
+  ]}
+  ]
+}

package/test-fixtures/addMissingField336/cod/expectedResult.json

@@ -0,0 +1,12 @@
+{
+  "_validationOptions": {},
+  "leader": "12345cmm a22123454i 4500",
+  "fields": [
+    { "tag": "008", "value": "121212s2000    fi ||||    a| | | | fin  "},
+    { "tag": "336", "ind1": " ", "ind2": " ", "subfields": [
+      { "code": "a", "value": "digitaalinen data" },
+      { "code": "b", "value": "cod" },
+      { "code": "2", "value": "rdacontent" }
+    ]}
+  ]
+}

package/test-fixtures/addMissingField336/cod/metadata.json

@@ -0,0 +1,6 @@
+{
+  "description": "Fix: Add field 336 (b=cod). Decision based on CF's 008/26=a)",
+  "enabled": true,
+  "only": false,
+  "fix": true
+}

package/test-fixtures/addMissingField336/cod/record.json

@@ -0,0 +1,6 @@
+{
+  "leader": "12345cmm a22123454i 4500",
+  "fields": [
+    { "tag": "008", "value": "121212s2000    fi ||||    a| | | | fin  "}
+  ]
+}

package/test-fixtures/addMissingField336/cop/expectedResult.json

@@ -0,0 +1,12 @@
+{
+  "_validationOptions": {},
+  "leader": "12345cmm a22123454i 4500",
+  "fields": [
+    { "tag": "008", "value": "121212s2000    fi |||| q  b| | | | fin  "},
+    { "tag": "336", "ind1": " ", "ind2": " ", "subfields": [
+      { "code": "a", "value": "tietokoneohjelma" },
+      { "code": "b", "value": "cop" },
+      { "code": "2", "value": "rdacontent" }
+    ]}
+  ]
+}

package/test-fixtures/addMissingField336/cop/metadata.json

@@ -0,0 +1,6 @@
+{
+  "description": "Fix: Add field 336 (b=cop). Decision based on CF's 008/26=b)",
+  "enabled": true,
+  "only": false,
+  "fix": true
+}

package/test-fixtures/addMissingField336/cop/record.json

@@ -0,0 +1,6 @@
+{
+  "leader": "12345cmm a22123454i 4500",
+  "fields": [
+    { "tag": "008", "value": "121212s2000    fi |||| q  b| | | | fin  "}
+  ]
+}

package/test-fixtures/addMissingField336/cop2/expectedResult.json

@@ -0,0 +1,13 @@
+{
+  "_validationOptions": {},
+  "leader": "12345cmm a22123454i 4500",
+  "fields": [
+    { "tag": "008", "value": "121212s2000    fi |||| q   | | | | fin  "},
+    { "tag": "336", "ind1": " ", "ind2": " ", "subfields": [
+      { "code": "a", "value": "tietokoneohjelma" },
+      { "code": "b", "value": "cop" },
+      { "code": "2", "value": "rdacontent" }
+    ]},
+    { "tag": "516", "ind1": " ", "ind2": " ", "subfields": [ { "code": "a", "value": "tietokoneohjelma" } ] }
+  ]
+}

package/test-fixtures/addMissingField336/cop2/metadata.json

@@ -0,0 +1,6 @@
+{
+  "description": "Fix: Add field 336 (b=cop). Decision based on field 516)",
+  "enabled": true,
+  "only": false,
+  "fix": true
+}

package/test-fixtures/addMissingField336/cop2/record.json

@@ -0,0 +1,7 @@
+{
+  "leader": "12345cmm a22123454i 4500",
+  "fields": [
+    { "tag": "008", "value": "121212s2000    fi |||| q   | | | | fin  "},
+    { "tag": "516", "ind1": " ", "ind2": " ", "subfields": [ { "code": "a", "value": "tietokoneohjelma" } ] }
+  ]
+}

package/test-fixtures/addMissingField336/crf/expectedResult.json

@@ -0,0 +1,12 @@
+{
+  "_validationOptions": {},
+  "leader": "12345cem a22123454i 4500",
+  "fields": [
+    { "tag": "008", "value": "121212s2000    fi        d         fin  "},
+    { "tag": "336", "ind1": " ", "ind2": " ", "subfields": [
+      { "code": "a", "value": "kartografinen kolmiulotteinen muoto" },
+      { "code": "b", "value": "crf" },
+      { "code": "2", "value": "rdacontent" }
+    ]}
+  ]
+}

package/test-fixtures/addMissingField336/crf/metadata.json

@@ -0,0 +1,6 @@
+{
+  "description": "Fix: Add field 336 (crf) based on LDR/06=g + 008/25=d/globe",
+  "enabled": true,
+  "only": false,
+  "fix": true
+}

package/test-fixtures/addMissingField336/crf/record.json

@@ -0,0 +1,6 @@
+{
+  "leader": "12345cem a22123454i 4500",
+  "fields": [
+    { "tag": "008", "value": "121212s2000    fi        d         fin  "}
+  ]
+}

package/test-fixtures/addMissingField336/cri/expectedResult.json

@@ -0,0 +1,12 @@
+{
+  "_validationOptions": {},
+  "leader": "12345cem a22123454i 4500",
+  "fields": [
+    { "tag": "008", "value": "121212s2000    fi                  fin  "},
+    { "tag": "336", "ind1": " ", "ind2": " ", "subfields": [
+      { "code": "a", "value": "kartografinen kuva" },
+      { "code": "b", "value": "cri" },
+      { "code": "2", "value": "rdacontent" }
+    ]}
+  ]
+}

package/test-fixtures/addMissingField336/cri/metadata.json

@@ -0,0 +1,6 @@
+{
+  "description": "Fix: Add field 336 (cri) based on LDR/06=e",
+  "enabled": true,
+  "only": false,
+  "fix": true
+}

package/test-fixtures/addMissingField336/cri/record.json

@@ -0,0 +1,6 @@
+{
+  "leader": "12345cem a22123454i 4500",
+  "fields": [
+    { "tag": "008", "value": "121212s2000    fi                  fin  "}
+  ]
+}

package/test-fixtures/addMissingField336/crt/expectedResult.json

@@ -0,0 +1,13 @@
+{
+  "_validationOptions": {},
+  "leader": "12345cem a22123454i 4500",
+  "fields": [
+    { "tag": "007", "value": "aq234567"},
+    { "tag": "008", "value": "121212s2000    fi            f     fin  "},
+    { "tag": "336", "ind1": " ", "ind2": " ", "subfields": [
+      { "code": "a", "value": "kartografinen taktiili kuva" },
+      { "code": "b", "value": "crt" },
+      { "code": "2", "value": "rdacontent" }
+    ]}
+  ]
+}

package/test-fixtures/addMissingField336/crt/metadata.json

@@ -0,0 +1,6 @@
+{
+  "description": "Fix: Add field 336 (crt) based on LDR/06=e, form of item=f (braille) and 007/00-01=aq",
+  "enabled": true,
+  "only": false,
+  "fix": true
+}

package/test-fixtures/addMissingField336/crt/record.json

@@ -0,0 +1,7 @@
+{
+  "leader": "12345cem a22123454i 4500",
+  "fields": [
+    { "tag": "007", "value": "aq234567" },
+    { "tag": "008", "value": "121212s2000    fi            f     fin  "}
+  ]
+}

package/test-fixtures/addMissingField336/f01/expectedResult.json

@@ -0,0 +1,17 @@
+{
+  "_validationOptions": {},
+  "leader": "12345cam a22123454i 4500",
+  "fields": [
+    { "tag": "040", "ind1": " ", "ind2": " ", "subfields": [
+      { "code": "b", "value": "swe" }
+    ]},
+    { "tag": "300", "ind1": " ", "ind2": " ", "subfields": [
+        { "code": "a", "value": "123 sivua" }
+    ]},
+    { "tag": "336", "ind1": " ", "ind2": " ", "subfields": [
+      { "code": "a", "value": "text" },
+      { "code": "b", "value": "txt" },
+      { "code": "2", "value": "rdacontent" }
+    ]}
+  ]
+}

package/test-fixtures/addMissingField336/f01/metadata.json

@@ -0,0 +1,6 @@
+{
+  "description": "Fix: Add field 336 (b=txt), cat kanguage (040$b) is 'swe'",
+  "enabled": true,
+  "only": false,
+  "fix": true
+}

package/test-fixtures/addMissingField336/f01/record.json

@@ -0,0 +1,11 @@
+{
+  "leader": "12345cam a22123454i 4500",
+  "fields": [
+    { "tag": "040", "ind1": " ", "ind2": " ", "subfields": [
+      { "code": "b", "value": "swe" }
+    ]},
+    { "tag": "300", "ind1": " ", "ind2": " ", "subfields": [
+        { "code": "a", "value": "123 sivua" }
+    ]}
+  ]
+}

package/test-fixtures/addMissingField336/f02/expectedResult.json

@@ -0,0 +1,15 @@
+{
+  "_validationOptions": {},
+  "leader": "12345cam a22123454i 4500",
+  "fields": [
+    { "tag": "008", "value": "121212s2000    fi abcd f     000 1 fin  "},
+    { "tag": "300", "ind1": " ", "ind2": " ", "subfields": [
+        { "code": "a", "value": "123 sivua" }
+    ]},
+    { "tag": "336", "ind1": " ", "ind2": " ", "subfields": [
+      { "code": "a", "value": "taktiili teksti" },
+      { "code": "b", "value": "tct" },
+      { "code": "2", "value": "rdacontent" }
+    ]}
+  ]
+}

package/test-fixtures/addMissingField336/f02/metadata.json

@@ -0,0 +1,6 @@
+{
+  "description": "Fix: Add field 336 (b=txt)",
+  "enabled": true,
+  "only": false,
+  "fix": true
+}

package/test-fixtures/addMissingField336/f02/record.json

@@ -0,0 +1,9 @@
+{
+  "leader": "12345cam a22123454i 4500",
+  "fields": [
+    { "tag": "008", "value": "121212s2000    fi abcd f     000 1 fin  "},
+    { "tag": "300", "ind1": " ", "ind2": " ", "subfields": [
+        { "code": "a", "value": "123 sivua" }
+    ]}
+  ]
+}

package/test-fixtures/addMissingField336/mixed2txt/expectedResult.json

@@ -0,0 +1,12 @@
+{
+  "_validationOptions": {},
+  "leader": "12345cpm a22123454i 4500",
+  "fields": [
+    { "tag": "008", "value": "121212s2000    fi |||| r  b| | | | fin  "},
+    { "tag": "336", "ind1": " ", "ind2": " ", "subfields": [
+      { "code": "a", "value": "teksti" },
+      { "code": "b", "value": "txt" },
+      { "code": "2", "value": "rdacontent" }
+    ]}
+  ]
+}

package/test-fixtures/addMissingField336/mixed2txt/metadata.json

@@ -0,0 +1,6 @@
+{
+  "description": "Fix: Add field 336 (b=txt). Default value for LDR/06=p is overridden by form of item 008/23=r",
+  "enabled": true,
+  "only": false,
+  "fix": true
+}

package/test-fixtures/addMissingField336/mixed2txt/record.json

@@ -0,0 +1,6 @@
+{
+  "leader": "12345cpm a22123454i 4500",
+  "fields": [
+    { "tag": "008", "value": "121212s2000    fi |||| r  b| | | | fin  "}
+  ]
+}

package/test-fixtures/addMissingField336/mixed2xxx/expectedResult.json

@@ -0,0 +1,12 @@
+{
+  "_validationOptions": {},
+  "leader": "12345cpm a22123454i 4500",
+  "fields": [
+    { "tag": "008", "value": "121212s2000    fi |||| a  b| | | | fin  "},
+    { "tag": "336", "ind1": " ", "ind2": " ", "subfields": [
+      { "code": "a", "value": "muu" },
+      { "code": "b", "value": "xxx" },
+      { "code": "2", "value": "rdacontent" }
+    ]}
+  ]
+}

package/test-fixtures/addMissingField336/mixed2xxx/metadata.json

@@ -0,0 +1,6 @@
+{
+  "description": "Fix: Add field 336 (b=xxx). Default value for LDR/06=p",
+  "enabled": true,
+  "only": false,
+  "fix": true
+}

package/test-fixtures/addMissingField336/mixed2xxx/record.json

@@ -0,0 +1,6 @@
+{
+  "leader": "12345cpm a22123454i 4500",
+  "fields": [
+    { "tag": "008", "value": "121212s2000    fi |||| a  b| | | | fin  "}
+  ]
+}

package/test-fixtures/addMissingField336/ntm/expectedResult.json

@@ -0,0 +1,12 @@
+{
+  "_validationOptions": {},
+  "leader": "12345cdm a22123454i 4500",
+  "fields": [
+    { "tag": "008", "value": "121212s2000    fi                  fin  "},
+    { "tag": "336", "ind1": " ", "ind2": " ", "subfields": [
+      { "code": "a", "value": "nuottikirjoitus" },
+      { "code": "b", "value": "ntm" },
+      { "code": "2", "value": "rdacontent" }
+    ]}
+  ]
+}

package/test-fixtures/addMissingField336/ntm/metadata.json

@@ -0,0 +1,6 @@
+{
+  "description": "Fix: Add field 336 (notated music), based on LDR/06=d (does not have exceptions)",
+  "enabled": true,
+  "only": false,
+  "fix": true
+}

package/test-fixtures/addMissingField336/ntm/record.json

@@ -0,0 +1,6 @@
+{
+  "leader": "12345cdm a22123454i 4500",
+  "fields": [
+    { "tag": "008", "value": "121212s2000    fi                  fin  "}
+  ]
+}

package/test-fixtures/addMissingField336/snd/expectedResult.json

@@ -0,0 +1,12 @@
+{
+  "_validationOptions": {},
+  "leader": "12345cmm a22123454i 4500",
+  "fields": [
+    { "tag": "008", "value": "121212s2000    fi |||| q  h| | | | fin  "},
+    { "tag": "336", "ind1": " ", "ind2": " ", "subfields": [
+      { "code": "a", "value": "ääni" },
+      { "code": "b", "value": "snd" },
+      { "code": "2", "value": "rdacontent" }
+    ]}
+  ]
+}

package/test-fixtures/addMissingField336/snd/metadata.json

@@ -0,0 +1,6 @@
+{
+  "description": "Fix: Add field 336 (b=snd). Decision based on CF's 008/26=h)",
+  "enabled": true,
+  "only": false,
+  "fix": true
+}

package/test-fixtures/addMissingField336/snd/record.json

@@ -0,0 +1,6 @@
+{
+  "leader": "12345cmm a22123454i 4500",
+  "fields": [
+    { "tag": "008", "value": "121212s2000    fi |||| q  h| | | | fin  "}
+  ]
+}

package/test-fixtures/addMissingField336/spw/expectedResult.json

@@ -0,0 +1,12 @@
+{
+  "_validationOptions": {},
+  "leader": "12345cim a22123454i 4500",
+  "fields": [
+    { "tag": "008", "value": "121212s2000    fi                  fin  "},
+    { "tag": "336", "ind1": " ", "ind2": " ", "subfields": [
+      { "code": "a", "value": "puhe" },
+      { "code": "b", "value": "spw" },
+      { "code": "2", "value": "rdacontent" }
+    ]}
+  ]
+}

package/test-fixtures/addMissingField336/spw/metadata.json

@@ -0,0 +1,6 @@
+{
+  "description": "Fix: Add field 336 (spw) based on LDR/06=i",
+  "enabled": true,
+  "only": false,
+  "fix": true
+}

package/test-fixtures/addMissingField336/spw/record.json

@@ -0,0 +1,6 @@
+{
+  "leader": "12345cim a22123454i 4500",
+  "fields": [
+    { "tag": "008", "value": "121212s2000    fi                  fin  "}
+  ]
+}

package/test-fixtures/addMissingField336/spw2/expectedResult.json

@@ -0,0 +1,13 @@
+{
+  "_validationOptions": {},
+  "leader": "12345cmm a22123454i 4500",
+  "fields": [
+    { "tag": "008", "value": "121212s2000    fi |||| q   | | | | fin  "},
+    { "tag": "336", "ind1": " ", "ind2": " ", "subfields": [
+      { "code": "a", "value": "puhe" },
+      { "code": "b", "value": "spw" },
+      { "code": "2", "value": "rdacontent" }
+    ]},
+    { "tag": "516", "ind1": " ", "ind2": " ", "subfields": [ { "code": "a", "value": "äänikirja" } ] }
+  ]
+}

package/test-fixtures/addMissingField336/spw2/metadata.json

@@ -0,0 +1,6 @@
+{
+  "description": "Fix: Add field 336 (b=spw). Decision based on field 516",
+  "enabled": true,
+  "only": false,
+  "fix": true
+}

package/test-fixtures/addMissingField336/spw2/record.json

@@ -0,0 +1,7 @@
+{
+  "leader": "12345cmm a22123454i 4500",
+  "fields": [
+    { "tag": "008", "value": "121212s2000    fi |||| q   | | | | fin  "},
+    { "tag": "516", "ind1": " ", "ind2": " ", "subfields": [ { "code": "a", "value": "äänikirja" } ] }
+  ]
+}