@natlibfi/marc-record-validators-melinda 10.0.1-alpha.2 → 10.0.1-alpha.5

package/dist/ending-whitespace.js

@@ -17,7 +17,7 @@ function _default() {
   function validate(record) {
     const nonValidFields = record.fields.filter(({
       subfields
-    }) => subfields.filter(valueEndsWithWhitespace).length > 0);
+    }) => subfields && subfields.filter(valueEndsWithWhitespace).length > 0);
     const valid = nonValidFields.length === 0;
     const messages = nonValidFields.flatMap(({
       tag,

package/dist/ending-whitespace.js.map

@@ -1 +1 @@
-{"version":3,"file":"ending-whitespace.js","names":["description","validate","fix","record","nonValidFields","fields","filter","subfields","valueEndsWithWhitespace","length","valid","messages","flatMap","tag","map","sf","code","forEach","undefined","subfield","value","trimEnd","test"],"sources":["../src/ending-whitespace.js"],"sourcesContent":["/**\n * Provides interface to validate and fix record fields, which include subfields that end with whitespace character\n * @returns {Object} Object containing interfaces required by marc-record-validators-melinda package\n */\nexport default function () {\n  return {\n    description: 'Handles subfields that ends with whitespace character',\n    validate,\n    fix\n  };\n\n  function validate(record) {\n    const nonValidFields = record.fields.filter(({subfields}) => subfields.filter(valueEndsWithWhitespace).length > 0);\n\n    const valid = nonValidFields.length === 0;\n    const messages = nonValidFields.flatMap(({tag, subfields}) => subfields.map(sf => `Field ${tag} subfield $${sf.code} ends with whitespace`));\n\n    return valid ? {valid, messages: []} : {valid, messages};\n  }\n\n  /* eslint-disable functional/immutable-data,functional/no-conditional-statement */\n  function fix(record) {\n    record.fields.forEach(({subfields}) => {\n      if (subfields === undefined) {\n        return;\n      }\n\n      subfields.forEach(subfield => {\n        if (valueEndsWithWhitespace(subfield)) {\n          subfield.value = subfield.value.trimEnd();\n        }\n      });\n    });\n  }\n  /* eslint-enable functional/immutable-data,functional/no-conditional-statement */\n\n  function valueEndsWithWhitespace({value}) {\n    return (/\\s$/u).test(value);\n  }\n}\n"],"mappings":";;;;;;AAAA;AACA;AACA;AACA;AACe,oBAAY;EACzB,OAAO;IACLA,WAAW,EAAE,uDAAuD;IACpEC,QAAQ;IACRC;EACF,CAAC;EAED,SAASD,QAAQ,CAACE,MAAM,EAAE;IACxB,MAAMC,cAAc,GAAGD,MAAM,CAACE,MAAM,CAACC,MAAM,CAAC,CAAC;MAACC;IAAS,CAAC,KAAKA,SAAS,CAACD,MAAM,CAACE,uBAAuB,CAAC,CAACC,MAAM,GAAG,CAAC,CAAC;IAElH,MAAMC,KAAK,GAAGN,cAAc,CAACK,MAAM,KAAK,CAAC;IACzC,MAAME,QAAQ,GAAGP,cAAc,CAACQ,OAAO,CAAC,CAAC;MAACC,GAAG;MAAEN;IAAS,CAAC,KAAKA,SAAS,CAACO,GAAG,CAACC,EAAE,IAAK,SAAQF,GAAI,cAAaE,EAAE,CAACC,IAAK,uBAAsB,CAAC,CAAC;IAE5I,OAAON,KAAK,GAAG;MAACA,KAAK;MAAEC,QAAQ,EAAE;IAAE,CAAC,GAAG;MAACD,KAAK;MAAEC;IAAQ,CAAC;EAC1D;;EAEA;EACA,SAAST,GAAG,CAACC,MAAM,EAAE;IACnBA,MAAM,CAACE,MAAM,CAACY,OAAO,CAAC,CAAC;MAACV;IAAS,CAAC,KAAK;MACrC,IAAIA,SAAS,KAAKW,SAAS,EAAE;QAC3B;MACF;MAEAX,SAAS,CAACU,OAAO,CAACE,QAAQ,IAAI;QAC5B,IAAIX,uBAAuB,CAACW,QAAQ,CAAC,EAAE;UACrCA,QAAQ,CAACC,KAAK,GAAGD,QAAQ,CAACC,KAAK,CAACC,OAAO,EAAE;QAC3C;MACF,CAAC,CAAC;IACJ,CAAC,CAAC;EACJ;EACA;;EAEA,SAASb,uBAAuB,CAAC;IAACY;EAAK,CAAC,EAAE;IACxC,OAAQ,MAAM,CAAEE,IAAI,CAACF,KAAK,CAAC;EAC7B;AACF"}
+{"version":3,"file":"ending-whitespace.js","names":["description","validate","fix","record","nonValidFields","fields","filter","subfields","valueEndsWithWhitespace","length","valid","messages","flatMap","tag","map","sf","code","forEach","undefined","subfield","value","trimEnd","test"],"sources":["../src/ending-whitespace.js"],"sourcesContent":["/**\n * Provides interface to validate and fix record fields, which include subfields that end with whitespace character\n * @returns {Object} Object containing interfaces required by marc-record-validators-melinda package\n */\nexport default function () {\n  return {\n    description: 'Handles subfields that ends with whitespace character',\n    validate,\n    fix\n  };\n\n  function validate(record) {\n    const nonValidFields = record.fields.filter(({subfields}) => subfields && subfields.filter(valueEndsWithWhitespace).length > 0);\n\n    const valid = nonValidFields.length === 0;\n    const messages = nonValidFields.flatMap(({tag, subfields}) => subfields.map(sf => `Field ${tag} subfield $${sf.code} ends with whitespace`));\n\n    return valid ? {valid, messages: []} : {valid, messages};\n  }\n\n  /* eslint-disable functional/immutable-data,functional/no-conditional-statement */\n  function fix(record) {\n    record.fields.forEach(({subfields}) => {\n      if (subfields === undefined) {\n        return;\n      }\n\n      subfields.forEach(subfield => {\n        if (valueEndsWithWhitespace(subfield)) {\n          subfield.value = subfield.value.trimEnd();\n        }\n      });\n    });\n  }\n  /* eslint-enable functional/immutable-data,functional/no-conditional-statement */\n\n  function valueEndsWithWhitespace({value}) {\n    return (/\\s$/u).test(value);\n  }\n}\n"],"mappings":";;;;;;AAAA;AACA;AACA;AACA;AACe,oBAAY;EACzB,OAAO;IACLA,WAAW,EAAE,uDAAuD;IACpEC,QAAQ;IACRC;EACF,CAAC;EAED,SAASD,QAAQ,CAACE,MAAM,EAAE;IACxB,MAAMC,cAAc,GAAGD,MAAM,CAACE,MAAM,CAACC,MAAM,CAAC,CAAC;MAACC;IAAS,CAAC,KAAKA,SAAS,IAAIA,SAAS,CAACD,MAAM,CAACE,uBAAuB,CAAC,CAACC,MAAM,GAAG,CAAC,CAAC;IAE/H,MAAMC,KAAK,GAAGN,cAAc,CAACK,MAAM,KAAK,CAAC;IACzC,MAAME,QAAQ,GAAGP,cAAc,CAACQ,OAAO,CAAC,CAAC;MAACC,GAAG;MAAEN;IAAS,CAAC,KAAKA,SAAS,CAACO,GAAG,CAACC,EAAE,IAAK,SAAQF,GAAI,cAAaE,EAAE,CAACC,IAAK,uBAAsB,CAAC,CAAC;IAE5I,OAAON,KAAK,GAAG;MAACA,KAAK;MAAEC,QAAQ,EAAE;IAAE,CAAC,GAAG;MAACD,KAAK;MAAEC;IAAQ,CAAC;EAC1D;;EAEA;EACA,SAAST,GAAG,CAACC,MAAM,EAAE;IACnBA,MAAM,CAACE,MAAM,CAACY,OAAO,CAAC,CAAC;MAACV;IAAS,CAAC,KAAK;MACrC,IAAIA,SAAS,KAAKW,SAAS,EAAE;QAC3B;MACF;MAEAX,SAAS,CAACU,OAAO,CAACE,QAAQ,IAAI;QAC5B,IAAIX,uBAAuB,CAACW,QAAQ,CAAC,EAAE;UACrCA,QAAQ,CAACC,KAAK,GAAGD,QAAQ,CAACC,KAAK,CAACC,OAAO,EAAE;QAC3C;MACF,CAAC,CAAC;IACJ,CAAC,CAAC;EACJ;EACA;;EAEA,SAASb,uBAAuB,CAAC;IAACY;EAAK,CAAC,EAAE;IACxC,OAAQ,MAAM,CAAEE,IAAI,CAACF,KAAK,CAAC;EAC7B;AACF"}

package/package.json

@@ -14,7 +14,7 @@
     "url": "git@github.com:natlibfi/marc-record-validators-melinda.git"
   },
   "license": "MIT",
-  "version": "10.0.1-alpha.2",
+  "version": "10.0.1-alpha.5",
   "main": "./dist/index.js",
   "publishConfig": {
     "access": "public"

package/src/ending-whitespace.js

@@ -10,7 +10,7 @@ export default function () {
   };
 
   function validate(record) {
-    const nonValidFields = record.fields.filter(({subfields}) => subfields.filter(valueEndsWithWhitespace).length > 0);
+    const nonValidFields = record.fields.filter(({subfields}) => subfields && subfields.filter(valueEndsWithWhitespace).length > 0);
 
     const valid = nonValidFields.length === 0;
     const messages = nonValidFields.flatMap(({tag, subfields}) => subfields.map(sf => `Field ${tag} subfield $${sf.code} ends with whitespace`));

package/test-fixtures/ending-whitespace/04/expectedResult.json

@@ -0,0 +1,10 @@
+{
+  "_validationOptions": {},
+  "fields": [
+    {
+      "tag": "008",
+      "value": "Foo "
+    }
+  ],
+  "leader": ""
+}

package/test-fixtures/ending-whitespace/04/metadata.json

@@ -0,0 +1,6 @@
+{
+  "description": "Does not handle control fields",
+  "skip": false,
+  "only": false,
+  "fix": true
+}

package/test-fixtures/ending-whitespace/04/record.json

@@ -0,0 +1,8 @@
+{
+  "fields": [
+    {
+      "tag": "008",
+      "value": "Foo "
+    }
+  ]
+}