@natlibfi/marc-record-merge 6.0.0-beta.9 → 7.0.0-alpha.1

package/package.json

@@ -14,10 +14,10 @@
 		"url": "git@github.com:natlibfi/marc-record-merge-js.git"
 	},
 	"license": "MIT",
-	"version": "6.0.0-beta.9",
+	"version": "7.0.0-alpha.1",
 	"main": "./dist/index.js",
 	"engines": {
-		"node": ">=14"
+		"node": ">=18"
 	},
 	"type": "commonjs",
 	"scripts": {
@@ -25,8 +25,8 @@
 		"prepublishOnly": "npm run build:transpile",
 		"lint": "eslint ./src",
 		"lint:dev": "eslint ./src --fix",
-		"test:base": "cross-env NODE_ENV=test mocha --require @babel/register --reporter-option maxDiffSize=15000 src/reducers/*.spec.js",
-		"test": "npm run lint && npm run test:base",
+		"test:base": "cross-env NODE_ENV=test mocha --require @babel/register --reporter-option maxDiffSize=15000",
+		"test": "npm run lint && npm run test:base -- --recursive src",
 		"test:dev": "npm run lint:dev && npm run coverage",
 		"coverage": "npm run coverage:unit && npm run coverage:report",
 		"coverage:unit": "nyc --silent npm run test:base",
@@ -37,26 +37,26 @@
 		"dev:test:debug": "cross-env DEBUG=@natlibfi/* NODE_ENV=test nodemon -w src -w test-fixtures --exec 'clear && npm run test:dev'"
 	},
 	"dependencies": {
-		"@natlibfi/fixugen": "1.1.0",
-		"@natlibfi/fixura": "^2.2.1",
-		"@natlibfi/marc-record": "^7.1.0-alpha.2",
+		"@natlibfi/marc-record": "^7.2.2",
 		"debug": "^4.3.4",
-		"normalize-diacritics": "2.14.0"
+		"normalize-diacritics": "^2.13.2"
 	},
 	"devDependencies": {
-		"@babel/cli": "^7.17.10",
-		"@babel/core": "^7.18.5",
-		"@babel/eslint-parser": "^7.18.2",
-		"@babel/preset-env": "^7.18.2",
-		"@babel/register": "^7.17.7",
-		"@natlibfi/eslint-config-melinda-backend": "^2.0.0",
+		"@babel/cli": "^7.21.0",
+		"@babel/core": "^7.21.4",
+		"@babel/eslint-parser": "^7.21.3",
+		"@babel/preset-env": "^7.21.4",
+		"@babel/register": "^7.21.0",
+		"@natlibfi/eslint-config-melinda-backend": "^3.0.0",
 		"babel-plugin-istanbul": "^6.1.1",
 		"babel-plugin-rewire": "^1.2.0",
-		"chai": "^4.3.6",
+		"chai": "^4.3.7",
 		"cross-env": "^7.0.3",
-		"eslint": "^8.17.0",
-		"mocha": "^10.0.0",
-		"nodemon": "^2.0.16",
+		"eslint": "^8.38.0",
+		"mocha": "^10.2.0",
+		"@natlibfi/fixugen": "2.0.0",
+		"@natlibfi/fixura": "^3.0.0",
+		"nodemon": "^2.0.22",
 		"nyc": "^15.1.0"
 	},
 	"eslintConfig": {

package/src/index.js

@@ -1,4 +1,54 @@
 import Reducers from './reducers';
+import createDebugLogger from 'debug';
+
+const debug = createDebugLogger('@natlibfi/melinda-marc-record-merge:index');
+const debugData = debug.extend('data');
 
 export {Reducers};
-export default ({base, source, reducers}) => reducers.reduce((base, reducer) => reducer(base, source), base);
+// export default ({base, source, reducers}) => reducers.reduce((base, reducer) => reducer(base, source), base);
+
+// NV: Modified the reducer loop so, that not only base, but also is carried back.
+// However, we try to be backward-compatible: normally after the reducers, only base is returned.
+
+export default ({base, source, reducers}) => {
+
+  const combo = {base, source};
+  const resultCombo = reducers.reduce((combo, reducer) => {
+    const returnCombo = singleRound(reducer, combo.base, combo.source);
+    //debugData(`returnCombo after current reducer: ${JSON.stringify(returnCombo)}`);
+    return returnCombo;
+  }, combo);
+
+  debugData(`ResultCombo after reducers: ${JSON.stringify(resultCombo)}`);
+
+  // Hack to make my melinda-marc-record-merge-reducers single tests that expect both
+  // base and source to return them both:
+  if (reducers.length === 1 && resultCombo.base && resultCombo.source) {
+    debug('Single reducer, returning resultCombo');
+    debugData(JSON.stringify(resultCombo));
+
+    return resultCombo;
+  }
+  // All other tests return just base... Backward (compability) it is!
+  debug('Multiple reducers, returning just base');
+  debugData(JSON.stringify(resultCombo.base));
+  return resultCombo.base;
+
+  function singleRound(reducer, base, source) {
+    //debug(`SINGLE ROUND INPUT (base, source)`);
+    //debugData(base);
+    //debugData(base);
+    const reducerResult = reducer(base, source);
+    //debug(`reducerResult:`);
+    //debugData(reducerResult);
+    if (reducerResult.base !== undefined && reducerResult.source !== undefined) {
+      debug('NEW STYLE REDUCER RESULT v2');
+      const combo = reducerResult;
+      //debugData(combo);
+      return combo;
+    }
+    debug('OLD SCHOOL REDUCER RESULT v2');
+    //debugData({base: reducerResult, source});
+    return {base: reducerResult, source};
+  }
+};

package/src/index.spec.js

@@ -0,0 +1,45 @@
+import merger, {Reducers} from './index';
+import {inspect} from 'util';
+import createDebugLogger from 'debug';
+import {expect} from 'chai';
+import {MarcRecord} from '@natlibfi/marc-record';
+import {READERS} from '@natlibfi/fixura';
+import generateTests from '@natlibfi/fixugen';
+
+generateTests({
+  callback,
+  path: [__dirname, '..', 'test-fixtures', 'index'],
+  recurse: false,
+  useMetadataFile: true,
+  fixura: {
+    failWhenNotFound: false,
+    reader: READERS.JSON
+  }
+});
+
+function callback({getFixture, reducerConfigs = []}) {
+  const base = new MarcRecord(getFixture('base.json'), {subfieldValues: false});
+  const source = new MarcRecord(getFixture('source.json'), {subfieldValues: false});
+  const expectedRecord = getFixture('merged.json');
+
+  const debug = createDebugLogger('@natlibfi/melinda-marc-record-merge-reducers:index:test');
+  const debugData = debug.extend('data');
+
+  const testReducerConfigs = reducerConfigs;
+  const reducers = [...testReducerConfigs.map(conf => Reducers.copy(conf))];
+
+  debugData(`Reducers: ${inspect(reducers, {colors: true, maxArrayLength: 10, depth: 8})})}`);
+
+  const result = merger({base, source, reducers});
+
+  debug(`Merge result is: ${result.constructor.name}`);
+  debugData(`${JSON.stringify(result)}`);
+
+  // Use either result.base or a plain result as resultRecord
+  // It can also be a MarcRecord or a plain object
+  const resultRecord = result.base || result;
+  const resultRecordToRecord = new MarcRecord(resultRecord, {subfieldValues: false});
+  expect(resultRecordToRecord.toObject()).to.eql(expectedRecord);
+
+
+}

package/src/reducers/copy.js

@@ -9,6 +9,8 @@ export default ({
   compareTagsOnly = false,
   compareWithoutTag = false,
   compareWithoutIndicators = false,
+  compareWithoutIndicator1 = false,
+  compareWithoutIndicator2 = false,
   subfieldsMustBeIdentical = true,
   excludeSubfields = [],
   dropSubfields = [],
@@ -19,15 +21,37 @@ export default ({
   swapSubfieldCode = [],
   doNotCopyIfFieldPresent = false
 }) => (base, source) => {
-  const baseRecord = new MarcRecord(base, baseValidators);
-  const sourceRecord = new MarcRecord(source, sourceValidators);
 
-  const debug = createDebugLogger('@natlibfi/marc-record-merge');
+  const debug = createDebugLogger('@natlibfi/marc-record-merge:copy');
+  const debugData = debug.extend('data');
   const debugOptions = createDebugLogger('@natlibfi/marc-record-merge:compare-options');
   const debugCompare = createDebugLogger('@natlibfi/marc-record-merge:compare');
+
+  debugData(`base: ${JSON.stringify(base)}`);
+  debugData(`source: ${JSON.stringify(source)}`);
+
+  const {baseRecord, sourceRecord} = getRecordsFromParameters(base, source, baseValidators, sourceValidators);
+
+  function getRecordsFromParameters(base, source, baseValidators, sourceValidators) {
+    // records if we got an object ({base, source}) as a parameter
+    if (source === undefined && base.base !== undefined && base.source !== undefined) {
+      const baseRecord = new MarcRecord(base.base, baseValidators);
+      const sourceRecord = new MarcRecord(base.source, sourceValidators);
+      return {baseRecord, sourceRecord};
+    }
+    // records if we got an non-object (base, source) as a parameter
+    const baseRecord = new MarcRecord(base, baseValidators);
+    const sourceRecord = new MarcRecord(source, sourceValidators);
+    return {baseRecord, sourceRecord};
+  }
+
+  const ignoreInd1 = compareWithoutIndicators || compareWithoutIndicator1;
+  const ignoreInd2 = compareWithoutIndicators || compareWithoutIndicator2;
+
   debugOptions(`Tag Pattern: ${tagPattern}`);
   debugOptions(`Compare tags only: ${compareTagsOnly}`);
-  debugOptions(`Compare without indicators ${compareWithoutIndicators}`);
+  debugOptions(`Omit indicator 1 from comparison: ${ignoreInd1}`);
+  debugOptions(`Omit indicator 2 from comparison: ${ignoreInd2}`);
   debugOptions(`Copy if identical: ${subfieldsMustBeIdentical}`);
   debugOptions(`Exclude subfields: [${excludeSubfields}]`);
   debugOptions(`Drop subfields [${dropSubfields}]`);
@@ -40,7 +64,7 @@ export default ({
   if (doNotCopy) {
     return baseRecord.toObject();
   }
-
+  debug(`FFS: ${compareWithoutIndicator1}, ${compareWithoutIndicators}, ${ignoreInd1}`);
   debug(`Base fields: `, baseFields);
   debug(`Source fields: `, sourceFields);
 
@@ -57,6 +81,8 @@ export default ({
 
   // Add fields to base;
   uniqueFields.forEach(field => baseRecord.insertField(field));
+  debugData(`baseRecord before return: ${JSON.stringify(baseRecord)}`);
+  //return baseRecord;
   return baseRecord.toObject();
 
   function compareFields(sourceFields, baseCompareFields, uniqFields = []) {
@@ -132,7 +158,7 @@ export default ({
     }
   }
 
-  // compare objects have only fields that matter in comparing
+  // compare objects have only fields that matter in comparison
   function createCompareField(field) {
     if (compareTagsOnly) {
       return {tag: field.tag};
@@ -148,8 +174,8 @@ export default ({
 
     const params = [
       {name: 'tag', value: compareWithoutTag ? replacementTag : field.tag},
-      {name: 'ind1', value: compareWithoutIndicators ? undefined : field.ind1},
-      {name: 'ind2', value: compareWithoutIndicators ? undefined : field.ind2},
+      {name: 'ind1', value: ignoreInd1 ? undefined : field.ind1},
+      {name: 'ind2', value: ignoreInd2 ? undefined : field.ind2},
       {name: 'subfields', value: createCompareSubfields(filteredField.subfields)}
     ].map(param => [param.name, param.value]);
 

package/src/reducers/copy.spec.js

@@ -23,6 +23,8 @@ function callback({
   compareTagsOnly = false,
   compareWithoutTag = false,
   compareWithoutIndicators = false,
+  compareWithoutIndicator1 = false,
+  compareWithoutIndicator2 = false,
   subfieldsMustBeIdentical = false,
   copyUnless = undefined,
   excludeSubfields = undefined,
@@ -37,7 +39,7 @@ function callback({
   const expectedRecord = getFixture('merged.json');
 
   const merged = createReducer({
-    tagPattern, compareTagsOnly, compareWithoutTag, compareWithoutIndicators,
+    tagPattern, compareTagsOnly, compareWithoutTag, compareWithoutIndicators, compareWithoutIndicator1, compareWithoutIndicator2,
     copyUnless, subfieldsMustBeIdentical, excludeSubfields,
     dropSubfields, swapSubfieldCode, swapTag,
     doNotCopyIfFieldPresent

package/src/reducers/copy2.spec.js

@@ -0,0 +1,55 @@
+import {expect} from 'chai';
+import {READERS} from '@natlibfi/fixura';
+import createReducer from './copy';
+import generateTests from '@natlibfi/fixugen';
+
+//import createDebugLogger from 'debug'; // <---
+//const debug = createDebugLogger('@natlibfi/marc-record-merge/copy.spec.js'); // <---
+
+generateTests({
+  callback,
+  path: [__dirname, '..', '..', 'test-fixtures', 'reducers', 'copy'],
+  useMetadataFile: true,
+  recurse: true,
+  fixura: {
+    reader: READERS.JSON,
+    failWhenNotFound: false
+  }
+});
+
+
+function callback({
+  getFixture,
+  tagPatternRegExp,
+  compareTagsOnly = false,
+  compareWithoutTag = false,
+  compareWithoutIndicators = false,
+  compareWithoutIndicator1 = false,
+  compareWithoutIndicator2 = false,
+  subfieldsMustBeIdentical = false,
+  copyUnless = undefined,
+  excludeSubfields = undefined,
+  dropSubfields = undefined,
+  swapSubfieldCode = [],
+  swapTag = [],
+  doNotCopyIfFieldPresent = false
+}) {
+  const base = getFixture('base.json');
+  const source = getFixture('source.json');
+  const tagPattern = new RegExp(tagPatternRegExp, 'u');
+  const expectedRecord = getFixture('merged.json');
+
+  const merged = createReducer({
+    tagPattern, compareTagsOnly, compareWithoutTag, compareWithoutIndicators, compareWithoutIndicator1, compareWithoutIndicator2,
+    copyUnless, subfieldsMustBeIdentical, excludeSubfields,
+    dropSubfields, swapSubfieldCode, swapTag,
+    doNotCopyIfFieldPresent
+  })({base, source});
+  //debug(`***     mergedRecord: `, mergedRecord); //<--
+  //debug(`***     mergedRecord,Strfy: `, JSON.stringify(mergedRecord)); //<--
+  //debug(`***     expectedRecord: `, expectedRecord); //<--
+  //debug(`***     expectedRecord,Strfy: `, JSON.stringify(expectedRecord)); //<--
+  expect(merged.constructor.name).not.to.eql('MarcRecord');
+  expect(merged.constructor.name).to.eql('Object');
+  expect(merged).to.eql(expectedRecord);
+}

package/src/reducers/select.js

@@ -12,10 +12,31 @@ export function subsetEquality(subfieldA, subfieldB) {
     (subfieldA.value.indexOf(subfieldB.value) !== -1 || subfieldB.value.indexOf(subfieldA.value) !== -1);
 }
 // EqualityFunction can be either strictEquality or subsetEquality
-export default ({tagPattern, equalityFunction = strictEquality}) => (base, source) => {
+
+export default ({
+  tagPattern,
+  equalityFunction = strictEquality,
+  baseValidators = {subfieldValues: false},
+  sourceValidators = {subfieldValues: false}
+// eslint-disable-next-line max-statements
+}) => (base, source) => {
   const debug = createDebugLogger('@natlibfi/marc-record-merge:select');
-  const baseRecord = new MarcRecord(base, {subfieldValues: false});
-  const sourceRecord = new MarcRecord(source, {subfieldValues: false});
+
+  const {baseRecord, sourceRecord} = getRecordsFromParameters(base, source, baseValidators, sourceValidators);
+
+  function getRecordsFromParameters(base, source, baseValidators, sourceValidators) {
+    // records if we got an object ({base, source}) as a parameter
+    if (source === undefined && base.base !== undefined && base.source !== undefined) {
+      const baseRecord = new MarcRecord(base.base, baseValidators);
+      const sourceRecord = new MarcRecord(base.source, sourceValidators);
+      return {baseRecord, sourceRecord};
+    }
+    // records if we got an non-object (base, source) as a parameter
+    const baseRecord = new MarcRecord(base, baseValidators);
+    const sourceRecord = new MarcRecord(source, sourceValidators);
+    return {baseRecord, sourceRecord};
+  }
+
   const baseFields = baseRecord.get(tagPattern);
   const sourceFields = sourceRecord.get(tagPattern);
   const fieldTag = sourceFields.map(field => field.tag);
@@ -27,7 +48,7 @@ export default ({tagPattern, equalityFunction = strictEquality}) => (base, sourc
   if (baseFields.length > 1 || sourceFields.length > 1) {
     debug(`Multiple fields in base or source`);
     debug(`No changes to base`);
-    return base;
+    return baseRecord.toObject();
   }
   const [baseField] = baseFields;
   const [sourceField] = sourceFields;
@@ -35,7 +56,7 @@ export default ({tagPattern, equalityFunction = strictEquality}) => (base, sourc
   if (baseField.tag === sourceField.tag === false) {
     debug(`Base tag ${baseField.tag} is not equal to source tag ${sourceField.tag}`);
     debug(`No changes to base`);
-    return base;
+    return baseRecord.toObject();
   }
   const baseSubs = baseField.subfields;
   const sourceSubs = sourceField.subfields;
@@ -61,7 +82,7 @@ export default ({tagPattern, equalityFunction = strictEquality}) => (base, sourc
   if (baseSubs.length === sourceSubs.length && equalSubfieldsBase.length < baseSubs.length) {
     debug(`Base and source subfields are not equal`);
     debug(`No changes to base`);
-    return base;
+    return baseRecord.toObject();
   }
 
   if (baseSubs.length === sourceSubs.length && equalSubfieldsBase.length === equalSubfieldsSource.length) {
@@ -74,16 +95,16 @@ export default ({tagPattern, equalityFunction = strictEquality}) => (base, sourc
       .reduce((acc, value) => acc + value);
 
     if (totalSubfieldLengthSource > totalSubfieldLengthBase) {
-      return replaceBasefieldWithSourcefield(base);
+      return replaceBasefieldWithSourcefield(baseRecord.toObject());
     }
   }
 
   if (sourceSubs.length > baseSubs.length && equalSubfieldsBase.length === baseSubs.length) {
-    return replaceBasefieldWithSourcefield(base);
+    return replaceBasefieldWithSourcefield(baseRecord.toObject());
   }
 
   debug(`No changes to base`);
-  return base;
+  return baseRecord.toObject();
 
   function replaceBasefieldWithSourcefield(base) {
     const index = base.fields.findIndex(field => field === baseField);
@@ -94,7 +115,7 @@ export default ({tagPattern, equalityFunction = strictEquality}) => (base, sourc
 
   function checkFieldType(fields) {
     const checkedFields = fields.map(field => {
-      if ('value' in field) { // eslint-disable-line functional/no-conditional-statement
+      if ('value' in field) { // eslint-disable-line functional/no-conditional-statements
         throw new Error('Invalid control field, expected data field');
       }
       return field;

package/src/reducers/select2.spec.js

@@ -0,0 +1,49 @@
+import {expect} from 'chai';
+import {MarcRecord} from '@natlibfi/marc-record';
+import createReducer, {subsetEquality} from './select';
+import {READERS} from '@natlibfi/fixura';
+import generateTests from '@natlibfi/fixugen';
+
+MarcRecord.setValidationOptions({subfieldValues: false});
+
+generateTests({
+  callback,
+  path: [__dirname, '..', '..', 'test-fixtures', 'reducers', 'select'],
+  useMetadataFile: true,
+  recurse: false,
+  fixura: {
+    reader: READERS.JSON,
+    failWhenNotFound: false
+  }
+});
+
+function callback({
+  getFixture,
+  disabled = false,
+  tagPatternRegExp = false,
+  expectedError = false,
+  useSubsetEquality = false
+}) {
+  if (disabled) {
+    console.log('TEST DISABLED!'); // eslint-disable-line no-console
+    return;
+  }
+  //  const base = new MarcRecord(getFixture('base.json'), {subfieldValues: false});
+  //  const source = new MarcRecord(getFixture('source.json'), {subfieldValues: false});
+
+  const base = getFixture('base.json');
+  const source = getFixture('source.json');
+
+  const tagPattern = new RegExp(tagPatternRegExp, 'u');
+  const expectedRecord = getFixture('merged.json');
+  const equalityFunction = useSubsetEquality ? subsetEquality : undefined;
+
+  // Bypass expected error in testing
+  if (expectedError) {
+    expect(() => createReducer.to.throw(Error, 'control field'));
+    return;
+  }
+
+  const mergedRecord = createReducer({tagPattern, equalityFunction})({base, source});
+  expect(mergedRecord).to.eql(expectedRecord);
+}

package/test-fixtures/index/01/base.json

@@ -0,0 +1,24 @@
+{
+  "leader": "01331cam a22003494i 4500",
+  "fields": [
+    {
+      "tag": "001",
+      "value": "001_base"
+    },
+    {
+      "tag": "010",
+      "ind1": " ",
+      "ind2": " ",
+      "subfields": [
+        {
+          "code": "a",
+          "value": "010a_base"
+        },
+        {
+          "code": "b",
+          "value": "010b_base"
+        }
+      ]
+    }
+  ]
+}

package/test-fixtures/index/01/merged.json

@@ -0,0 +1,24 @@
+{
+  "leader": "01331cam a22003494i 4500",
+  "fields": [
+    {
+      "tag": "001",
+      "value": "001_base"
+    },
+    {
+      "tag": "010",
+      "ind1": " ",
+      "ind2": " ",
+      "subfields": [
+        {
+          "code": "a",
+          "value": "010a_base"
+        },
+        {
+          "code": "b",
+          "value": "010b_base"
+        }
+      ]
+    }
+  ]
+}

package/test-fixtures/index/01/metadata.json

@@ -0,0 +1,8 @@
+{
+  "description":"Reducers should run after each another - two reducers",
+  "reducerConfigs": [
+    {"tagPattern": "/010/u", "compareTagsOnly": true},
+    {"tagPattern": "/33./u"}
+
+  ]
+}

package/test-fixtures/index/01/source.json

@@ -0,0 +1,40 @@
+{
+  "leader": "01331cam a22003494i 4500",
+  "fields": [
+    {
+      "tag": "001",
+      "value": "001_sorsa"
+    },
+    {
+      "tag": "010",
+      "ind1": " ",
+      "ind2": " ",
+      "subfields": [
+        {
+          "code": "a",
+          "value": "010a_sorsa"
+        },
+        {
+          "code": "b",
+          "value": "010b_sorsa"
+        }
+      ]
+    },
+    {
+      "tag": "650",
+      "ind1": " ",
+      "ind2": "7",
+      "subfields": [
+        {
+          "code": "a",
+          "value": "poista mut"
+        },
+        {
+          "code": "2",
+          "value": "ysa"
+        }
+      ]
+    }
+
+  ]
+}

package/test-fixtures/index/02/base.json

@@ -0,0 +1,24 @@
+{
+  "leader": "01331cam a22003494i 4500",
+  "fields": [
+    {
+      "tag": "001",
+      "value": "001_base"
+    },
+    {
+      "tag": "010",
+      "ind1": " ",
+      "ind2": " ",
+      "subfields": [
+        {
+          "code": "a",
+          "value": "010a_base"
+        },
+        {
+          "code": "b",
+          "value": "010b_base"
+        }
+      ]
+    }
+  ]
+}

package/test-fixtures/index/02/merged.json

@@ -0,0 +1,24 @@
+{
+  "leader": "01331cam a22003494i 4500",
+  "fields": [
+    {
+      "tag": "001",
+      "value": "001_base"
+    },
+    {
+      "tag": "010",
+      "ind1": " ",
+      "ind2": " ",
+      "subfields": [
+        {
+          "code": "a",
+          "value": "010a_base"
+        },
+        {
+          "code": "b",
+          "value": "010b_base"
+        }
+      ]
+    }
+  ]
+}

package/test-fixtures/index/02/metadata.json

@@ -0,0 +1,7 @@
+{
+  "description":"Reducers should run after each another - single reducer",
+  "reducerConfigs": [
+    {"tagPattern": "/33./u"}
+  ],
+  "skip": false
+}

package/test-fixtures/index/02/source.json

@@ -0,0 +1,40 @@
+{
+  "leader": "01331cam a22003494i 4500",
+  "fields": [
+    {
+      "tag": "001",
+      "value": "001_sorsa"
+    },
+    {
+      "tag": "010",
+      "ind1": " ",
+      "ind2": " ",
+      "subfields": [
+        {
+          "code": "a",
+          "value": "010a_sorsa"
+        },
+        {
+          "code": "b",
+          "value": "010b_sorsa"
+        }
+      ]
+    },
+    {
+      "tag": "650",
+      "ind1": " ",
+      "ind2": "7",
+      "subfields": [
+        {
+          "code": "a",
+          "value": "poista mut"
+        },
+        {
+          "code": "2",
+          "value": "ysa"
+        }
+      ]
+    }
+
+  ]
+}

package/test-fixtures/reducers/copy/04 - compareWithoutIndicators/03/metadata.json

@@ -0,0 +1,6 @@
+{
+    "description": "Copy fields 730: omit ind 1 from comparison - same field no copy",
+    "tagPatternRegExp": "^730$",
+    "compareWithoutIndicator1": true,
+    "skip": true
+}