@natlibfi/marc-record-merge 6.0.0-beta.2 → 6.0.0-beta.4

package/src/reducers/select.spec.js

@@ -1,66 +1,45 @@
-/**
-*
-* @licstart  The following is the entire license notice for the JavaScript code in this file.
-*
-* Merge MARC records
-*
-* Copyright (C) 2015-2019 University Of Helsinki (The National Library Of Finland)
-*
-* This file is part of marc-record-merge-js
-
-* marc-record-merge-js program is free software: you can redistribute it and/or modify
-* it under the terms of the GNU Lesser General Public License as
-* published by the Free Software Foundation, either version 3 of the
-* License, or (at your option) any later version.
-*
-* marc-record-merge-js is distributed in the hope that it will be useful,
-* but WITHOUT ANY WARRANTY; without even the implied warranty of
-* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-* GNU Lesser General Public License for more details.
-*
-* You should have received a copy of the GNU Lesser General Public License
-* along with this program.  If not, see <http://www.gnu.org/licenses/>.
-*
-* @licend  The above is the entire license notice
-* for the JavaScript code in this file.
-*
-*/
-import chai from 'chai';
-import fs from 'fs';
-import path from 'path';
+import {expect} from 'chai';
 import {MarcRecord} from '@natlibfi/marc-record';
 import createReducer, {subsetEquality} from './select';
-import fixturesFactory, {READERS} from '@natlibfi/fixura';
+import {READERS} from '@natlibfi/fixura';
+import generateTests from '@natlibfi/fixugen';
 
 MarcRecord.setValidationOptions({subfieldValues: false});
 
-describe('reducers/select', () => {
-  const {expect} = chai;
-  const fixturesPath = path.join(__dirname, '..', '..', 'test-fixtures', 'reducers', 'select');
+generateTests({
+  callback,
+  path: [__dirname, '..', '..', 'test-fixtures', 'reducers', 'select'],
+  useMetadataFile: true,
+  recurse: false,
+  fixura: {
+    reader: READERS.JSON,
+    failWhenNotFound: false
+  }
+});
 
-  fs.readdirSync(fixturesPath).forEach(subDir => {
-    const {getFixture} = fixturesFactory({root: [fixturesPath, subDir], reader: READERS.JSON, failWhenNotFound: false});
-    it(subDir, () => {
-      const base = new MarcRecord(getFixture('base.json'));
-      const source = new MarcRecord(getFixture('source.json'));
-      const tagPattern = new RegExp(getFixture({components: ['pattern.txt'], reader: READERS.TEXT}), 'u');
-      const expectedRecord = getFixture('merged.json');
-      const expectedError = getFixture({components: ['expected-error.txt'], reader: READERS.TEXT});
-      const equalityFunction = getEqualityFunction();
+function callback({
+  getFixture,
+  disabled = false,
+  tagPatternRegExp = false,
+  expectedError = false,
+  useSubsetEquality = false
+}) {
+  if (disabled) {
+    console.log('TEST DISABLED!'); // eslint-disable-line no-console
+    return;
+  }
+  const base = new MarcRecord(getFixture('base.json'), {subfieldValues: false});
+  const source = new MarcRecord(getFixture('source.json'), {subfieldValues: false});
+  const tagPattern = new RegExp(tagPatternRegExp, 'u');
+  const expectedRecord = getFixture('merged.json');
+  const equalityFunction = useSubsetEquality ? subsetEquality : undefined;
 
-      // Bypass expected error in testing
-      if (expectedError) {
-        expect(() => createReducer.to.throw(Error, 'control field'));
-        return;
-      }
-      const mergedRecord = createReducer({tagPattern, equalityFunction})(base, source);
-      expect(mergedRecord.toObject()).to.eql(expectedRecord);
+  // Bypass expected error in testing
+  if (expectedError) {
+    expect(() => createReducer.to.throw(Error, 'control field'));
+    return;
+  }
 
-      // Choose which equality function to use
-      function getEqualityFunction() {
-        const functionName = getFixture({components: ['equalityFunction.txt'], reader: READERS.TEXT});
-        return functionName === 'subsetEquality' ? subsetEquality : undefined;
-      }
-    });
-  });
-});
+  const mergedRecord = createReducer({tagPattern, equalityFunction})(base, source);
+  expect(mergedRecord.toObject()).to.eql(expectedRecord);
+}

package/test-fixtures/reducers/copy/{01/base.json → basic copy/01/base.json }

@@ -4,6 +4,6 @@
         {
             "tag": "001",
             "value": "007346734"
-        }       
+        }
     ]
 }

package/test-fixtures/reducers/copy/basic copy/01/metadata.json

@@ -0,0 +1,5 @@
+{
+    "description": "If base does not contain the field at all, it is copied from source to base",
+    "tagPatternRegExp": "^010$",
+    "disabled": false
+}

package/test-fixtures/reducers/copy/basic copy/02/metadata.json

@@ -0,0 +1,5 @@
+{
+    "description": "Identical control fields are not copied",
+    "tagPatternRegExp": "^001$",
+    "disabled": false
+}

package/test-fixtures/reducers/copy/{02/base.json → basic copy/02/source.json }

@@ -15,6 +15,6 @@
                     "value": "##2002021346"
                 }
             ]
-        }       
+        }
     ]
 }

package/test-fixtures/reducers/copy/{03/base.json → basic copy/03/base.json }

@@ -15,6 +15,6 @@
                     "value": "##2002021346"
                 }
             ]
-        }       
+        }
     ]
 }

package/test-fixtures/reducers/copy/basic copy/03/metadata.json

@@ -0,0 +1,5 @@
+{
+    "description": "Add missing control field to base",
+    "tagPatternRegExp": "^001$",
+    "disabled": false
+}

package/test-fixtures/reducers/copy/{05/base.json → basic copy/04/base.json }

@@ -34,6 +34,6 @@
                     "value": "##2002021357"
                 }
             ]
-        }       
+        }
     ]
 }

package/test-fixtures/reducers/copy/{04/merged.json → basic copy/04/merged.json }

@@ -34,6 +34,6 @@
                     "value": "##2002021357"
                 }
             ]
-        }       
+        }
     ]
 }

package/test-fixtures/reducers/copy/basic copy/04/metadata.json

@@ -0,0 +1,5 @@
+{
+    "description": "Identical data fields in base and source, not copied",
+    "tagPatternRegExp": "^010$",
+    "disabled": false
+}

package/test-fixtures/reducers/copy/{04/source.json → basic copy/04/source.json }

@@ -34,6 +34,6 @@
                     "value": "##2002021357"
                 }
             ]
-        }       
+        }
     ]
 }

package/test-fixtures/reducers/copy/{04/base.json → basic copy/05/base.json }

@@ -34,6 +34,6 @@
                     "value": "##2002021357"
                 }
             ]
-        }       
+        }
     ]
 }

package/test-fixtures/reducers/copy/basic copy/05/metadata.json

@@ -0,0 +1,5 @@
+{
+    "description": "Different data fields are copied from source to base (multiple fields)",
+    "tagPatternRegExp": "^010$",
+    "disabled": false
+}

package/test-fixtures/reducers/copy/basic copy/06/base.json

@@ -0,0 +1,24 @@
+{
+    "leader": "01331cam a22003494i 4500",
+    "fields": [
+        {
+            "tag": "001",
+            "value": "007346734"
+        },
+        {
+            "tag": "010",
+            "ind1": " ",
+            "ind2": " ",
+            "subfields": [
+                {
+                    "code": "a",
+                    "value": "##2002021346"
+                },
+                {
+                    "code": "b",
+                    "value": "##2002021356"
+                }
+            ]
+        }
+    ]
+}

package/test-fixtures/reducers/copy/basic copy/06/merged.json

@@ -0,0 +1,39 @@
+{
+    "leader": "01331cam a22003494i 4500",
+    "fields": [
+        {
+            "tag": "001",
+            "value": "007346734"
+        },
+        {
+            "tag": "010",
+            "ind1": " ",
+            "ind2": " ",
+            "subfields": [
+                {
+                    "code": "a",
+                    "value": "##2002021346"
+                },
+                {
+                    "code": "b",
+                    "value": "##2002021356"
+                }
+            ]
+        },
+        {
+            "tag": "010",
+            "ind1": " ",
+            "ind2": "1",
+            "subfields": [
+                {
+                    "code": "a",
+                    "value": "##2002021346"
+                },
+                {
+                    "code": "b",
+                    "value": "##2002021356"
+                }
+            ]
+        }
+    ]
+}

package/test-fixtures/reducers/copy/basic copy/06/metadata.json

@@ -0,0 +1,5 @@
+{
+    "description": "Different data fields are copied from source to base (Ind2 diff)",
+    "tagPatternRegExp": "^010$",
+    "disabled": false
+}

package/test-fixtures/reducers/copy/basic copy/06/source.json

@@ -0,0 +1,24 @@
+{
+    "leader": "01331cam a22003494i 4500",
+    "fields": [
+        {
+            "tag": "001",
+            "value": "007346734"
+        },
+        {
+            "tag": "010",
+            "ind1": " ",
+            "ind2": "1",
+            "subfields": [
+                {
+                    "code": "a",
+                    "value": "##2002021346"
+                },
+                {
+                    "code": "b",
+                    "value": "##2002021356"
+                }
+            ]
+        }
+    ]
+}

package/test-fixtures/reducers/copy/compareTagsOnly/01/metadata.json

@@ -0,0 +1,6 @@
+{
+    "description": "Field is copied from source only if it is missing in base, a different instance is not copied",
+    "tagPatternRegExp": "^018$",
+    "compareTagsOnly": true,
+    "disabled": false
+}

package/test-fixtures/reducers/copy/compareTagsOnly/02/metadata.json

@@ -0,0 +1,6 @@
+{
+    "description": "for repeatable fields, 2x each 260/264",
+    "tagPatternRegExp": "^(260|264)$",
+    "compareTagsOnly": true,
+    "disabled": false
+}

package/test-fixtures/reducers/copy/compareWithoutIndicators/01/base.json

@@ -0,0 +1,24 @@
+{
+    "leader": "01331cam a22003494i 4500",
+    "fields": [
+        {
+            "tag": "001",
+            "value": "007346734"
+        },
+        {
+            "tag": "010",
+            "ind1": " ",
+            "ind2": " ",
+            "subfields": [
+                {
+                    "code": "a",
+                    "value": "foo"
+                },
+                {
+                    "code": "b",
+                    "value": "bar"
+                }
+            ]
+        }
+    ]
+}

package/test-fixtures/reducers/copy/compareWithoutIndicators/01/merged.json

@@ -0,0 +1,24 @@
+{
+    "leader": "01331cam a22003494i 4500",
+    "fields": [
+        {
+            "tag": "001",
+            "value": "007346734"
+        },
+        {
+            "tag": "010",
+            "ind1": " ",
+            "ind2": " ",
+            "subfields": [
+                {
+                    "code": "a",
+                    "value": "foo"
+                },
+                {
+                    "code": "b",
+                    "value": "bar"
+                }
+            ]
+        }
+    ]
+}

package/test-fixtures/reducers/copy/compareWithoutIndicators/01/metadata.json

@@ -0,0 +1,6 @@
+{
+    "description": "Copy fields 010 compare without indicators - same field no copy",
+    "tagPatternRegExp": "^010$",
+    "compareWithoutIndicators": true,
+    "disabled": false
+}

package/test-fixtures/reducers/copy/compareWithoutIndicators/01/source.json

@@ -0,0 +1,24 @@
+{
+    "leader": "01331cam a22003494i 4500",
+    "fields": [
+        {
+            "tag": "001",
+            "value": "007346734"
+        },
+        {
+            "tag": "010",
+            "ind1": "1",
+            "ind2": "2",
+            "subfields": [
+                {
+                    "code": "a",
+                    "value": "foo"
+                },
+                {
+                    "code": "b",
+                    "value": "bar"
+                }
+            ]
+        }
+    ]
+}

package/test-fixtures/reducers/copy/compareWithoutIndicators/02/base.json

@@ -0,0 +1,24 @@
+{
+    "leader": "01331cam a22003494i 4500",
+    "fields": [
+        {
+            "tag": "001",
+            "value": "007346734"
+        },
+        {
+            "tag": "010",
+            "ind1": "1",
+            "ind2": " ",
+            "subfields": [
+                {
+                    "code": "a",
+                    "value": "foo"
+                },
+                {
+                    "code": "b",
+                    "value": "bar"
+                }
+            ]
+        }
+    ]
+}

package/test-fixtures/reducers/copy/compareWithoutIndicators/02/merged.json

@@ -0,0 +1,39 @@
+{
+    "leader": "01331cam a22003494i 4500",
+    "fields": [
+        {
+            "tag": "001",
+            "value": "007346734"
+        },
+        {
+            "tag": "010",
+            "ind1": "1",
+            "ind2": " ",
+            "subfields": [
+                {
+                    "code": "a",
+                    "value": "foo"
+                },
+                {
+                    "code": "b",
+                    "value": "bar"
+                }
+            ]
+        },
+        {
+            "tag": "010",
+            "ind1": " ",
+            "ind2": "2",
+            "subfields": [
+                {
+                    "code": "a",
+                    "value": "foo"
+                },
+                {
+                    "code": "b",
+                    "value": "bar"
+                }
+            ]
+        }
+    ]
+}

package/test-fixtures/reducers/copy/compareWithoutIndicators/02/metadata.json

@@ -0,0 +1,6 @@
+{
+    "description": "Copy fields 010 compare with indicators - different field copy",
+    "tagPatternRegExp": "^010$",
+    "compareWithoutIndicators": false,
+    "disabled": false
+}

package/test-fixtures/reducers/copy/compareWithoutIndicators/02/source.json

@@ -0,0 +1,24 @@
+{
+    "leader": "01331cam a22003494i 4500",
+    "fields": [
+        {
+            "tag": "001",
+            "value": "007346734"
+        },
+        {
+            "tag": "010",
+            "ind1": " ",
+            "ind2": "2",
+            "subfields": [
+                {
+                    "code": "a",
+                    "value": "foo"
+                },
+                {
+                    "code": "b",
+                    "value": "bar"
+                }
+            ]
+        }
+    ]
+}

package/test-fixtures/reducers/copy/copyUnless/01/base.json

@@ -0,0 +1,9 @@
+{
+    "leader": "01331cam a22003494i 4500",
+    "fields": [
+        {
+            "tag": "001",
+            "value": "007346734"
+        }
+    ]
+}

package/test-fixtures/reducers/copy/copyUnless/01/merged.json

@@ -0,0 +1,24 @@
+{
+    "leader": "01331cam a22003494i 4500",
+    "fields": [
+        {
+            "tag": "001",
+            "value": "007346734"
+        },
+        {
+            "tag": "010",
+            "ind1": " ",
+            "ind2": " ",
+            "subfields": [
+                {
+                    "code": "a",
+                    "value": "##2002021346"
+                },
+                {
+                    "code": "b",
+                    "value": "##2002021356"
+                }
+            ]
+        }
+    ]
+}

package/test-fixtures/reducers/copy/copyUnless/01/metadata.json

@@ -0,0 +1,6 @@
+{
+    "description": "Copy fields unless contains subfields - {code: 9, value: MALLI<DROP>}",
+    "tagPatternRegExp": "^010$",
+    "copyUnless": [{"code": "9", "value": "MALLI<DROP>"}],
+    "disabled": false
+}

package/test-fixtures/reducers/copy/copyUnless/01/source.json

@@ -0,0 +1,47 @@
+{
+    "leader": "01331cam a22003494i 4500",
+    "fields": [
+        {
+            "tag": "001",
+            "value": "007346734"
+        },
+        {
+            "tag": "010",
+            "ind1": " ",
+            "ind2": " ",
+            "subfields": [
+                {
+                    "code": "a",
+                    "value": "##2002021346"
+                },
+                {
+                    "code": "b",
+                    "value": "##2002021356"
+                }
+            ]
+        },
+        {
+            "tag": "010",
+            "ind1": " ",
+            "ind2": " ",
+            "subfields": [
+                {
+                    "code": "c",
+                    "value": "##2002021348"
+                },
+                {
+                    "code": "d",
+                    "value": "##2002021358"
+                },
+                {
+                    "code": "e",
+                    "value": "##2002021359"
+                },
+                {
+                    "code": "9",
+                    "value": "MALLI<DROP>"
+                }
+            ]
+        }
+    ]
+}

package/test-fixtures/reducers/copy/{08 → dropSubfields/01}/merged.json

@@ -36,6 +36,14 @@
             "ind1": " ",
             "ind2": " ",
             "subfields": [
+                {
+                    "code": "c",
+                    "value": "##2002021348"
+                },
+                {
+                    "code": "d",
+                    "value": "##2002021358"
+                },
                 {
                     "code": "f",
                     "value": "##2002021361"

package/test-fixtures/reducers/copy/dropSubfields/01/metadata.json

@@ -0,0 +1,6 @@
+{
+    "description": "Drop subfields from source before copying",
+    "tagPatternRegExp": "^010$",
+    "dropSubfields": ["c", "d"],
+    "disabled": false
+}