@nativescript/windows 0.1.0-alpha.5 → 0.1.0-alpha.50

package/build.ps1

@@ -119,14 +119,16 @@ foreach ($t in $Targets) {
 
     if (-not $SkipRelease) {
         Write-Host "`n=== Release ($arch) ===" -ForegroundColor Cyan
-        Build-Crate -Profile "release" -Target $rustTarget
+        $releaseArgs = @()
+        Build-Crate -Profile "release" -Target $rustTarget -ExtraArgs $releaseArgs
         $dll = Join-Path $RepoRoot "target\$rustTarget\release\nativescript.dll"
         Copy-Dll -Src $dll -Dest (Join-Path $FrameworkLibs "$arch\nativescript.dll")
     }
 
     if (-not $SkipDevtools) {
         Write-Host "`n=== Release-with-devtools ($arch) ===" -ForegroundColor Cyan
-        Build-Crate -Profile "release-with-devtools" -Target $rustTarget -ExtraArgs @("--features", "devtools")
+        $devtoolsArgs = @("--features", "devtools")
+        Build-Crate -Profile "release-with-devtools" -Target $rustTarget -ExtraArgs $devtoolsArgs
         $dll = Join-Path $RepoRoot "target\$rustTarget\release-with-devtools\nativescript.dll"
         Copy-Dll -Src $dll -Dest (Join-Path $FrameworkLibs "devtools\$arch\nativescript.dll")
     }

package/framework/__PROJECT_NAME__/App.xaml.cs

@@ -19,46 +19,80 @@ namespace __PROJECT_NAME__
             this.UnhandledException += OnUnhandledException;
         }
 
-        protected override void OnLaunched(LaunchActivatedEventArgs e)
+        protected override async void OnLaunched(LaunchActivatedEventArgs e)
         {
             _runtimeHost.Initialize();
+
+            // Capture before any await — continuations may resume on a thread pool thread.
+            var dispatcher = Window.Current.Dispatcher;
+
+            // Show crash report from the previous run if one exists.
+            try
+            {
+                var panicLogPath = System.IO.Path.Combine(
+                    ApplicationData.Current.LocalFolder.Path, "nativescript-panic.log");
+                if (System.IO.File.Exists(panicLogPath))
+                {
+                    var content = System.IO.File.ReadAllText(panicLogPath);
+                    System.IO.File.Delete(panicLogPath);
+                    if (!string.IsNullOrWhiteSpace(content))
+                        await CrashDiagnostics.ShowCrashDialogAsync("Crash from previous run", content);
+                }
+            }
+            catch { }
+
+            string jsError = null;
             try
             {
                 _runtimeHost.RunMainScript();
+                jsError = _runtimeHost.GetLastJsError();
+                if (!string.IsNullOrEmpty(jsError))
+                {
+                    CrashDiagnostics.WriteMessage("JS Error", jsError);
+                    var report = CrashDiagnostics.BuildErrorReport(null, jsError);
+                    CrashDiagnostics.WriteToTraceLog(report);
+                    await CrashDiagnostics.ShowCrashDialogAsync("JavaScript Error", report);
+                }
             }
             catch (Exception scriptEx)
             {
+                jsError = _runtimeHost.GetLastJsError();
                 System.Diagnostics.Debug.WriteLine($"[NativeScript] Script exception: {scriptEx.Message}");
+                CrashDiagnostics.WriteExceptionReport("RunMainScript", scriptEx, null);
+                var report = CrashDiagnostics.BuildErrorReport(scriptEx, jsError);
+                CrashDiagnostics.WriteToTraceLog(report);
+                await CrashDiagnostics.ShowCrashDialogAsync("Script Execution Error", report);
             }
 
-#if DEBUG
-            Windows.UI.Xaml.Media.CompositionTarget.Rendering += OnRenderFrame;
-#endif
-
-            if (Window.Current.Content == null)
+            // After any await, the continuation may run on a thread pool thread.
+            // Schedule all UI-thread-required operations through the dispatcher.
+            _ = dispatcher.RunAsync(Windows.UI.Core.CoreDispatcherPriority.Normal, () =>
             {
-                Window.Current.Content = new Windows.UI.Xaml.Controls.TextBlock
+                Windows.UI.Xaml.Media.CompositionTarget.Rendering += OnRenderFrame;
+
+                if (Window.Current.Content == null)
                 {
-                    Text = "NativeScript runtime initialized but no UI was rendered.\n" +
-                           "Check the Output window for JS errors.",
-                    Margin = new Windows.UI.Xaml.Thickness(20),
-                    TextWrapping = Windows.UI.Xaml.TextWrapping.Wrap,
-                    FontSize = 16,
-                };
-            }
+                    Window.Current.Content = new Windows.UI.Xaml.Controls.TextBlock
+                    {
+                        Text = "NativeScript runtime initialized but no UI was rendered.\n" +
+                               "Check the Output window for JS errors.",
+                        Margin = new Windows.UI.Xaml.Thickness(20),
+                        TextWrapping = Windows.UI.Xaml.TextWrapping.Wrap,
+                        FontSize = 16,
+                    };
+                }
 
-            if (!e.PrelaunchActivated)
-            {
-                Window.Current.Activate();
-            }
+                if (!e.PrelaunchActivated)
+                {
+                    Window.Current.Activate();
+                }
+            });
         }
 
         private void OnSuspending(object sender, SuspendingEventArgs e)
         {
             var deferral = e.SuspendingOperation.GetDeferral();
-#if DEBUG
             Windows.UI.Xaml.Media.CompositionTarget.Rendering -= OnRenderFrame;
-#endif
             ApplicationData.Current.LocalSettings.Values[LastLaunchArgsKey] = string.Empty;
             _runtimeHost.Dispose();
             deferral.Complete();
@@ -66,14 +100,25 @@ namespace __PROJECT_NAME__
 
         private void OnUnhandledException(object sender, Windows.UI.Xaml.UnhandledExceptionEventArgs e)
         {
+            e.Handled = true;
+            var jsError = _runtimeHost.GetLastJsError();
             CrashDiagnostics.WriteExceptionReport(
                 "Xaml.UnhandledException",
                 e.Exception,
-                "Message=" + e.Message + "; Handled=" + e.Handled);
+                "JsError=" + (jsError ?? "<none>"));
+
+            var report = CrashDiagnostics.BuildErrorReport(e.Exception, jsError);
+            CrashDiagnostics.WriteToTraceLog(report);
+            var _ = CrashDiagnostics.ShowCrashDialogAsync(
+                e.Message ?? "Unhandled exception", report);
         }
 
+        private void OnRenderFrame(object sender, object e)
+        {
+            _runtimeHost.PumpTimers();
 #if DEBUG
-        private void OnRenderFrame(object sender, object e) => _runtimeHost.PumpDevtools();
+            _runtimeHost.PumpDevtools();
 #endif
+        }
     }
 }

package/framework/__PROJECT_NAME__/CrashDiagnostics.cs

@@ -1,66 +1,249 @@
-using System;
-using System.IO;
-using System.Text;
-using System.Threading.Tasks;
-using Windows.Storage;
-
-namespace __PROJECT_NAME__
-{
-    internal static class CrashDiagnostics
-    {
-        private static bool _installed;
-
-        public static void InstallGlobalHandlers()
-        {
-            if (_installed) return;
-            _installed = true;
-
-            AppDomain.CurrentDomain.UnhandledException += (_, args) =>
-            {
-                var ex = args.ExceptionObject as Exception;
-                WriteExceptionReport("AppDomain.UnhandledException", ex, "IsTerminating=" + args.IsTerminating);
-            };
-
-            TaskScheduler.UnobservedTaskException += (_, args) =>
-            {
-                WriteExceptionReport("TaskScheduler.UnobservedTaskException", args.Exception, null);
-            };
-        }
-
-        public static void WriteExceptionReport(string source, Exception ex, string details)
-        {
-            var sb = new StringBuilder();
-            sb.AppendLine("============================================================");
-            sb.AppendLine("Timestamp: " + DateTimeOffset.UtcNow.ToString("o"));
-            sb.AppendLine("Source: " + source);
-            if (!string.IsNullOrWhiteSpace(details)) sb.AppendLine("Details: " + details);
-            if (ex != null) { sb.AppendLine("Exception:"); sb.AppendLine(ex.ToString()); }
-            else sb.AppendLine("Exception: <null>");
-            sb.AppendLine("Managed stack snapshot:");
-            sb.AppendLine(Environment.StackTrace);
-            sb.AppendLine();
-            AppendToLog(sb.ToString());
-        }
-
-        public static void WriteMessage(string source, string message)
-        {
-            var sb = new StringBuilder();
-            sb.AppendLine("============================================================");
-            sb.AppendLine("Timestamp: " + DateTimeOffset.UtcNow.ToString("o"));
-            sb.AppendLine("Source: " + source);
-            sb.AppendLine("Message: " + message);
-            sb.AppendLine();
-            AppendToLog(sb.ToString());
-        }
-
-        private static void AppendToLog(string content)
-        {
-            try
-            {
-                var logPath = Path.Combine(ApplicationData.Current.LocalFolder.Path, "nativescript-crash.log");
-                File.AppendAllText(logPath, content, Encoding.UTF8);
-            }
-            catch { }
-        }
-    }
-}
+using System;
+using System.IO;
+using System.Text;
+using System.Text.RegularExpressions;
+using System.Threading.Tasks;
+using Windows.ApplicationModel.Core;
+using Windows.ApplicationModel.DataTransfer;
+using Windows.Storage;
+using Windows.System;
+using Windows.UI.Popups;
+
+namespace __PROJECT_NAME__
+{
+    internal static class CrashDiagnostics
+    {
+        private static bool _installed;
+
+        public static void InstallGlobalHandlers()
+        {
+            if (_installed) return;
+            _installed = true;
+
+            AppDomain.CurrentDomain.UnhandledException += (_, args) =>
+            {
+                var ex = args.ExceptionObject as Exception;
+                WriteExceptionReport("AppDomain.UnhandledException", ex, "IsTerminating=" + args.IsTerminating);
+            };
+
+            TaskScheduler.UnobservedTaskException += (_, args) =>
+            {
+                WriteExceptionReport("TaskScheduler.UnobservedTaskException", args.Exception, null);
+            };
+        }
+
+        public static void WriteExceptionReport(string source, Exception ex, string details)
+        {
+            var sb = new StringBuilder();
+            sb.AppendLine("============================================================");
+            sb.AppendLine("Timestamp: " + DateTimeOffset.UtcNow.ToString("o"));
+            sb.AppendLine("Source: " + source);
+            if (!string.IsNullOrWhiteSpace(details)) sb.AppendLine("Details: " + details);
+            if (ex != null) { sb.AppendLine("Exception:"); sb.AppendLine(ex.ToString()); }
+            else sb.AppendLine("Exception: <null>");
+            sb.AppendLine("Managed stack snapshot:");
+            sb.AppendLine(Environment.StackTrace);
+            sb.AppendLine();
+            AppendToLog(sb.ToString());
+        }
+
+        public static void WriteMessage(string source, string message)
+        {
+            var sb = new StringBuilder();
+            sb.AppendLine("============================================================");
+            sb.AppendLine("Timestamp: " + DateTimeOffset.UtcNow.ToString("o"));
+            sb.AppendLine("Source: " + source);
+            sb.AppendLine("Message: " + message);
+            sb.AppendLine();
+            AppendToLog(sb.ToString());
+        }
+
+        public static string BuildErrorReport(Exception ex, string jsError = null, string extraDetails = null)
+        {
+            var sb = new StringBuilder();
+
+            if (!string.IsNullOrWhiteSpace(jsError))
+            {
+                sb.AppendLine("── JavaScript Error ──────────────────────────────────────");
+                sb.AppendLine(jsError.Trim());
+                sb.AppendLine();
+            }
+
+            if (ex != null)
+            {
+                sb.AppendLine("── Native Exception ──────────────────────────────────────");
+                sb.AppendLine(ex.GetType().Name + ": " + ex.Message);
+                if (ex.StackTrace != null) sb.AppendLine(ex.StackTrace);
+                var inner = ex.InnerException;
+                while (inner != null)
+                {
+                    sb.AppendLine("Caused by: " + inner.GetType().Name + ": " + inner.Message);
+                    if (inner.StackTrace != null) sb.AppendLine(inner.StackTrace);
+                    inner = inner.InnerException;
+                }
+                sb.AppendLine();
+            }
+
+            // Include panic log from previous or current run
+            try
+            {
+                var panicLog = Path.Combine(ApplicationData.Current.LocalFolder.Path, "nativescript-panic.log");
+                if (File.Exists(panicLog))
+                {
+                    var content = File.ReadAllText(panicLog, Encoding.UTF8).Trim();
+                    if (!string.IsNullOrEmpty(content))
+                    {
+                        sb.AppendLine("── Rust Panic Log ────────────────────────────────────────");
+                        sb.AppendLine(content);
+                        sb.AppendLine();
+                    }
+                }
+            }
+            catch { }
+
+            if (!string.IsNullOrWhiteSpace(extraDetails))
+            {
+                sb.AppendLine("── Additional Info ───────────────────────────────────────");
+                sb.AppendLine(extraDetails);
+                sb.AppendLine();
+            }
+
+            sb.AppendLine("──────────────────────────────────────────────────────────");
+            sb.AppendLine("Timestamp: " + DateTimeOffset.UtcNow.ToString("o"));
+
+            return sb.ToString();
+        }
+
+        public static string CrashLogPath()
+        {
+            try { return Path.Combine(ApplicationData.Current.LocalFolder.Path, "nativescript-crash.log"); }
+            catch { return null; }
+        }
+
+        /// Parses the first "path:line:col" source location from a JS stack trace.
+        /// Returns null if none found. Handles Windows drive-letter paths (C:\...).
+        public static (string file, int line, int col)? TryExtractSourceLocation(string errorReport)
+        {
+            if (string.IsNullOrEmpty(errorReport)) return null;
+
+            // Match the contents of the first (path:line:col) group in the stack trace.
+            var m = Regex.Match(errorReport, @"\(([^)]+)\)");
+            if (!m.Success) return null;
+
+            var inner = m.Groups[1].Value; // e.g. "C:\app\bundle.js:42:13"
+
+            // Parse col from the right (last :digits).
+            var lastColon = inner.LastIndexOf(':');
+            if (lastColon < 0 || !int.TryParse(inner.Substring(lastColon + 1), out int col)) return null;
+            inner = inner.Substring(0, lastColon);
+
+            // Parse line from the right (second-to-last :digits).
+            lastColon = inner.LastIndexOf(':');
+            if (lastColon < 0 || !int.TryParse(inner.Substring(lastColon + 1), out int line)) return null;
+            var file = inner.Substring(0, lastColon);
+
+            return string.IsNullOrEmpty(file) ? null : (file, line, col);
+        }
+
+        public static async Task ShowCrashDialogAsync(string heading, string errorReport)
+        {
+            try
+            {
+                // Write full details to log so developer can access them even if the
+                // dialog summary is truncated.
+                var logPath = CrashLogPath();
+                if (logPath != null)
+                    File.WriteAllText(logPath, errorReport, Encoding.UTF8);
+
+                // Truncate for the dialog (MessageDialog has practical limits).
+                const int MaxLen = 800;
+                var summary = errorReport.Length > MaxLen
+                    ? errorReport.Substring(0, MaxLen) + "\n\n[truncated — see log for full details]"
+                    : errorReport;
+
+                if (logPath != null)
+                    summary += "\n\nFull log: " + logPath;
+
+                var dialog = new MessageDialog(summary, "NativeScript Runtime Error");
+
+                // MessageDialog supports at most 3 commands. When a source location is
+                // available, swap "Copy Details" for "Open in VS Code" so the user can
+                // choose between jumping to the error or restarting. Full details are
+                // always written to the log file shown in the dialog text.
+                var srcLocation = TryExtractSourceLocation(errorReport);
+                if (srcLocation.HasValue)
+                {
+                    var (srcFile, srcLine, srcCol) = srcLocation.Value;
+                    dialog.Commands.Add(new UICommand("Open Source File", async _ =>
+                    {
+                        try
+                        {
+                            var normalizedPath = srcFile.Replace('\\', '/');
+                            var uriStr = $"file:///{normalizedPath}";
+                            if (Uri.TryCreate(uriStr, UriKind.Absolute, out var fileUri))
+                                await Launcher.LaunchUriAsync(fileUri,
+                                    new LauncherOptions { DisplayApplicationPicker = true });
+                        }
+                        catch { }
+                    }));
+                }
+                else
+                {
+                    dialog.Commands.Add(new UICommand("Copy Details", _ =>
+                    {
+                        try
+                        {
+                            var dp = new DataPackage();
+                            dp.SetText(errorReport);
+                            Clipboard.SetContent(dp);
+                        }
+                        catch { }
+                    }));
+                }
+
+                dialog.Commands.Add(new UICommand("Restart App", async _ =>
+                {
+                    try { await CoreApplication.RequestRestartAsync("crash-restart"); }
+                    catch { }
+                }));
+
+                dialog.Commands.Add(new UICommand("Dismiss"));
+                dialog.DefaultCommandIndex = 0;
+                dialog.CancelCommandIndex = 2;
+
+                await dialog.ShowAsync();
+            }
+            catch (Exception ex)
+            {
+                System.Diagnostics.Debug.WriteLine("[NativeScript] Failed to show crash dialog: " + ex.Message);
+            }
+        }
+
+        /// <summary>
+        /// Appends <paramref name="message"/> to ns_trace.log using the Win32 temp path.
+        /// Inside UWP, GetTempPath() virtualises to AC\Temp — the same folder Rust's
+        /// std::env::temp_dir() uses — so this write appears in the CLI's log stream.
+        /// </summary>
+        public static void WriteToTraceLog(string message)
+        {
+            try
+            {
+                // System.IO.Path.GetTempPath() calls Win32 GetTempPathW() which inside a
+                // UWP process returns the container's AC\Temp folder, matching Rust.
+                var tracePath = Path.Combine(System.IO.Path.GetTempPath(), "ns_trace.log");
+                File.AppendAllText(tracePath, message, Encoding.UTF8);
+            }
+            catch { }
+        }
+
+        private static void AppendToLog(string content)
+        {
+            try
+            {
+                var logPath = Path.Combine(ApplicationData.Current.LocalFolder.Path, "nativescript-crash.log");
+                File.AppendAllText(logPath, content, Encoding.UTF8);
+            }
+            catch { }
+        }
+    }
+}

package/framework/__PROJECT_NAME__/Package.appxmanifest

@@ -2,17 +2,14 @@
 
 <Package
   xmlns="http://schemas.microsoft.com/appx/manifest/foundation/windows10"
-  xmlns:mp="http://schemas.microsoft.com/appx/2014/phone/manifest"
   xmlns:uap="http://schemas.microsoft.com/appx/manifest/uap/windows10"
-  IgnorableNamespaces="uap mp">
+  IgnorableNamespaces="uap">
 
   <Identity
     Name="__APP_IDENTIFIER__"
     Publisher="CN=__PROJECT_NAME__"
     Version="1.0.0.0" />
 
-  <mp:PhoneIdentity PhoneProductId="__APP_IDENTIFIER__" PhonePublisherId="00000000-0000-0000-0000-000000000000"/>
-
   <Properties>
     <DisplayName>__PROJECT_NAME__</DisplayName>
     <PublisherDisplayName>__PROJECT_NAME__</PublisherDisplayName>
@@ -24,7 +21,7 @@
   </Dependencies>
 
   <Resources>
-    <Resource Language="x-generate"/>
+    <Resource Language="en-US"/>
   </Resources>
 
   <Applications>