@nativescript/canvas 2.0.0-webgpu.3 → 2.0.0-webgpu.30

package/platforms/ios/src/cpp/webgpu/GPUDeviceImpl.h

@@ -36,6 +36,8 @@ public:
         return scope.Escape(object);
     }
 
+    static void GetLabel(v8::Local<v8::Name> name,
+                         const v8::PropertyCallbackInfo<v8::Value> &info);
 
     static void GetFeatures(v8::Local<v8::Name> name,
                             const v8::PropertyCallbackInfo<v8::Value> &info);

package/platforms/ios/src/cpp/webgpu/GPUImpl.cpp

@@ -154,8 +154,9 @@ void GPUImpl::RequestAdapter(const v8::FunctionCallbackInfo<v8::Value> &args) {
                             callback->Call(context, context->Global(),
                                            2,
                                            args);  // ignore JS return value
-
+                            
                             delete static_cast<AsyncCallback *>(data);
+
                         } else {
                             v8::Local<v8::Value> args[1] = {
                                     v8::Null(isolate)};

package/platforms/ios/src/cpp/webgpu/GPUImpl.h

@@ -12,7 +12,7 @@
 
 class GPUImpl : ObjectWrapperImpl {
 public:
-    GPUImpl(const CanvasWebGPUInstance *instance);
+    explicit GPUImpl(const CanvasWebGPUInstance *instance);
 
     ~GPUImpl() {
         if (this->instance_ != nullptr) {

package/platforms/ios/src/cpp/webgpu/GPULabel.h

@@ -0,0 +1,33 @@
+//
+// Created by Osei Fortune on 19/08/2024.
+//
+
+#ifndef CANVAS_ANDROID_GPULABEL_H
+#define CANVAS_ANDROID_GPULABEL_H
+
+#include "Common.h"
+#include "Helpers.h"
+
+class GPULabel {
+public:
+    GPULabel(){}
+    GPULabel(v8::Isolate *isolate, const v8::Local<v8::Value> &label) {
+        if (label->IsString() || label->IsStringObject()) {
+            label_ = ConvertFromV8String(isolate, label);
+            hasLabel_ = true;
+        }
+    }
+
+    const char *operator*() {
+        if (hasLabel_) {
+            return label_.c_str();
+        }
+        return nullptr;
+    }
+
+private:
+    std::string label_;
+    bool hasLabel_ = false;
+};
+
+#endif //CANVAS_ANDROID_GPULABEL_H

package/platforms/ios/src/cpp/webgpu/GPUPipelineLayoutImpl.cpp

@@ -47,8 +47,34 @@ v8::Local<v8::FunctionTemplate> GPUPipelineLayoutImpl::GetCtor(v8::Isolate *isol
     auto tmpl = ctorTmpl->InstanceTemplate();
     tmpl->SetInternalFieldCount(2);
 
+    tmpl->SetLazyDataProperty(
+            ConvertToV8String(isolate, "label"),
+            GetLabel
+    );
+
     cache->GPUPipelineLayoutTmpl =
             std::make_unique<v8::Persistent<v8::FunctionTemplate>>(isolate, ctorTmpl);
     return ctorTmpl;
 }
 
+
+void
+GPUPipelineLayoutImpl::GetLabel(v8::Local<v8::Name> name,
+                                const v8::PropertyCallbackInfo<v8::Value> &info) {
+    auto ptr = GetPointer(info.This());
+    if (ptr != nullptr) {
+        auto label = canvas_native_webgpu_pipeline_layout_get_label(ptr->pipeline_);
+        if (label == nullptr) {
+            info.GetReturnValue().SetEmptyString();
+            return;
+        }
+        info.GetReturnValue().Set(
+                ConvertToV8String(info.GetIsolate(), label)
+        );
+        canvas_native_string_destroy(label);
+        return;
+    }
+
+    info.GetReturnValue().SetEmptyString();
+}
+

package/platforms/ios/src/cpp/webgpu/GPUPipelineLayoutImpl.h

@@ -12,7 +12,7 @@
 
 class GPUPipelineLayoutImpl : ObjectWrapperImpl {
 public:
-    GPUPipelineLayoutImpl(const CanvasGPUPipelineLayout *pipeline);
+    explicit GPUPipelineLayoutImpl(const CanvasGPUPipelineLayout *pipeline);
 
     ~GPUPipelineLayoutImpl() {
         canvas_native_webgpu_pipeline_layout_release(this->GetPipeline());
@@ -38,6 +38,8 @@ public:
         return scope.Escape(object);
     }
 
+    static void GetLabel(v8::Local<v8::Name> name,
+                         const v8::PropertyCallbackInfo<v8::Value> &info);
 
 private:
     const CanvasGPUPipelineLayout *pipeline_;

package/platforms/ios/src/cpp/webgpu/GPUQuerySetImpl.cpp

@@ -78,7 +78,6 @@ void
 GPUQuerySetImpl::GetCount(v8::Local<v8::Name> name,
                           const v8::PropertyCallbackInfo<v8::Value> &info) {
     auto ptr = GetPointer(info.This());
-    auto isolate = info.GetIsolate();
     if (ptr != nullptr) {
         info.GetReturnValue().Set(canvas_native_webgpu_query_set_get_count(ptr->GetQuerySet()));
         return;
@@ -132,6 +131,6 @@ void GPUQuerySetImpl::Destroy(const v8::FunctionCallbackInfo<v8::Value> &args) {
     if (ptr == nullptr) {
         return;
     }
-    // todo
+    canvas_native_webgpu_query_set_destroy(ptr->querySet_);
 
 }

package/platforms/ios/src/cpp/webgpu/GPUQuerySetImpl.h

@@ -10,7 +10,7 @@
 
 class GPUQuerySetImpl : ObjectWrapperImpl {
 public:
-    GPUQuerySetImpl(const CanvasGPUQuerySet *querySet);
+    explicit GPUQuerySetImpl(const CanvasGPUQuerySet *querySet);
 
     ~GPUQuerySetImpl() {
         canvas_native_webgpu_query_set_release(this->GetQuerySet());

package/platforms/ios/src/cpp/webgpu/GPUQueueImpl.cpp

@@ -55,6 +55,10 @@ v8::Local<v8::FunctionTemplate> GPUQueueImpl::GetCtor(v8::Isolate *isolate) {
     auto tmpl = ctorTmpl->InstanceTemplate();
     tmpl->SetInternalFieldCount(2);
 
+    tmpl->SetLazyDataProperty(
+            ConvertToV8String(isolate, "label"),
+            GetLabel
+    );
 
     tmpl->Set(
             ConvertToV8String(isolate, "copyExternalImageToTexture"),
@@ -84,6 +88,28 @@ v8::Local<v8::FunctionTemplate> GPUQueueImpl::GetCtor(v8::Isolate *isolate) {
     return ctorTmpl;
 }
 
+
+void
+GPUQueueImpl::GetLabel(v8::Local<v8::Name> name,
+                                const v8::PropertyCallbackInfo<v8::Value> &info) {
+    auto ptr = GetPointer(info.This());
+    if (ptr != nullptr) {
+        auto label = canvas_native_webgpu_queue_get_label(ptr->queue_);
+        if (label == nullptr) {
+            info.GetReturnValue().SetEmptyString();
+            return;
+        }
+        info.GetReturnValue().Set(
+                ConvertToV8String(info.GetIsolate(), label)
+        );
+        canvas_native_string_destroy(label);
+        return;
+    }
+
+    info.GetReturnValue().SetEmptyString();
+}
+
+
 void GPUQueueImpl::CopyExternalImageToTexture(const v8::FunctionCallbackInfo<v8::Value> &args) {
     auto *ptr = GetPointer(args.This());
     if (ptr == nullptr) {
@@ -110,16 +136,13 @@ void GPUQueueImpl::CopyExternalImageToTexture(const v8::FunctionCallbackInfo<v8:
         U8Buffer *buffer = nullptr;
         uint32_t width = 0;
         uint32_t height = 0;
+        const ImageAsset* imageAsset = nullptr;
         if (sourceType == NativeType::ImageBitmap) {
-            auto imageAsset = ImageBitmapImpl::GetPointer(sourceSourceValue.As<v8::Object>());
-            buffer = canvas_native_image_asset_get_data(imageAsset->GetImageAsset());
-            width = canvas_native_image_asset_width(imageAsset->GetImageAsset());
-            height = canvas_native_image_asset_height(imageAsset->GetImageAsset());
+            auto bitmap = ImageBitmapImpl::GetPointer(sourceSourceValue.As<v8::Object>());
+            imageAsset = bitmap->GetImageAsset();
         } else if (sourceType == NativeType::ImageAsset) {
-            auto imageAsset = ImageAssetImpl::GetPointer(sourceSourceValue.As<v8::Object>());
-            buffer = canvas_native_image_asset_get_data(imageAsset->GetImageAsset());
-            width = canvas_native_image_asset_width(imageAsset->GetImageAsset());
-            height = canvas_native_image_asset_height(imageAsset->GetImageAsset());
+            auto asset = ImageAssetImpl::GetPointer(sourceSourceValue.As<v8::Object>());
+            imageAsset = asset->GetImageAsset();
         } else if (sourceType == NativeType::ImageData) {
             auto imageData = ImageDataImpl::GetPointer(sourceSourceValue.As<v8::Object>());
             buffer = canvas_native_image_data_get_data(imageData->GetImageData());
@@ -131,7 +154,7 @@ void GPUQueueImpl::CopyExternalImageToTexture(const v8::FunctionCallbackInfo<v8:
             auto webgl = WebGLRenderingContextBase::GetPointer(sourceSourceValue.As<v8::Object>());
         }
 
-        if (buffer == nullptr) {
+        if (buffer == nullptr && imageAsset == nullptr) {
             // todo error ??
             return;
         }
@@ -237,9 +260,26 @@ void GPUQueueImpl::CopyExternalImageToTexture(const v8::FunctionCallbackInfo<v8:
 
         CanvasExtent3d extent3D = ParseExtent3d(isolate, sizeVal);
 
+        if (imageAsset != nullptr){
+            CanvasImageCopyImageAsset source{
+                    imageAsset,
+                    sourceOrigin,
+                    flipY,
+            };
+
+
+            canvas_native_webgpu_queue_copy_image_asset_to_texture(ptr->GetGPUQueue(), &source,
+                                                                      &destination,
+                                                                      &extent3D);
+            return;
+        }
+
+
         auto data = canvas_native_u8_buffer_get_bytes(buffer);
         auto size = canvas_native_u8_buffer_get_length(buffer);
 
+
+
         if (data == nullptr || size == 0) {
             // todo error
             return;
@@ -368,7 +408,6 @@ void GPUQueueImpl::WriteBuffer(const v8::FunctionCallbackInfo<v8::Value> &args)
     if (bufferValue->IsObject()) {
         auto buffer = GPUBufferImpl::GetPointer(bufferValue.As<v8::Object>());
 
-
         auto bufferOffset = (uint64_t) args[1].As<v8::Number>()->Value();
 
         auto dataValue = args[2].As<v8::TypedArray>();
@@ -379,7 +418,7 @@ void GPUQueueImpl::WriteBuffer(const v8::FunctionCallbackInfo<v8::Value> &args)
 
         auto data = static_cast<uint8_t *>(store->Data()) + offset;
 
-        auto data_size = store->ByteLength();
+        auto data_size = store->ByteLength() - offset;
 
         auto dataOffset = (uint64_t) args[3].As<v8::Number>()->Value();
 
@@ -410,8 +449,6 @@ void GPUQueueImpl::WriteTexture(const v8::FunctionCallbackInfo<v8::Value> &args)
     auto isolate = args.GetIsolate();
     auto context = isolate->GetCurrentContext();
 
-    bool flipY = false;
-
 
     auto destinationVal = args[0];
     auto dataVal = args[1];

package/platforms/ios/src/cpp/webgpu/GPUQueueImpl.h

@@ -37,6 +37,9 @@ public:
         return scope.Escape(object);
     }
 
+    static void GetLabel(v8::Local<v8::Name> name,
+                         const v8::PropertyCallbackInfo<v8::Value> &info);
+
     static void CopyExternalImageToTexture(const v8::FunctionCallbackInfo<v8::Value> &args);
 
     static void Submit(const v8::FunctionCallbackInfo<v8::Value> &args);

package/platforms/ios/src/cpp/webgpu/GPURenderBundleEncoderImpl.cpp

@@ -8,6 +8,7 @@
 #include "GPUBufferImpl.h"
 #include "GPURenderBundleImpl.h"
 #include "GPUBindGroupImpl.h"
+#include "GPULabel.h"
 
 GPURenderBundleEncoderImpl::GPURenderBundleEncoderImpl(const CanvasGPURenderBundleEncoder *encoder)
         : encoder_(
@@ -54,6 +55,11 @@ v8::Local<v8::FunctionTemplate> GPURenderBundleEncoderImpl::GetCtor(v8::Isolate
     auto tmpl = ctorTmpl->InstanceTemplate();
     tmpl->SetInternalFieldCount(2);
 
+    tmpl->SetLazyDataProperty(
+            ConvertToV8String(isolate, "label"),
+            GetLabel
+    );
+
     tmpl->Set(
             ConvertToV8String(isolate, "draw"),
             v8::FunctionTemplate::New(isolate, &Draw));
@@ -109,6 +115,28 @@ v8::Local<v8::FunctionTemplate> GPURenderBundleEncoderImpl::GetCtor(v8::Isolate
     return ctorTmpl;
 }
 
+
+void
+GPURenderBundleEncoderImpl::GetLabel(v8::Local<v8::Name> name,
+                        const v8::PropertyCallbackInfo<v8::Value> &info) {
+    auto ptr = GetPointer(info.This());
+    if (ptr != nullptr) {
+        auto label = canvas_native_webgpu_render_bundle_encoder_get_label(ptr->encoder_);
+        if (label == nullptr) {
+            info.GetReturnValue().SetEmptyString();
+            return;
+        }
+        info.GetReturnValue().Set(
+                ConvertToV8String(info.GetIsolate(), label)
+        );
+        canvas_native_string_destroy(label);
+        return;
+    }
+
+    info.GetReturnValue().SetEmptyString();
+}
+
+
 void GPURenderBundleEncoderImpl::Draw(const v8::FunctionCallbackInfo<v8::Value> &args) {
     auto *ptr = GetPointer(args.This());
     if (ptr == nullptr) {
@@ -163,12 +191,16 @@ void GPURenderBundleEncoderImpl::DrawIndexed(const v8::FunctionCallbackInfo<v8::
 
 
     auto indexCountVal = args[0];
-    auto firstIndexVal = args[1];
-    auto baseVertexVal = args[2];
-    auto firstInstanceVal = args[3];
+    auto instanceCountVal = args[1];
+    auto firstIndexVal = args[2];
+    auto baseVertexVal = args[3];
+    auto firstInstanceVal = args[4];
 
     if (indexCountVal->IsUint32()) {
 
+        if (instanceCountVal->IsUint32()) {
+            instanceCount = instanceCountVal.As<v8::Uint32>()->Value();
+        }
 
         if (firstIndexVal->IsUint32()) {
             firstIndex = firstIndexVal.As<v8::Uint32>()->Value();
@@ -256,7 +288,7 @@ void GPURenderBundleEncoderImpl::Finish(const v8::FunctionCallbackInfo<v8::Value
     auto isolate = args.GetIsolate();
     auto context = isolate->GetCurrentContext();
 
-    char *label = nullptr;
+    GPULabel label;
     v8::Local<v8::Value> labelVal;
 
     auto optionsVal = args[0];
@@ -265,13 +297,11 @@ void GPURenderBundleEncoderImpl::Finish(const v8::FunctionCallbackInfo<v8::Value
         auto options = optionsVal.As<v8::Object>();
         options->Get(context, ConvertToV8String(isolate, "label")).ToLocal(&labelVal);
 
-        if (!labelVal.IsEmpty() && labelVal->IsString()) {
-            label = *v8::String::Utf8Value(isolate, labelVal);
-        }
+        label = GPULabel(isolate, labelVal);
     }
 
 
-    auto bundle = canvas_native_webgpu_render_bundle_encoder_finish(ptr->GetEncoder(), label);
+    auto bundle = canvas_native_webgpu_render_bundle_encoder_finish(ptr->GetEncoder(), *label);
 
     if (bundle != nullptr) {
         auto ret = GPURenderBundleImpl::NewInstance(isolate, new GPURenderBundleImpl(bundle));
@@ -345,7 +375,7 @@ void GPURenderBundleEncoderImpl::SetBindGroup(const v8::FunctionCallbackInfo<v8:
         auto index = indexVal->Uint32Value(context).FromJust();
         auto bindGroup = GPUBindGroupImpl::GetPointer(bindGroupVal.As<v8::Object>());
 
-        if (dynamicOffsets->IsUint8Array()) {
+        if (dynamicOffsets->IsUint32Array()) {
             auto buf = dynamicOffsets.As<v8::Uint32Array>();
             auto buffer = buf->Buffer();
             auto store = buffer->GetBackingStore();
@@ -374,7 +404,6 @@ void GPURenderBundleEncoderImpl::SetIndexBuffer(const v8::FunctionCallbackInfo<v
     }
 
     auto isolate = args.GetIsolate();
-    auto context = isolate->GetCurrentContext();
 
     auto bufferVal = args[0];
     auto indexFormatVal = args[1];
@@ -385,7 +414,7 @@ void GPURenderBundleEncoderImpl::SetIndexBuffer(const v8::FunctionCallbackInfo<v
 
     auto type = GetNativeType(bufferVal);
 
-    if (type == NativeType::GPURenderBundleEncoder) {
+    if (type == NativeType::GPUBuffer) {
         auto buffer = GPUBufferImpl::GetPointer(bufferVal.As<v8::Object>());
         auto indexFormat = ConvertFromV8String(isolate, indexFormatVal);
         if (offsetVal->IsNumber()) {
@@ -421,7 +450,7 @@ void GPURenderBundleEncoderImpl::SetPipeline(const v8::FunctionCallbackInfo<v8::
     }
 
     auto pipelineVal = args[0];
-    if (pipelineVal->IsObject()) {
+    if(GetNativeType(pipelineVal) == NativeType::GPURenderPipeline){
         auto pipeline = GPURenderPipelineImpl::GetPointer(pipelineVal.As<v8::Object>());
         if (pipeline != nullptr) {
             canvas_native_webgpu_render_bundle_encoder_set_pipeline(ptr->GetEncoder(),
@@ -445,11 +474,11 @@ void GPURenderBundleEncoderImpl::SetVertexBuffer(const v8::FunctionCallbackInfo<
 
     if (slotVal->IsUint32() && bufferVal->IsObject()) {
         auto slot = slotVal.As<v8::Uint32>()->Value();
-        auto buffer = GPUBufferImpl::GetPointer(bufferVal.As<v8::Object>());
-        if (buffer == nullptr) {
+        if (GetNativeType(bufferVal) != NativeType::GPUBuffer) {
             // todo throw ??
             return;
         }
+        auto buffer = GPUBufferImpl::GetPointer(bufferVal.As<v8::Object>());
 
         if (offsetVal->IsNumber()) {
             offset = (int64_t) offsetVal.As<v8::Number>()->Value();

package/platforms/ios/src/cpp/webgpu/GPURenderBundleEncoderImpl.h

@@ -38,6 +38,9 @@ public:
         return scope.Escape(object);
     }
 
+    static void GetLabel(v8::Local<v8::Name> name,
+                         const v8::PropertyCallbackInfo<v8::Value> &info);
+
     static void Draw(const v8::FunctionCallbackInfo<v8::Value> &args);
 
     static void DrawIndexed(const v8::FunctionCallbackInfo<v8::Value> &args);

package/platforms/ios/src/cpp/webgpu/GPURenderBundleImpl.cpp

@@ -47,7 +47,32 @@ v8::Local<v8::FunctionTemplate> GPURenderBundleImpl::GetCtor(v8::Isolate *isolat
     auto tmpl = ctorTmpl->InstanceTemplate();
     tmpl->SetInternalFieldCount(2);
 
+    tmpl->SetLazyDataProperty(
+            ConvertToV8String(isolate, "label"),
+            GetLabel
+    );
+
     cache->GPURenderBundleTmpl =
             std::make_unique<v8::Persistent<v8::FunctionTemplate>>(isolate, ctorTmpl);
     return ctorTmpl;
 }
+
+void
+GPURenderBundleImpl::GetLabel(v8::Local<v8::Name> name,
+                                     const v8::PropertyCallbackInfo<v8::Value> &info) {
+    auto ptr = GetPointer(info.This());
+    if (ptr != nullptr) {
+        auto label = canvas_native_webgpu_render_bundle_get_label(ptr->bundle_);
+        if (label == nullptr) {
+            info.GetReturnValue().SetEmptyString();
+            return;
+        }
+        info.GetReturnValue().Set(
+                ConvertToV8String(info.GetIsolate(), label)
+        );
+        canvas_native_string_destroy(label);
+        return;
+    }
+
+    info.GetReturnValue().SetEmptyString();
+}

package/platforms/ios/src/cpp/webgpu/GPURenderBundleImpl.h

@@ -36,6 +36,9 @@ public:
         return scope.Escape(object);
     }
 
+    static void GetLabel(v8::Local<v8::Name> name,
+                         const v8::PropertyCallbackInfo<v8::Value> &info);
+
 
 private:
     const CanvasGPURenderBundle *bundle_;

package/platforms/ios/src/cpp/webgpu/GPURenderPassEncoderImpl.cpp

@@ -54,6 +54,11 @@ v8::Local<v8::FunctionTemplate> GPURenderPassEncoderImpl::GetCtor(v8::Isolate *i
     auto tmpl = ctorTmpl->InstanceTemplate();
     tmpl->SetInternalFieldCount(2);
 
+    tmpl->SetLazyDataProperty(
+            ConvertToV8String(isolate, "label"),
+            GetLabel
+    );
+
     tmpl->Set(
             ConvertToV8String(isolate, "beginOcclusionQuery"),
             v8::FunctionTemplate::New(isolate, &BeginOcclusionQuery));
@@ -136,6 +141,27 @@ v8::Local<v8::FunctionTemplate> GPURenderPassEncoderImpl::GetCtor(v8::Isolate *i
 }
 
 
+void
+GPURenderPassEncoderImpl::GetLabel(v8::Local<v8::Name> name,
+                                   const v8::PropertyCallbackInfo<v8::Value> &info) {
+    auto ptr = GetPointer(info.This());
+    if (ptr != nullptr) {
+        auto label = canvas_native_webgpu_render_pass_encoder_get_label(ptr->pass_);
+        if (label == nullptr) {
+            info.GetReturnValue().SetEmptyString();
+            return;
+        }
+        info.GetReturnValue().Set(
+                ConvertToV8String(info.GetIsolate(), label)
+        );
+        canvas_native_string_destroy(label);
+        return;
+    }
+
+    info.GetReturnValue().SetEmptyString();
+}
+
+
 void
 GPURenderPassEncoderImpl::BeginOcclusionQuery(const v8::FunctionCallbackInfo<v8::Value> &args) {
     auto *ptr = GetPointer(args.This());
@@ -229,7 +255,7 @@ void GPURenderPassEncoderImpl::DrawIndexed(const v8::FunctionCallbackInfo<v8::Va
         }
 
         auto indexCount = indexCountVal->Uint32Value(
-                                                     context).FromJust();
+                context).FromJust();
         canvas_native_webgpu_render_pass_encoder_draw_indexed(ptr->GetPass(),
                                                               indexCount,
                                                               instanceCount, firstIndex,
@@ -328,7 +354,7 @@ void GPURenderPassEncoderImpl::ExecuteBundles(const v8::FunctionCallbackInfo<v8:
         std::vector<const CanvasGPURenderBundle *> bundles;
         for (int i = 0; i < len; i++) {
             v8::Local<v8::Value> bundleVal;
-            bundlesArray->Get(context, i).ToLocal(&bundlesVal);
+            bundlesArray->Get(context, i).ToLocal(&bundleVal);
             auto type = GetNativeType(bundleVal);
             if (type == NativeType::GPURenderBundle) {
                 auto bundle = GPURenderBundleImpl::GetPointer(bundleVal.As<v8::Object>());
@@ -408,7 +434,7 @@ void GPURenderPassEncoderImpl::SetBindGroup(const v8::FunctionCallbackInfo<v8::V
         auto index = indexVal->Uint32Value(context).FromJust();
         auto bindgroup = GPUBindGroupImpl::GetPointer(bindGroupVal.As<v8::Object>());
 
-        if (dynamicOffsets->IsUint8Array()) {
+        if (dynamicOffsets->IsUint32Array()) {
             auto buf = dynamicOffsets.As<v8::Uint32Array>();
             auto buffer = buf->Buffer();
             auto store = buffer->GetBackingStore();
@@ -446,7 +472,7 @@ void GPURenderPassEncoderImpl::SetIndexBuffer(const v8::FunctionCallbackInfo<v8:
 
     auto type = GetNativeType(bufferVal);
 
-    if (type == NativeType::GPURenderBundleEncoder) {
+    if (type == NativeType::GPUBuffer) {
         auto buffer = GPUBufferImpl::GetPointer(bufferVal.As<v8::Object>());
         auto indexFormat = ConvertFromV8String(isolate, indexFormatVal);
         if (offsetVal->IsNumber()) {
@@ -502,7 +528,7 @@ void GPURenderPassEncoderImpl::SetPipeline(const v8::FunctionCallbackInfo<v8::Va
     }
 
     auto pipelineVal = args[0];
-    if(GetNativeType(pipelineVal) == NativeType::GPURenderPipeline){
+    if (GetNativeType(pipelineVal) == NativeType::GPURenderPipeline) {
         auto pipeline = GPURenderPipelineImpl::GetPointer(pipelineVal.As<v8::Object>());
         canvas_native_webgpu_render_pass_encoder_set_pipeline(ptr->GetPass(),
                                                               pipeline->GetGPUPipeline());
@@ -565,13 +591,13 @@ void GPURenderPassEncoderImpl::SetVertexBuffer(const v8::FunctionCallbackInfo<v8
     int64_t size = -1;
     auto offsetVal = args[2];
     auto sizeVal = args[3];
-
-    if (slotVal->IsUint32() && bufferVal->IsObject()) {
-        auto slot = slotVal.As<v8::Uint32>()->Value();
-        if (GetNativeType(bufferVal) != NativeType::GPUBuffer) {
-            // todo throw ??
-            return;
-        }
+    auto type = GetNativeType(bufferVal);
+    auto isolate = args.GetIsolate();
+    if (type == NativeType::GPUBuffer) {
+        auto context = isolate->GetCurrentContext();
+        auto slot = slotVal->ToUint32(context).ToLocalChecked();
+        
+    
 
         auto buffer = GPUBufferImpl::GetPointer(bufferVal.As<v8::Object>());
 
@@ -583,7 +609,7 @@ void GPURenderPassEncoderImpl::SetVertexBuffer(const v8::FunctionCallbackInfo<v8
             size = (int64_t) sizeVal.As<v8::Number>()->Value();
         }
 
-        canvas_native_webgpu_render_pass_encoder_set_vertex_buffer(ptr->GetPass(), slot,
+        canvas_native_webgpu_render_pass_encoder_set_vertex_buffer(ptr->GetPass(), slot->Value(),
                                                                    buffer->GetGPUBuffer(), offset,
                                                                    size);
 

package/platforms/ios/src/cpp/webgpu/GPURenderPassEncoderImpl.h

@@ -38,6 +38,9 @@ public:
         return scope.Escape(object);
     }
 
+    static void GetLabel(v8::Local<v8::Name> name,
+                         const v8::PropertyCallbackInfo<v8::Value> &info);
+
     static void BeginOcclusionQuery(const v8::FunctionCallbackInfo<v8::Value> &args);
 
     static void Draw(const v8::FunctionCallbackInfo<v8::Value> &args);

package/platforms/ios/src/cpp/webgpu/GPURenderPipelineImpl.cpp

@@ -48,6 +48,10 @@ v8::Local<v8::FunctionTemplate> GPURenderPipelineImpl::GetCtor(v8::Isolate *isol
     auto tmpl = ctorTmpl->InstanceTemplate();
     tmpl->SetInternalFieldCount(2);
 
+    tmpl->SetLazyDataProperty(
+            ConvertToV8String(isolate, "label"),
+            GetLabel
+    );
 
     tmpl->Set(
             ConvertToV8String(isolate, "getBindGroupLayout"),
@@ -82,3 +86,24 @@ void GPURenderPipelineImpl::GetBindGroupLayout(const v8::FunctionCallbackInfo<v8
     args.GetReturnValue().SetUndefined();
 }
 
+
+void
+GPURenderPipelineImpl::GetLabel(v8::Local<v8::Name> name,
+                                const v8::PropertyCallbackInfo<v8::Value> &info) {
+    auto ptr = GetPointer(info.This());
+    if (ptr != nullptr) {
+        auto label = canvas_native_webgpu_render_pipeline_get_label(ptr->pipeline_);
+        if (label == nullptr) {
+            info.GetReturnValue().SetEmptyString();
+            return;
+        }
+        info.GetReturnValue().Set(
+                ConvertToV8String(info.GetIsolate(), label)
+        );
+        canvas_native_string_destroy(label);
+        return;
+    }
+
+    info.GetReturnValue().SetEmptyString();
+}
+

package/platforms/ios/src/cpp/webgpu/GPURenderPipelineImpl.h

@@ -37,6 +37,9 @@ public:
         return scope.Escape(object);
     }
 
+    static void GetLabel(v8::Local<v8::Name> name,
+                         const v8::PropertyCallbackInfo<v8::Value> &info);
+
 
     static void GetBindGroupLayout(const v8::FunctionCallbackInfo <v8::Value> &args);