@nativescript/canvas 2.0.0-webgpu.14 → 2.0.0-webgpu.16

package/platforms/ios/src/cpp/webgpu/GPUCanvasContextImpl.cpp

@@ -207,7 +207,7 @@ void GPUCanvasContextImpl::UnConfigure(const v8::FunctionCallbackInfo<v8::Value>
         return;
     }
 
-    //  canvas_native_webgpu_context_unconfigure(ptr->GetContext());
+    canvas_native_webgpu_context_unconfigure(ptr->GetContext());
 
 }
 

package/platforms/ios/src/cpp/webgpu/GPUCommandEncoderImpl.cpp

@@ -282,7 +282,6 @@ void GPUCommandEncoderImpl::BeginRenderPass(const v8::FunctionCallbackInfo<v8::V
 
             v8::Local<v8::Value> viewVal;
 
-
             if (colorAttachment->Get(context, ConvertToV8String(isolate,
                                                                 "view")).ToLocal(&viewVal)) {
                 auto type = GetNativeType(viewVal);

package/platforms/ios/src/cpp/webgpu/GPUDeviceImpl.cpp

@@ -1294,8 +1294,6 @@ void GPUDeviceImpl::CreateRenderPipeline(const v8::FunctionCallbackInfo<v8::Valu
     }
     auto options = optionsVal.As<v8::Object>();
 
-    GPULabel label;
-
     v8::Local<v8::Value> stencilValue;
     options->Get(context, ConvertToV8String(isolate, "depthStencil")).ToLocal(
             &stencilValue);
@@ -1707,9 +1705,9 @@ void GPUDeviceImpl::CreateRenderPipeline(const v8::FunctionCallbackInfo<v8::Valu
             &labelVal);
 
 
-    label = GPULabel(isolate, labelVal);
+    auto label = GPULabel(isolate, labelVal);
+
 
-  
     descriptor.label = *label;
 
 
@@ -2628,7 +2626,7 @@ void GPUDeviceImpl::CreateRenderPipelineAsync(const v8::FunctionCallbackInfo<v8:
     label = GPULabel(isolate, labelVal);
 
     descriptor.label = *label;
-    
+
 
 
     v8::Local<v8::Value> layoutVal;
@@ -3547,7 +3545,6 @@ void GPUDeviceImpl::CreateTexture(const v8::FunctionCallbackInfo<v8::Value> &arg
 
         if (dimensionVal->IsString()) {
             auto dimension = ConvertFromV8String(isolate, dimensionVal);
-
             // todo use enum
             if (dimension == "1d") {
                 descriptor.dimension = CanvasTextureDimension::CanvasTextureDimensionD1;

package/platforms/ios/src/cpp/webgpu/GPUQueueImpl.cpp

@@ -259,7 +259,7 @@ void GPUQueueImpl::CopyExternalImageToTexture(const v8::FunctionCallbackInfo<v8:
 
 
         CanvasExtent3d extent3D = ParseExtent3d(isolate, sizeVal);
-        
+
         if (imageAsset != nullptr){
             CanvasImageCopyImageAsset source{
                     imageAsset,
@@ -273,7 +273,7 @@ void GPUQueueImpl::CopyExternalImageToTexture(const v8::FunctionCallbackInfo<v8:
                                                                       &extent3D);
             return;
         }
-        
+
 
         auto data = canvas_native_u8_buffer_get_bytes(buffer);
         auto size = canvas_native_u8_buffer_get_length(buffer);
@@ -449,8 +449,6 @@ void GPUQueueImpl::WriteTexture(const v8::FunctionCallbackInfo<v8::Value> &args)
     auto isolate = args.GetIsolate();
     auto context = isolate->GetCurrentContext();
 
-    bool flipY = false;
-
 
     auto destinationVal = args[0];
     auto dataVal = args[1];

package/platforms/ios/src/cpp/webgpu/GPURenderBundleEncoderImpl.cpp

@@ -8,6 +8,7 @@
 #include "GPUBufferImpl.h"
 #include "GPURenderBundleImpl.h"
 #include "GPUBindGroupImpl.h"
+#include "GPULabel.h"
 
 GPURenderBundleEncoderImpl::GPURenderBundleEncoderImpl(const CanvasGPURenderBundleEncoder *encoder)
         : encoder_(
@@ -287,7 +288,7 @@ void GPURenderBundleEncoderImpl::Finish(const v8::FunctionCallbackInfo<v8::Value
     auto isolate = args.GetIsolate();
     auto context = isolate->GetCurrentContext();
 
-    std::string label;
+    GPULabel label;
     v8::Local<v8::Value> labelVal;
 
     auto optionsVal = args[0];
@@ -296,11 +297,11 @@ void GPURenderBundleEncoderImpl::Finish(const v8::FunctionCallbackInfo<v8::Value
         auto options = optionsVal.As<v8::Object>();
         options->Get(context, ConvertToV8String(isolate, "label")).ToLocal(&labelVal);
 
-        label = ConvertFromV8String(isolate, labelVal);
+        label = GPULabel(isolate, labelVal);
     }
 
 
-    auto bundle = canvas_native_webgpu_render_bundle_encoder_finish(ptr->GetEncoder(), label.c_str());
+    auto bundle = canvas_native_webgpu_render_bundle_encoder_finish(ptr->GetEncoder(), *label);
 
     if (bundle != nullptr) {
         auto ret = GPURenderBundleImpl::NewInstance(isolate, new GPURenderBundleImpl(bundle));

package/platforms/ios/src/cpp/webgpu/GPUTextureImpl.cpp

@@ -5,6 +5,7 @@
 #include "GPUTextureImpl.h"
 #include "Caches.h"
 #include "GPUTextureViewImpl.h"
+#include "GPULabel.h"
 
 GPUTextureImpl::GPUTextureImpl(const CanvasGPUTexture *texture) : texture_(texture) {}
 
@@ -274,7 +275,7 @@ void GPUTextureImpl::CreateView(const v8::FunctionCallbackInfo<v8::Value> &args)
             aspect, 0, -1, 0, -1
     };
 
-    std::string label;
+    GPULabel label;
 
     if (descVal->IsObject()) {
         descriptor = new CanvasCreateTextureViewDescriptor{};
@@ -341,9 +342,9 @@ void GPUTextureImpl::CreateView(const v8::FunctionCallbackInfo<v8::Value> &args)
         v8::Local<v8::Value> labelVal;
         descObj->Get(context, ConvertToV8String(isolate, "label")).ToLocal(&labelVal);
 
-        label = ConvertFromV8String(isolate, labelVal);
+        label = GPULabel(isolate, labelVal);
 
-        descriptor->label = label.c_str();
+        descriptor->label = *label;
 
         v8::Local<v8::Value> dimensionVal;
         if (descObj->Get(context, ConvertToV8String(isolate, "dimension")).ToLocal(&dimensionVal)) {