@nativescript/canvas 2.0.0-webgpu.1 → 2.0.0-webgpu.3

package/platforms/ios/src/cpp/webgpu/GPUCommandEncoderImpl.cpp

@@ -232,7 +232,6 @@ void GPUCommandEncoderImpl::BeginRenderPass(const v8::FunctionCallbackInfo<v8::V
     if (!descVal->IsNullOrUndefined() && descVal->IsObject()) {
         auto desc = descVal.As<v8::Object>();
 
-
         v8::Local<v8::Value> labelVal;
         desc->Get(context, ConvertToV8String(isolate, "label")).ToLocal(&labelVal);
 
@@ -265,10 +264,10 @@ void GPUCommandEncoderImpl::BeginRenderPass(const v8::FunctionCallbackInfo<v8::V
                                                             "view")).ToLocal(&viewVal);
 
             const CanvasGPUTextureView *view = nullptr;
-         
+
             auto viewPtr = GPUTextureViewImpl::GetPointer(viewVal.As<v8::Object>());
             view = viewPtr->GetTextureView();
-            
+
             const CanvasGPUTextureView *resolve_target = nullptr;
 
             v8::Local<v8::Value> resolve_target_val;
@@ -288,8 +287,8 @@ void GPUCommandEncoderImpl::BeginRenderPass(const v8::FunctionCallbackInfo<v8::V
             CanvasStoreOp store = CanvasStoreOp::CanvasStoreOpStore;
             v8::Local<v8::Value> loadVal;
 
-            if(colorAttachment->Get(context, ConvertToV8String(isolate,
-                                                               "loadOp")).ToLocal(&loadVal)){
+            if (colorAttachment->Get(context, ConvertToV8String(isolate,
+                                                                "loadOp")).ToLocal(&loadVal)) {
                 if (loadVal->IsUint32()) {
                     load = (CanvasLoadOp) loadVal->Uint32Value(
                             context).ToChecked();
@@ -302,11 +301,11 @@ void GPUCommandEncoderImpl::BeginRenderPass(const v8::FunctionCallbackInfo<v8::V
                     }
                 }
             }
-    
-         
+
+
             v8::Local<v8::Value> storeVal;
-            if(colorAttachment->Get(context, ConvertToV8String(isolate,
-                                                               "storeOp")).ToLocal(&storeVal)){
+            if (colorAttachment->Get(context, ConvertToV8String(isolate,
+                                                                "storeOp")).ToLocal(&storeVal)) {
                 if (storeVal->IsUint32()) {
                     store = (CanvasStoreOp) storeVal->Uint32Value(
                             context).ToChecked();
@@ -381,20 +380,20 @@ void GPUCommandEncoderImpl::BeginRenderPass(const v8::FunctionCallbackInfo<v8::V
                     &depthLoadOp);
 
             depthStencilAttachment->depth_load_op = CanvasOptionalLoadOp{
-                CanvasOptionalLoadOpNone
+                    CanvasOptionalLoadOpNone
             };
 
             if (!depthLoadOp.IsEmpty() && depthLoadOp->IsString()) {
                 auto value = ConvertFromV8String(isolate, depthLoadOp);
                 if (value == "load") {
                     depthStencilAttachment->depth_load_op = CanvasOptionalLoadOp{
-                        CanvasOptionalLoadOpSome,
-                        CanvasLoadOpLoad
+                            CanvasOptionalLoadOpSome,
+                            CanvasLoadOpLoad
                     };
                 } else if (value == "clear") {
                     depthStencilAttachment->depth_load_op = CanvasOptionalLoadOp{
-                        CanvasOptionalLoadOpSome,
-                        CanvasLoadOpClear
+                            CanvasOptionalLoadOpSome,
+                            CanvasLoadOpClear
                     };
                 }
             }
@@ -406,20 +405,20 @@ void GPUCommandEncoderImpl::BeginRenderPass(const v8::FunctionCallbackInfo<v8::V
                     &depthStoreOp);
 
             depthStencilAttachment->depth_store_op = CanvasOptionalStoreOp{
-                CanvasOptionalStoreOpNone
+                    CanvasOptionalStoreOpNone
             };
 
             if (!depthStoreOp.IsEmpty() && depthStoreOp->IsString()) {
                 auto value = ConvertFromV8String(isolate, depthStoreOp);
                 if (value == "store") {
                     depthStencilAttachment->depth_store_op = depthStencilAttachment->depth_store_op = CanvasOptionalStoreOp{
-                        CanvasOptionalStoreOpSome,
-                        CanvasStoreOpStore
+                            CanvasOptionalStoreOpSome,
+                            CanvasStoreOpStore
                     };
                 } else if (value == "discard") {
                     depthStencilAttachment->depth_store_op = depthStencilAttachment->depth_store_op = CanvasOptionalStoreOp{
-                        CanvasOptionalStoreOpSome,
-                        CanvasStoreOpDiscard
+                            CanvasOptionalStoreOpSome,
+                            CanvasStoreOpDiscard
                     };
                 }
             }
@@ -455,20 +454,20 @@ void GPUCommandEncoderImpl::BeginRenderPass(const v8::FunctionCallbackInfo<v8::V
                     &stencilLoadOp);
 
             depthStencilAttachment->stencil_load_op = CanvasOptionalLoadOp{
-                CanvasOptionalLoadOpNone
+                    CanvasOptionalLoadOpNone
             };
 
             if (!stencilLoadOp.IsEmpty() && stencilLoadOp->IsString()) {
                 auto value = ConvertFromV8String(isolate, stencilLoadOp);
                 if (value == "load") {
                     depthStencilAttachment->stencil_load_op = CanvasOptionalLoadOp{
-                        CanvasOptionalLoadOpSome,
-                        CanvasLoadOpLoad
+                            CanvasOptionalLoadOpSome,
+                            CanvasLoadOpLoad
                     };
                 } else if (value == "clear") {
                     depthStencilAttachment->stencil_load_op = CanvasOptionalLoadOp{
-                        CanvasOptionalLoadOpSome,
-                        CanvasLoadOpClear
+                            CanvasOptionalLoadOpSome,
+                            CanvasLoadOpClear
                     };
                 }
             }
@@ -480,20 +479,20 @@ void GPUCommandEncoderImpl::BeginRenderPass(const v8::FunctionCallbackInfo<v8::V
                     &stencilStoreOp);
 
             depthStencilAttachment->stencil_store_op = CanvasOptionalStoreOp{
-                CanvasOptionalStoreOpNone
+                    CanvasOptionalStoreOpNone
             };
 
             if (!stencilStoreOp.IsEmpty() && stencilStoreOp->IsString()) {
                 auto value = ConvertFromV8String(isolate, stencilStoreOp);
                 if (value == "store") {
                     depthStencilAttachment->stencil_store_op = CanvasOptionalStoreOp{
-                        CanvasOptionalStoreOpSome,
-                        CanvasStoreOpStore
+                            CanvasOptionalStoreOpSome,
+                            CanvasStoreOpStore
                     };
                 } else if (value == "discard") {
                     depthStencilAttachment->stencil_store_op = CanvasOptionalStoreOp{
-                        CanvasOptionalStoreOpSome,
-                        CanvasStoreOpDiscard
+                            CanvasOptionalStoreOpSome,
+                            CanvasStoreOpDiscard
                     };
                 }
             }
@@ -518,7 +517,7 @@ void GPUCommandEncoderImpl::BeginRenderPass(const v8::FunctionCallbackInfo<v8::V
         desc->Get(context, ConvertToV8String(isolate, "occlusionQuerySet")).ToLocal(
                 &occlusionQuerySetVal);
 
-        
+
         if (GetNativeType(occlusionQuerySetVal) == NativeType::GPUQuerySet) {
             auto occlusionQuerySet = GPUQuerySetImpl::GetPointer(
                     occlusionQuerySetVal.As<v8::Object>());
@@ -585,6 +584,7 @@ void GPUCommandEncoderImpl::BeginRenderPass(const v8::FunctionCallbackInfo<v8::V
 
         if (depthStencilAttachment != nullptr) {
             delete depthStencilAttachment;
+            depthStencilAttachment = nullptr;
         }
 
 
@@ -1099,7 +1099,6 @@ void GPUCommandEncoderImpl::Finish(const v8::FunctionCallbackInfo<v8::Value> &ar
     auto isolate = args.GetIsolate();
     auto context = isolate->GetCurrentContext();
 
-
     auto descVal = args[0];
     std::string label;
     bool didSet = false;

package/platforms/ios/src/cpp/webgpu/GPUCommandEncoderImpl.h

@@ -29,7 +29,7 @@ public:
         v8::EscapableHandleScope scope(isolate);
         auto object = GPUCommandEncoderImpl::GetCtor(isolate)->GetFunction(
                 context).ToLocalChecked()->NewInstance(context).ToLocalChecked();
-        SetNativeType(object, NativeType::GPUCommandEncoder);
+        SetNativeType(encoder, NativeType::GPUCommandEncoder);
         object->SetAlignedPointerInInternalField(0, encoder);
         encoder->BindFinalizer(isolate, object);
         return scope.Escape(object);

package/platforms/ios/src/cpp/webgpu/GPUComputePassEncoderImpl.cpp

@@ -26,7 +26,7 @@ void GPUComputePassEncoderImpl::Init(v8::Local<v8::Object> canvasModule, v8::Iso
     auto context = isolate->GetCurrentContext();
     auto func = ctor->GetFunction(context).ToLocalChecked();
 
-    canvasModule->Set(context, ConvertToV8String(isolate, "GPUComputePassEncoder"), func).FromJust();;
+    canvasModule->Set(context, ConvertToV8String(isolate, "GPUComputePassEncoder"), func).FromJust();
 }
 
 GPUComputePassEncoderImpl *

package/platforms/ios/src/cpp/webgpu/GPUComputePassEncoderImpl.h

@@ -30,7 +30,7 @@ public:
         v8::EscapableHandleScope scope(isolate);
         auto object = GPUComputePassEncoderImpl::GetCtor(isolate)->GetFunction(
                 context).ToLocalChecked()->NewInstance(context).ToLocalChecked();
-        SetNativeType(object, NativeType::GPUComputePass);
+        SetNativeType(pass, NativeType::GPUComputePass);
         object->SetAlignedPointerInInternalField(0, pass);
         pass->BindFinalizer(isolate, object);
         return scope.Escape(object);

package/platforms/ios/src/cpp/webgpu/GPUComputePipelineImpl.cpp

@@ -24,7 +24,7 @@ void GPUComputePipelineImpl::Init(v8::Local<v8::Object> canvasModule, v8::Isolat
     auto context = isolate->GetCurrentContext();
     auto func = ctor->GetFunction(context).ToLocalChecked();
 
-    canvasModule->Set(context, ConvertToV8String(isolate, "GPUComputePipeline"), func).FromJust();;
+    canvasModule->Set(context, ConvertToV8String(isolate, "GPUComputePipeline"), func).FromJust();
 }
 
 GPUComputePipelineImpl *GPUComputePipelineImpl::GetPointer(const v8::Local<v8::Object> &object) {

package/platforms/ios/src/cpp/webgpu/GPUComputePipelineImpl.h

@@ -31,7 +31,7 @@ public:
         v8::EscapableHandleScope scope(isolate);
         auto object = GPUComputePipelineImpl::GetCtor(isolate)->GetFunction(
                 context).ToLocalChecked()->NewInstance(context).ToLocalChecked();
-        SetNativeType(object, NativeType::GPUComputePipeline);
+        SetNativeType(pipeline, NativeType::GPUComputePipeline);
         object->SetAlignedPointerInInternalField(0, pipeline);
         pipeline->BindFinalizer(isolate, object);
         return scope.Escape(object);

package/platforms/ios/src/cpp/webgpu/GPUDeviceImpl.cpp

@@ -38,7 +38,7 @@ void GPUDeviceImpl::Init(v8::Local<v8::Object> canvasModule, v8::Isolate *isolat
     auto context = isolate->GetCurrentContext();
     auto func = ctor->GetFunction(context).ToLocalChecked();
 
-    canvasModule->Set(context, ConvertToV8String(isolate, "GPUDevice"), func).FromJust();;
+    canvasModule->Set(context, ConvertToV8String(isolate, "GPUDevice"), func).FromJust();
 }
 
 GPUDeviceImpl *GPUDeviceImpl::GetPointer(const v8::Local<v8::Object> &object) {
@@ -248,13 +248,13 @@ GPUDeviceImpl::GetFeatures(v8::Local<v8::Name> name,
         for (int i = 0; i < len; ++i) {
             auto item = canvas_native_string_buffer_get_value_at(features, i);
             if (item != nullptr) {
-                auto keyValue = ConvertToV8OneByteString(isolate, (char *) item);
+                auto keyValue = ConvertToV8String(isolate, (char *) item);
                 map->Set(context, keyValue, keyValue);
                 canvas_native_string_destroy(item);
             }
 
         }
-        canvas_native_string_buffer_destroy(features);
+        canvas_native_string_buffer_release(features);
 
         info.GetReturnValue().Set(map);
 
@@ -296,6 +296,11 @@ GPUDeviceImpl::GetQueue(v8::Local<v8::Name> name,
 }
 
 
+struct LostData {
+    int32_t reason;
+    char *message;
+};
+
 void
 GPUDeviceImpl::GetLost(v8::Local<v8::Name> name,
                        const v8::PropertyCallbackInfo<v8::Value> &info) {
@@ -304,64 +309,84 @@ GPUDeviceImpl::GetLost(v8::Local<v8::Name> name,
     auto resolver = v8::Promise::Resolver::New(isolate->GetCurrentContext()).ToLocalChecked();
     info.GetReturnValue().Set(resolver->GetPromise());
     if (ptr != nullptr) {
-        v8::Global<v8::Promise::Resolver> promise(isolate, resolver);
         auto callback = new PromiseCallback{
                 isolate,
-                std::move(promise)
+                resolver,
+                [](bool done, void *data) {
+                    if (data != nullptr) {
+                        auto async_data = static_cast<PromiseCallback *>(data);
+                        auto func = async_data->inner_.get();
+                        if (func != nullptr && func->isolate_ != nullptr) {
+                            v8::Isolate *isolate = func->isolate_;
+                            v8::Locker locker(isolate);
+                            v8::Isolate::Scope isolate_scope(
+                                    isolate);
+                            v8::HandleScope handle_scope(
+                                    isolate);
+                            v8::Local<v8::Promise::Resolver> callback = func->callback_.Get(
+                                    isolate);
+                            v8::Local<v8::Context> context = callback->GetCreationContextChecked();
+                            v8::Context::Scope context_scope(
+                                    context);
+
+                            auto ret = v8::Object::New(
+                                    isolate);
+                            LostData *lostData = nullptr;
+                            if (func->data != nullptr) {
+                                lostData = static_cast<LostData *>(func->data);
+                            }
+
+                            if (lostData != nullptr) {
+
+                                if (lostData->message != nullptr) {
+                                    ret->Set(context,
+                                             ConvertToV8String(
+                                                     isolate,
+                                                     "message"),
+                                             ConvertToV8String(
+                                                     isolate,
+                                                     lostData->message));
+                                    canvas_native_string_destroy(
+                                            lostData->message);
+                                }
+
+                                ret->Set(context,
+                                         ConvertToV8String(
+                                                 isolate,
+                                                 "reason"),
+                                         v8::Int32::New(isolate,
+                                                        lostData->reason)).IsJust();
+                            } else {
+                                ret->Set(context,
+                                         ConvertToV8String(
+                                                 isolate,
+                                                 "message"),
+                                         v8::String::Empty(
+                                                 isolate));
+                            }
+
+                            callback->Resolve(context, ret);
+                            delete static_cast<PromiseCallback *>(data);
+                        }
+                    }
+                }
         };
 
+        callback->prepare();
+
         canvas_native_webgpu_device_set_lost_callback(ptr->GetGPUDevice(),
                                                       [](int32_t reason, char *message,
                                                          void *data) {
                                                           if (data != nullptr) {
-                                                              auto func = static_cast<PromiseCallback *>(data);
-                                                              if (func->isolate != nullptr) {
-                                                                  v8::Isolate *isolate = func->isolate;
-                                                                  v8::Locker locker(isolate);
-                                                                  v8::Isolate::Scope isolate_scope(
-                                                                          isolate);
-                                                                  v8::HandleScope handle_scope(
-                                                                          isolate);
-                                                                  v8::Local<v8::Promise::Resolver> callback = func->callback.Get(
-                                                                          isolate);
-                                                                  v8::Local<v8::Context> context = callback->GetCreationContextChecked();
-                                                                  v8::Context::Scope context_scope(
-                                                                          context);
-
-                                                                  auto ret = v8::Object::New(
-                                                                          isolate);
-                                                                  if (message == nullptr) {
-                                                                      ret->Set(context,
-                                                                               ConvertToV8String(
-                                                                                       isolate,
-                                                                                       "message"),
-                                                                               v8::String::Empty(
-                                                                                       isolate));
-                                                                  } else {
-                                                                      ret->Set(context,
-                                                                               ConvertToV8String(
-                                                                                       isolate,
-                                                                                       "message"),
-                                                                               ConvertToV8String(
-                                                                                       isolate,
-                                                                                       message));
-                                                                      canvas_native_string_destroy(
-                                                                              message);
-                                                                  }
-
-                                                                  ret->Set(context,
-                                                                           ConvertToV8String(
-                                                                                   isolate,
-                                                                                   "reason"),
-                                                                           v8::Int32::New(isolate,
-                                                                                          reason)).IsJust();
-
-
-                                                                  callback->Resolve(context, ret);
-                                                                  delete static_cast<PromiseCallback *>(data);
+                                                              auto async_data = static_cast<PromiseCallback *>(data);
+                                                              auto inner = async_data->inner_.get();
+                                                              if (inner != nullptr) {
+                                                                  inner->data = new LostData{
+                                                                          reason, message
+                                                                  };
+                                                                  async_data->execute(true);
                                                               }
                                                           }
-
                                                       }, callback);
     }
 }
@@ -377,7 +402,7 @@ void GPUDeviceImpl::CreateBindGroup(const v8::FunctionCallbackInfo<v8::Value> &a
     char *label = nullptr;
 
     auto optionsVal = args[0];
-    
+
     std::vector<CanvasBindGroupEntry> entries;
 
     if (optionsVal->IsObject()) {
@@ -467,10 +492,10 @@ void GPUDeviceImpl::CreateBindGroup(const v8::FunctionCallbackInfo<v8::Value> &a
                                         int64_t offset = -1;
 
                                         v8::Local<v8::Value> offsetVal;
-                                        
+
                                         resourceObj->Get(context,
-                                                       ConvertToV8String(isolate,
-                                                                         "offset")).ToLocal(
+                                                         ConvertToV8String(isolate,
+                                                                           "offset")).ToLocal(
                                                 &offsetVal);
                                         if (!offsetVal.IsEmpty() && offsetVal->IsNumber()) {
                                             offset = (int64_t) offsetVal->NumberValue(
@@ -481,7 +506,8 @@ void GPUDeviceImpl::CreateBindGroup(const v8::FunctionCallbackInfo<v8::Value> &a
 
                                         v8::Local<v8::Value> sizeVal;
                                         resourceObj->Get(context,
-                                                       ConvertToV8String(isolate, "size")).ToLocal(
+                                                         ConvertToV8String(isolate,
+                                                                           "size")).ToLocal(
                                                 &sizeVal);
                                         if (!sizeVal.IsEmpty() && sizeVal->IsNumber()) {
                                             size = (int64_t) sizeVal->NumberValue(
@@ -1234,7 +1260,6 @@ void GPUDeviceImpl::CreateQuerySet(const v8::FunctionCallbackInfo<v8::Value> &ar
         label = *v8::String::Utf8Value(isolate, labelVal);
     }
 
-
     v8::Local<v8::Value> typeVal;
     options->Get(context, ConvertToV8String(isolate, "type")).ToLocal(&labelVal);
 
@@ -1438,7 +1463,7 @@ void GPUDeviceImpl::CreateRenderPipeline(const v8::FunctionCallbackInfo<v8::Valu
                 &depthBiasClampVal);
 
         if (!depthBiasClampVal.IsEmpty() && depthBiasClampVal->IsNumber()) {
-            stencil->depth_bias_clamp = (float)depthBiasClampVal->NumberValue(context).FromJust();
+            stencil->depth_bias_clamp = (float) depthBiasClampVal->NumberValue(context).FromJust();
         }
 
 
@@ -1447,7 +1472,7 @@ void GPUDeviceImpl::CreateRenderPipeline(const v8::FunctionCallbackInfo<v8::Valu
                 &depthBiasSlopeScaleVal);
 
         if (!depthBiasSlopeScaleVal.IsEmpty() && depthBiasSlopeScaleVal->IsNumber()) {
-            stencil->depth_bias_slope_scale = (float)depthBiasSlopeScaleVal->NumberValue(
+            stencil->depth_bias_slope_scale = (float) depthBiasSlopeScaleVal->NumberValue(
                     context).FromJust();
         }
 
@@ -1573,7 +1598,7 @@ void GPUDeviceImpl::CreateRenderPipeline(const v8::FunctionCallbackInfo<v8::Valu
         if (!stencilWriteMaskVal.IsEmpty() && stencilWriteMaskVal->IsUint32()) {
             stencil->stencil_write_mask = stencilWriteMaskVal->Uint32Value(context).FromJust();
         }
-        
+
         descriptor.depth_stencil = stencil;
 
     }
@@ -1898,7 +1923,7 @@ void GPUDeviceImpl::CreateRenderPipeline(const v8::FunctionCallbackInfo<v8::Valu
         v8::Local<v8::Value> cullModeValue;
 
         if (primitiveObj->Get(context, ConvertToV8String(isolate, "cullMode")).ToLocal(
-                                                                                       &cullModeValue)) {
+                &cullModeValue)) {
             if (cullModeValue->IsUint32()) {
                 auto cullMode = cullModeValue.As<v8::Uint32>()->Value();
 
@@ -1933,7 +1958,7 @@ void GPUDeviceImpl::CreateRenderPipeline(const v8::FunctionCallbackInfo<v8::Valu
         v8::Local<v8::Value> frontFaceValue;
 
         if (primitiveObj->Get(context, ConvertToV8String(isolate, "frontFace")).ToLocal(
-                                                                                        &frontFaceValue)) {
+                &frontFaceValue)) {
             if (frontFaceValue->IsUint32()) {
                 auto frontFace = frontFaceValue.As<v8::Uint32>()->Value();
                 switch (frontFace) {
@@ -1960,7 +1985,7 @@ void GPUDeviceImpl::CreateRenderPipeline(const v8::FunctionCallbackInfo<v8::Valu
         v8::Local<v8::Value> stripIndexFormatValue;
 
         if (primitiveObj->Get(context, ConvertToV8String(isolate, "stripIndexFormat")).ToLocal(
-                                                                                               &stripIndexFormatValue)) {
+                &stripIndexFormatValue)) {
             if (stripIndexFormatValue->IsUint32()) {
                 auto stripIndexFormat = stripIndexFormatValue.As<v8::Uint32>()->Value();
                 switch (stripIndexFormat) {
@@ -2001,7 +2026,7 @@ void GPUDeviceImpl::CreateRenderPipeline(const v8::FunctionCallbackInfo<v8::Valu
         v8::Local<v8::Value> topologyValue;
 
         if (primitiveObj->Get(context, ConvertToV8String(isolate, "topology")).ToLocal(
-                                                                                       &topologyValue)) {
+                &topologyValue)) {
 
             if (topologyValue->IsUint32()) {
                 auto topology = topologyValue.As<v8::Uint32>()->Value();
@@ -2262,8 +2287,8 @@ void GPUDeviceImpl::CreateRenderPipeline(const v8::FunctionCallbackInfo<v8::Valu
         }
 
     }
-    
-    if(descriptor.depth_stencil != nullptr){
+
+    if (descriptor.depth_stencil != nullptr) {
         delete descriptor.depth_stencil;
     }
 
@@ -2493,7 +2518,8 @@ void GPUDeviceImpl::CreateShaderModule(const v8::FunctionCallbackInfo<v8::Value>
         v8::Local<v8::Value> codeVal;
 
         std::string code;
-        if (desc->Get(context, ConvertToV8String(isolate, "code")).ToLocal(&codeVal) && codeVal->IsString()) {
+        if (desc->Get(context, ConvertToV8String(isolate, "code")).ToLocal(&codeVal) &&
+            codeVal->IsString()) {
             code = ConvertFromV8String(isolate, codeVal);
         }
 
@@ -2542,15 +2568,15 @@ void GPUDeviceImpl::CreateTexture(const v8::FunctionCallbackInfo<v8::Value> &arg
         v8::Local<v8::Value> depthOrArrayLayersVal;
 
         if (options->Get(context, ConvertToV8String(isolate, "depthOrArrayLayers")).ToLocal(
-                                                                                            &depthOrArrayLayersVal) && depthOrArrayLayersVal->IsUint32()) {
+                &depthOrArrayLayersVal) && depthOrArrayLayersVal->IsUint32()) {
             descriptor.depthOrArrayLayers = depthOrArrayLayersVal.As<v8::Uint32>()->Value();
         }
 
 
         v8::Local<v8::Value> widthVal;
 
-        if ( options->Get(context, ConvertToV8String(isolate, "width")).ToLocal(
-                                                                                &widthVal) &&widthVal->IsUint32()) {
+        if (options->Get(context, ConvertToV8String(isolate, "width")).ToLocal(
+                &widthVal) && widthVal->IsUint32()) {
             descriptor.width = widthVal.As<v8::Uint32>()->Value();
         }
 
@@ -2558,7 +2584,7 @@ void GPUDeviceImpl::CreateTexture(const v8::FunctionCallbackInfo<v8::Value> &arg
         v8::Local<v8::Value> heightVal;
 
         if (options->Get(context, ConvertToV8String(isolate, "height")).ToLocal(
-                                                                                &heightVal) && heightVal->IsUint32()) {
+                &heightVal) && heightVal->IsUint32()) {
             descriptor.height = heightVal.As<v8::Uint32>()->Value();
         }
 
@@ -2566,7 +2592,7 @@ void GPUDeviceImpl::CreateTexture(const v8::FunctionCallbackInfo<v8::Value> &arg
         v8::Local<v8::Value> usageVal;
 
         if (options->Get(context, ConvertToV8String(isolate, "usage")).ToLocal(
-                                                                               &usageVal) && usageVal->IsUint32()) {
+                &usageVal) && usageVal->IsUint32()) {
             descriptor.usage = usageVal.As<v8::Uint32>()->Value();
         }
 
@@ -2611,7 +2637,7 @@ void GPUDeviceImpl::CreateTexture(const v8::FunctionCallbackInfo<v8::Value> &arg
         v8::Local<v8::Value> formatVal;
 
         if (options->Get(context, ConvertToV8String(isolate, "format")).ToLocal(
-                                                                                &formatVal) && formatVal->IsString()) {
+                &formatVal) && formatVal->IsString()) {
             auto format = ConvertFromV8String(isolate, formatVal);
 
             // todo use enum

package/platforms/ios/src/cpp/webgpu/GPUDeviceImpl.h

@@ -11,7 +11,7 @@
 
 class GPUDeviceImpl : ObjectWrapperImpl {
 public:
-    GPUDeviceImpl(const CanvasGPUDevice *device);
+    explicit GPUDeviceImpl(const CanvasGPUDevice *device);
 
     ~GPUDeviceImpl() {
         canvas_native_webgpu_device_release(this->device_);
@@ -30,7 +30,7 @@ public:
         v8::EscapableHandleScope scope(isolate);
         auto object = GPUDeviceImpl::GetCtor(isolate)->GetFunction(
                 context).ToLocalChecked()->NewInstance(context).ToLocalChecked();
-        SetNativeType(object, NativeType::GPUDevice);
+        SetNativeType(device, NativeType::GPUDevice);
         object->SetAlignedPointerInInternalField(0, device);
         device->BindFinalizer(isolate, object);
         return scope.Escape(object);