@nativescript-community/ui-mapbox 7.0.8 → 7.0.10

package/CHANGELOG.md

@@ -3,6 +3,16 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [7.0.10](https://github.com/nativescript-community/ui-mapbox/compare/v7.0.9...v7.0.10) (2025-11-04)
+
+**Note:** Version bump only for package @nativescript-community/ui-mapbox
+
+## [7.0.9](https://github.com/nativescript-community/ui-mapbox/compare/v7.0.8...v7.0.9) (2025-11-04)
+
+### Bug Fixes
+
+* **ios:** removed many unwanted error message (no actual error) ([f67277c](https://github.com/nativescript-community/ui-mapbox/commit/f67277c1ee0092eab4a2067b3d765c2aa2410246))
+
 ## [7.0.8](https://github.com/nativescript-community/ui-mapbox/compare/v7.0.7...v7.0.8) (2025-11-03)
 
 **Note:** Version bump only for package @nativescript-community/ui-mapbox

package/index.ios.js

@@ -145,8 +145,8 @@ export class MapboxView extends MapboxViewBase {
     }
     async disposeNativeView() {
         this.nativeView.owner = null;
-        if (this.mapbox)
-            await this.mapbox.destroy();
+        this.mapbox?.destroy();
+        this.mapbox = null;
         super.disposeNativeView();
     }
     getMapboxApi() {
@@ -398,7 +398,7 @@ export class Mapbox extends MapboxCommon {
                 }));
                 nativeMap.autoresizingMask = 2 /* UIViewAutoresizing.FlexibleWidth */ | 16 /* UIViewAutoresizing.FlexibleHeight */;
                 _markers = [];
-                this.addMarkers(settings.markers);
+                this.addMarkers(settings.markers || []);
                 // setTimeout(() => view.addSubview(nativeMap), 0);
                 view.addSubview(nativeMap);
                 this.setMapboxViewInstance(nativeMap);
@@ -463,24 +463,24 @@ export class Mapbox extends MapboxCommon {
                     this._programmaticMapView = null;
                 }
                 const bridge = MapboxBridge.bridgeFor(theMap);
-                bridge.destroy();
-                if (bridge === this.bridgeInstance) {
-                    this.bridgeInstance = null;
-                }
-                try {
-                    this._observerTokens.forEach((t) => {
-                        try {
-                            NSNotificationCenter.defaultCenter.removeObserver(t);
-                        }
-                        catch (e) {
-                            console.error(e, e.stack);
-                        }
-                    });
-                    this._observerTokens = [];
+                if (Trace.isEnabled()) {
+                    CLog(CLogTypes.info, 'destroy():', theMap, bridge);
                 }
-                catch (e) {
-                    console.error(e, e.stack);
+                if (bridge) {
+                    bridge.destroy();
+                    if (bridge === this.bridgeInstance) {
+                        this.bridgeInstance = null;
+                    }
                 }
+                this._observerTokens.forEach((t) => {
+                    try {
+                        NSNotificationCenter.defaultCenter.removeObserver(t);
+                    }
+                    catch (e) {
+                        console.error(e, e.stack);
+                    }
+                });
+                this._observerTokens = [];
                 if (this._reusableCalloutView) {
                     this._reusableCalloutView._tearDownUI();
                     this._reusableCalloutView = null;
@@ -1034,8 +1034,14 @@ export class Mapbox extends MapboxCommon {
                     reject('No bridge available');
                     return;
                 }
+                if (Trace.isEnabled()) {
+                    CLog(CLogTypes.info, 'setMapStyle():', style);
+                }
                 const styleStr = (typeof style === 'string' ? style : style.toString()) ?? 'streets';
                 b.setStyle(styleStr, (success, error) => {
+                    if (Trace.isEnabled()) {
+                        CLog(CLogTypes.info, 'setMapStyle():', style, 'done:', success, error);
+                    }
                     if (success)
                         resolve();
                     else
@@ -1043,6 +1049,7 @@ export class Mapbox extends MapboxCommon {
                 });
             }
             catch (ex) {
+                console.error('setMapStyle():', ex, ex['stack']);
                 reject(ex);
             }
         });
@@ -1304,14 +1311,14 @@ export class Mapbox extends MapboxCommon {
     // ---------------- Callouts ----------------
     createCalloutView(marker) {
         if (Trace.isEnabled()) {
-            CLog(CLogTypes.info, 'createCalloutView():', marker.id, marker.title, !!this._reusableCalloutView);
+            CLog(CLogTypes.info, 'createCalloutView():', marker.id, marker.title, marker?.subtitle, !!this._reusableCalloutView);
         }
         if (this._reusableCalloutView) {
             const title = this._reusableCalloutView.getViewById('title');
             title.text = marker?.title || '';
             const subtitle = this._reusableCalloutView.getViewById('subtitle');
             subtitle.text = marker?.subtitle;
-            subtitle.visibility = marker?.subtitle ? 'visible' : 'collapse';
+            // subtitle.visibility = marker?.subtitle ? 'visible' : 'collapse';
         }
         else {
             this._reusableCalloutView = createInfoWindowView(marker.title, marker.subtitle);

package/markers/Marker.common.js

@@ -8,6 +8,7 @@ export function createInfoWindowView(title, snippet) {
     view.width = 'auto'; // WRAP_CONTENT
     view.height = 'auto'; // WRAP_CONTENT
     view.borderRadius = 12;
+    view.color = new Color('#555');
     view['shadowColor'] = '#000';
     view['shadowOpacity'] = 0.25;
     view['shadowRadius'] = 8;

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@nativescript-community/ui-mapbox",
-    "version": "7.0.8",
+    "version": "7.0.10",
     "description": "Interactive, thoroughly customizable maps powered by vector tiles and OpenGL.",
     "main": "index",
     "typings": "index.d.ts",
@@ -55,5 +55,5 @@
     "dependencies": {
         "@nativescript-community/perms": "^3.0.4"
     },
-    "gitHead": "95b0b4305dc426d5bc4f46178686228ff9636fc3"
+    "gitHead": "c43922d8db0e76946ab89655313a4acfc34a0d81"
 }

package/platforms/ios/src/MapboxBridge.swift

@@ -592,7 +592,7 @@ public class MapboxBridge: NSObject {
         guard let mv = mapView else { completion(false, NSError(domain: "MapboxBridge", code: 1, userInfo: [NSLocalizedDescriptionKey: "No map available"])); return }
         mv.mapboxMap.onStyleLoaded.observeNext { _ in completion(true, nil) }.store(in: &cancelables)
         mv.mapboxMap.loadStyle(getMapStyleURI(styleURIorURL));
-        completion(false, NSError(domain: "MapboxBridge", code: 2, userInfo: [NSLocalizedDescriptionKey: "Invalid style string"]))
+        // completion(false, NSError(domain: "MapboxBridge", code: 2, userInfo: [NSLocalizedDescriptionKey: "Invalid style string"]))
     }
     
     // MARK: - Camera / viewport / animateCamera
@@ -953,14 +953,14 @@ public class MapboxBridge: NSObject {
         return true
         
     }
-    @objc public func removePolygons(_ _ids: [String]?) {
-        guard let manager = polygonAnnotationManager else { return }
+    @objc public func removePolygons(_ _ids: [String]?) -> Bool {
+        guard let manager = polygonAnnotationManager else { return false }
         guard let ids = _ids else {
             manager.annotations.removeAll()
             if let outlineManager = polygonOutlineAnnotationManager {
                 outlineManager.annotations.removeAll()
             }
-            return
+            return true
         }
         //        guard let data = idsJSON!.data(using: .utf8) else { return }
         //        guard let ids = try? JSONSerialization.jsonObject(with: data, options: []) as! [String] else { return }
@@ -977,18 +977,20 @@ public class MapboxBridge: NSObject {
         if let outlineManager = polygonOutlineAnnotationManager {
             outlineManager.annotations.removeAll { idSet.contains($0.id) }
         }
+        return true
     }
     
-    @objc public func removePolylines(_ _ids: [String]?) {
-        guard let manager = polylineAnnotationManager else { return }
+    @objc public func removePolylines(_ _ids: [String]?) -> Bool {
+        guard let manager = polylineAnnotationManager else { return false }
         guard let ids = _ids else {
             manager.annotations.removeAll()
-            return
+            return true
         }
         
         let idSet = Set<String>(ids)
         
         manager.annotations.removeAll { idSet.contains($0.id) }
+        return true
     }
     
     enum GeoJSONSourceUpdateError: Error {