@nativescript-community/ui-image 4.3.15 → 4.3.16

package/CHANGELOG.md

@@ -3,6 +3,12 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [4.3.16](https://github.com/nativescript-community/ui-image/compare/v4.3.15...v4.3.16) (2023-09-29)
+
+### Bug Fixes
+
+* **android:** fix for image disappearing on fragment/ativity transitions. See https://github.com/facebook/fresco/issues/1446 ([b36d001](https://github.com/nativescript-community/ui-image/commit/b36d0012af443fadcdb969e901f7f0e69f4e0c80))
+
 ## [4.3.15](https://github.com/nativescript-community/ui-image/compare/v4.3.14...v4.3.15) (2023-09-28)
 
 ### Bug Fixes

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@nativescript-community/ui-image",
-    "version": "4.3.15",
+    "version": "4.3.16",
     "description": "Advanced and efficient image display plugin which uses Fresco (Android) and SDWebImage (iOS) to implement caching, placeholders, image effects, and much more.",
     "main": "./index",
     "sideEffects": false,
@@ -44,5 +44,5 @@
     },
     "license": "Apache-2.0",
     "readmeFilename": "README.md",
-    "gitHead": "b2f5267f7fb2098d3bc7d6c77f4c88f6235005b7"
+    "gitHead": "7d5be4ee8fb3fcef33da045af7151873cd084b4b"
 }

package/platforms/android/java/com/nativescript/image/DraweeView.java

@@ -39,12 +39,24 @@ public class DraweeView extends SimpleDraweeView {
     public boolean isUsingOutlineProvider = false;
     private static Paint clipPaint;
 
+    private boolean mLegacyVisibilityHandlingEnabled = false;
+
+    private static boolean sGlobalLegacyVisibilityHandlingEnabled = true;
+
+    public static void setGlobalLegacyVisibilityHandlingEnabled(
+        boolean legacyVisibilityHandlingEnabled) {
+        sGlobalLegacyVisibilityHandlingEnabled = legacyVisibilityHandlingEnabled;
+    }
+
     public DraweeView(Context context, GenericDraweeHierarchy hierarchy) {
         super(context);
     }
 
     public DraweeView(Context context) {
         super(context);
+        // In Android N and above, visibility handling for Drawables has been changed, which breaks
+        // activity transitions with DraweeViews.
+        mLegacyVisibilityHandlingEnabled = sGlobalLegacyVisibilityHandlingEnabled  && context.getApplicationInfo().targetSdkVersion >= 24; //Build.VERSION_CODES.N
     }
 
     public DraweeView(Context context, AttributeSet attrs) {
@@ -55,6 +67,61 @@ public class DraweeView extends SimpleDraweeView {
         super(context, attrs, defStyle);
     }
 
+    @Override
+    protected void onAttachedToWindow() {
+        super.onAttachedToWindow();
+        maybeOverrideVisibilityHandling();
+        onAttach();
+    }
+
+    @Override
+    protected void onDetachedFromWindow() {
+        super.onDetachedFromWindow();
+        maybeOverrideVisibilityHandling();
+        onDetach();
+    }
+
+    @Override
+    public void onStartTemporaryDetach() {
+        super.onStartTemporaryDetach();
+        maybeOverrideVisibilityHandling();
+        onDetach();
+    }
+
+    @Override
+    public void onFinishTemporaryDetach() {
+        super.onFinishTemporaryDetach();
+        maybeOverrideVisibilityHandling();
+        onAttach();
+    }
+
+    @Override
+    protected void onVisibilityChanged(
+        View changedView,
+        int visibility) {
+        super.onVisibilityChanged(changedView, visibility);
+        maybeOverrideVisibilityHandling();
+    }
+
+    @Override
+    public void onVisibilityAggregated (boolean isVisible) {
+        super.onVisibilityAggregated(isVisible);
+        maybeOverrideVisibilityHandling();
+    }
+
+    private void maybeOverrideVisibilityHandling() {
+        if (mLegacyVisibilityHandlingEnabled)  {
+            Drawable drawable = getDrawable();
+            if (drawable != null) {
+                drawable.setVisible(getVisibility() == VISIBLE, false);
+            }
+        }
+    }
+
+    public void setLegacyVisibilityHandlingEnabled(boolean legacyVisibilityHandlingEnabled) {
+        mLegacyVisibilityHandlingEnabled = legacyVisibilityHandlingEnabled;
+    }
+
 	// private final Rect outlineRect = new RectF();
     public void updateOutlineProvider() {
         Drawable drawable = getBackground();