@nathapp/nax 0.78.0 → 0.79.0

package/flows/nax-finish/nax-finish.flow.ts

@@ -31,11 +31,11 @@
  *   the `acceptance` node last passed, and the repo-root `test` command does
  *   not cover per-feature acceptance tests — so without this a fix could break
  *   the contract the first gate proved and still ship.
- * - `commit_gate` re-enters `review_quality` when its fix touched non-test code
- *   — the gate loop was previously the one editing loop whose output only ever
- *   faced mechanical checks. A test-only fix skips the re-review by explicit
- *   cost tradeoff; see `gateCommitRoute` for why that is a known hole. The skip
- *   records `review-skipped`, so it is visible in the audit.
+ * - `commit_gate` re-enters `review_quality` whenever its fix committed — the
+ *   gate loop was otherwise the one editing loop whose output faced only
+ *   mechanical checks, which a fix that degrades the tests it repairs will
+ *   satisfy. A test-only fix used to skip the re-review as a cost tradeoff;
+ *   #1510 closed that hole. See `gateCommitRoute`.
  * - `load_ctx` and `open_pr` both route to `escalate` rather than throwing on
  *   their own failures. acpx has no error edge, so a throw ends the run with no
  *   result file for the plugin to read or notify from — the one outcome that
@@ -103,14 +103,23 @@ export const _openPrDeps = {
  *
  * - `unchanged` — nothing committed; no new diff, so nothing to review.
  * - `tests-only` — every touched path matched the repo's test-file patterns.
- *   Skipped by explicit choice: the re-review is the flow's most expensive node
- *   and a gate fix is usually a mechanical test repair. **This is a real hole.**
- *   The defect that motivated the re-entry (rs-stock `b6fb66dd`) was itself
- *   test-only — 8 copy-pasted stubs across 3 test files — so this route would
- *   not have caught it. Widen it here if test-quality regressions start
- *   shipping — the audit's `review-skipped` rounds are the evidence.
  * - `changed` — production code was touched, or the paths could not be
  *   classified at all. "Cannot classify" reviews rather than skips.
+ *
+ * `tests-only` and `changed` both re-enter `review_quality` (#1510). They used
+ * to diverge: `tests-only` skipped the re-review as a cost tradeoff, on the
+ * reasoning that a gate fix is usually a mechanical test repair. That was a
+ * real hole — the defect that motivated the re-entry was itself test-only, 8
+ * copy-pasted stubs across 3 test files, so the skip would not have caught the
+ * very thing it was built for. A gate fix can turn a red suite green by
+ * degrading the tests it repairs, and `quality_gates` is satisfied by exactly
+ * that; nothing else read that diff. The audit settled the cost side: across
+ * every finish recorded, exactly one `gate` round has ever fired, so the skip
+ * was saving a review that almost never runs.
+ *
+ * The classification is kept even though both routes now review. It is what a
+ * cheaper test-quality-scoped reviewer would key off if gate rounds ever become
+ * frequent enough for the full re-review to hurt.
  */
 async function gateCommitRoute(
   i: FinishInput,
@@ -509,7 +518,7 @@ export default defineFlow({
       from: "commit_gate",
       switch: {
         on: "$.route",
-        cases: { changed: "review_quality", "tests-only": "quality_gates", unchanged: "quality_gates" },
+        cases: { changed: "review_quality", "tests-only": "review_quality", unchanged: "quality_gates" },
       },
     },
     // The narrative runs only once the PR exists. acpx has no error edge, so an

package/flows/nax-finish/steps/commit-round.ts

@@ -16,16 +16,15 @@ const REVIEWED_PHASES: FinishPhase[] = ["spec", "quality"];
 /**
  * What produced this round, given the successor the commit routed to.
  *
- * The `route` argument is why this is computed after the commit rather than
- * alongside it: `tests-only` is only known once the committed paths have been
- * classified, and it is the difference between "no reviewer exists for this
- * phase" and "a reviewer exists, was owed a look, and was skipped".
+ * `route` no longer changes the answer, and that is the point: since #1510
+ * every committed gate fix re-enters `review_quality`, so no route can skip an
+ * owed re-review. The parameter stays because the round is still keyed on the
+ * successor conceptually, and a future route that *does* bypass a reviewer
+ * would need to be reflected here rather than silently inheriting
+ * `no-reviewer`.
  */
-export function commitRoundOutcome(phase: FinishPhase, route: string): FinishRoundOutcome {
+export function commitRoundOutcome(phase: FinishPhase, _route: string): FinishRoundOutcome {
   if (REVIEWED_PHASES.includes(phase)) return "fixed";
-  // Only `gate` can skip an owed re-review; `acceptance` has no reviewer to
-  // skip, so its `tests-only`-shaped routes (it has none today) stay honest.
-  if (phase === "gate" && route === "tests-only") return "review-skipped";
   return "no-reviewer";
 }
 
@@ -58,6 +57,7 @@ export function buildCommitRound(i: CommitRoundInput): FinishRound {
     committed: i.committed,
     outcome: commitRoundOutcome(i.phase, i.route),
     findings: i.findings,
+    route: i.route,
     ...(i.failing ? { failing: i.failing } : {}),
     ...(i.committed && i.shaAfter ? { sha: i.shaAfter } : {}),
   };

package/flows/nax-finish/types.ts

@@ -80,16 +80,17 @@ export type FinishRoundOutcome =
    */
   | "no-reviewer"
   /**
-   * A re-review was owed and deliberately skipped — today only a `gate` fix
-   * that touched test files exclusively (`gateCommitRoute` → `tests-only`).
+   * A re-review was owed and deliberately skipped.
    *
-   * Distinct from `no-reviewer`, which the same node writes when the fix *is*
-   * routed on to `review_quality`. Without the distinction both wrote
-   * `no-reviewer`, so the audit could not tell a gate fix that was re-reviewed
-   * from one whose re-review was skipped by policy — the #1507 failure mode
-   * surviving on the one path where the omission is intentional, and the path
-   * where a reader most needs to know. Recording it is also what makes "how
-   * often does this fire?" answerable before anyone decides to close the hole.
+   * **No longer emitted.** It described the `gate` → `tests-only` route, which
+   * skipped `review_quality` as a cost tradeoff; #1510 closed that hole, so
+   * every committed gate fix is now re-reviewed and nothing writes this.
+   *
+   * Retained because the audit trail is read, not just written: a project that
+   * ran an earlier nax can hold rounds carrying this outcome, and dropping it
+   * from the union would make those unrenderable. Do not reuse the name for a
+   * new meaning — a reader hitting it in an old artifact must still be told
+   * what it meant when it was written.
    */
   | "review-skipped";
 
@@ -106,6 +107,19 @@ export interface FinishRound {
   findings: Finding[];
   /** Gate commands that were red this round (gate phase). */
   failing?: string[];
+  /**
+   * The successor this round's commit routed to — `changed` / `tests-only` /
+   * `unchanged` for `gate`, `changed` / `unchanged` elsewhere.
+   *
+   * Recorded because `outcome` stopped carrying it. Until #1510 a tests-only
+   * gate fix was the only round writing `review-skipped`, so the outcome
+   * doubled as the classification; now every committed gate fix is reviewed
+   * and writes `no-reviewer`, which would leave "what did this fix touch?"
+   * unanswerable from the trail. That question is the input to deciding
+   * whether the re-review ever needs a cheaper, test-scoped form, so it has to
+   * survive the round it was computed in.
+   */
+  route?: string;
   /**
    * `HEAD` SHA after this round's commit (set only when `committed`); absent
    * on no-op rounds so a reader can distinguish "no commit" from "record lost".

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nathapp/nax",
-  "version": "0.78.0",
+  "version": "0.79.0",
   "description": "AI Coding Agent Orchestrator — loops until done",
   "type": "module",
   "bin": {
@@ -47,9 +47,14 @@
     "check:dispatch-context": "bash scripts/check-dispatch-context.sh",
     "check:naxconfig-cast": "bash scripts/check-no-silent-naxconfig-cast.sh",
     "check:runtime-cleanup": "bash scripts/check-runtime-cleanup.sh",
+    "check:scripts": "bash scripts/check-scripts.sh",
     "check:adapter-no-config-import": "bash scripts/check-adapter-no-config-import.sh",
+    "check:test-typecheck": "bun run scripts/check-test-typecheck.ts",
+    "check:test-typecheck:update": "bun run scripts/check-test-typecheck.ts --update-baseline",
+    "check:test-as-unknown-as": "bun run scripts/check-test-as-unknown-as.ts",
+    "check:test-as-unknown-as:update": "bun run scripts/check-test-as-unknown-as.ts --update-baseline",
     "check:gate-reachability": "bun run scripts/check-gate-reachability.ts",
-    "check:all": "bun run lint && bun run check:test-mocks && bun run check:process-cwd && bun run check:no-adapter-wrap && bun run check:dispatch-context && bun run check:naxconfig-cast && bun run check:runtime-cleanup && bun run check:adapter-no-config-import && bun run check:gate-reachability",
+    "check:all": "bun run lint && bun run check:test-mocks && bun run check:process-cwd && bun run check:no-adapter-wrap && bun run check:scripts && bun run check:dispatch-context && bun run check:naxconfig-cast && bun run check:runtime-cleanup && bun run check:adapter-no-config-import && bun run check:test-typecheck && bun run check:test-as-unknown-as && bun run check:gate-reachability",
     "prepublishOnly": "bun run build",
     "test:full": "FULL=1 NAX_PRECHECK=1 bun test test/ --timeout=60000"
   },