@nathapp/nax 0.68.3 → 0.68.4

package/dist/nax.js

@@ -41077,10 +41077,18 @@ ${exceptions.join(`
 
 `)}`;
 }
+function implementerOwnsTests(story) {
+  return SINGLE_SESSION_TEST_OWNING_STRATEGIES.has(story.routing?.testStrategy ?? "");
+}
+function testEditHeadline(story, prohibition) {
+  return implementerOwnsTests(story) ? SINGLE_SESSION_PERMIT_HEADLINE : prohibition;
+}
 function exceptionCountWord(story) {
   return THREE_SESSION_STRATEGIES.has(story.routing?.testStrategy ?? "") ? "four" : "three";
 }
 function escapeHatchFor(story) {
+  if (implementerOwnsTests(story))
+    return SINGLE_SESSION_TEST_EDIT_POLICY;
   const isTdd = THREE_SESSION_STRATEGIES.has(story.routing?.testStrategy ?? "");
   return buildEscapeHatch({ includeMockHandoff: isTdd });
 }
@@ -41152,7 +41160,7 @@ ${errors3}
 2. Only fix findings that are actually valid problems
 3. Do NOT add keys, functions, or imports that already exist \u2014 check first
 
-Do NOT change test files or test behavior \u2014 see the ${exceptionCountWord(story)} narrow exceptions appended below.
+${testEditHeadline(story, `Do NOT change test files or test behavior \u2014 see the ${exceptionCountWord(story)} narrow exceptions appended below.`)}
 Do NOT add new features \u2014 only fix valid issues.
 Commit your fixes when done.${scopeConstraint}${noTestIsolationBlock(story)}${escapeHatchFor(story)}`;
 }
@@ -41206,6 +41214,7 @@ Commit your fixes when done.${scopeConstraint}${noTestIsolationBlock(story)}${es
 }
 function mechanicalRectification(checks3, story, scopeConstraint, opts) {
   const errors3 = formatCheckErrors(checks3, opts);
+  const scopeDirective = implementerOwnsTests(story) ? `Fix all errors listed above that are within this story's scope. ${SINGLE_SESSION_PERMIT_HEADLINE}` : `Fix all errors listed above that are within this story's scope \u2014 see the ${exceptionCountWord(story)} narrow exceptions appended below for sibling-story spillover. Do NOT change test files or test behavior except via those exceptions.`;
   return `You are fixing lint/typecheck errors from a code review.
 
 Story: ${story.title} (${story.id})
@@ -41214,7 +41223,7 @@ The following quality checks failed after implementation:
 
 ${errors3}
 
-Fix all errors listed above that are within this story's scope \u2014 see the ${exceptionCountWord(story)} narrow exceptions appended below for sibling-story spillover. Do NOT change test files or test behavior except via those exceptions.
+${scopeDirective}
 Do NOT add new features \u2014 only fix the quality check errors.
 After fixing, re-run the failing check(s) to verify they pass, then commit your changes.${scopeConstraint}${noTestIsolationBlock(story)}${escapeHatchFor(story)}`;
 }
@@ -41285,11 +41294,29 @@ REASON: <one paragraph: which mock is wrong vs which dispatch the new code uses,
 Rules:
 - Do NOT make any edits yourself; the test-writer will fulfill.
 - Do NOT also emit \`UNRESOLVED:\` in the same turn \u2014 this declaration IS the handoff.
-- FILES must list real test files. Each path must exist and be a test file.`, THREE_SESSION_STRATEGIES, CONTRADICTION_ESCAPE_HATCH, MAX_STRUCTURED_FINDINGS = 10, RAW_WITH_FINDINGS_LIMIT = 1000, RAW_FALLBACK_LIMIT = 4000;
+- FILES must list real test files. Each path must exist and be a test file.`, THREE_SESSION_STRATEGIES, SINGLE_SESSION_TEST_OWNING_STRATEGIES, SINGLE_SESSION_PERMIT_HEADLINE = "You authored these tests in the same session as the implementation, so you MAY edit test files \u2014 but ONLY to resolve a genuine contradiction between a test and this story's acceptance criteria (or between two acceptance criteria). NEVER weaken, delete, loosen, or skip a test merely to make it pass. See the test-edit guidance appended below.", SINGLE_SESSION_TEST_EDIT_POLICY = `
+
+## Test-edit guidance (single-session implementer)
+
+You wrote both the tests and the implementation for this story in one session, so no
+separate test-writer owns the test contract. You therefore MAY edit test files during
+rectification \u2014 subject to these limits:
+
+- Edit a test ONLY to resolve a genuine contradiction between the test and an acceptance
+  criterion, a contradiction between two acceptance criteria, or a clear defect in a test
+  you authored (wrong arity/type, impossible setup, or asserting behavior the ACs do not require).
+- NEVER weaken, delete, loosen, or \`skip\` a test simply because the implementation fails it.
+  A failing test usually means the SOURCE is wrong \u2014 fix the source first.
+- The semantic and adversarial reviewers still gate correctness; gaming a test to pass will be caught.
+
+If two findings or two acceptance criteria contradict each other and you cannot satisfy
+both even after adjusting tests, do not guess. Emit:
+UNRESOLVED: <which findings/ACs conflicted and why they cannot both be satisfied>`, CONTRADICTION_ESCAPE_HATCH, MAX_STRUCTURED_FINDINGS = 10, RAW_WITH_FINDINGS_LIMIT = 1000, RAW_FALLBACK_LIMIT = 4000;
 var init_rectifier_builder_helpers = __esm(() => {
   init_review();
   init_sections2();
   THREE_SESSION_STRATEGIES = new Set(["three-session-tdd", "three-session-tdd-lite"]);
+  SINGLE_SESSION_TEST_OWNING_STRATEGIES = new Set(["tdd-simple", "test-after"]);
   CONTRADICTION_ESCAPE_HATCH = buildEscapeHatch({ includeMockHandoff: false });
 });
 
@@ -41375,11 +41402,13 @@ class RectifierPromptBuilder {
     const parts = [];
     const attemptWord = maxAttempts === 1 ? "1 attempt" : `${maxAttempts} attempts`;
     const exCount = story ? exceptionCountWord(story) : "three";
+    const prohibition = `Do NOT change test files or test behavior \u2014 see the ${exCount} narrow exceptions appended below.`;
+    const testDirective = story ? testEditHeadline(story, prohibition) : prohibition;
     parts.push(`Review failed after your implementation. Fix the following issues (${attemptWord} available before escalation):
 `);
     parts.push(renderPrioritizedFailures(failedChecks));
     parts.push(`
-Fix in priority order. After fixing each priority, re-run the failing check(s) at that level to verify they pass before moving on. Do NOT change test files or test behavior \u2014 see the ${exCount} narrow exceptions appended below. Commit your changes when all checks pass.`);
+Fix in priority order. After fixing each priority, re-run the failing check(s) at that level to verify they pass before moving on. ${testDirective} Commit your changes when all checks pass.`);
     parts.push(story ? escapeHatchFor(story) : CONTRADICTION_ESCAPE_HATCH);
     const guardrails = buildBehavioralGuardrailsSection("implementer", guardrailLevel ?? "lite");
     if (guardrails) {
@@ -41642,7 +41671,7 @@ ${testCommands}
 6. Ensure ALL tests pass before completing.
 
 **IMPORTANT:**
-- Do NOT modify test files \u2014 see the ${exceptionCountWord(story)} narrow exceptions appended below if you believe a test has a lint error, a PRD-contract mismatch, or belongs to a sibling story.
+- ${testEditHeadline(story, `Do NOT modify test files \u2014 see the ${exceptionCountWord(story)} narrow exceptions appended below if you believe a test has a lint error, a PRD-contract mismatch, or belongs to a sibling story.`)}
 - Do NOT loosen assertions to mask implementation bugs.
 - Focus on fixing the source code to meet the test requirements.
 - When running tests, run ONLY the failing test files shown above${cmd ? ` \u2014 NEVER run \`${cmd}\` without a file filter` : " \u2014 never run the full test suite without a file filter"}.
@@ -41742,7 +41771,7 @@ ${errors3}${reasoningSection}${historySection}
 2. Only fix findings that are actually valid problems
 3. Do NOT add keys, functions, or imports that already exist \u2014 check first
 
-Do NOT change test files or test behavior \u2014 see the ${exceptionCountWord(story)} narrow exceptions appended below.
+${testEditHeadline(story, `Do NOT change test files or test behavior \u2014 see the ${exceptionCountWord(story)} narrow exceptions appended below.`)}
 Do NOT add new features \u2014 only fix valid issues.
 Commit your fixes when done.${scopeConstraint}${escapeHatchFor(story)}`;
   }
@@ -41836,7 +41865,7 @@ Tests are failing. Fix the source so all tests pass \u2014 not just the ones lis
 4. Do not declare done until step 3 shows 0 failures.
 
 **IMPORTANT:**
-- Do NOT modify test files \u2014 see the ${exceptionCountWord(opts.story)} narrow exceptions appended below if you believe a test has a lint error, a PRD-contract mismatch, or belongs to a sibling story.
+- ${testEditHeadline(opts.story, `Do NOT modify test files \u2014 see the ${exceptionCountWord(opts.story)} narrow exceptions appended below if you believe a test has a lint error, a PRD-contract mismatch, or belongs to a sibling story.`)}
 - Do NOT loosen assertions to mask implementation bugs.
 - Focus on fixing the source code to meet the test requirements.`);
     parts.push(escapeHatchFor(opts.story));
@@ -58354,7 +58383,7 @@ var package_default;
 var init_package = __esm(() => {
   package_default = {
     name: "@nathapp/nax",
-    version: "0.68.3",
+    version: "0.68.4",
     description: "AI Coding Agent Orchestrator \u2014 loops until done",
     type: "module",
     bin: {
@@ -58449,8 +58478,8 @@ var init_version = __esm(() => {
   NAX_VERSION = package_default.version;
   NAX_COMMIT = (() => {
     try {
-      if (/^[0-9a-f]{6,10}$/.test("a1007103"))
-        return "a1007103";
+      if (/^[0-9a-f]{6,10}$/.test("197c6530"))
+        return "197c6530";
     } catch {}
     try {
       const result = Bun.spawnSync(["git", "rev-parse", "--short", "HEAD"], {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nathapp/nax",
-  "version": "0.68.3",
+  "version": "0.68.4",
   "description": "AI Coding Agent Orchestrator — loops until done",
   "type": "module",
   "bin": {