@nathapp/nax 0.67.4 → 0.67.6

package/dist/nax.js

@@ -51902,6 +51902,82 @@ function collectRectificationPhases(state) {
     state.adversarialReview
   ].filter((phase) => phase !== undefined);
 }
+function toReviewDecisionPayload(opName, output) {
+  if (output === null || output === undefined || typeof output !== "object")
+    return null;
+  const record2 = output;
+  const reviewer = opName === "semantic-review" ? "semantic" : opName === "adversarial-review" ? "adversarial" : null;
+  if (!reviewer)
+    return null;
+  if (record2.failOpen === true) {
+    return { reviewer, parsed: false, passed: true, failOpen: true, result: null };
+  }
+  if (record2.looksLikeFail === true) {
+    return { reviewer, parsed: false, passed: false, looksLikeFail: true, result: null };
+  }
+  if (typeof record2.passed !== "boolean" || !Array.isArray(record2.findings)) {
+    return null;
+  }
+  return {
+    reviewer,
+    parsed: true,
+    passed: record2.passed,
+    result: { passed: record2.passed, findings: record2.findings }
+  };
+}
+function emitReviewDecision(ctx, opName, output) {
+  const payload = toReviewDecisionPayload(opName, output);
+  if (!payload)
+    return;
+  ctx.runtime.dispatchEvents.emitReviewDecision({
+    kind: "review-decision",
+    runId: ctx.runtime.runId,
+    reviewer: payload.reviewer,
+    workdir: ctx.packageDir,
+    projectDir: ctx.runtime.projectDir,
+    outputDir: ctx.runtime.outputDir,
+    storyId: ctx.storyId,
+    featureName: ctx.featureName,
+    timestamp: Date.now(),
+    parsed: payload.parsed,
+    looksLikeFail: payload.parsed ? undefined : payload.looksLikeFail,
+    failOpen: payload.parsed ? false : payload.failOpen,
+    passed: payload.passed,
+    result: payload.result
+  });
+}
+function logUnifiedReviewPhaseStart(storyId, opName) {
+  const logger = getSafeLogger();
+  if (opName === "semantic-review") {
+    logger?.info("review", "Running semantic check", { storyId });
+  } else if (opName === "adversarial-review") {
+    logger?.info("review", "Running adversarial check", { storyId });
+  }
+}
+function logUnifiedReviewPhaseResult(storyId, opName, output) {
+  const logger = getSafeLogger();
+  const payload = toReviewDecisionPayload(opName, output);
+  if (!payload)
+    return;
+  if (!payload.parsed) {
+    if (payload.failOpen) {
+      logger?.warn("review", `${payload.reviewer} review fail-open`, { storyId });
+    } else if (payload.looksLikeFail) {
+      logger?.warn("review", `${payload.reviewer} review returned truncated failure`, { storyId });
+    }
+    return;
+  }
+  const findingsCount = payload.result.findings.length;
+  const title = payload.reviewer === "semantic" ? "Semantic review" : "Adversarial review";
+  if (payload.passed) {
+    logger?.info("review", `${title} passed`, { storyId });
+  } else {
+    logger?.warn("review", `${title} failed: ${findingsCount} findings`, {
+      storyId,
+      findingsCount
+    });
+  }
+}
 async function runPhase(ctx, slot, phaseCosts, phaseOutputs, isThreeSession = false) {
   const logger = getSafeLogger();
   const opName = slot.op.name;
@@ -51913,11 +51989,14 @@ async function runPhase(ctx, slot, phaseCosts, phaseOutputs, isThreeSession = fa
   } else if (isThreeSession && opName === "full-suite-gate") {
     logger?.info("tdd", "-> Running full test suite gate (before Verifier)", { storyId: ctx.storyId });
   }
+  logUnifiedReviewPhaseStart(ctx.storyId, opName);
   const phaseStartedAt = Date.now();
   const scope = ctx.runtime.costAggregator.openScope();
   try {
     const output = await _storyOrchestratorDeps.callOp({ ...ctx, scopeId: scope.scopeId }, slot.op, dispatchInput);
     phaseOutputs[opName] = output;
+    emitReviewDecision(ctx, opName, output);
+    logUnifiedReviewPhaseResult(ctx.storyId, opName, output);
     if (isTddPhase) {
       const durationMs = Date.now() - phaseStartedAt;
       logger?.info("tdd", `Session complete: ${opName}`, {
@@ -52555,6 +52634,9 @@ async function closeAllRunSessions(sessionManager, agentGetFn, opts) {
 }
 
 // src/execution/post-run.ts
+function shouldRollbackTddFailure(tddMode, failureCategory) {
+  return tddMode?.rollbackEnabled === true && failureCategory === "isolation-violation";
+}
 function extractPauseReason(phaseOutputs) {
   for (const output of Object.values(phaseOutputs)) {
     if (output !== null && typeof output === "object") {
@@ -52737,7 +52819,7 @@ async function decideStageAction(ctx, planResult, inspection, opts) {
   const logger = getLogger();
   const isTdd = opts.tddMode !== null;
   const isLiteMode = opts.tddMode?.isLite ?? false;
-  const shouldRollback = opts.tddMode?.rollbackEnabled === true;
+  const shouldRollback = shouldRollbackTddFailure(opts.tddMode, inspection.failureCategory);
   const { agentResult, selfVerificationFailed, pauseReason, failureCategory, needsHumanReview, combinedOutput } = inspection;
   if (planResult.rectificationExhausted && planResult.unfixedFindings && planResult.unfixedFindings.length > 0) {
     const sources = new Set(planResult.unfixedFindings.map((f) => f.source));
@@ -56654,7 +56736,7 @@ var package_default;
 var init_package = __esm(() => {
   package_default = {
     name: "@nathapp/nax",
-    version: "0.67.4",
+    version: "0.67.6",
     description: "AI Coding Agent Orchestrator \u2014 loops until done",
     type: "module",
     bin: {
@@ -56749,8 +56831,8 @@ var init_version = __esm(() => {
   NAX_VERSION = package_default.version;
   NAX_COMMIT = (() => {
     try {
-      if (/^[0-9a-f]{6,10}$/.test("58c1f972"))
-        return "58c1f972";
+      if (/^[0-9a-f]{6,10}$/.test("8e8f2b3a"))
+        return "8e8f2b3a";
     } catch {}
     try {
       const result = Bun.spawnSync(["git", "rev-parse", "--short", "HEAD"], {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nathapp/nax",
-  "version": "0.67.4",
+  "version": "0.67.6",
   "description": "AI Coding Agent Orchestrator — loops until done",
   "type": "module",
   "bin": {