@nathapp/nax 0.67.12 → 0.67.13

package/dist/nax.js

@@ -32839,6 +32839,122 @@ var init_categorization = __esm(() => {
   MECHANICAL_REVIEW_CHECKS = new Set(ORDERED_MECHANICAL_REVIEW_CHECKS);
   LLM_REVIEW_CHECKS = new Set(ORDERED_LLM_REVIEW_CHECKS);
 });
+
+// src/review/prepare-inputs.ts
+import { relative as relative8, sep as sep2 } from "path";
+function derivePackageDirs(workdir, projectDir) {
+  const repoRoot = projectDir ?? workdir;
+  const packageDir = workdir !== repoRoot ? workdir : undefined;
+  let packageDirRelative;
+  if (projectDir && workdir !== projectDir) {
+    const rel = relative8(projectDir, workdir);
+    if (rel !== ".." && !rel.startsWith(`..${sep2}`)) {
+      packageDirRelative = rel && rel !== "." ? rel : undefined;
+    }
+  }
+  return { repoRoot, packageDir, packageDirRelative };
+}
+async function prepareSemanticReviewInput(args) {
+  const { workdir, projectDir, storyId, storyGitRef, config: config2, naxIgnoreIndex, semanticConfig } = args;
+  const effectiveRef = await resolveEffectiveRef(workdir, storyGitRef, storyId);
+  if (!effectiveRef) {
+    return {
+      effectiveRef: undefined,
+      stat: "",
+      diff: undefined,
+      excludePatterns: [],
+      skipReason: "no git ref"
+    };
+  }
+  const { packageDir, packageDirRelative } = derivePackageDirs(workdir, projectDir);
+  const stat = await collectDiffStat(workdir, effectiveRef, { naxIgnoreIndex, packageDir });
+  const resolved = await resolveTestFilePatterns(config2 ?? reviewConfigSelector.select(DEFAULT_CONFIG), projectDir ?? workdir, packageDirRelative);
+  const excludePatterns = [...resolveReviewExcludePatterns(semanticConfig.excludePatterns, resolved)];
+  const diffMode = semanticConfig.diffMode ?? "ref";
+  if (diffMode === "ref") {
+    if (!stat) {
+      return { effectiveRef, stat: "", diff: undefined, excludePatterns, skipReason: "no changes detected" };
+    }
+    return { effectiveRef, stat, diff: undefined, excludePatterns };
+  }
+  const rawDiff = await collectDiff(workdir, effectiveRef, excludePatterns, { naxIgnoreIndex, packageDir });
+  const diff = truncateDiff(rawDiff, rawDiff.length > DIFF_CAP_BYTES ? stat : undefined);
+  if (!diff) {
+    return { effectiveRef, stat, diff: undefined, excludePatterns, skipReason: "no production code changes" };
+  }
+  return { effectiveRef, stat, diff, excludePatterns };
+}
+async function prepareAdversarialReviewInput(args) {
+  const { workdir, projectDir, storyId, storyGitRef, config: config2, naxIgnoreIndex, adversarialConfig } = args;
+  const effectiveRef = await resolveEffectiveRef(workdir, storyGitRef, storyId);
+  if (!effectiveRef) {
+    return {
+      effectiveRef: undefined,
+      stat: "",
+      diff: undefined,
+      testInventory: undefined,
+      excludePatterns: [],
+      testGlobs: [],
+      refExcludePatterns: [],
+      skipReason: "no git ref"
+    };
+  }
+  const { packageDir, packageDirRelative } = derivePackageDirs(workdir, projectDir);
+  const stat = await collectDiffStat(workdir, effectiveRef, { naxIgnoreIndex, packageDir });
+  const effectiveConfig = config2 ?? reviewConfigSelector.select(DEFAULT_CONFIG);
+  const resolved = await resolveTestFilePatterns(effectiveConfig, projectDir ?? workdir, packageDirRelative);
+  const refExcludePatterns = [...resolveReviewExcludePatterns(adversarialConfig.excludePatterns, resolved)];
+  const testGlobs = resolved.globs ?? [];
+  const excludePatterns = [...adversarialConfig.excludePatterns ?? []];
+  const diffMode = adversarialConfig.diffMode ?? "ref";
+  const testFilePatterns = (typeof config2?.execution?.smartTestRunner === "object" ? config2.execution.smartTestRunner?.testFilePatterns : undefined) ?? undefined;
+  if (diffMode === "ref") {
+    if (!stat) {
+      return {
+        effectiveRef,
+        stat: "",
+        diff: undefined,
+        testInventory: undefined,
+        excludePatterns,
+        testGlobs,
+        refExcludePatterns,
+        skipReason: "no changes detected"
+      };
+    }
+    return {
+      effectiveRef,
+      stat,
+      diff: undefined,
+      testInventory: undefined,
+      excludePatterns,
+      testGlobs,
+      refExcludePatterns
+    };
+  }
+  const diff = await collectDiff(workdir, effectiveRef, excludePatterns, { naxIgnoreIndex, packageDir });
+  if (!diff) {
+    return {
+      effectiveRef,
+      stat,
+      diff: undefined,
+      testInventory: undefined,
+      excludePatterns,
+      testGlobs,
+      refExcludePatterns,
+      skipReason: "no code changes"
+    };
+  }
+  const testInventory = await computeTestInventory(workdir, effectiveRef, testFilePatterns, {
+    naxIgnoreIndex,
+    packageDir
+  });
+  return { effectiveRef, stat, diff, testInventory, excludePatterns, testGlobs, refExcludePatterns };
+}
+var init_prepare_inputs = __esm(() => {
+  init_config();
+  init_test_runners();
+  init_diff_utils();
+});
 // src/utils/process-kill.ts
 function killProcessGroup(pid, signal) {
   try {
@@ -33271,7 +33387,7 @@ var init_runners = __esm(() => {
 });
 
 // src/verification/smart-runner.ts
-import { join as join19, relative as relative8 } from "path";
+import { join as join19, relative as relative9 } from "path";
 function extractPatternSuffix(pattern) {
   const lastStar = pattern.lastIndexOf("*");
   if (lastStar === -1)
@@ -33381,7 +33497,7 @@ async function getChangedNonTestFiles(workdir, baseRef, packagePrefix, testFileR
     let effectivePrefix = packagePrefix;
     if (packagePrefix && repoRoot) {
       const gitRoot = await _gitUtilDeps.getGitRoot(workdir);
-      const extraPrefix2 = gitRoot && gitRoot !== repoRoot ? relative8(gitRoot, repoRoot) : "";
+      const extraPrefix2 = gitRoot && gitRoot !== repoRoot ? relative9(gitRoot, repoRoot) : "";
       effectivePrefix = extraPrefix2 ? `${extraPrefix2}/${packagePrefix}` : packagePrefix;
     }
     const scopedRaw = effectivePrefix ? lines.filter((f) => f.startsWith(`${effectivePrefix}/`)) : lines;
@@ -33408,7 +33524,7 @@ async function getChangedTestFiles(workdir, repoRoot, baseRef, packagePrefix, te
     const packageDir = packagePrefix ? join19(repoRoot, packagePrefix) : undefined;
     const ignoreMatchers = naxIgnoreIndex?.getMatchers(packageDir) ?? await resolveNaxIgnorePatterns(repoRoot, packageDir);
     const gitRoot = await _gitUtilDeps.getGitRoot(workdir);
-    const extraPrefix = gitRoot && gitRoot !== repoRoot ? relative8(gitRoot, repoRoot) : "";
+    const extraPrefix = gitRoot && gitRoot !== repoRoot ? relative9(gitRoot, repoRoot) : "";
     const effectivePrefix = packagePrefix ? extraPrefix ? `${extraPrefix}/${packagePrefix}` : packagePrefix : undefined;
     const scopedRaw = effectivePrefix ? lines.filter((f) => f.startsWith(`${effectivePrefix}/`)) : lines;
     const scoped2 = filterNaxInternalPaths(scopedRaw, ignoreMatchers);
@@ -33841,12 +33957,12 @@ function acceptanceDiagnoseRawArrayToFindings(raw) {
 }
 
 // src/findings/path-utils.ts
-import { relative as relative9, resolve as resolve11 } from "path";
+import { relative as relative10, resolve as resolve11 } from "path";
 function rebaseToWorkdir(rawPath, cwd, workdir) {
   if (rawPath.startsWith("/")) {
-    return relative9(workdir, rawPath);
+    return relative10(workdir, rawPath);
   }
-  return relative9(workdir, resolve11(cwd, rawPath));
+  return relative10(workdir, resolve11(cwd, rawPath));
 }
 var init_path_utils = () => {};
 
@@ -39211,7 +39327,7 @@ var init_lint_parsing = __esm(() => {
 });
 
 // src/review/scoped-lint.ts
-import { join as join24, relative as relative10 } from "path";
+import { join as join24, relative as relative11 } from "path";
 function shellQuotePath4(path5) {
   return `'${path5.replaceAll("'", "'\\''")}'`;
 }
@@ -39248,7 +39364,7 @@ async function listChangedFiles(workdir, baseRef) {
 function inferActivePackageDir(workdir, projectDir) {
   if (!projectDir)
     return;
-  const rel = normalizePath3(relative10(projectDir, workdir));
+  const rel = normalizePath3(relative11(projectDir, workdir));
   if (!rel || rel === "." || rel.startsWith(".."))
     return;
   return rel;
@@ -39733,7 +39849,7 @@ var init_semantic_debate = __esm(() => {
 });
 
 // src/review/semantic.ts
-import { relative as relative11, sep as sep2 } from "path";
+import { relative as relative12, sep as sep3 } from "path";
 function recordSemanticAudit(opts) {
   opts.runtime?.dispatchEvents.emitReviewDecision({
     kind: "review-decision",
@@ -39799,8 +39915,8 @@ async function runSemanticReview(opts) {
   const packageDir = workdir !== repoRoot ? workdir : undefined;
   const stat = await collectDiffStat(workdir, effectiveRef, { naxIgnoreIndex, packageDir });
   const packageDirRelative = projectDir && workdir !== projectDir ? (() => {
-    const rel = relative11(projectDir, workdir);
-    if (rel === ".." || rel.startsWith(`..${sep2}`))
+    const rel = relative12(projectDir, workdir);
+    if (rel === ".." || rel.startsWith(`..${sep3}`))
       return;
     return rel && rel !== "." ? rel : undefined;
   })() : undefined;
@@ -40518,6 +40634,7 @@ var init_review = __esm(() => {
   init_semantic_evidence();
   init_categorization();
   init_diff_utils();
+  init_prepare_inputs();
   init_finding_projection();
   init_runner2();
   init_requote_response();
@@ -44078,9 +44195,9 @@ var init_pid_registry = __esm(() => {
 // src/session/manager-deps.ts
 import { randomUUID as randomUUID3 } from "crypto";
 import { mkdir as mkdir5 } from "fs/promises";
-import { isAbsolute as isAbsolute9, join as join27, relative as relative12, sep as sep3 } from "path";
+import { isAbsolute as isAbsolute9, join as join27, relative as relative13, sep as sep4 } from "path";
 function resolveProjectDirFromScratchDir(scratchDir) {
-  const marker = `${sep3}.nax${sep3}features${sep3}`;
+  const marker = `${sep4}.nax${sep4}features${sep4}`;
   const markerIdx = scratchDir.lastIndexOf(marker);
   if (markerIdx > 0)
     return scratchDir.slice(0, markerIdx);
@@ -44090,7 +44207,7 @@ function resolveProjectDirFromScratchDir(scratchDir) {
   return;
 }
 function toProjectRelativePath(projectDir, pathValue) {
-  const relativePath = isAbsolute9(pathValue) ? relative12(projectDir, pathValue) : pathValue;
+  const relativePath = isAbsolute9(pathValue) ? relative13(projectDir, pathValue) : pathValue;
   return relativePath === "" ? "." : relativePath;
 }
 var _sessionManagerDeps;
@@ -45399,7 +45516,7 @@ var init_windsurf = __esm(() => {
 
 // src/context/generator.ts
 import { existsSync as existsSync9 } from "fs";
-import { join as join30, relative as relative13 } from "path";
+import { join as join30, relative as relative14 } from "path";
 async function loadContextContent(options, config2) {
   if (!_generatorDeps.existsSync(options.contextPath)) {
     throw new Error(`Context file not found: ${options.contextPath}`);
@@ -45527,7 +45644,7 @@ async function discoverWorkspacePackages2(repoRoot) {
 }
 async function generateForPackage(packageDir, config2, dryRun = false, repoRoot) {
   const resolvedRepoRoot = repoRoot ?? packageDir;
-  const relativePkgPath = relative13(resolvedRepoRoot, packageDir);
+  const relativePkgPath = relative14(resolvedRepoRoot, packageDir);
   const contextPath = join30(resolvedRepoRoot, ".nax", "mono", relativePkgPath, "context.md");
   if (!_generatorDeps.existsSync(contextPath)) {
     return [
@@ -52683,26 +52800,34 @@ function phaseExplicitlyPassed(output) {
   const r = output;
   return r.success === true || r.passed === true;
 }
-function phasePassed(opName, output) {
+function phasePassed(opName, output, storyId) {
+  const strictVerdictPhase = STRICT_VERDICT_PHASE_NAMES.has(opName);
   if (output === null || output === undefined) {
-    getSafeLogger()?.warn("story-orchestrator", "Phase produced no output \u2014 treating as pass", {
-      storyId: undefined,
+    getSafeLogger()?.warn("story-orchestrator", strictVerdictPhase ? "Strict phase produced no output \u2014 treating as fail" : "Phase produced no output \u2014 treating as pass", {
+      storyId,
       phase: opName
     });
-    return true;
+    return !strictVerdictPhase;
+  }
+  if (typeof output !== "object") {
+    if (!strictVerdictPhase)
+      return true;
+    getSafeLogger()?.warn("story-orchestrator", "Strict phase produced non-object output \u2014 treating as fail", {
+      storyId,
+      phase: opName
+    });
+    return false;
   }
-  if (typeof output !== "object")
-    return true;
   const r = output;
   if ("success" in r)
     return r.success !== false;
   if ("passed" in r)
     return r.passed !== false;
-  getSafeLogger()?.warn("story-orchestrator", "Phase output has neither 'success' nor 'passed' \u2014 treating as pass", {
-    storyId: undefined,
+  getSafeLogger()?.warn("story-orchestrator", strictVerdictPhase ? "Strict phase output has neither 'success' nor 'passed' \u2014 treating as fail" : "Phase output has neither 'success' nor 'passed' \u2014 treating as pass", {
+    storyId,
     phase: opName
   });
-  return true;
+  return !strictVerdictPhase;
 }
 function isFinding(value) {
   return typeof value === "object" && value !== null && typeof value.source === "string" && value.source.length > 0;
@@ -52825,6 +52950,29 @@ function logUnifiedReviewPhaseStart(storyId, opName) {
     logger?.info("review", "Running adversarial check", { storyId });
   }
 }
+function logDeterministicPhaseOutcome(storyId, opName, output, durationMs, isTddPhase) {
+  if (isTddPhase)
+    return;
+  if (opName === "semantic-review" || opName === "adversarial-review")
+    return;
+  if (output === null || output === undefined || typeof output !== "object")
+    return;
+  const logger = getSafeLogger();
+  const r = output;
+  const success2 = r.success === true || r.passed === true;
+  const findingsCount = Array.isArray(r.findings) ? r.findings.length : undefined;
+  const status = typeof r.status === "string" ? r.status : undefined;
+  const data = { storyId, phase: opName, durationMs };
+  if (findingsCount !== undefined)
+    data.findingsCount = findingsCount;
+  if (status !== undefined)
+    data.status = status;
+  if (success2) {
+    logger?.info("story-orchestrator", `Phase passed: ${opName}`, data);
+  } else {
+    logger?.warn("story-orchestrator", `Phase failed: ${opName}`, data);
+  }
+}
 function logUnifiedReviewPhaseResult(storyId, opName, output) {
   const logger = getSafeLogger();
   const payload = toReviewDecisionPayload(opName, output);
@@ -52894,6 +53042,7 @@ async function runPhase(ctx, slot, phaseCosts, phaseOutputs, isThreeSession = fa
     phaseOutputs[opName] = output;
     emitReviewDecision(ctx, opName, output);
     logUnifiedReviewPhaseResult(ctx.storyId, opName, output);
+    logDeterministicPhaseOutcome(ctx.storyId, opName, output, Date.now() - phaseStartedAt, isTddPhase);
     if (isTddPhase) {
       const durationMs = Date.now() - phaseStartedAt;
       logger?.info("tdd", `Session complete: ${opName}`, {
@@ -52997,8 +53146,22 @@ async function runRectification(ctx, state, phaseCosts, phaseOutputs) {
   };
   const cycleResult = await _storyOrchestratorDeps.runFixCycle(cycle, ctx, "story-orchestrator-rectification", { callOp: wrappedCallOp });
   phaseOutputs.rectification = { iterationCount: cycleResult.iterations.length };
+  const rectLogger = getSafeLogger();
+  const rectSummary = {
+    storyId: ctx.storyId,
+    initialFindingsCount: initialFindings.length,
+    iterationCount: cycleResult.iterations.length,
+    finalFindingsCount: cycleResult.finalFindings.length,
+    exitReason: cycleResult.exitReason,
+    costUsd: cycleResult.costUsd
+  };
+  if (cycleResult.exitReason === "resolved") {
+    rectLogger?.info("story-orchestrator", "Rectification resolved all findings", rectSummary);
+  } else {
+    rectLogger?.warn("story-orchestrator", `Rectification exited: ${cycleResult.exitReason}`, rectSummary);
+  }
   if (cycleResult.exitReason === "validator-error") {
-    getSafeLogger()?.warn("story-orchestrator", "rectification cycle aborted \u2014 validator infrastructure error", {
+    rectLogger?.warn("story-orchestrator", "rectification cycle aborted \u2014 validator infrastructure error", {
       storyId: ctx.storyId
     });
   }
@@ -53054,8 +53217,12 @@ class ExecutionPlan {
         });
         throw error48;
       }
-      if (!phasePassed(phase.slot.op.name, phaseOutputs[phase.slot.op.name])) {
+      if (!phasePassed(phase.slot.op.name, phaseOutputs[phase.slot.op.name], this.ctx.storyId)) {
         if (!shortCircuitExempt.has(phase.slot.op.name)) {
+          logger?.warn("story-orchestrator", "Short-circuiting on phase failure", {
+            storyId: this.ctx.storyId,
+            phase: phase.slot.op.name
+          });
           break;
         }
       }
@@ -53064,20 +53231,43 @@ class ExecutionPlan {
     const verifierName = this.state.verifier?.slot.op.name;
     const gateName = this.state.fullSuiteGate?.slot.op.name;
     const verifierPassedSsot = verifierName !== undefined && phaseExplicitlyPassed(phaseOutputs[verifierName]);
-    if (verifierPassedSsot && gateName !== undefined && !phasePassed(gateName, phaseOutputs[gateName])) {
+    if (verifierPassedSsot && gateName !== undefined && !phasePassed(gateName, phaseOutputs[gateName], this.ctx.storyId)) {
       logger?.warn("story-orchestrator", "Full-suite gate failed but verifier judged story OK \u2014 treating gate failures as unrelated regressions", { storyId: this.ctx.storyId, packageDir: this.ctx.packageDir });
     }
     const success2 = Object.entries(phaseOutputs).every(([name, output]) => {
       if (verifierPassedSsot && name === gateName)
         return true;
-      return phasePassed(name, output);
+      return phasePassed(name, output, this.ctx.storyId);
     });
     const totalCostUsd = Object.values(phaseCosts).reduce((sum, cost) => sum + cost, 0);
+    const durationMs = Date.now() - startedAt;
+    const failedPhases = Object.entries(phaseOutputs).filter(([name, output]) => {
+      if (verifierPassedSsot && name === gateName)
+        return false;
+      return !phasePassed(name, output, this.ctx.storyId);
+    }).map(([name]) => name);
+    const summary = {
+      storyId: this.ctx.storyId,
+      success: success2,
+      totalCostUsd,
+      durationMs,
+      phaseCount: Object.keys(phaseOutputs).length,
+      failedPhases: failedPhases.length > 0 ? failedPhases : undefined
+    };
+    if (rectResult.rectificationExhausted)
+      summary.rectificationExhausted = true;
+    if (rectResult.unfixedFindings)
+      summary.unfixedFindingsCount = rectResult.unfixedFindings.length;
+    if (success2) {
+      logger?.info("story-orchestrator", "Story orchestration complete", summary);
+    } else {
+      logger?.warn("story-orchestrator", "Story orchestration failed", summary);
+    }
     return {
       success: success2,
       phaseCosts,
       totalCostUsd,
-      durationMs: Date.now() - startedAt,
+      durationMs,
       phaseOutputs,
       ...rectResult
     };
@@ -53137,7 +53327,7 @@ class StoryOrchestratorBuilder {
     return new ExecutionPlan(ctx, { ...this.state }, opts.isThreeSession ?? false);
   }
 }
-var _storyOrchestratorDeps, TDD_OP_NAMES, CANONICAL_ORDER, PHASE_KIND_TO_STATE_KEY, STRATEGY_TO_REVALIDATION_PHASES;
+var _storyOrchestratorDeps, TDD_OP_NAMES, STRICT_VERDICT_PHASE_NAMES, CANONICAL_ORDER, PHASE_KIND_TO_STATE_KEY, STRATEGY_TO_REVALIDATION_PHASES;
 var init_story_orchestrator = __esm(() => {
   init_errors();
   init_findings();
@@ -53151,6 +53341,13 @@ var init_story_orchestrator = __esm(() => {
     captureGitRef
   };
   TDD_OP_NAMES = new Set(["test-writer", "implementer", "verifier"]);
+  STRICT_VERDICT_PHASE_NAMES = new Set([
+    fullSuiteGateOp.name,
+    verifyScopedOp.name,
+    lintCheckOp.name,
+    typecheckCheckOp.name,
+    verifierOp.name
+  ]);
   CANONICAL_ORDER = [
     "test-writer",
     "greenfield-gate",
@@ -53392,24 +53589,63 @@ async function assemblePlanInputsFromCtx(ctx) {
   const verifyScopedInput = !_isTdd ? { workdir: ctx.workdir, storyId: story.id } : undefined;
   const lintCheckInput = ctx.config.review?.enabled === true && ctx.config.review.checks?.includes("lint") && ctx.config.quality.commands.lint ? { workdir: ctx.workdir, storyId: story.id } : undefined;
   const typecheckCheckInput = ctx.config.review?.enabled === true && ctx.config.review.checks?.includes("typecheck") && ctx.config.quality.commands.typecheck ? { workdir: ctx.workdir, storyId: story.id } : undefined;
-  const semanticReviewInput = ctx.config.review?.enabled === true && ctx.config.review.checks?.includes("semantic") && ctx.config.review.semantic ? {
-    workdir: ctx.workdir,
-    story,
-    semanticConfig: ctx.config.review.semantic,
-    mode: ctx.config.review.semantic.diffMode,
-    storyGitRef: ctx.storyGitRef,
-    featureCtxBlock: buildFeatureCtxBlock(ctx, "reviewer-semantic"),
-    blockingThreshold: ctx.config.review.blockingThreshold
-  } : undefined;
-  const adversarialReviewInput = ctx.config.review?.enabled === true && ctx.config.review.checks?.includes("adversarial") && ctx.config.review.adversarial ? {
-    workdir: ctx.workdir,
-    story,
-    adversarialConfig: ctx.config.review.adversarial,
-    mode: ctx.config.review.adversarial.diffMode,
-    storyGitRef: ctx.storyGitRef,
-    featureCtxBlock: buildFeatureCtxBlock(ctx, "reviewer-adversarial"),
-    blockingThreshold: ctx.config.review.blockingThreshold
-  } : undefined;
+  const semanticEnabled = ctx.config.review?.enabled === true && ctx.config.review.checks?.includes("semantic") && !!ctx.config.review.semantic;
+  const semanticReviewInput = semanticEnabled ? await (async () => {
+    const prepared = await prepareSemanticReviewInput({
+      workdir: ctx.workdir,
+      projectDir: ctx.projectDir,
+      storyId: story.id,
+      storyGitRef: ctx.storyGitRef,
+      config: ctx.config,
+      naxIgnoreIndex: ctx.naxIgnoreIndex,
+      semanticConfig: ctx.config.review.semantic
+    });
+    if (prepared.skipReason)
+      return;
+    return {
+      workdir: ctx.workdir,
+      story,
+      semanticConfig: ctx.config.review.semantic,
+      mode: ctx.config.review.semantic.diffMode,
+      storyGitRef: prepared.effectiveRef,
+      stat: prepared.stat,
+      diff: prepared.diff,
+      excludePatterns: prepared.excludePatterns,
+      featureCtxBlock: buildFeatureCtxBlock(ctx, "reviewer-semantic"),
+      priorSemanticIterations: ctx.priorSemanticIterations,
+      blockingThreshold: ctx.config.review.blockingThreshold
+    };
+  })() : undefined;
+  const adversarialEnabled = ctx.config.review?.enabled === true && ctx.config.review.checks?.includes("adversarial") && !!ctx.config.review.adversarial;
+  const adversarialReviewInput = adversarialEnabled ? await (async () => {
+    const prepared = await prepareAdversarialReviewInput({
+      workdir: ctx.workdir,
+      projectDir: ctx.projectDir,
+      storyId: story.id,
+      storyGitRef: ctx.storyGitRef,
+      config: ctx.config,
+      naxIgnoreIndex: ctx.naxIgnoreIndex,
+      adversarialConfig: ctx.config.review.adversarial
+    });
+    if (prepared.skipReason)
+      return;
+    return {
+      workdir: ctx.workdir,
+      story,
+      adversarialConfig: ctx.config.review.adversarial,
+      mode: ctx.config.review.adversarial.diffMode,
+      storyGitRef: prepared.effectiveRef,
+      stat: prepared.stat,
+      diff: prepared.diff,
+      testInventory: prepared.testInventory,
+      excludePatterns: prepared.excludePatterns,
+      testGlobs: prepared.testGlobs,
+      refExcludePatterns: prepared.refExcludePatterns,
+      featureCtxBlock: buildFeatureCtxBlock(ctx, "reviewer-adversarial"),
+      priorAdversarialIterations: ctx.priorAdversarialIterations,
+      blockingThreshold: ctx.config.review.blockingThreshold
+    };
+  })() : undefined;
   const rectificationInput = ctx.config.execution?.rectification?.enabled === true ? {
     maxAttempts: ctx.config.execution.rectification.maxAttemptsTotal,
     strategies: [],
@@ -53435,23 +53671,28 @@ var init_plan_inputs = __esm(() => {
   init_context();
   init_errors();
   init_prompts();
+  init_review();
   init_resolver();
   init_build_plan_for_strategy();
 });
 
 // src/pipeline/stages/execution-helpers.ts
-function routeTddFailure(failureCategory, isLiteMode, ctx, reviewReason) {
+function routeTddFailure(failureCategory, isLiteMode, ctx, reviewReason, failureDetail) {
+  const buildReason = (category) => {
+    const trimmedDetail = failureDetail?.trim();
+    return trimmedDetail ? `TDD ${category}: ${trimmedDetail}` : `TDD ${category}`;
+  };
   if (failureCategory === "isolation-violation") {
     if (!isLiteMode) {
       ctx.retryAsLite = true;
     }
-    return { action: "escalate" };
+    return { action: "escalate", reason: buildReason("isolation-violation") };
   }
   if (failureCategory === "session-failure" || failureCategory === "tests-failing" || failureCategory === "full-suite-gate-exhausted" || failureCategory === "verifier-rejected") {
-    return { action: "escalate" };
+    return { action: "escalate", reason: buildReason(failureCategory) };
   }
   if (failureCategory === "greenfield-no-tests") {
-    return { action: "escalate" };
+    return { action: "escalate", reason: buildReason("greenfield-no-tests") };
   }
   return {
     action: "pause",
@@ -53905,7 +54146,16 @@ Category: ${failureCategory ?? "unknown"}`,
       logger.warn("execution", "Rate limited \u2014 will retry", { storyId: ctx.story.id });
     }
     await cleanupSessionOnFailure(ctx);
-    return { action: "escalate" };
+    const failedPhaseNames = Object.keys(failedPhases);
+    const reasonParts = [];
+    reasonParts.push(`agent session failed (exit ${agentResult.exitCode ?? "?"})`);
+    if (failureCategory)
+      reasonParts.push(`category=${failureCategory}`);
+    if (agentResult.rateLimited)
+      reasonParts.push("rate-limited");
+    if (failedPhaseNames.length > 0)
+      reasonParts.push(`phases=${failedPhaseNames.join(",")}`);
+    return { action: "escalate", reason: reasonParts.join("; ") };
   }
   if (!isTdd) {
     await _postRunDeps.autoCommitIfDirty(ctx.workdir, "execution", "single-session", ctx.story.id);
@@ -57730,7 +57980,7 @@ var package_default;
 var init_package = __esm(() => {
   package_default = {
     name: "@nathapp/nax",
-    version: "0.67.12",
+    version: "0.67.13",
     description: "AI Coding Agent Orchestrator \u2014 loops until done",
     type: "module",
     bin: {
@@ -57825,8 +58075,8 @@ var init_version = __esm(() => {
   NAX_VERSION = package_default.version;
   NAX_COMMIT = (() => {
     try {
-      if (/^[0-9a-f]{6,10}$/.test("c747dea2"))
-        return "c747dea2";
+      if (/^[0-9a-f]{6,10}$/.test("45ff95d3"))
+        return "45ff95d3";
     } catch {}
     try {
       const result = Bun.spawnSync(["git", "rev-parse", "--short", "HEAD"], {
@@ -60593,13 +60843,16 @@ var init_tier_outcome = __esm(() => {
 });
 
 // src/execution/escalation/tier-escalation.ts
-function buildEscalationFailure(story, currentTier, reviewFindings, cost) {
+function buildEscalationFailure(story, currentTier, reviewFindings, cost, pipelineReason, failureCategory) {
   const stage = reviewFindings && reviewFindings.length > 0 ? "review" : "escalation";
+  const trimmedReason = pipelineReason?.trim();
+  const categoryPart = failureCategory ? ` [${failureCategory}]` : "";
+  const summary = trimmedReason ? `Tier ${currentTier}${categoryPart}: ${trimmedReason}` : `Tier ${currentTier}${categoryPart} failed \u2014 no pipeline reason recorded`;
   return {
     attempt: (story.attempts ?? 0) + 1,
     modelTier: currentTier,
     stage,
-    summary: `Failed with tier ${currentTier}, escalating to next tier`,
+    summary,
     reviewFindings: reviewFindings && reviewFindings.length > 0 ? reviewFindings : undefined,
     cost: cost ?? 0,
     timestamp: new Date().toISOString()
@@ -60703,7 +60956,7 @@ async function handleTierEscalation(ctx) {
       const isChangingTier = currentStoryTier !== escalatedTier;
       const shouldResetAttempts = isChangingTier || shouldSwitchToTestAfter;
       const escalationRecord = isChangingTier || shouldSwitchToTestAfter ? buildEscalationRecord(currentStoryTier, shouldSwitchToTestAfter ? currentStoryTier : escalatedTier, ctx.pipelineResult.reason ?? "Escalated to next retry path") : undefined;
-      const escalationFailure = buildEscalationFailure(s, currentStoryTier, escalateReviewFindings, ctx.attemptCost);
+      const escalationFailure = buildEscalationFailure(s, currentStoryTier, escalateReviewFindings, ctx.attemptCost, verifiedPipelineReason, escalateFailureCategory);
       return {
         ...s,
         attempts: shouldResetAttempts ? 0 : (s.attempts ?? 0) + 1,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nathapp/nax",
-  "version": "0.67.12",
+  "version": "0.67.13",
   "description": "AI Coding Agent Orchestrator — loops until done",
   "type": "module",
   "bin": {