@nathapp/nax 0.67.1 → 0.67.3

package/dist/nax.js

@@ -35108,6 +35108,24 @@ async function getChangedFiles(workdir, fromRef = "HEAD") {
   return output.trim().split(`
 `).filter(Boolean);
 }
+async function getAddedLinesPerFile(workdir, fromRef = "HEAD") {
+  const proc = _isolationDeps.spawn(["git", "diff", "--numstat", fromRef], {
+    cwd: workdir,
+    stdout: "pipe",
+    stderr: "pipe"
+  });
+  const output = await Bun.readableStreamToText(proc.stdout);
+  await proc.exited;
+  const result = new Map;
+  for (const line of output.trim().split(`
+`).filter(Boolean)) {
+    const [addedStr, _deletedStr, path4] = line.split("\t");
+    const added = Number.parseInt(addedStr ?? "", 10);
+    if (path4 && Number.isFinite(added))
+      result.set(path4, added);
+  }
+  return result;
+}
 function matchesAllowedPath(filePath, allowedPaths) {
   return allowedPaths.some((pattern) => {
     const regexPattern = pattern.replace(/\*\*/g, ".*").replace(/\*/g, "[^/]*").replace(/\//g, "\\/");
@@ -35115,17 +35133,25 @@ function matchesAllowedPath(filePath, allowedPaths) {
     return regex.test(filePath);
   });
 }
-async function verifyTestWriterIsolation(workdir, beforeRef, allowedPaths = ["src/index.ts", "src/**/index.ts"], testFilePatterns = DEFAULT_TEST_FILE_PATTERNS) {
+async function verifyTestWriterIsolation(workdir, beforeRef, allowedPaths = ["src/index.ts", "src/**/index.ts"], testFilePatterns = DEFAULT_TEST_FILE_PATTERNS, mode = "strict") {
   const changed = await getChangedFiles(workdir, beforeRef);
   const sourceFiles = changed.filter((f) => isSourceFile(f) && !isTestFileByPatterns(f, testFilePatterns));
+  const addedLines = mode === "lite" && sourceFiles.length > 0 ? await getAddedLinesPerFile(workdir, beforeRef) : null;
   const softViolations = [];
   const violations = [];
   for (const file3 of sourceFiles) {
     if (matchesAllowedPath(file3, allowedPaths)) {
       softViolations.push(file3);
-    } else {
-      violations.push(file3);
+      continue;
     }
+    if (addedLines) {
+      const added = addedLines.get(file3) ?? Number.POSITIVE_INFINITY;
+      if (added <= LITE_STUB_ADDED_LINES_CEILING) {
+        softViolations.push(file3);
+        continue;
+      }
+    }
+    violations.push(file3);
   }
   return {
     passed: violations.length === 0,
@@ -35151,7 +35177,7 @@ async function verifyImplementerIsolation(workdir, beforeRef, testFilePatterns =
     description: "Implementer should not modify test files"
   };
 }
-var _isolationDeps, SRC_PATTERNS;
+var _isolationDeps, SRC_PATTERNS, LITE_STUB_ADDED_LINES_CEILING = 20;
 var init_isolation = __esm(() => {
   init_test_runners();
   init_bun_deps();
@@ -35235,7 +35261,7 @@ var init_write_test = __esm(() => {
         return parsed;
       const allowedPaths = ctx.config.tdd?.testWriterAllowedPaths ?? ["src/index.ts", "src/**/index.ts"];
       const testFilePatterns = typeof ctx.packageView.config.execution?.smartTestRunner === "object" && ctx.packageView.config.execution.smartTestRunner !== null ? ctx.packageView.config.execution.smartTestRunner.testFilePatterns : undefined;
-      const isolation = await verifyTestWriterIsolation(ctx.packageView.packageDir, input.beforeRef, allowedPaths, testFilePatterns);
+      const isolation = await verifyTestWriterIsolation(ctx.packageView.packageDir, input.beforeRef, allowedPaths, testFilePatterns, input.lite ? "lite" : "strict");
       return { ...parsed, isolation };
     }
   };
@@ -51779,12 +51805,12 @@ async function assertionSiteDiffCheck(workdir, beforeRef, files) {
   }
   return { violated: false };
 }
-async function runIsolationGuard(workdir, beforeRef, config2, packageDir) {
+async function runIsolationGuard(workdir, beforeRef, config2, packageDir, mode = "strict") {
   if (config2.quality.autofix?.enforceTestWriterIsolation === false) {
     return { violated: false, skipped: true };
   }
   const resolved = await resolveTestFilePatterns(config2, workdir, packageDir);
-  const result = await _guardDeps.verifyTestWriterIsolation(workdir, beforeRef, config2.tdd?.testWriterAllowedPaths, resolved.globs);
+  const result = await _guardDeps.verifyTestWriterIsolation(workdir, beforeRef, config2.tdd?.testWriterAllowedPaths, resolved.globs, mode);
   if (!result.passed) {
     return { violated: true, files: result.violations ?? [] };
   }
@@ -52129,7 +52155,7 @@ async function runAgentRectificationV2(ctx, _lintFixCmd, _formatFixCmd, _effecti
         });
         return { unresolved: `assertion_weakening:${assertionResult.file}:${assertionResult.line}` };
       }
-      const isolationResult = await _autofixCycleGuardDeps.runIsolationGuard(ctx.workdir, beforeRef, ctx.config, ctx.story.workdir || undefined);
+      const isolationResult = await _autofixCycleGuardDeps.runIsolationGuard(ctx.workdir, beforeRef, ctx.config, ctx.story.workdir || undefined, ctx.routing?.testStrategy === "three-session-tdd-lite" ? "lite" : "strict");
       if (isolationResult.violated) {
         await _autofixCycleGuardDeps.revertDiff(ctx.workdir, isolationResult.files);
         logger.info("autofix-cycle", "test-writer isolation guard violated \u2014 reverted", {
@@ -54185,6 +54211,12 @@ function collectOrderedPhases(state) {
     return [];
   });
 }
+function phaseExplicitlyPassed(output) {
+  if (output === null || output === undefined || typeof output !== "object")
+    return false;
+  const r = output;
+  return r.success === true || r.passed === true;
+}
 function phasePassed(opName, output) {
   if (output === null || output === undefined) {
     getSafeLogger()?.warn("story-orchestrator", "Phase produced no output \u2014 treating as pass", {
@@ -54368,10 +54400,13 @@ class ExecutionPlan {
     const phaseOutputs = {};
     const startedAt = Date.now();
     const logger = getSafeLogger();
-    const shortCircuitExempt = this.state.rectification ? new Set([
+    const verifierPresent = this.state.verifier !== undefined;
+    const rectificationExempt = this.state.rectification ? [
       ...this.state.fullSuiteGate ? [this.state.fullSuiteGate.slot.op.name] : [],
       ...this.state.verifier ? [this.state.verifier.slot.op.name] : []
-    ]) : new Set;
+    ] : [];
+    const verifierExempt = verifierPresent && this.state.fullSuiteGate ? [this.state.fullSuiteGate.slot.op.name] : [];
+    const shortCircuitExempt = new Set([...rectificationExempt, ...verifierExempt]);
     for (const phase of collectOrderedPhases(this.state)) {
       try {
         await runPhase(this.ctx, phase.slot, phaseCosts, phaseOutputs, this.isThreeSession);
@@ -54390,7 +54425,17 @@ class ExecutionPlan {
       }
     }
     await runRectification(this.ctx, this.state, phaseCosts, phaseOutputs);
-    const success2 = Object.entries(phaseOutputs).every(([name, output]) => phasePassed(name, output));
+    const verifierName = this.state.verifier?.slot.op.name;
+    const gateName = this.state.fullSuiteGate?.slot.op.name;
+    const verifierPassedSsot = verifierName !== undefined && phaseExplicitlyPassed(phaseOutputs[verifierName]);
+    if (verifierPassedSsot && gateName !== undefined && !phasePassed(gateName, phaseOutputs[gateName])) {
+      logger?.warn("story-orchestrator", "Full-suite gate failed but verifier judged story OK \u2014 treating gate failures as unrelated regressions", { storyId: this.ctx.storyId, packageDir: this.ctx.packageDir });
+    }
+    const success2 = Object.entries(phaseOutputs).every(([name, output]) => {
+      if (verifierPassedSsot && name === gateName)
+        return true;
+      return phasePassed(name, output);
+    });
     const totalCostUsd = Object.values(phaseCosts).reduce((sum, cost) => sum + cost, 0);
     return {
       success: success2,
@@ -54599,7 +54644,8 @@ async function assemblePlanInputsFromCtx(ctx) {
     story,
     promptMarkdown: testWriterPrompt,
     featureContextMarkdown: ctx.featureContextMarkdown,
-    constitution: ctx.constitution?.content
+    constitution: ctx.constitution?.content,
+    lite: isLite
   } : undefined;
   const greenfieldGateInput = _isTdd && _isFreshRun && resolvedTestPatterns ? { story, workdir: ctx.workdir, resolvedTestPatterns } : undefined;
   const implementerInput = {
@@ -54800,6 +54846,13 @@ function deriveTddFailureCategory(phaseOutputs) {
     }
     return "tests-failing";
   }
+  const verifierPassed = verifierOutput?.success === true;
+  if (!verifierPassed) {
+    const gateOutput = phaseOutputs[fullSuiteGateOp.name];
+    if (gateOutput && (gateOutput.success === false || gateOutput.passed === false)) {
+      return "tests-failing";
+    }
+  }
   const implOutput = phaseOutputs[implementerOp.name];
   if (implOutput?.success === false) {
     return "session-failure";
@@ -54898,6 +54951,24 @@ async function applyPostRunInspection(ctx, planResult, opts) {
   }
   const pauseReason = extractPauseReason(planResult.phaseOutputs);
   const failureCategory = isTdd && !planResult.success ? deriveTddFailureCategory(planResult.phaseOutputs) : undefined;
+  if (isTdd && !planResult.success && !failureCategory) {
+    const phaseSignals = {};
+    for (const [name, output] of Object.entries(planResult.phaseOutputs)) {
+      if (output && typeof output === "object") {
+        const r = output;
+        const signal = {};
+        if (typeof r.success === "boolean")
+          signal.success = r.success;
+        if (typeof r.passed === "boolean")
+          signal.passed = r.passed;
+        phaseSignals[name] = signal;
+      }
+    }
+    logger.warn("execution", "TDD plan failed but no failure category derived \u2014 defaulting to pause", {
+      storyId: ctx.story.id,
+      phaseSignals
+    });
+  }
   const tddIsolations = {};
   for (const opName of ["test-writer", "implementer", "verifier"]) {
     const phaseOut = planResult.phaseOutputs[opName];
@@ -59182,7 +59253,7 @@ var package_default;
 var init_package = __esm(() => {
   package_default = {
     name: "@nathapp/nax",
-    version: "0.67.1",
+    version: "0.67.3",
     description: "AI Coding Agent Orchestrator \u2014 loops until done",
     type: "module",
     bin: {
@@ -59277,8 +59348,8 @@ var init_version = __esm(() => {
   NAX_VERSION = package_default.version;
   NAX_COMMIT = (() => {
     try {
-      if (/^[0-9a-f]{6,10}$/.test("be0f8521"))
-        return "be0f8521";
+      if (/^[0-9a-f]{6,10}$/.test("bcfe96ad"))
+        return "bcfe96ad";
     } catch {}
     try {
       const result = Bun.spawnSync(["git", "rev-parse", "--short", "HEAD"], {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nathapp/nax",
-  "version": "0.67.1",
+  "version": "0.67.3",
   "description": "AI Coding Agent Orchestrator — loops until done",
   "type": "module",
   "bin": {