@nathapp/nax 0.65.0 → 0.65.1

package/dist/nax.js

@@ -40710,6 +40710,9 @@ var init_checks_cli = __esm(() => {
 
 // src/precheck/checks-system.ts
 import { existsSync as existsSync12, statSync as statSync4 } from "fs";
+function discoverCanonicalRuleRoots(workdir) {
+  return [workdir];
+}
 async function checkDependenciesInstalled(workdir) {
   const depPaths = [
     { path: "node_modules" },
@@ -40787,7 +40790,47 @@ async function checkTypecheckCommand(config2) {
     message: `Typecheck command configured: ${typecheckCommand}`
   };
 }
-var init_checks_system = () => {};
+async function checkCanonicalRulesLint(workdir) {
+  const roots = _checkCanonicalRulesDeps.discoverRoots(workdir);
+  let ruleCount = 0;
+  try {
+    for (const root of roots) {
+      const rules = await _checkCanonicalRulesDeps.loadCanonicalRules(root);
+      ruleCount += rules.length;
+    }
+  } catch (err) {
+    if (err instanceof NeutralityLintError) {
+      const first = err.violations[0];
+      const detail = first ? `${first.file}:${first.lineNumber} (${first.ruleId})` : "unknown location";
+      return {
+        name: "canonical-rules-lint",
+        tier: "blocker",
+        passed: false,
+        message: `Canonical rules lint failed (${err.violations.length} violation(s)): ${detail}`
+      };
+    }
+    return {
+      name: "canonical-rules-lint",
+      tier: "blocker",
+      passed: false,
+      message: `Canonical rules lint failed: ${errorMessage(err)}`
+    };
+  }
+  return {
+    name: "canonical-rules-lint",
+    tier: "blocker",
+    passed: true,
+    message: `Canonical rules lint passed (${ruleCount} file(s) across ${roots.length} root(s))`
+  };
+}
+var _checkCanonicalRulesDeps;
+var init_checks_system = __esm(() => {
+  init_canonical_loader();
+  _checkCanonicalRulesDeps = {
+    discoverRoots: discoverCanonicalRuleRoots,
+    loadCanonicalRules
+  };
+});
 
 // src/precheck/checks-blockers.ts
 var init_checks_blockers = __esm(() => {
@@ -41255,6 +41298,7 @@ function getLateEnvironmentBlockers(config2, workdir) {
     () => checkTestCommand(config2),
     () => checkLintCommand(config2),
     () => checkTypecheckCommand(config2),
+    () => checkCanonicalRulesLint(workdir),
     () => checkGitUserConfigured(workdir)
   ];
 }
@@ -44712,6 +44756,109 @@ var init_diff_utils = __esm(() => {
   DEFAULT_SUFFIX_STRIPPERS = [/\.(test|spec)\.(ts|js|tsx|jsx)$/, /_test\.go$/];
 });
 
+// src/review/finding-projection.ts
+function narrowSeverity(raw) {
+  return SEVERITY_MAP[raw] ?? "info";
+}
+function slugLeadingTokens(text, tokenCount = RULE_ID_SLUG_TOKENS) {
+  return text.toLowerCase().replace(/[^a-z0-9\s-]/g, " ").split(/\s+/).filter(Boolean).slice(0, tokenCount).join("-");
+}
+function deriveRuleId(category, issue2) {
+  const prefix = category?.trim() ? category.trim() : "review";
+  const slug = slugLeadingTokens(issue2) || "unspecified";
+  return `${prefix}:${slug}`;
+}
+function joinMessage(issue2, suggestion) {
+  const trimmedIssue = issue2.trim();
+  const trimmedSuggestion = (suggestion ?? "").trim();
+  if (trimmedIssue && trimmedSuggestion) {
+    return `${trimmedIssue}
+\u2192 ${trimmedSuggestion}`;
+  }
+  return trimmedIssue;
+}
+function buildMeta(f, originalSeverity) {
+  const meta3 = {};
+  if (f.issue)
+    meta3.issue = f.issue;
+  if (f.suggestion)
+    meta3.suggestion = f.suggestion;
+  if (f.acQuote)
+    meta3.acQuote = f.acQuote;
+  if (typeof f.acIndex === "number" && f.acIndex >= 1)
+    meta3.acIndex = f.acIndex;
+  if ("acId" in f && f.acId)
+    meta3.acId = f.acId;
+  if ("verifiedBy" in f && f.verifiedBy)
+    meta3.verifiedBy = f.verifiedBy;
+  if (originalSeverity !== undefined)
+    meta3.originalSeverity = originalSeverity;
+  return Object.keys(meta3).length > 0 ? meta3 : undefined;
+}
+function findingCategory(f) {
+  return "category" in f && f.category ? f.category : undefined;
+}
+function llmFindingToReviewFinding(f, opts = {}) {
+  const category = findingCategory(f);
+  const narrowed = narrowSeverity(f.severity);
+  const result = {
+    ruleId: deriveRuleId(category, f.issue),
+    severity: narrowed,
+    file: f.file,
+    line: f.line,
+    message: joinMessage(f.issue, f.suggestion)
+  };
+  if (category)
+    result.category = category;
+  if (opts.source)
+    result.source = opts.source;
+  const meta3 = buildMeta(f, f.severity !== narrowed ? f.severity : undefined);
+  if (meta3)
+    result.meta = meta3;
+  return result;
+}
+function llmFindingsToReviewFindings(findings, opts = {}) {
+  return findings.map((f) => llmFindingToReviewFinding(f, opts));
+}
+function findingToReviewFinding(f, opts = {}) {
+  const narrowed = narrowSeverity(f.severity);
+  const ruleId = f.rule?.trim() ? f.rule.trim() : deriveRuleId(f.category, f.message);
+  const result = {
+    ruleId,
+    severity: narrowed,
+    file: f.file ?? "",
+    line: f.line ?? 0,
+    message: f.message
+  };
+  if (f.category)
+    result.category = f.category;
+  const effectiveSource = opts.source ?? f.source;
+  if (effectiveSource)
+    result.source = effectiveSource;
+  const meta3 = { ...f.meta ?? {} };
+  if (f.suggestion)
+    meta3.suggestion = f.suggestion;
+  if (f.severity !== narrowed)
+    meta3.originalSeverity = f.severity;
+  if (Object.keys(meta3).length > 0)
+    result.meta = meta3;
+  return result;
+}
+function findingsToReviewFindings(findings, opts = {}) {
+  return findings.map((f) => findingToReviewFinding(f, opts));
+}
+var SEVERITY_MAP, RULE_ID_SLUG_TOKENS = 6;
+var init_finding_projection = __esm(() => {
+  SEVERITY_MAP = {
+    critical: "critical",
+    error: "error",
+    warning: "warning",
+    warn: "warning",
+    info: "info",
+    low: "low"
+  };
+});
+
 // src/review/adversarial.ts
 import { relative as relative11, sep as sep3 } from "path";
 function recordAdversarialAudit(opts) {
@@ -45002,8 +45149,11 @@ async function runAdversarialReview(opts) {
       failOpen: false,
       passed: false,
       blockingThreshold: threshold,
-      result: { passed: false, findings: parsed.findings },
-      advisoryFindings
+      result: {
+        passed: false,
+        findings: llmFindingsToReviewFindings(parsed.findings, { source: "adversarial-review" })
+      },
+      advisoryFindings: advisoryFindings.length > 0 ? llmFindingsToReviewFindings(advisoryFindings, { source: "adversarial-review" }) : undefined
     });
     return {
       check: "adversarial",
@@ -45035,8 +45185,11 @@ ${formatFindings2(blockingFindings)}`,
       failOpen: false,
       passed: true,
       blockingThreshold: threshold,
-      result: { passed: true, findings: parsed.findings },
-      advisoryFindings
+      result: {
+        passed: true,
+        findings: llmFindingsToReviewFindings(parsed.findings, { source: "adversarial-review" })
+      },
+      advisoryFindings: advisoryFindings.length > 0 ? llmFindingsToReviewFindings(advisoryFindings, { source: "adversarial-review" }) : undefined
     });
     return {
       check: "adversarial",
@@ -45063,8 +45216,11 @@ ${formatFindings2(blockingFindings)}`,
     failOpen: false,
     passed: parsed.passed,
     blockingThreshold: threshold,
-    result: { passed: parsed.passed, findings: parsed.findings },
-    advisoryFindings
+    result: {
+      passed: parsed.passed,
+      findings: llmFindingsToReviewFindings(parsed.findings, { source: "adversarial-review" })
+    },
+    advisoryFindings: advisoryFindings.length > 0 ? llmFindingsToReviewFindings(advisoryFindings, { source: "adversarial-review" }) : undefined
   });
   return {
     check: "adversarial",
@@ -45089,6 +45245,7 @@ var init_adversarial = __esm(() => {
   init_ac_quote_validator();
   init_adversarial_helpers();
   init_diff_utils();
+  init_finding_projection();
   init_review_audit();
   _adversarialDeps = {
     writeReviewAudit,
@@ -45481,7 +45638,10 @@ async function runSemanticDebate(opts) {
           parsed: true,
           passed: false,
           blockingThreshold,
-          result: { passed: false, findings }
+          result: {
+            passed: false,
+            findings: findingsToReviewFindings(findings, { source: "semantic-debate-review" })
+          }
         });
         return {
           check: "semantic",
@@ -45507,7 +45667,10 @@ ${findings.map((f) => `${f.rule ?? "semantic"}: ${f.message}`).join(`
         parsed: true,
         passed: true,
         blockingThreshold,
-        result: { passed: true, findings }
+        result: {
+          passed: true,
+          findings: findingsToReviewFindings(findings, { source: "semantic-debate-review" })
+        }
       });
       return {
         check: "semantic",
@@ -45567,8 +45730,11 @@ ${findings.map((f) => `${f.rule ?? "semantic"}: ${f.message}`).join(`
         parsed: true,
         passed: false,
         blockingThreshold: debateThreshold,
-        result: { passed: false, findings: debateFindings },
-        advisoryFindings: debateAdvisory
+        result: {
+          passed: false,
+          findings: llmFindingsToReviewFindings(debateFindings, { source: "semantic-debate-review" })
+        },
+        advisoryFindings: debateAdvisory.length > 0 ? llmFindingsToReviewFindings(debateAdvisory, { source: "semantic-debate-review" }) : undefined
       });
       return {
         check: "semantic",
@@ -45596,8 +45762,11 @@ ${formatFindings(debateBlocking)}`,
       parsed: true,
       passed: true,
       blockingThreshold: debateThreshold,
-      result: { passed: true, findings: debateFindings },
-      advisoryFindings: debateAdvisory
+      result: {
+        passed: true,
+        findings: llmFindingsToReviewFindings(debateFindings, { source: "semantic-debate-review" })
+      },
+      advisoryFindings: debateAdvisory.length > 0 ? llmFindingsToReviewFindings(debateAdvisory, { source: "semantic-debate-review" }) : undefined
     });
     return {
       check: "semantic",
@@ -45619,8 +45788,11 @@ ${formatFindings(debateBlocking)}`,
     parsed: true,
     passed: true,
     blockingThreshold: debateThreshold,
-    result: { passed: true, findings: debateFindings },
-    advisoryFindings: debateAdvisory
+    result: {
+      passed: true,
+      findings: llmFindingsToReviewFindings(debateFindings, { source: "semantic-debate-review" })
+    },
+    advisoryFindings: debateAdvisory.length > 0 ? llmFindingsToReviewFindings(debateAdvisory, { source: "semantic-debate-review" }) : undefined
   });
   return {
     check: "semantic",
@@ -45636,6 +45808,7 @@ ${formatFindings(debateBlocking)}`,
 var init_semantic_debate = __esm(() => {
   init_logger2();
   init_ac_quote_validator();
+  init_finding_projection();
   init_semantic_helpers();
 });
 
@@ -46036,8 +46209,11 @@ ${formatFindings(blockingFindings)}`;
       failOpen: false,
       passed: false,
       blockingThreshold: threshold,
-      result: { passed: false, findings: sanitizedParsed.findings },
-      advisoryFindings
+      result: {
+        passed: false,
+        findings: llmFindingsToReviewFindings(sanitizedParsed.findings, { source: "semantic-review" })
+      },
+      advisoryFindings: advisoryFindings.length > 0 ? llmFindingsToReviewFindings(advisoryFindings, { source: "semantic-review" }) : undefined
     });
     return {
       check: "semantic",
@@ -46067,8 +46243,11 @@ ${formatFindings(blockingFindings)}`;
       failOpen: false,
       passed: true,
       blockingThreshold: threshold,
-      result: { passed: true, findings: sanitizedParsed.findings },
-      advisoryFindings
+      result: {
+        passed: true,
+        findings: llmFindingsToReviewFindings(sanitizedParsed.findings, { source: "semantic-review" })
+      },
+      advisoryFindings: advisoryFindings.length > 0 ? llmFindingsToReviewFindings(advisoryFindings, { source: "semantic-review" }) : undefined
     });
     return {
       check: "semantic",
@@ -46095,8 +46274,11 @@ ${formatFindings(blockingFindings)}`;
     failOpen: false,
     passed: sanitizedParsed.passed,
     blockingThreshold: threshold,
-    result: { passed: sanitizedParsed.passed, findings: sanitizedParsed.findings },
-    advisoryFindings
+    result: {
+      passed: sanitizedParsed.passed,
+      findings: llmFindingsToReviewFindings(sanitizedParsed.findings, { source: "semantic-review" })
+    },
+    advisoryFindings: advisoryFindings.length > 0 ? llmFindingsToReviewFindings(advisoryFindings, { source: "semantic-review" }) : undefined
   });
   return {
     check: "semantic",
@@ -46122,6 +46304,7 @@ var init_semantic = __esm(() => {
   init_test_runners();
   init_ac_quote_validator();
   init_diff_utils();
+  init_finding_projection();
   init_review_audit();
   init_semantic_debate();
   init_semantic_evidence();
@@ -52583,7 +52766,18 @@ async function collectFromMetrics(context) {
   return observations;
 }
 function findingRuleId(finding) {
-  return stringValue(finding.rule ?? finding.ruleId ?? finding.checkId ?? finding.category, "unknown");
+  return stringValue(finding.ruleId ?? finding.rule ?? finding.checkId ?? finding.category, "unknown");
+}
+function findingMessage(finding) {
+  const message = stringValue(finding.message);
+  if (message)
+    return message;
+  const issue2 = stringValue(finding.issue);
+  const suggestion = stringValue(finding.suggestion);
+  if (issue2 && suggestion)
+    return `${issue2}
+\u2192 ${suggestion}`;
+  return issue2;
 }
 async function collectFromReviewAudit(context) {
   const observations = [];
@@ -52619,7 +52813,7 @@ async function collectFromReviewAudit(context) {
               severity: stringValue(finding.severity, "info"),
               file: stringValue(finding.file),
               line: numberValue(finding.line, 0),
-              message: stringValue(finding.message)
+              message: findingMessage(finding)
             }
           };
           observations.push(obs);
@@ -52893,31 +53087,43 @@ function mergeThresholds(thresholds) {
 function uniqueStoryIds(storyIds) {
   return [...new Set(storyIds)];
 }
+function firstLine2(message) {
+  return message.split(`
+`)[0] ?? message;
+}
 function h1RepeatedReviewFinding(observations, threshold) {
   const findings = observations.filter((o) => o.kind === "review-finding");
-  const byRuleId = new Map;
+  const groups = new Map;
   for (const obs of findings) {
     const ruleId = obs.payload.ruleId;
-    const existing = byRuleId.get(ruleId);
+    const message = obs.payload.message;
+    const existing = groups.get(ruleId);
     if (existing) {
-      existing.push(obs.storyId);
+      existing.storyIds.push(obs.storyId);
+      const sampleKey = firstLine2(message);
+      if (existing.samples.length < 2 && sampleKey && !existing.samples.includes(sampleKey)) {
+        existing.samples.push(sampleKey);
+      }
     } else {
-      byRuleId.set(ruleId, [obs.storyId]);
+      const sampleKey = firstLine2(message);
+      groups.set(ruleId, { storyIds: [obs.storyId], samples: sampleKey ? [sampleKey] : [] });
     }
   }
   const proposals = [];
-  for (const [ruleId, storyIds] of byRuleId.entries()) {
+  for (const [ruleId, { storyIds, samples }] of groups.entries()) {
     if (storyIds.length < threshold)
       continue;
     const count = storyIds.length;
     const severity = count >= 4 ? "HIGH" : "MED";
     const unique = uniqueStoryIds(storyIds);
+    const sampleSection = samples.length > 0 ? `
+  Examples: ${samples.join(" | ")}` : "";
     proposals.push({
       id: "H1",
       severity,
       target: { canonicalFile: ".nax/rules/curator-suggestions.md", action: "add" },
       description: `Repeated review finding: ${ruleId} appeared ${count}x across stories`,
-      evidence: `Rule ${ruleId} fired ${count}\xD7 in stories: ${unique.join(", ")}`,
+      evidence: `Rule ${ruleId} fired ${count}\xD7 in stories: ${unique.join(", ")}${sampleSection}`,
       sourceKinds: ["review-finding"],
       storyIds: unique
     });
@@ -54080,7 +54286,7 @@ var package_default;
 var init_package = __esm(() => {
   package_default = {
     name: "@nathapp/nax",
-    version: "0.65.0",
+    version: "0.65.1",
     description: "AI Coding Agent Orchestrator \u2014 loops until done",
     type: "module",
     bin: {
@@ -54166,8 +54372,8 @@ var init_version = __esm(() => {
   NAX_VERSION = package_default.version;
   NAX_COMMIT = (() => {
     try {
-      if (/^[0-9a-f]{6,10}$/.test("c067a82c"))
-        return "c067a82c";
+      if (/^[0-9a-f]{6,10}$/.test("3aa1ff6b"))
+        return "3aa1ff6b";
     } catch {}
     try {
       const result = Bun.spawnSync(["git", "rev-parse", "--short", "HEAD"], {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nathapp/nax",
-  "version": "0.65.0",
+  "version": "0.65.1",
   "description": "AI Coding Agent Orchestrator — loops until done",
   "type": "module",
   "bin": {