@nathapp/nax 0.64.0-canary.2 → 0.64.0-canary.4

package/dist/nax.js

@@ -3660,7 +3660,8 @@ class SpawnAcpSession {
         return {
           messages: [{ role: "assistant", content: errorContent }],
           stopReason: "error",
-          retryable: parsedOnError.retryable
+          retryable: parsedOnError.retryable,
+          exitCode
         };
       }
       try {
@@ -18937,6 +18938,7 @@ class AcpSessionHandleImpl {
   _resumed;
   _timeoutSeconds;
   _modelDef;
+  _permissionMode;
   constructor(opts) {
     this.id = opts.id;
     this.agentName = opts.agentName;
@@ -18947,6 +18949,7 @@ class AcpSessionHandleImpl {
     this._resumed = opts.resumed;
     this._timeoutSeconds = opts.timeoutSeconds;
     this._modelDef = opts.modelDef;
+    this._permissionMode = opts.permissionMode;
   }
 }
 function extractOutput(response) {
@@ -19288,7 +19291,8 @@ class AcpAgentAdapter {
         sessionName: name,
         resumed: ensured.resumed,
         timeoutSeconds,
-        modelDef
+        modelDef,
+        permissionMode: resolvedPermissions.mode
       });
     } catch (error48) {
       if (session) {
@@ -19300,7 +19304,8 @@ class AcpAgentAdapter {
   }
   async sendTurn(handle, prompt, opts) {
     const impl = handle;
-    const { _session: session, _sessionName: sessionName, _timeoutSeconds: timeoutSeconds, _modelDef: modelDef } = impl;
+    const { _sessionName: sessionName, _timeoutSeconds: timeoutSeconds, _modelDef: modelDef } = impl;
+    let sessionRecreated = false;
     const { interactionHandler, signal } = opts;
     const MAX_TURNS = opts.maxTurns ?? 10;
     let totalTokenUsage = { inputTokens: 0, outputTokens: 0 };
@@ -19321,7 +19326,7 @@ class AcpAgentAdapter {
     while (turnCount < MAX_TURNS) {
       turnCount++;
       getSafeLogger()?.debug("acp-adapter", `Session turn ${turnCount}/${MAX_TURNS}`, { sessionName });
-      const turnResult = await runSessionPrompt(session, currentPrompt, timeoutSeconds * 1000, signal);
+      const turnResult = await runSessionPrompt(impl._session, currentPrompt, timeoutSeconds * 1000, signal);
       if (turnResult.timedOut) {
         timedOut = true;
         break;
@@ -19333,6 +19338,21 @@ class AcpAgentAdapter {
       lastResponse = turnResult.response;
       if (!lastResponse)
         break;
+      if (lastResponse.exitCode === 4 && !sessionRecreated) {
+        sessionRecreated = true;
+        getSafeLogger()?.info("acp-adapter", "NO_SESSION detected \u2014 re-establishing session", { sessionName });
+        try {
+          const ensured = await ensureAcpSession(impl._client, impl._sessionName, impl.agentName, impl._permissionMode);
+          impl._session = ensured.session;
+          turnCount--;
+          continue;
+        } catch (err) {
+          getSafeLogger()?.warn("acp-adapter", "Session re-establishment failed after NO_SESSION", {
+            sessionName,
+            error: err instanceof Error ? err.message : String(err)
+          });
+        }
+      }
       if (lastResponse.cumulative_token_usage) {
         totalTokenUsage = addTokenUsage(totalTokenUsage, this._mapper.toInternal(lastResponse.cumulative_token_usage));
       }
@@ -19973,6 +19993,7 @@ class AgentManager {
       agentName,
       kind: "complete",
       request: null,
+      completeOptions: augmented,
       prompt,
       config: this._config,
       signal: options.signal,
@@ -30190,6 +30211,7 @@ function turnResultToAgentResult(r) {
     rateLimited: false,
     durationMs: 0,
     estimatedCostUsd: r.estimatedCostUsd ?? 0,
+    exactCostUsd: r.exactCostUsd,
     tokenUsage: r.tokenUsage
   };
 }
@@ -30362,7 +30384,8 @@ async function callOp(ctx, op, input) {
       jsonMode: completeOp.jsonMode ?? false,
       pipelineStage: op.stage,
       storyId: ctx.storyId,
-      workdir: ctx.packageDir
+      workdir: ctx.packageDir,
+      featureName: ctx.featureName
     });
     return op.parse(raw.output, input, buildCtx);
   }
@@ -34509,8 +34532,8 @@ var init_truncation = __esm(() => {
   init_adapter();
 });
 
-// src/operations/semantic-review.ts
-function parseLLMShape(raw) {
+// src/operations/types.ts
+function parseLlmReviewShape(raw) {
   if (typeof raw !== "object" || raw === null)
     return null;
   const obj = raw;
@@ -34520,11 +34543,13 @@ function parseLLMShape(raw) {
     return null;
   return { passed: obj.passed, findings: obj.findings };
 }
+
+// src/operations/semantic-review.ts
 var FAIL_OPEN, semanticReviewHopBody = async (initialPrompt, ctx) => {
   const first = await ctx.send(initialPrompt);
   const isTruncated = looksLikeTruncatedJson(first.output);
   const parsed = tryParseLLMJson(first.output);
-  if (!isTruncated && parsed && parseLLMShape(parsed))
+  if (!isTruncated && parsed && parseLlmReviewShape(parsed))
     return first;
   const retryPrompt = isTruncated ? ReviewPromptBuilder.jsonRetryCondensed() : ReviewPromptBuilder.jsonRetry();
   const retry = await ctx.send(retryPrompt);
@@ -34562,7 +34587,7 @@ var init_semantic_review = __esm(() => {
     },
     parse(output, _input, _ctx) {
       const raw = tryParseLLMJson(output);
-      const parsed = parseLLMShape(raw);
+      const parsed = parseLlmReviewShape(raw);
       if (parsed)
         return parsed;
       if (/"passed"\s*:\s*false/.test(output))
@@ -34573,21 +34598,11 @@ var init_semantic_review = __esm(() => {
 });
 
 // src/operations/adversarial-review.ts
-function parseLLMShape2(raw) {
-  if (typeof raw !== "object" || raw === null)
-    return null;
-  const obj = raw;
-  if (typeof obj.passed !== "boolean")
-    return null;
-  if (!Array.isArray(obj.findings))
-    return null;
-  return { passed: obj.passed, findings: obj.findings };
-}
 var FAIL_OPEN2, adversarialReviewHopBody = async (initialPrompt, ctx) => {
   const first = await ctx.send(initialPrompt);
   const isTruncated = looksLikeTruncatedJson(first.output);
   const parsed = tryParseLLMJson(first.output);
-  if (!isTruncated && parsed && parseLLMShape2(parsed))
+  if (!isTruncated && parsed && parseLlmReviewShape(parsed))
     return first;
   const retryPrompt = isTruncated ? ReviewPromptBuilder.jsonRetryCondensed() : ReviewPromptBuilder.jsonRetry();
   const retry = await ctx.send(retryPrompt);
@@ -34627,7 +34642,7 @@ var init_adversarial_review = __esm(() => {
     },
     parse(output, _input, _ctx) {
       const raw = tryParseLLMJson(output);
-      const parsed = parseLLMShape2(raw);
+      const parsed = parseLlmReviewShape(raw);
       if (parsed)
         return parsed;
       if (/"passed"\s*:\s*false/.test(output))
@@ -35189,7 +35204,7 @@ var init_cost_aggregator = __esm(() => {
 });
 
 // src/runtime/prompt-auditor.ts
-import { mkdirSync as mkdirSync3 } from "fs";
+import { appendFile as appendFile3, mkdir as mkdir3 } from "fs/promises";
 import { join as join21 } from "path";
 function createNoOpPromptAuditor() {
   return {
@@ -35198,6 +35213,25 @@ function createNoOpPromptAuditor() {
     async flush() {}
   };
 }
+function deriveTxtFilename(entry) {
+  if (entry.sessionName) {
+    const suffix = deriveAuditSuffix(entry);
+    return `${entry.ts}-${entry.sessionName}${suffix ? `-${suffix}` : ""}.txt`;
+  }
+  const parts = [String(entry.ts), entry.callType ?? "call", entry.stage ?? "unknown"];
+  if (entry.storyId)
+    parts.push(entry.storyId);
+  return `${parts.join("-")}.txt`;
+}
+function deriveAuditSuffix(entry) {
+  if (entry.callType === "run" && entry.turn !== undefined) {
+    const stage = entry.stage ?? "run";
+    return `${stage}-t${String(entry.turn).padStart(2, "0")}`;
+  }
+  if (entry.callType === "complete")
+    return "complete";
+  return entry.stage ?? entry.callType;
+}
 function buildTxtContent(entry) {
   const ts = new Date(entry.ts).toISOString();
   const lines = [
@@ -35226,77 +35260,51 @@ function buildTxtContent(entry) {
 }
 
 class PromptAuditor {
-  _runId;
-  _flushDir;
-  _featureName;
-  _entries = [];
-  _draining = false;
-  _inFlightEntries = [];
-  constructor(_runId, _flushDir, _featureName) {
-    this._runId = _runId;
-    this._flushDir = _flushDir;
-    this._featureName = _featureName;
+  _queue = Promise.resolve();
+  _dirCreated = false;
+  _jsonlPath;
+  _featureDir;
+  constructor(runId, flushDir, featureName) {
+    this._featureDir = join21(flushDir, featureName);
+    this._jsonlPath = join21(this._featureDir, `${runId}.jsonl`);
   }
   record(entry) {
-    if (this._draining) {
-      this._inFlightEntries.push(entry);
-      return;
-    }
-    this._entries.push(entry);
+    this._enqueue(entry);
   }
   recordError(entry) {
-    if (this._draining) {
-      this._inFlightEntries.push(entry);
-      return;
+    this._enqueue(entry);
+  }
+  _enqueue(entry) {
+    this._queue = this._queue.then(() => this._writeEntry(entry)).catch((err) => {
+      getSafeLogger()?.warn("audit", "prompt-audit write failed", {
+        path: this._jsonlPath,
+        error: errorMessage(err)
+      });
+    });
+  }
+  async _writeEntry(entry) {
+    if (!this._dirCreated) {
+      await mkdir3(this._featureDir, { recursive: true });
+      this._dirCreated = true;
     }
-    this._entries.push(entry);
+    await _promptAuditorDeps.appendLine(this._jsonlPath, `${JSON.stringify(entry)}
+`);
+    if (!("prompt" in entry) || !("response" in entry))
+      return;
+    const auditEntry = entry;
+    const filename = deriveTxtFilename(auditEntry);
+    await _promptAuditorDeps.write(join21(this._featureDir, filename), buildTxtContent(auditEntry));
   }
   async flush() {
-    this._draining = true;
-    try {
-      const entries = this._entries.splice(0);
-      if (entries.length === 0)
-        return;
-      const featureDir = join21(this._flushDir, this._featureName);
-      mkdirSync3(featureDir, { recursive: true });
-      const jsonlPath = join21(featureDir, `${this._runId}.jsonl`);
-      await _promptAuditorDeps.write(jsonlPath, `${entries.map((e) => JSON.stringify(e)).join(`
-`)}
-`);
-      for (const entry of entries) {
-        if (!("prompt" in entry) || !("response" in entry))
-          continue;
-        const auditEntry = entry;
-        if (!auditEntry.sessionName)
-          continue;
-        const filename = `${auditEntry.ts}-${auditEntry.sessionName}.txt`;
-        await _promptAuditorDeps.write(join21(featureDir, filename), buildTxtContent(auditEntry));
-      }
-      const lateEntries = this._inFlightEntries.splice(0);
-      if (lateEntries.length > 0) {
-        const allEntries = [...entries, ...lateEntries];
-        await _promptAuditorDeps.write(jsonlPath, `${allEntries.map((e) => JSON.stringify(e)).join(`
-`)}
-`);
-        for (const entry of lateEntries) {
-          if (!("prompt" in entry) || !("response" in entry))
-            continue;
-          const auditEntry = entry;
-          if (!auditEntry.sessionName)
-            continue;
-          const filename = `${auditEntry.ts}-${auditEntry.sessionName}.txt`;
-          await _promptAuditorDeps.write(join21(featureDir, filename), buildTxtContent(auditEntry));
-        }
-      }
-    } finally {
-      this._draining = false;
-    }
+    await this._queue;
   }
 }
 var _promptAuditorDeps;
 var init_prompt_auditor = __esm(() => {
+  init_logger2();
   _promptAuditorDeps = {
-    write: (path4, data) => Bun.write(path4, data)
+    write: (path4, data) => Bun.write(path4, data),
+    appendLine: (path4, data) => appendFile3(path4, data, "utf8")
   };
 });
 
@@ -35358,7 +35366,7 @@ var init_types5 = __esm(() => {
 
 // src/session/manager.ts
 import { randomUUID as randomUUID2 } from "crypto";
-import { mkdir as mkdir3 } from "fs/promises";
+import { mkdir as mkdir4 } from "fs/promises";
 import { isAbsolute as isAbsolute8, join as join22, relative as relative8, sep } from "path";
 function resolveProjectDirFromScratchDir(scratchDir) {
   const marker = `${sep}.nax${sep}features${sep}`;
@@ -35678,6 +35686,10 @@ class SessionManager {
     if (this._busySessions.has(handle.id)) {
       throw new NaxError(`Session "${handle.id}" is already processing a prompt (single-flight invariant)`, "SESSION_BUSY", { stage: "session", sessionName: handle.id });
     }
+    const terminalDesc = this._findByName(handle.id);
+    if (terminalDesc && (terminalDesc.state === "COMPLETED" || terminalDesc.state === "FAILED")) {
+      throw new NaxError(`Session "${handle.id}" is in terminal state ${terminalDesc.state} \u2014 call openSession first to resume`, "SESSION_TERMINAL_STATE", { stage: "session", sessionName: handle.id, state: terminalDesc.state });
+    }
     const adapter = this._getAdapter(handle.agentName);
     if (!adapter) {
       throw new NaxError(`SessionManager.sendPrompt: no adapter found for agent "${handle.agentName}"`, "ADAPTER_NOT_FOUND", { stage: "session", agentName: handle.agentName });
@@ -35842,7 +35854,7 @@ var init_manager2 = __esm(() => {
     uuid: () => randomUUID2(),
     sessionScratchDir: (projectDir, featureName, sessionId) => join22(projectDir, ".nax", "features", featureName, "sessions", sessionId),
     writeDescriptor: async (scratchDir, descriptor, projectDir) => {
-      await mkdir3(scratchDir, { recursive: true });
+      await mkdir4(scratchDir, { recursive: true });
       const { handle: _handle, ...persistable } = descriptor;
       const derivedProjectDir = projectDir ?? resolveProjectDirFromScratchDir(scratchDir);
       if (derivedProjectDir) {
@@ -35955,9 +35967,11 @@ function extractCosts(result) {
   if (!result || typeof result !== "object")
     return null;
   const r = result;
+  const hasEstimatedCost = "estimatedCostUsd" in r;
+  const hasCost = "costUsd" in r;
   const estimatedCostUsd = r.estimatedCostUsd ?? r.costUsd ?? 0;
   const exactCostUsd = r.exactCostUsd;
-  if (estimatedCostUsd === 0 && exactCostUsd == null)
+  if (!hasEstimatedCost && !hasCost && exactCostUsd == null)
     return null;
   return { estimatedCostUsd, exactCostUsd };
 }
@@ -35965,6 +35979,8 @@ function costMiddleware(aggregator, runId) {
   return {
     name: "cost",
     async after(ctx, result, durationMs) {
+      if (ctx.kind === "run" && ctx.sessionHandle === undefined && ctx.request?.executeHop)
+        return;
       const tokens = extractTokens(result);
       const costs = extractCosts(result);
       if (!tokens && !costs)
@@ -36013,17 +36029,35 @@ function extractOutput2(result) {
     return "";
   return result.output ?? "";
 }
+function sessionNameFromCompleteOptions(ctx) {
+  const opts = ctx.completeOptions;
+  if (!opts)
+    return;
+  if (opts.sessionName)
+    return opts.sessionName;
+  if (!opts.workdir || !opts.featureName)
+    return;
+  return formatSessionName({
+    workdir: opts.workdir,
+    featureName: opts.featureName,
+    storyId: opts.storyId,
+    role: opts.sessionRole,
+    pipelineStage: opts.pipelineStage
+  });
+}
 function auditMiddleware(auditor, runId) {
   return {
     name: "audit",
     async after(ctx, result, durationMs) {
+      if (ctx.kind === "run" && ctx.sessionHandle === undefined && ctx.request?.executeHop)
+        return;
       const runOpts = ctx.request?.runOptions;
       const prompt = ctx.prompt ?? runOpts?.prompt;
       if (!prompt)
         return;
       const agentResult = result ?? {};
       const { protocolIds } = agentResult;
-      const sessionName = ctx.sessionHandle?.id;
+      const sessionName = ctx.sessionHandle?.id ?? sessionNameFromCompleteOptions(ctx);
       const internalRoundTrips = result && typeof result === "object" && "internalRoundTrips" in result ? result.internalRoundTrips : undefined;
       const entry = {
         ts: Date.now(),
@@ -36036,9 +36070,9 @@ function auditMiddleware(auditor, runId) {
         response: extractOutput2(result),
         durationMs,
         callType: ctx.kind,
-        workdir: runOpts?.workdir,
+        workdir: runOpts?.workdir ?? ctx.completeOptions?.workdir,
         projectDir: runOpts?.projectDir,
-        featureName: runOpts?.featureName,
+        featureName: runOpts?.featureName ?? ctx.completeOptions?.featureName,
         ...sessionName !== undefined && { sessionName },
         ...protocolIds?.recordId !== undefined && { recordId: protocolIds.recordId },
         ...protocolIds?.sessionId !== undefined && { sessionId: protocolIds.sessionId },
@@ -36072,6 +36106,7 @@ function auditMiddleware(auditor, runId) {
 }
 var init_audit = __esm(() => {
   init_errors();
+  init_session_name();
 });
 
 // src/runtime/middleware/index.ts
@@ -38274,6 +38309,9 @@ __export(exports_acceptance_setup, {
   _acceptanceSetupDeps: () => _acceptanceSetupDeps
 });
 import path7 from "path";
+function hasLikelyTestContent2(content) {
+  return /\b(?:describe|test|it|expect)\s*\(/.test(content) || /func\s+Test\w+\s*\(/.test(content) || /def\s+test_\w+/.test(content) || /#\[test\]/.test(content);
+}
 function computeACFingerprint(criteria) {
   const sorted = [...criteria].sort().join(`
 `);
@@ -38344,6 +38382,9 @@ var init_acceptance_setup = __esm(() => {
     writeMeta: async (metaPath, meta3) => {
       await Bun.write(metaPath, JSON.stringify(meta3, null, 2));
     },
+    readFile: async (filePath) => {
+      return Bun.file(filePath).text();
+    },
     autoCommitIfDirty,
     loadGroupConfig: async (projectDir, relativeWorkdir) => {
       return loadConfigForWorkdir(path7.join(projectDir, ".nax", "config.json"), relativeWorkdir || undefined);
@@ -38464,6 +38505,7 @@ ${stderr}` };
 `);
           const frameworkOverrideLine = ctx.config.acceptance.testFramework ? `
 [FRAMEWORK OVERRIDE: Use ${ctx.config.acceptance.testFramework} as the test framework regardless of what you detect.]` : "";
+          const groupStoryId = group.stories[0]?.id;
           const genResult = await _acceptanceSetupDeps.callOp(ctx, packageDir, acceptanceGenerateOp, {
             featureName: featureName ?? "",
             criteriaList,
@@ -38471,17 +38513,53 @@ ${stderr}` };
             targetTestFilePath: testPath,
             ..."implementationContext" in ctx && ctx.implementationContext ? { implementationContext: ctx.implementationContext } : {},
             ..."previousFailure" in ctx && ctx.previousFailure ? { previousFailure: ctx.previousFailure } : {}
-          });
+          }, groupStoryId);
           let testCode = genResult.testCode;
           if (!testCode) {
-            const skeletonCriteria = groupRefined.map((c, i) => ({
-              id: `AC-${i + 1}`,
-              text: c.refined,
-              lineNumber: i + 1
-            }));
-            testCode = generateSkeletonTests(featureName, skeletonCriteria, ctx.config.acceptance.testFramework, language);
+            const backupPath = `${testPath}.llm-recovery.bak`;
+            if (await _acceptanceSetupDeps.fileExists(testPath)) {
+              try {
+                const existing = await _acceptanceSetupDeps.readFile(testPath);
+                const extracted = extractTestCode(existing);
+                if (extracted) {
+                  testCode = extracted;
+                  getSafeLogger()?.info("acceptance-setup", "Agent wrote fenced code block to disk \u2014 using extracted code", { storyId: groupStoryId, testPath });
+                } else if (existing.trim().length > 0 && hasLikelyTestContent2(existing)) {
+                  let backupCreated = false;
+                  try {
+                    await _acceptanceSetupDeps.writeFile(backupPath, existing);
+                    backupCreated = true;
+                  } catch (backupErr) {
+                    getSafeLogger()?.warn("acceptance-setup", "Failed to create .llm-recovery.bak \u2014 preserving agent file anyway", { storyId: groupStoryId, testPath, backupPath, error: errorMessage(backupErr) });
+                  }
+                  testCode = existing;
+                  getSafeLogger()?.info("acceptance-setup", "Agent wrote acceptance test directly \u2014 preserving file with backup", { storyId: groupStoryId, testPath, backupPath, backupCreated });
+                } else {
+                  if (existing.trim().length > 0) {
+                    try {
+                      await _acceptanceSetupDeps.writeFile(backupPath, existing);
+                    } catch (backupErr) {
+                      getSafeLogger()?.warn("acceptance-setup", "Failed to create .llm-recovery.bak for unrecognised file", { storyId: groupStoryId, testPath, backupPath, error: errorMessage(backupErr) });
+                    }
+                  }
+                  getSafeLogger()?.error("acceptance-setup", "Agent-written file not recognised as test code \u2014 falling back to skeleton", { storyId: groupStoryId, testPath, backupPath, fileSize: existing.length });
+                }
+              } catch (err) {
+                getSafeLogger()?.warn("acceptance-setup", "Failed to read agent-written file \u2014 falling back to skeleton", { storyId: groupStoryId, testPath, error: errorMessage(err) });
+              }
+            }
+            if (!testCode) {
+              const skeletonCriteria = groupRefined.map((c, i) => ({
+                id: `AC-${i + 1}`,
+                text: c.refined,
+                lineNumber: i + 1
+              }));
+              testCode = generateSkeletonTests(featureName, skeletonCriteria, ctx.config.acceptance.testFramework, language);
+            }
+          }
+          if (testCode) {
+            await _acceptanceSetupDeps.writeFile(testPath, testCode);
           }
-          await _acceptanceSetupDeps.writeFile(testPath, testCode);
         }
         if (allRefinedCriteria.length > 0) {
           const refinedJsonContent = JSON.stringify(allRefinedCriteria.map((c, i) => ({
@@ -39982,7 +40060,7 @@ var init_nax_project_root = __esm(() => {
 });
 
 // src/review/review-audit.ts
-import { mkdir as mkdir4 } from "fs/promises";
+import { mkdir as mkdir5 } from "fs/promises";
 import { join as join33 } from "path";
 async function writeReviewAudit(entry) {
   try {
@@ -40015,7 +40093,7 @@ var init_review_audit = __esm(() => {
   init_nax_project_root();
   _reviewAuditDeps = {
     async mkdir(path8) {
-      await mkdir4(path8, { recursive: true });
+      await mkdir5(path8, { recursive: true });
     },
     async writeFile(path8, content) {
       await Bun.write(path8, content);
@@ -41466,7 +41544,7 @@ var init_runner4 = __esm(() => {
 });
 
 // src/review/verdict-writer.ts
-import { mkdir as mkdir5 } from "fs/promises";
+import { mkdir as mkdir6 } from "fs/promises";
 import { join as join34 } from "path";
 async function writeReviewVerdict(entry) {
   const logger = getSafeLogger();
@@ -41495,7 +41573,7 @@ var init_verdict_writer = __esm(() => {
   init_nax_project_root();
   _verdictWriterDeps = {
     findNaxProjectRoot,
-    mkdir: mkdir5,
+    mkdir: mkdir6,
     writeFile: Bun.write
   };
 });
@@ -42555,8 +42633,8 @@ var init_semantic_verdict = __esm(() => {
   init_logger2();
   _semanticVerdictDeps = {
     mkdirp: async (dir) => {
-      const { mkdir: mkdir6 } = await import("fs/promises");
-      await mkdir6(dir, { recursive: true });
+      const { mkdir: mkdir7 } = await import("fs/promises");
+      await mkdir7(dir, { recursive: true });
     },
     writeFile: async (filePath, content) => {
       await Bun.write(filePath, content);
@@ -42703,15 +42781,15 @@ var init_effectiveness = __esm(() => {
 });
 
 // src/execution/progress.ts
-import { appendFile as appendFile3, mkdir as mkdir6 } from "fs/promises";
+import { appendFile as appendFile4, mkdir as mkdir7 } from "fs/promises";
 import { join as join36 } from "path";
 async function appendProgress(featureDir, storyId, status, message) {
-  await mkdir6(featureDir, { recursive: true });
+  await mkdir7(featureDir, { recursive: true });
   const progressPath = join36(featureDir, "progress.txt");
   const timestamp = new Date().toISOString();
   const entry = `[${timestamp}] ${storyId} \u2014 ${status.toUpperCase()} \u2014 ${message}
 `;
-  await appendFile3(progressPath, entry);
+  await appendFile4(progressPath, entry);
 }
 var init_progress = () => {};
 
@@ -43550,7 +43628,7 @@ async function getStoryChangedFiles(workdir, fromRef) {
 async function runFullSuiteGate(story, config2, workdir, agentManager, implementerTier, lite, logger, featureName, projectDir, storyFromRef, sessionManager, sessionId, runtime) {
   const rectificationEnabled = config2.execution.rectification?.enabled ?? false;
   if (!rectificationEnabled)
-    return { passed: false, cost: 0 };
+    return { passed: false, cost: 0, fullSuiteGatePassed: false };
   const rectificationConfig = config2.execution.rectification;
   const fullSuiteTimeout = rectificationConfig.fullSuiteTimeoutSeconds;
   const { testCommand: resolvedTestCmd } = await _rectificationGateDeps.resolveTestCommands(config2, workdir, story.workdir);
@@ -43564,8 +43642,18 @@ async function runFullSuiteGate(story, config2, workdir, agentManager, implement
   if (!fullSuitePassed && fullSuiteResult.output) {
     const testSummary = _rectificationGateDeps.parseTestOutput(fullSuiteResult.output);
     if (testSummary.failed > 0) {
+      if (testSummary.failures.length === 0) {
+        logger.warn("tdd", "Full suite gate found unattributable failures \u2014 deferring to run-level regression", {
+          storyId: story.id,
+          failedTests: testSummary.failed,
+          passedTests: testSummary.passed,
+          outputLength: fullSuiteResult.output.length,
+          outputTail: fullSuiteResult.output.slice(-200)
+        });
+        return { passed: true, cost: 0, fullSuiteGatePassed: false };
+      }
       let filteredFailures = testSummary.failures;
-      if (storyFromRef && testSummary.failures.length > 0) {
+      if (storyFromRef) {
         const storyFiles = await getStoryChangedFiles(workdir, storyFromRef);
         if (storyFiles.size > 0) {
           filteredFailures = testSummary.failures.filter((f) => storyFiles.has(f.file));
@@ -43580,7 +43668,7 @@ async function runFullSuiteGate(story, config2, workdir, agentManager, implement
           suppressedTestCount: testSummary.failures.length,
           suppressedFiles: uniqueSuppressedFiles
         });
-        return { passed: true, cost: 0 };
+        return { passed: true, cost: 0, fullSuiteGatePassed: true };
       }
       if (wasFiltered) {
         logger.info("tdd", "Full suite gate: suppressed pre-existing failures", {
@@ -43603,7 +43691,7 @@ async function runFullSuiteGate(story, config2, workdir, agentManager, implement
         exitCode: fullSuiteResult.exitCode,
         passedTests: testSummary.passed
       });
-      return { passed: true, cost: 0 };
+      return { passed: true, cost: 0, fullSuiteGatePassed: true };
     }
     logger.warn("tdd", "Full suite gate inconclusive \u2014 no test results parsed from output (possible crash/OOM)", {
       storyId: story.id,
@@ -43611,17 +43699,17 @@ async function runFullSuiteGate(story, config2, workdir, agentManager, implement
       outputLength: fullSuiteResult.output.length,
       outputTail: fullSuiteResult.output.slice(-200)
     });
-    return { passed: false, cost: 0 };
+    return { passed: false, cost: 0, fullSuiteGatePassed: false };
   }
   if (fullSuitePassed) {
     logger.info("tdd", "Full suite gate passed", { storyId: story.id });
-    return { passed: true, cost: 0 };
+    return { passed: true, cost: 0, fullSuiteGatePassed: true };
   }
   logger.warn("tdd", "Full suite gate execution failed (no output)", {
     storyId: story.id,
     exitCode: fullSuiteResult.exitCode
   });
-  return { passed: false, cost: 0 };
+  return { passed: false, cost: 0, fullSuiteGatePassed: false };
 }
 async function runRectificationLoop(story, config2, workdir, agentManager, implementerTier, lite, logger, testSummary, rectificationConfig, testCmd, fullSuiteTimeout, testOutput, featureName, projectDir, sessionManager, sessionId, runtime) {
   logger.warn("tdd", "Full suite gate detected regressions", {
@@ -43761,13 +43849,13 @@ async function runRectificationLoop(story, config2, workdir, agentManager, imple
   });
   const fixed = outcome.outcome === "fixed";
   if (fixed) {
-    return { passed: true, cost: gateCostAccum };
+    return { passed: true, cost: gateCostAccum, fullSuiteGatePassed: true };
   }
   logger.warn("tdd", "[WARN] Full suite gate failed after rectification exhausted", {
     storyId: story.id,
     attempts: outcome.attempts
   });
-  return { passed: false, cost: gateCostAccum };
+  return { passed: false, cost: gateCostAccum, fullSuiteGatePassed: false };
 }
 var _rectificationGateDeps;
 var init_rectification_gate = __esm(() => {
@@ -44236,7 +44324,7 @@ async function runThreeSessionTdd(options) {
     };
   }
   const implementerBinding = getTddSessionBinding?.("implementer");
-  const { passed: fullSuiteGatePassed, cost: fullSuiteGateCost } = await runFullSuiteGate(story, config2, workdir, wrapAdapterAsManager(agent), implementerTier, lite, logger, featureName, projectDir, initialRef, implementerBinding?.sessionManager, implementerBinding?.sessionId);
+  const { cost: fullSuiteGateCost, fullSuiteGatePassed } = await runFullSuiteGate(story, config2, workdir, wrapAdapterAsManager(agent), implementerTier, lite, logger, featureName, projectDir, initialRef, implementerBinding?.sessionManager, implementerBinding?.sessionId);
   const session3Ref = await captureGitRef(workdir) ?? "HEAD";
   const verifierBundle = await getTddContextBundle?.("verifier") ?? tddContextBundles?.verifier;
   const session3 = await runTddSessionOp(verifyTddOp, options, session3Ref, verifierBundle, getTddSessionBinding?.("verifier"));
@@ -46400,7 +46488,7 @@ __export(exports_init_context, {
   _initContextDeps: () => _initContextDeps
 });
 import { existsSync as existsSync21 } from "fs";
-import { mkdir as mkdir7 } from "fs/promises";
+import { mkdir as mkdir8 } from "fs/promises";
 import { basename as basename5, join as join42 } from "path";
 async function findFiles(dir, maxFiles = 200) {
   try {
@@ -46644,7 +46732,7 @@ async function initPackage(repoRoot, packagePath, force = false) {
     return;
   }
   if (!existsSync21(naxDir)) {
-    await mkdir7(naxDir, { recursive: true });
+    await mkdir8(naxDir, { recursive: true });
   }
   const content = generatePackageContextTemplate(packagePath);
   await Bun.write(contextPath, content);
@@ -46659,7 +46747,7 @@ async function initContext(projectRoot, options = {}) {
     return;
   }
   if (!existsSync21(naxDir)) {
-    await mkdir7(naxDir, { recursive: true });
+    await mkdir8(naxDir, { recursive: true });
   }
   const scan = await scanProject(projectRoot);
   let content;
@@ -47427,7 +47515,7 @@ var package_default;
 var init_package = __esm(() => {
   package_default = {
     name: "@nathapp/nax",
-    version: "0.64.0-canary.2",
+    version: "0.64.0-canary.4",
     description: "AI Coding Agent Orchestrator \u2014 loops until done",
     type: "module",
     bin: {
@@ -47509,8 +47597,8 @@ var init_version = __esm(() => {
   NAX_VERSION = package_default.version;
   NAX_COMMIT = (() => {
     try {
-      if (/^[0-9a-f]{6,10}$/.test("c7d0f838"))
-        return "c7d0f838";
+      if (/^[0-9a-f]{6,10}$/.test("c0ad2048"))
+        return "c0ad2048";
     } catch {}
     try {
       const result = Bun.spawnSync(["git", "rev-parse", "--short", "HEAD"], {
@@ -48331,7 +48419,7 @@ var init_acceptance_loop = __esm(() => {
 });
 
 // src/session/scratch-purge.ts
-import { mkdir as mkdir9, rename, rm } from "fs/promises";
+import { mkdir as mkdir10, rename, rm } from "fs/promises";
 import { dirname as dirname9, join as join60 } from "path";
 async function purgeStaleScratch(projectDir, featureName, retentionDays, archiveInsteadOfDelete = false) {
   const sessionsDir = join60(projectDir, ".nax", "features", featureName, "sessions");
@@ -48383,7 +48471,7 @@ var init_scratch_purge = __esm(() => {
     readFile: (path16) => Bun.file(path16).text(),
     remove: (path16) => rm(path16, { recursive: true, force: true }),
     move: async (src, dest) => {
-      await mkdir9(dirname9(dest), { recursive: true });
+      await mkdir10(dirname9(dest), { recursive: true });
       await rename(src, dest);
     },
     now: () => Date.now()
@@ -49017,7 +49105,7 @@ function precomputeBatchPlan(stories, maxBatchSize = DEFAULT_MAX_BATCH_SIZE) {
 var DEFAULT_MAX_BATCH_SIZE = 4;
 
 // src/pipeline/subscribers/events-writer.ts
-import { appendFile as appendFile4, mkdir as mkdir10 } from "fs/promises";
+import { appendFile as appendFile5, mkdir as mkdir11 } from "fs/promises";
 import { homedir as homedir5 } from "os";
 import { basename as basename9, join as join61 } from "path";
 function wireEventsWriter(bus, feature, runId, workdir) {
@@ -49030,10 +49118,10 @@ function wireEventsWriter(bus, feature, runId, workdir) {
     return (async () => {
       try {
         if (!dirReady) {
-          await mkdir10(eventsDir, { recursive: true });
+          await mkdir11(eventsDir, { recursive: true });
           dirReady = true;
         }
-        await appendFile4(eventsFile, `${JSON.stringify(line)}
+        await appendFile5(eventsFile, `${JSON.stringify(line)}
 `);
       } catch (err) {
         logger?.warn("events-writer", "Failed to write event line (non-fatal)", {
@@ -49203,7 +49291,7 @@ var init_interaction2 = __esm(() => {
 });
 
 // src/pipeline/subscribers/registry.ts
-import { mkdir as mkdir11, writeFile } from "fs/promises";
+import { mkdir as mkdir12, writeFile } from "fs/promises";
 import { homedir as homedir6 } from "os";
 import { basename as basename10, join as join62 } from "path";
 function wireRegistry(bus, feature, runId, workdir) {
@@ -49214,7 +49302,7 @@ function wireRegistry(bus, feature, runId, workdir) {
   const unsub = bus.on("run:started", (_ev) => {
     return (async () => {
       try {
-        await mkdir11(runDir, { recursive: true });
+        await mkdir12(runDir, { recursive: true });
         const meta3 = {
           runId,
           project,
@@ -49556,7 +49644,7 @@ __export(exports_manager, {
   WorktreeManager: () => WorktreeManager
 });
 import { existsSync as existsSync30, symlinkSync } from "fs";
-import { mkdir as mkdir12 } from "fs/promises";
+import { mkdir as mkdir13 } from "fs/promises";
 import { join as join64 } from "path";
 
 class WorktreeManager {
@@ -49565,7 +49653,7 @@ class WorktreeManager {
     const infoDir = join64(projectRoot, ".git", "info");
     const excludePath = join64(infoDir, "exclude");
     try {
-      await mkdir12(infoDir, { recursive: true });
+      await mkdir13(infoDir, { recursive: true });
       let existing = "";
       if (existsSync30(excludePath)) {
         existing = await Bun.file(excludePath).text();
@@ -52006,7 +52094,7 @@ var exports_precheck_runner = {};
 __export(exports_precheck_runner, {
   runPrecheckValidation: () => runPrecheckValidation
 });
-import { mkdirSync as mkdirSync7 } from "fs";
+import { mkdirSync as mkdirSync6 } from "fs";
 import path18 from "path";
 async function runPrecheckValidation(ctx) {
   const logger = getSafeLogger();
@@ -52022,7 +52110,7 @@ async function runPrecheckValidation(ctx) {
     silent: true
   });
   if (ctx.logFilePath) {
-    mkdirSync7(path18.dirname(ctx.logFilePath), { recursive: true });
+    mkdirSync6(path18.dirname(ctx.logFilePath), { recursive: true });
     const precheckLog = {
       type: "precheck",
       timestamp: new Date().toISOString(),
@@ -83483,7 +83571,7 @@ var require_jsx_dev_runtime = __commonJS((exports, module) => {
 
 // bin/nax.ts
 init_source();
-import { existsSync as existsSync33, mkdirSync as mkdirSync8 } from "fs";
+import { existsSync as existsSync33, mkdirSync as mkdirSync7 } from "fs";
 import { homedir as homedir8 } from "os";
 import { join as join72 } from "path";
 
@@ -85347,7 +85435,7 @@ async function runsShowCommand(options) {
 }
 // src/cli/prompts-main.ts
 init_logger2();
-import { existsSync as existsSync19, mkdirSync as mkdirSync4 } from "fs";
+import { existsSync as existsSync19, mkdirSync as mkdirSync3 } from "fs";
 import { join as join40 } from "path";
 
 // src/pipeline/index.ts
@@ -85487,7 +85575,7 @@ async function promptsCommand(options) {
     throw new Error(storyId ? `Story "${storyId}" not found in feature "${feature}"` : `No stories found in feature "${feature}"`);
   }
   if (outputDir) {
-    mkdirSync4(outputDir, { recursive: true });
+    mkdirSync3(outputDir, { recursive: true });
   }
   logger.info("cli", "Assembling prompts", {
     feature,
@@ -85569,7 +85657,7 @@ ${"=".repeat(80)}`);
 }
 // src/cli/prompts-init.ts
 init_role_task();
-import { existsSync as existsSync20, mkdirSync as mkdirSync5 } from "fs";
+import { existsSync as existsSync20, mkdirSync as mkdirSync4 } from "fs";
 import { join as join41 } from "path";
 var TEMPLATE_ROLES = [
   { file: "test-writer.md", role: "test-writer" },
@@ -85595,7 +85683,7 @@ var TEMPLATE_HEADER = `<!--
 async function promptsInitCommand(options) {
   const { workdir, force = false, autoWireConfig = true } = options;
   const templatesDir = join41(workdir, ".nax", "templates");
-  mkdirSync5(templatesDir, { recursive: true });
+  mkdirSync4(templatesDir, { recursive: true });
   const existingFiles = TEMPLATE_ROLES.map((t) => t.file).filter((f) => existsSync20(join41(templatesDir, f)));
   if (existingFiles.length > 0 && !force) {
     console.warn(`[WARN] nax/templates/ already contains files: ${existingFiles.join(", ")}. No files overwritten.
@@ -86736,7 +86824,7 @@ function formatValueForTable(value) {
 // src/cli/config-profile.ts
 init_paths();
 init_profile();
-import { mkdirSync as mkdirSync6 } from "fs";
+import { mkdirSync as mkdirSync5 } from "fs";
 import { readdirSync as readdirSync7 } from "fs";
 import { join as join49 } from "path";
 var _profileCLIDeps = {
@@ -86830,7 +86918,7 @@ async function profileCreateCommand(profileName, startDir) {
   if (await profileFile.exists()) {
     throw new Error(`Profile "${profileName}" already exists at ${profilePath}`);
   }
-  mkdirSync6(profilesDir, { recursive: true });
+  mkdirSync5(profilesDir, { recursive: true });
   await Bun.write(profilePath, "{}");
   return profilePath;
 }
@@ -86946,7 +87034,7 @@ async function contextInspectCommand(options) {
 // src/cli/rules.ts
 init_canonical_loader();
 init_errors();
-import { mkdir as mkdir8 } from "fs/promises";
+import { mkdir as mkdir9 } from "fs/promises";
 import { basename as basename8, join as join50 } from "path";
 var _rulesCLIDeps = {
   readFile: async (path15) => Bun.file(path15).text(),
@@ -86962,7 +87050,7 @@ var _rulesCLIDeps = {
     }
   },
   mkdir: async (path15) => {
-    await mkdir8(path15, { recursive: true });
+    await mkdir9(path15, { recursive: true });
   },
   globCanonicalRuleFiles: (workdir) => {
     try {
@@ -95647,8 +95735,8 @@ Next: nax generate --package ${options.package}`));
     console.log(source_default.yellow("nax already initialized. Use --force to overwrite."));
     return;
   }
-  mkdirSync8(join72(naxDir, "features"), { recursive: true });
-  mkdirSync8(join72(naxDir, "hooks"), { recursive: true });
+  mkdirSync7(join72(naxDir, "features"), { recursive: true });
+  mkdirSync7(join72(naxDir, "hooks"), { recursive: true });
   await Bun.write(join72(naxDir, "config.json"), JSON.stringify(DEFAULT_CONFIG, null, 2));
   await Bun.write(join72(naxDir, "hooks.json"), JSON.stringify({
     hooks: {
@@ -95817,7 +95905,7 @@ program2.command("run").description("Run the orchestration loop for a feature").
     }
     try {
       const planLogDir = join72(featureDir, "plan");
-      mkdirSync8(planLogDir, { recursive: true });
+      mkdirSync7(planLogDir, { recursive: true });
       const planLogId = new Date().toISOString().replace(/:/g, "-").replace(/\..+/, "");
       const planLogPath = join72(planLogDir, `${planLogId}.jsonl`);
       initLogger({ level: "info", filePath: planLogPath, useChalk: false, headless: true });
@@ -95864,7 +95952,7 @@ program2.command("run").description("Run the orchestration loop for a feature").
   }
   resetLogger();
   const runsDir = join72(featureDir, "runs");
-  mkdirSync8(runsDir, { recursive: true });
+  mkdirSync7(runsDir, { recursive: true });
   const runId = new Date().toISOString().replace(/:/g, "-").replace(/\..+/, "");
   const logFilePath = join72(runsDir, `${runId}.jsonl`);
   const isTTY = process.stdout.isTTY ?? false;
@@ -95971,7 +96059,7 @@ features.command("create <name>").description("Create a new feature").option("-d
     process.exit(1);
   }
   const featureDir = join72(naxDir, "features", name);
-  mkdirSync8(featureDir, { recursive: true });
+  mkdirSync7(featureDir, { recursive: true });
   await Bun.write(join72(featureDir, "spec.md"), `# Feature: ${name}
 
 ## Overview
@@ -96082,7 +96170,7 @@ Use: nax plan -f <feature> --from <spec>`));
   }
   const config2 = await loadConfig(workdir, cliOverrides);
   const featureLogDir = join72(naxDir, "features", options.feature, "plan");
-  mkdirSync8(featureLogDir, { recursive: true });
+  mkdirSync7(featureLogDir, { recursive: true });
   const planLogId = new Date().toISOString().replace(/:/g, "-").replace(/\..+/, "");
   const planLogPath = join72(featureLogDir, `${planLogId}.jsonl`);
   initLogger({ level: "info", filePath: planLogPath, useChalk: false, headless: true });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nathapp/nax",
-  "version": "0.64.0-canary.2",
+  "version": "0.64.0-canary.4",
   "description": "AI Coding Agent Orchestrator — loops until done",
   "type": "module",
   "bin": {