@nathapp/nax 0.56.5 → 0.57.1-canary.1

package/dist/nax.js

@@ -17991,7 +17991,13 @@ var init_defaults = __esm(() => {
       model: "fast",
       refinement: true,
       redGate: true,
-      timeoutMs: 1800000
+      timeoutMs: 1800000,
+      fix: {
+        diagnoseModel: "fast",
+        fixModel: "balanced",
+        strategy: "diagnose-first",
+        maxRetries: 2
+      }
     },
     context: {
       fileInjection: "disabled",
@@ -18042,31 +18048,36 @@ var init_defaults = __esm(() => {
           enabled: true,
           resolver: { type: "synthesis" },
           sessionMode: "stateful",
-          rounds: 3
+          rounds: 3,
+          timeoutSeconds: 600
         },
         review: {
           enabled: true,
           resolver: { type: "majority-fail-closed" },
           sessionMode: "one-shot",
-          rounds: 2
+          rounds: 2,
+          timeoutSeconds: 600
         },
         acceptance: {
           enabled: false,
           resolver: { type: "majority-fail-closed" },
           sessionMode: "one-shot",
-          rounds: 1
+          rounds: 1,
+          timeoutSeconds: 600
         },
         rectification: {
           enabled: false,
           resolver: { type: "synthesis" },
           sessionMode: "one-shot",
-          rounds: 1
+          rounds: 1,
+          timeoutSeconds: 600
         },
         escalation: {
           enabled: false,
           resolver: { type: "majority-fail-closed" },
           sessionMode: "one-shot",
-          rounds: 1
+          rounds: 1,
+          timeoutSeconds: 600
         }
       }
     }
@@ -18086,7 +18097,7 @@ function isLegacyFlatModels(val) {
   }
   return false;
 }
-var TokenPricingSchema, ModelDefSchema, ModelEntrySchema, PerAgentModelMapSchema, ModelMapSchema, ModelTierSchema, TierConfigSchema, AutoModeConfigSchema, RectificationConfigSchema, RegressionGateConfigSchema, SmartTestRunnerConfigSchema, SMART_TEST_RUNNER_DEFAULT, smartTestRunnerFieldSchema, ExecutionConfigSchema, QualityConfigSchema, TddConfigSchema, ConstitutionConfigSchema, AnalyzeConfigSchema, SemanticReviewConfigSchema, ReviewConfigSchema, PlanConfigSchema, AcceptanceConfigSchema, TestCoverageConfigSchema, ContextAutoDetectConfigSchema, ContextConfigSchema, LlmRoutingConfigSchema, RoutingConfigSchema, OptimizerConfigSchema, PluginConfigEntrySchema, HooksConfigSchema, InteractionConfigSchema, StorySizeGateConfigSchema, AgentConfigSchema, PrecheckConfigSchema, PromptsConfigSchema, ProjectProfileSchema, VALID_AGENT_TYPES, GenerateConfigSchema, DebaterSchema, toObject = (val) => val === undefined || val === null ? {} : val, RESOLVER_TYPES, makeResolverSchema = (defaultType) => exports_external.preprocess(toObject, exports_external.object({
+var TokenPricingSchema, ModelDefSchema, ModelEntrySchema, PerAgentModelMapSchema, ModelMapSchema, ModelTierSchema, TierConfigSchema, AutoModeConfigSchema, RectificationConfigSchema, RegressionGateConfigSchema, SmartTestRunnerConfigSchema, SMART_TEST_RUNNER_DEFAULT, smartTestRunnerFieldSchema, ExecutionConfigSchema, QualityConfigSchema, TddConfigSchema, ConstitutionConfigSchema, AnalyzeConfigSchema, SemanticReviewConfigSchema, ReviewConfigSchema, PlanConfigSchema, AcceptanceFixConfigSchema, AcceptanceConfigSchema, TestCoverageConfigSchema, ContextAutoDetectConfigSchema, ContextConfigSchema, LlmRoutingConfigSchema, RoutingConfigSchema, OptimizerConfigSchema, PluginConfigEntrySchema, HooksConfigSchema, InteractionConfigSchema, StorySizeGateConfigSchema, AgentConfigSchema, PrecheckConfigSchema, PromptsConfigSchema, ProjectProfileSchema, VALID_AGENT_TYPES, GenerateConfigSchema, DebaterSchema, toObject = (val) => val === undefined || val === null ? {} : val, RESOLVER_TYPES, makeResolverSchema = (defaultType) => exports_external.preprocess(toObject, exports_external.object({
   type: exports_external.enum(RESOLVER_TYPES).default(defaultType),
   agent: exports_external.string().min(1).optional(),
   tieBreaker: exports_external.string().min(1).optional(),
@@ -18096,7 +18107,8 @@ var TokenPricingSchema, ModelDefSchema, ModelEntrySchema, PerAgentModelMapSchema
   resolver: makeResolverSchema(defaults.resolverType),
   sessionMode: exports_external.enum(["one-shot", "stateful"]).default(defaults.sessionMode),
   rounds: exports_external.number().int().min(1).default(defaults.rounds),
-  debaters: exports_external.array(DebaterSchema).min(2, "debaters must have at least 2 entries").optional()
+  debaters: exports_external.array(DebaterSchema).min(2, "debaters must have at least 2 entries").optional(),
+  timeoutSeconds: exports_external.number().int().positive().default(600)
 })), DebateConfigSchema, NaxConfigSchema;
 var init_schemas3 = __esm(() => {
   init_zod();
@@ -18297,7 +18309,14 @@ var init_schemas3 = __esm(() => {
   });
   PlanConfigSchema = exports_external.object({
     model: ModelTierSchema,
-    outputPath: exports_external.string().min(1, "plan.outputPath must be non-empty")
+    outputPath: exports_external.string().min(1, "plan.outputPath must be non-empty"),
+    timeoutSeconds: exports_external.number().int().positive().default(600)
+  });
+  AcceptanceFixConfigSchema = exports_external.object({
+    diagnoseModel: exports_external.string().min(1, "acceptance.fix.diagnoseModel must be non-empty"),
+    fixModel: exports_external.string().min(1, "acceptance.fix.fixModel must be non-empty"),
+    strategy: exports_external.enum(["diagnose-first", "implement-only"]),
+    maxRetries: exports_external.number().int().nonnegative()
   });
   AcceptanceConfigSchema = exports_external.object({
     enabled: exports_external.boolean(),
@@ -18310,7 +18329,13 @@ var init_schemas3 = __esm(() => {
     redGate: exports_external.boolean().default(true),
     testStrategy: exports_external.enum(["unit", "component", "cli", "e2e", "snapshot"]).optional(),
     testFramework: exports_external.string().min(1, "acceptance.testFramework must be non-empty").optional(),
-    timeoutMs: exports_external.number().int().min(30000).max(3600000).default(1800000)
+    timeoutMs: exports_external.number().int().min(30000).max(3600000).default(1800000),
+    fix: AcceptanceFixConfigSchema.optional().default({
+      diagnoseModel: "fast",
+      fixModel: "balanced",
+      strategy: "diagnose-first",
+      maxRetries: 2
+    })
   });
   TestCoverageConfigSchema = exports_external.object({
     enabled: exports_external.boolean().default(true),
@@ -18982,7 +19007,8 @@ class AcpAgentAdapter {
     const tryOneAgent = async (agentName) => {
       const model = await resolveModel2(agentName);
       const cmdStr = `acpx --model ${model} ${agentName}`;
-      const client = _acpAdapterDeps.createClient(cmdStr, workdir);
+      const timeoutSeconds = Math.ceil(timeoutMs / 1000);
+      const client = _acpAdapterDeps.createClient(cmdStr, workdir, timeoutSeconds);
       await client.start();
       let session = null;
       let hadError = false;
@@ -19827,9 +19853,9 @@ async function runPlan(binary, options, pidRegistry, buildAllowedEnv2) {
     modelDef,
     prompt: "",
     modelTier: options.modelTier || "balanced",
-    timeoutSeconds: 600
+    timeoutSeconds: options.timeoutSeconds ?? 600
   };
-  const PLAN_TIMEOUT_MS = 600000;
+  const planTimeoutMs = (options.timeoutSeconds ?? 600) * 1000;
   if (options.interactive) {
     const proc = Bun.spawn(cmd, {
       cwd: options.workdir,
@@ -19841,7 +19867,7 @@ async function runPlan(binary, options, pidRegistry, buildAllowedEnv2) {
     await pidRegistry.register(proc.pid);
     let exitCode;
     try {
-      const timeoutResult = await withProcessTimeout(proc, PLAN_TIMEOUT_MS, {
+      const timeoutResult = await withProcessTimeout(proc, planTimeoutMs, {
         graceMs: 5000
       });
       exitCode = timeoutResult.exitCode;
@@ -19867,7 +19893,7 @@ async function runPlan(binary, options, pidRegistry, buildAllowedEnv2) {
     await pidRegistry.register(proc.pid);
     let exitCode;
     try {
-      const timeoutResult = await withProcessTimeout(proc, PLAN_TIMEOUT_MS, {
+      const timeoutResult = await withProcessTimeout(proc, planTimeoutMs, {
         graceMs: 5000
       });
       exitCode = timeoutResult.exitCode;
@@ -20909,7 +20935,8 @@ async function refineAcceptanceCriteria(criteria, context) {
       featureName,
       storyId,
       workdir,
-      sessionRole: "refine"
+      sessionRole: "refine",
+      timeoutMs: config2.acceptance?.timeoutMs ?? 120000
     });
     response = typeof completeResult === "string" ? completeResult : completeResult.output;
   } catch (error48) {
@@ -20958,6 +20985,7 @@ var init_refinement = __esm(() => {
 // src/acceptance/generator.ts
 var exports_generator = {};
 __export(exports_generator, {
+  resolveAcceptanceTestFile: () => resolveAcceptanceTestFile,
   parseAcceptanceCriteria: () => parseAcceptanceCriteria,
   generateSkeletonTests: () => generateSkeletonTests,
   generateFromPRD: () => generateFromPRD,
@@ -20993,6 +21021,9 @@ function acceptanceTestFilename(language) {
       return ".nax-acceptance.test.ts";
   }
 }
+function resolveAcceptanceTestFile(language, testPathConfig) {
+  return testPathConfig ?? acceptanceTestFilename(language);
+}
 function buildAcceptanceRunCommand(testPath, testFramework, commandOverride) {
   if (commandOverride) {
     const resolved = commandOverride.replace(/\{\{files\}\}/g, testPath).replace(/\{\{file\}\}/g, testPath).replace(/\{\{FILE\}\}/g, testPath);
@@ -21061,7 +21092,7 @@ Rules:
 - Every test MUST have real assertions that PASS when the feature is correctly implemented and FAIL when it is broken
 - **Prefer behavioral tests** \u2014 import functions and call them rather than reading source files. For example, to verify "getPostRunActions() returns empty array", import PluginRegistry and call getPostRunActions(), don't grep the source file for the method name.
 - **File output (REQUIRED)**: Write the acceptance test file DIRECTLY to the path shown below. Do NOT output the test code in your response. After writing the file, reply with a brief confirmation.
-- **Path anchor (CRITICAL)**: Write the test file to this exact path: \`${join5(options.workdir, ".nax", "features", options.featureName, acceptanceTestFilename(options.language))}\`. Import from package sources using relative paths like \`../../../src/...\` (3 levels up from \`.nax/features/<name>/\` to the package root).`;
+- **Path anchor (CRITICAL)**: Write the test file to this exact path: \`${join5(options.workdir, ".nax", "features", options.featureName, resolveAcceptanceTestFile(options.language, options.config?.acceptance?.testPath))}\`. Import from package sources using relative paths like \`../../../src/...\` (3 levels up from \`.nax/features/<name>/\` to the package root).`;
   const prompt = basePrompt;
   logger.info("acceptance", "Generating tests from PRD refined criteria", { count: refinedCriteria.length });
   const completeResult = await (options.adapter ?? _generatorPRDDeps.adapter).complete(prompt, {
@@ -21080,7 +21111,7 @@ Rules:
     outputPreview: rawOutput.slice(0, 300)
   });
   if (!testCode) {
-    const targetPath = join5(options.workdir, ".nax", "features", options.featureName, acceptanceTestFilename(options.language));
+    const targetPath = join5(options.workdir, ".nax", "features", options.featureName, resolveAcceptanceTestFile(options.language, options.config?.acceptance?.testPath));
     let recoveryFailed = false;
     logger.debug("acceptance", "BUG-076 recovery: checking for agent-written file", { targetPath });
     try {
@@ -22132,7 +22163,7 @@ var package_default;
 var init_package = __esm(() => {
   package_default = {
     name: "@nathapp/nax",
-    version: "0.56.5",
+    version: "0.57.1-canary.1",
     description: "AI Coding Agent Orchestrator \u2014 loops until done",
     type: "module",
     bin: {
@@ -22211,8 +22242,8 @@ var init_version = __esm(() => {
   NAX_VERSION = package_default.version;
   NAX_COMMIT = (() => {
     try {
-      if (/^[0-9a-f]{6,10}$/.test("01c24d40"))
-        return "01c24d40";
+      if (/^[0-9a-f]{6,10}$/.test("814ed29f"))
+        return "814ed29f";
     } catch {}
     try {
       const result = Bun.spawnSync(["git", "rev-parse", "--short", "HEAD"], {
@@ -22499,10 +22530,11 @@ function modelTierFromDebater(debater) {
 function isTierLabel(value) {
   return value === "fast" || value === "balanced" || value === "powerful";
 }
-async function runComplete(adapter, prompt, options, modelTier) {
+async function runComplete(adapter, prompt, options, modelTier, timeoutMs) {
   return adapter.complete(prompt, {
     ...options,
-    modelTier
+    modelTier,
+    ...timeoutMs !== undefined && { timeoutMs }
   });
 }
 
@@ -22514,6 +22546,9 @@ class DebateSession {
   workdir;
   featureName;
   timeoutSeconds;
+  get timeoutMs() {
+    return this.timeoutSeconds * 1000;
+  }
   constructor(opts) {
     this.storyId = opts.storyId;
     this.stage = opts.stage;
@@ -22521,7 +22556,7 @@ class DebateSession {
     this.config = opts.config;
     this.workdir = opts.workdir ?? process.cwd();
     this.featureName = opts.featureName ?? opts.stage;
-    this.timeoutSeconds = opts.timeoutSeconds ?? opts.config?.execution?.sessionTimeoutSeconds ?? 600;
+    this.timeoutSeconds = opts.timeoutSeconds ?? opts.stageConfig.timeoutSeconds ?? DEFAULT_TIMEOUT_SECONDS;
   }
   pipelineStageForDebate() {
     switch (this.stage) {
@@ -22761,7 +22796,8 @@ class DebateSession {
       featureName: this.stage,
       config: this.config,
       storyId: this.storyId,
-      sessionRole: "debate-proposal"
+      sessionRole: "debate-proposal",
+      timeoutMs: this.timeoutMs
     }, modelTierFromDebater(debater)).then((result) => ({ debater, adapter, output: result.output, cost: result.costUsd }))));
     const successful = proposalSettled.filter((r) => r.status === "fulfilled").map((r) => r.value);
     for (const r of proposalSettled) {
@@ -22815,7 +22851,8 @@ class DebateSession {
             featureName: this.stage,
             config: this.config,
             storyId: this.storyId,
-            sessionRole: "debate-fallback"
+            sessionRole: "debate-fallback",
+            timeoutMs: this.timeoutMs
           }, modelTierFromDebater(fallbackDebater));
           totalCostUsd += fallbackResult.costUsd;
           logger?.info("debate", "debate:result", {
@@ -22845,7 +22882,8 @@ class DebateSession {
         featureName: this.stage,
         config: this.config,
         storyId: this.storyId,
-        sessionRole: "debate-critique"
+        sessionRole: "debate-critique",
+        timeoutMs: this.timeoutMs
       }, modelTierFromDebater(debater))));
       for (const r of critiqueSettled) {
         if (r.status === "fulfilled") {
@@ -22988,7 +23026,8 @@ Do NOT output the JSON to the conversation. Write the file, then reply with a br
             model: resolveDebaterModel({ agent: agentName }, this.config),
             config: this.config,
             storyId: this.storyId,
-            sessionRole: "synthesis"
+            sessionRole: "synthesis",
+            timeoutMs: this.timeoutMs
           }
         });
         return {
@@ -23010,7 +23049,8 @@ Do NOT output the JSON to the conversation. Write the file, then reply with a br
           model: resolveDebaterModel({ agent: agentName }, this.config),
           config: this.config,
           storyId: this.storyId,
-          sessionRole: "judge"
+          sessionRole: "judge",
+          timeoutMs: this.timeoutMs
         }
       });
       return {
@@ -23024,7 +23064,7 @@ Do NOT output the JSON to the conversation. Write the file, then reply with a br
     };
   }
 }
-var RESOLVER_FALLBACK_AGENT = "synthesis", _debateSessionDeps;
+var RESOLVER_FALLBACK_AGENT = "synthesis", _debateSessionDeps, DEFAULT_TIMEOUT_SECONDS = 600;
 var init_session = __esm(() => {
   init_registry();
   init_config();
@@ -23228,13 +23268,15 @@ class AutoInteractionPlugin {
       const modelDef = resolveModelForAgent(naxConfig.models, naxConfig.autoMode.defaultAgent, modelTier, naxConfig.autoMode.defaultAgent);
       modelArg = modelDef.model;
     }
+    const timeoutMs = this.config.naxConfig ? (this.config.naxConfig.execution?.sessionTimeoutSeconds ?? 600) * 1000 : undefined;
     const result = await adapter.complete(prompt, {
       ...modelArg && { model: modelArg },
       jsonMode: true,
       ...this.config.naxConfig && { config: this.config.naxConfig },
       featureName: request.featureName,
       storyId: request.storyId,
-      sessionRole: "auto"
+      sessionRole: "auto",
+      ...timeoutMs !== undefined && { timeoutMs }
     });
     const output = typeof result === "string" ? result : result.output;
     return this.parseResponse(output);
@@ -25977,6 +26019,7 @@ ${stderr}` };
         return { action: "fail", reason: "[acceptance-setup] featureDir is not set" };
       }
       const language = (ctx.effectiveConfig ?? ctx.config).project?.language;
+      const testPathConfig = (ctx.effectiveConfig ?? ctx.config).acceptance.testPath;
       const metaPath = path5.join(ctx.featureDir, "acceptance-meta.json");
       const allCriteria = ctx.prd.userStories.filter((s) => !s.id.startsWith("US-FIX-")).flatMap((s) => s.acceptanceCriteria);
       const nonFixStories = ctx.prd.userStories.filter((s) => !s.id.startsWith("US-FIX-"));
@@ -25999,7 +26042,7 @@ ${stderr}` };
       const testPaths = [];
       for (const [workdir] of workdirGroups) {
         const packageDir = workdir ? path5.join(ctx.workdir, workdir) : ctx.workdir;
-        const testPath = path5.join(packageDir, ".nax", "features", featureName, acceptanceTestFilename(language));
+        const testPath = path5.join(packageDir, ".nax", "features", featureName, resolveAcceptanceTestFile(language, testPathConfig));
         testPaths.push({ testPath, packageDir });
       }
       let totalCriteria = 0;
@@ -26062,7 +26105,7 @@ ${stderr}` };
         testableCount = allRefinedCriteria.filter((r) => r.testable).length;
         for (const [workdir, group] of workdirGroups) {
           const packageDir = workdir ? path5.join(ctx.workdir, workdir) : ctx.workdir;
-          const testPath = path5.join(packageDir, acceptanceTestFilename(language));
+          const testPath = path5.join(packageDir, resolveAcceptanceTestFile(language, testPathConfig));
           const groupStoryIds = new Set(group.stories.map((s) => s.id));
           const groupRefined = allRefinedCriteria.filter((r) => groupStoryIds.has(r.storyId));
           const result = await _acceptanceSetupDeps.generate(group.stories, groupRefined, {
@@ -31531,8 +31574,15 @@ async function _defaultRunDebate(storyId, stageConfig, prompt, config2) {
   if (resolved.length === 0) {
     return { output: null, totalCostUsd: 0 };
   }
+  const timeoutMs = (config2?.execution?.sessionTimeoutSeconds ?? 600) * 1000;
   const startMs = Date.now();
-  const proposalSettled = await Promise.allSettled(resolved.map(({ debater, adapter }) => adapter.complete(prompt, { model: debater.model }).then((out) => typeof out === "string" ? out : out.output)));
+  const proposalSettled = await Promise.allSettled(resolved.map(({ debater, adapter }) => adapter.complete(prompt, {
+    model: debater.model,
+    config: config2,
+    storyId,
+    sessionRole: "debate-proposal",
+    timeoutMs
+  }).then((out) => typeof out === "string" ? out : out.output)));
   const durationMs = Date.now() - startMs;
   const successful = proposalSettled.filter((r) => r.status === "fulfilled").map((r) => r.value);
   if (successful.length === 0) {
@@ -34087,6 +34137,214 @@ var init_crash_recovery = __esm(() => {
   init_crash_heartbeat();
 });
 
+// src/acceptance/fix-diagnosis.ts
+function parseImportStatements(content) {
+  const importRegex = /import\s+(?:{[^}]+}|[^;]+)\s+from\s+["']([^"']+)["']/g;
+  const imports = [];
+  const regexMatch = content.matchAll(importRegex);
+  for (const match of regexMatch) {
+    imports.push(match[1]);
+  }
+  return imports;
+}
+function resolveImportPaths(imports, workdir) {
+  const resolved = [];
+  for (const imp of imports) {
+    if (imp.startsWith(".")) {
+      resolved.push(imp);
+    }
+  }
+  return resolved.slice(0, MAX_SOURCE_FILES);
+}
+async function readSourceFileContent(filePath, workdir) {
+  try {
+    const fullPath = `${workdir}/${filePath}`;
+    const file3 = await Bun.file(fullPath).text();
+    const lines = file3.split(`
+`).slice(0, MAX_FILE_LINES);
+    return { path: filePath, content: lines.join(`
+`) };
+  } catch {
+    return null;
+  }
+}
+function buildDiagnosisPrompt(options) {
+  const truncatedOutput = options.testOutput.slice(0, MAX_TEST_OUTPUT_CHARS);
+  const sourceFilesSection = options.sourceFiles.length > 0 ? options.sourceFiles.map((f) => `FILE: ${f.path}
+\`\`\`
+${f.content}
+\`\`\``).join(`
+
+`) : "(No source files could be resolved from imports)";
+  return `You are a debugging expert. An acceptance test has failed.
+
+TASK: Diagnose whether the failure is due to a bug in the SOURCE CODE or a bug in the TEST CODE.
+
+FAILING TEST OUTPUT:
+${truncatedOutput}
+
+ACCEPTANCE TEST FILE CONTENT:
+\`\`\`typescript
+${options.testFileContent}
+\`\`\`
+
+SOURCE FILES (auto-detected from imports, up to ${MAX_FILE_LINES} lines each):
+${sourceFilesSection}
+
+Respond with ONLY a JSON object in this exact format (no markdown, no extra text):
+{
+  "verdict": "source_bug" | "test_bug" | "both",
+  "reasoning": "Your analysis explaining why this is a source_bug, test_bug, or both",
+  "confidence": 0.0-1.0,
+  "testIssues": ["Issue in test code if any"],
+  "sourceIssues": ["Issue in source code if any"]
+}`;
+}
+async function diagnoseAcceptanceFailure(agent, options) {
+  if (!agent) {
+    throw new Error("[diagnosis] Agent adapter is required");
+  }
+  const { testOutput, testFileContent, config: config2, workdir, featureName, storyId } = options;
+  const sessionName = buildSessionName(workdir, featureName, storyId, "diagnose");
+  const diagnoseModelTier = config2.acceptance.fix.diagnoseModel;
+  const modelDef = resolveModelForAgent(config2.models, config2.autoMode.defaultAgent, diagnoseModelTier, config2.autoMode.defaultAgent);
+  const imports = parseImportStatements(testFileContent);
+  const relativeImports = resolveImportPaths(imports, workdir);
+  const sourceFiles = await Promise.all(relativeImports.map((imp) => readSourceFileContent(imp, workdir)));
+  const validSourceFiles = sourceFiles.filter((f) => f !== null);
+  const prompt = buildDiagnosisPrompt({
+    testOutput,
+    testFileContent,
+    sourceFiles: validSourceFiles
+  });
+  try {
+    const result = await agent.run({
+      prompt,
+      workdir,
+      modelTier: undefined,
+      modelDef,
+      timeoutSeconds: 300,
+      sessionRole: "diagnose",
+      acpSessionName: sessionName,
+      featureName,
+      storyId,
+      config: config2
+    });
+    const diagnosis = parseDiagnosisResult(result.output);
+    if (diagnosis) {
+      return diagnosis;
+    }
+    return {
+      verdict: "source_bug",
+      reasoning: "diagnosis failed \u2014 falling back to source fix",
+      confidence: 0
+    };
+  } catch (err) {
+    return {
+      verdict: "source_bug",
+      reasoning: "diagnosis failed \u2014 falling back to source fix",
+      confidence: 0
+    };
+  }
+}
+function parseDiagnosisResult(output) {
+  if (!output || output.trim() === "") {
+    return null;
+  }
+  try {
+    const cleaned = output.trim();
+    let jsonStr = cleaned;
+    const firstBrace = cleaned.indexOf("{");
+    const lastBrace = cleaned.lastIndexOf("}");
+    if (firstBrace !== -1 && lastBrace !== -1 && lastBrace > firstBrace) {
+      jsonStr = cleaned.slice(firstBrace, lastBrace + 1);
+    }
+    const parsed = JSON.parse(jsonStr);
+    if (typeof parsed.verdict === "string" && typeof parsed.reasoning === "string" && typeof parsed.confidence === "number") {
+      return {
+        verdict: parsed.verdict,
+        reasoning: parsed.reasoning,
+        confidence: parsed.confidence,
+        testIssues: parsed.testIssues,
+        sourceIssues: parsed.sourceIssues
+      };
+    }
+    return null;
+  } catch {
+    return null;
+  }
+}
+var MAX_SOURCE_FILES = 5, MAX_FILE_LINES = 500, MAX_TEST_OUTPUT_CHARS = 2000;
+var init_fix_diagnosis = __esm(() => {
+  init_adapter();
+});
+
+// src/acceptance/fix-executor.ts
+function buildSourceFixPrompt(options) {
+  const { testOutput, diagnosis, acceptanceTestPath } = options;
+  let prompt = `ACCEPTANCE TEST FAILURE:
+${testOutput}
+
+`;
+  if (diagnosis.reasoning) {
+    prompt += `DIAGNOSIS:
+${diagnosis.reasoning}
+
+`;
+  }
+  prompt += `ACCEPTANCE TEST FILE: ${acceptanceTestPath}
+
+`;
+  prompt += "Fix the source implementation. Do NOT modify the test file.";
+  return prompt;
+}
+async function executeSourceFix(agent, options) {
+  if (!agent) {
+    throw new Error("[fix-executor] agent is required");
+  }
+  const { testOutput, testFileContent, diagnosis, config: config2, workdir, featureName, storyId, acceptanceTestPath } = options;
+  const modelDef = resolveModelForAgent(config2.models, config2.autoMode.defaultAgent, config2.acceptance.fix.fixModel, config2.autoMode.defaultAgent);
+  const sessionName = buildSessionName(workdir, featureName, storyId, "source-fix");
+  const prompt = buildSourceFixPrompt(options);
+  const timeoutSeconds = config2.execution?.sessionTimeoutSeconds ?? 3600;
+  const runOptions = {
+    prompt,
+    workdir,
+    modelTier: undefined,
+    modelDef,
+    timeoutSeconds,
+    sessionRole: "source-fix",
+    acpSessionName: sessionName,
+    featureName,
+    storyId,
+    config: config2,
+    pipelineStage: "acceptance"
+  };
+  const result = await agent.run(runOptions);
+  let success2 = result.success;
+  try {
+    const verifyProc = _fixExecutorDeps.spawn(["bun", "test", acceptanceTestPath], {
+      cwd: workdir,
+      stdout: "pipe",
+      stderr: "pipe"
+    });
+    const exitCode = await verifyProc.exited;
+    success2 = exitCode === 0;
+  } catch {
+    success2 = result.success;
+  }
+  return {
+    success: success2,
+    cost: result.estimatedCost
+  };
+}
+var _fixExecutorDeps;
+var init_fix_executor = __esm(() => {
+  init_adapter();
+  init_bun_deps();
+  _fixExecutorDeps = { spawn };
+});
+
 // src/execution/lifecycle/acceptance-loop.ts
 var exports_acceptance_loop = {};
 __export(exports_acceptance_loop, {
@@ -34113,6 +34371,14 @@ async function loadSpecContent(featureDir) {
   const specFile = Bun.file(specPath);
   return await specFile.exists() ? await specFile.text() : "";
 }
+async function loadAcceptanceTestContent(featureDir) {
+  if (!featureDir)
+    return { content: "", path: "" };
+  const testPath = path14.join(featureDir, "acceptance.test.ts");
+  const testFile = Bun.file(testPath);
+  const content = await testFile.exists() ? await testFile.text() : "";
+  return { content, path: testPath };
+}
 function buildResult(success2, prd, totalCost, iterations, storiesCompleted, prdDirty) {
   return { success: success2, prd, totalCost, iterations, storiesCompleted, prdDirty };
 }
@@ -34198,6 +34464,191 @@ async function regenerateAcceptanceTest(testPath, acceptanceContext) {
   logger?.info("acceptance", "Acceptance test regenerated successfully");
   return true;
 }
+async function runFixRouting(options) {
+  const logger = getSafeLogger();
+  const { ctx, failures, prd, acceptanceContext } = options;
+  const agentName = ctx.config.autoMode.defaultAgent;
+  const agent = (ctx.agentGetFn ?? _acceptanceLoopDeps.getAgent)(agentName);
+  if (!agent) {
+    logger?.error("acceptance", "Agent not found for fix routing");
+    return { fixed: false, cost: 0, prdDirty: false };
+  }
+  const strategy = ctx.config.acceptance.fix?.strategy ?? "diagnose-first";
+  const fixMaxRetries = ctx.config.acceptance.fix?.maxRetries ?? 2;
+  const { content: testFileContent, path: acceptanceTestPath } = await loadAcceptanceTestContent(ctx.featureDir);
+  const firstStory = prd.userStories[0];
+  const storyId = firstStory?.id ?? "unknown";
+  if (strategy === "implement-only") {
+    logger?.info("acceptance", "Strategy is implement-only \u2014 executing source fix directly");
+    let fixAttempts = 0;
+    while (fixAttempts < fixMaxRetries) {
+      fixAttempts++;
+      logger?.info("acceptance", `Source fix attempt ${fixAttempts}/${fixMaxRetries}`);
+      const defaultDiagnosis = {
+        verdict: "source_bug",
+        reasoning: "implement-only strategy \u2014 skipping diagnosis",
+        confidence: 1
+      };
+      const fixResult = await executeSourceFix(agent, {
+        testOutput: failures.testOutput,
+        testFileContent,
+        diagnosis: defaultDiagnosis,
+        config: ctx.config,
+        workdir: ctx.workdir,
+        featureName: ctx.feature,
+        storyId,
+        acceptanceTestPath
+      });
+      logger?.info("acceptance.source-fix", "Source fix completed", {
+        success: fixResult.success,
+        cost: fixResult.cost,
+        attempt: fixAttempts
+      });
+      if (fixResult.success) {
+        return { fixed: true, cost: fixResult.cost, prdDirty: false };
+      }
+      if (fixAttempts >= fixMaxRetries) {
+        logger?.error("acceptance", `Source fix failed after ${fixMaxRetries} attempts`);
+        break;
+      }
+    }
+    return { fixed: false, cost: 0, prdDirty: false };
+  }
+  logger?.info("acceptance", "Strategy is diagnose-first \u2014 running diagnosis");
+  const diagnosis = await diagnoseAcceptanceFailure(agent, {
+    testOutput: failures.testOutput,
+    testFileContent,
+    config: ctx.config,
+    workdir: ctx.workdir,
+    featureName: ctx.feature,
+    storyId
+  });
+  logger?.info("acceptance.diagnosis", "Diagnosis complete", {
+    verdict: diagnosis.verdict,
+    confidence: diagnosis.confidence,
+    reasoning: diagnosis.reasoning
+  });
+  if (diagnosis.verdict === "source_bug") {
+    logger?.info("acceptance", "Diagnosis: source_bug \u2014 executing source fix");
+    let fixAttempts = 0;
+    while (fixAttempts < fixMaxRetries) {
+      fixAttempts++;
+      logger?.info("acceptance", `Source fix attempt ${fixAttempts}/${fixMaxRetries}`);
+      const fixResult = await executeSourceFix(agent, {
+        testOutput: failures.testOutput,
+        testFileContent,
+        diagnosis,
+        config: ctx.config,
+        workdir: ctx.workdir,
+        featureName: ctx.feature,
+        storyId,
+        acceptanceTestPath
+      });
+      logger?.info("acceptance.source-fix", "Source fix completed", {
+        success: fixResult.success,
+        cost: fixResult.cost,
+        attempt: fixAttempts
+      });
+      if (fixResult.success) {
+        return { fixed: true, cost: fixResult.cost, prdDirty: false };
+      }
+      if (fixAttempts >= fixMaxRetries) {
+        logger?.error("acceptance", `Source fix failed after ${fixMaxRetries} attempts`);
+        break;
+      }
+    }
+    return { fixed: false, cost: 0, prdDirty: false };
+  }
+  if (diagnosis.verdict === "test_bug") {
+    logger?.info("acceptance", "Diagnosis: test_bug \u2014 regenerating acceptance test");
+    if (!ctx.featureDir) {
+      logger?.error("acceptance", "Cannot regenerate test without featureDir");
+      return { fixed: false, cost: 0, prdDirty: false };
+    }
+    const testPath = path14.join(ctx.featureDir, "acceptance.test.ts");
+    const testFile = Bun.file(testPath);
+    if (!await testFile.exists()) {
+      logger?.error("acceptance", "Acceptance test file not found for regeneration");
+      return { fixed: false, cost: 0, prdDirty: false };
+    }
+    const regenerated = await regenerateAcceptanceTest(testPath, acceptanceContext);
+    logger?.info("acceptance.test-regen", "Test regeneration completed", {
+      outcome: regenerated ? "success" : "failure"
+    });
+    if (!regenerated) {
+      return { fixed: false, cost: 0, prdDirty: false };
+    }
+    const { acceptanceStage: acceptanceStage2 } = await Promise.resolve().then(() => (init_acceptance2(), exports_acceptance));
+    const acceptanceResult = await acceptanceStage2.execute(acceptanceContext);
+    if (acceptanceResult.action === "continue") {
+      logger?.info("acceptance", "Acceptance passed after test regeneration");
+      return { fixed: true, cost: 0, prdDirty: true };
+    }
+    logger?.warn("acceptance", "Acceptance still failing after test regeneration");
+    return { fixed: false, cost: 0, prdDirty: true };
+  }
+  if (diagnosis.verdict === "both") {
+    logger?.info("acceptance", "Diagnosis: both \u2014 executing source fix then regenerating test if needed");
+    let sourceFixSuccess = false;
+    let sourceFixCost = 0;
+    let fixAttempts = 0;
+    while (fixAttempts < fixMaxRetries && !sourceFixSuccess) {
+      fixAttempts++;
+      logger?.info("acceptance", `Source fix attempt ${fixAttempts}/${fixMaxRetries}`);
+      const fixResult = await executeSourceFix(agent, {
+        testOutput: failures.testOutput,
+        testFileContent,
+        diagnosis,
+        config: ctx.config,
+        workdir: ctx.workdir,
+        featureName: ctx.feature,
+        storyId,
+        acceptanceTestPath
+      });
+      logger?.info("acceptance.source-fix", "Source fix completed", {
+        success: fixResult.success,
+        cost: fixResult.cost,
+        attempt: fixAttempts
+      });
+      sourceFixSuccess = fixResult.success;
+      sourceFixCost += fixResult.cost;
+      if (fixResult.success) {
+        break;
+      }
+      if (fixAttempts >= fixMaxRetries) {
+        logger?.error("acceptance", `Source fix failed after ${fixMaxRetries} attempts`);
+        break;
+      }
+    }
+    if (!sourceFixSuccess) {
+      return { fixed: false, cost: sourceFixCost, prdDirty: false };
+    }
+    logger?.info("acceptance", "Source fix succeeded \u2014 re-running acceptance to verify");
+    const { acceptanceStage: acceptanceStage2 } = await Promise.resolve().then(() => (init_acceptance2(), exports_acceptance));
+    const acceptanceResult = await acceptanceStage2.execute(acceptanceContext);
+    if (acceptanceResult.action === "continue") {
+      logger?.info("acceptance", "Acceptance passed after source fix");
+      return { fixed: true, cost: sourceFixCost, prdDirty: false };
+    }
+    logger?.info("acceptance", "Acceptance still failing after source fix \u2014 regenerating test");
+    if (!ctx.featureDir) {
+      logger?.error("acceptance", "Cannot regenerate test without featureDir");
+      return { fixed: false, cost: sourceFixCost, prdDirty: false };
+    }
+    const testPath = path14.join(ctx.featureDir, "acceptance.test.ts");
+    const testFile = Bun.file(testPath);
+    if (!await testFile.exists()) {
+      logger?.error("acceptance", "Acceptance test file not found for regeneration");
+      return { fixed: false, cost: sourceFixCost, prdDirty: false };
+    }
+    const regenerated = await regenerateAcceptanceTest(testPath, acceptanceContext);
+    logger?.info("acceptance.test-regen", "Test regeneration completed", {
+      outcome: regenerated ? "success" : "failure"
+    });
+    return { fixed: regenerated, cost: sourceFixCost, prdDirty: regenerated };
+  }
+  return { fixed: false, cost: 0, prdDirty: false };
+}
 async function runAcceptanceLoop(ctx) {
   const logger = getSafeLogger();
   const maxRetries = ctx.config.acceptance.maxRetries;
@@ -34292,6 +34743,23 @@ async function runAcceptanceLoop(ctx) {
         continue;
       }
     }
+    const strategy = ctx.config.acceptance.fix?.strategy ?? "diagnose-first";
+    if (strategy === "diagnose-first" || strategy === "implement-only") {
+      logger?.info("acceptance", `Running fix routing with strategy: ${strategy}`);
+      const fixResult = await runFixRouting({
+        ctx,
+        failures,
+        prd,
+        acceptanceContext
+      });
+      totalCost += fixResult.cost;
+      if (fixResult.fixed) {
+        logger?.info("acceptance", "Fix succeeded \u2014 re-running acceptance tests...");
+        continue;
+      }
+      logger?.error("acceptance", "Fix routing failed to resolve acceptance failures");
+      return buildResult(false, prd, totalCost, iterations, storiesCompleted, prdDirty);
+    }
     logger?.info("acceptance", "Generating fix stories...");
     const fixStories = await generateAndAddFixStories(ctx, failures, prd);
     if (!fixStories) {
@@ -34323,6 +34791,8 @@ async function runAcceptanceLoop(ctx) {
 var _acceptanceLoopDeps;
 var init_acceptance_loop = __esm(() => {
   init_acceptance();
+  init_fix_diagnosis();
+  init_fix_executor();
   init_registry();
   init_config();
   init_loader();
@@ -34437,6 +34907,16 @@ async function runDeferredRegression(options) {
     };
   }
   const testSummary = _regressionDeps.parseBunTestOutput(fullSuiteResult.output);
+  if (testSummary.failed === 0 && testSummary.passed === 0) {
+    logger?.warn("regression", "No test results parsed from output \u2014 test runner likely crashed or errored (not a regression, accepting as pass)", { output: fullSuiteResult.output.slice(0, 500) });
+    return {
+      success: true,
+      failedTests: 0,
+      passedTests: 0,
+      rectificationAttempts: 0,
+      affectedStories: []
+    };
+  }
   const affectedStories = new Set;
   const affectedStoriesObjs = new Map;
   logger?.warn("regression", "Regression detected", {
@@ -36618,13 +37098,25 @@ async function executeUnified(ctx, initialPrd) {
         prd = await loadPRD(ctx.prdPath);
         prdDirty = false;
       }
+      const storyCounts = countStories(prd);
+      logger?.debug("execution", "Loop iteration", {
+        iteration: iterations,
+        isComplete: isComplete(prd),
+        passed: storyCounts.passed,
+        pending: storyCounts.pending,
+        failed: storyCounts.failed,
+        total: storyCounts.total
+      });
       if (isComplete(prd)) {
+        logger?.debug("execution", "All stories complete \u2014 entering completion path");
         if (ctx.interactionChain && isTriggerEnabled("pre-merge", ctx.config)) {
           const shouldProceed = await checkPreMerge({ featureName: ctx.feature, totalStories: prd.userStories.length, cost: totalCost }, ctx.config, ctx.interactionChain);
           if (!shouldProceed)
             return buildResult2("pre-merge-aborted");
         }
+        logger?.debug("execution", "Running deferred review");
         deferredReview = await runDeferredReview(ctx.workdir, ctx.config.review, ctx.pluginRegistry, runStartRef);
+        logger?.debug("execution", "Deferred review done \u2014 returning completed");
         return buildResult2("completed");
       }
       const costLimit = ctx.config.execution.costLimit;
@@ -36877,9 +37369,7 @@ async function executeUnified(ctx, initialPrd) {
       }, ctx.eventEmitter);
     }
     return buildResult2("max-iterations");
-  } finally {
-    stopHeartbeat();
-  }
+  } finally {}
 }
 var _unifiedExecutorDeps;
 var init_unified_executor = __esm(() => {
@@ -69804,6 +70294,7 @@ function validatePlanOutput(raw, feature, branch) {
 }
 
 // src/cli/plan.ts
+var DEFAULT_TIMEOUT_SECONDS2 = 600;
 var _planDeps = {
   readFile: (path) => Bun.file(path).text(),
   writeFile: (path, content) => Bun.write(path, content).then(() => {}),
@@ -69854,7 +70345,7 @@ async function planCommand(workdir, config2, options) {
   const outputPath = join12(outputDir, "prd.json");
   await _planDeps.mkdirp(outputDir);
   const agentName = config2?.autoMode?.defaultAgent ?? "claude";
-  const timeoutSeconds = config2?.execution?.sessionTimeoutSeconds ?? 600;
+  const timeoutSeconds = config2?.plan?.timeoutSeconds ?? DEFAULT_TIMEOUT_SECONDS2;
   let rawResponse;
   const debateEnabled = config2?.debate?.enabled && config2?.debate?.stages?.plan?.enabled;
   if (debateEnabled) {
@@ -69938,13 +70429,15 @@ async function planCommand(workdir, config2, options) {
       }
       rawResponse = await _planDeps.readFile(outputPath);
     } else {
+      const timeoutMs = (config2?.plan?.timeoutSeconds ?? DEFAULT_TIMEOUT_SECONDS2) * 1000;
       const completeResult = await adapter.complete(prompt, {
         model: autoModel,
         jsonMode: true,
         workdir,
         config: config2,
         featureName: options.feature,
-        sessionRole: "plan"
+        sessionRole: "plan",
+        timeoutMs
       });
       let result = typeof completeResult === "string" ? completeResult : completeResult.output;
       try {
@@ -70317,6 +70810,8 @@ async function planDecomposeCommand(workdir, config2, options) {
   const stages = config2?.debate?.stages;
   const debateEnabled = config2?.debate?.enabled && stages?.decompose?.enabled;
   let rawResponse;
+  const timeoutSeconds = config2?.plan?.timeoutSeconds ?? DEFAULT_TIMEOUT_SECONDS2;
+  const timeoutMs = timeoutSeconds * 1000;
   if (debateEnabled) {
     const stageConfig = stages?.decompose;
     const debateSession = _planDeps.createDebateSession({
@@ -70326,7 +70821,7 @@ async function planDecomposeCommand(workdir, config2, options) {
       config: config2,
       workdir,
       featureName: options.feature,
-      timeoutSeconds: config2?.execution?.sessionTimeoutSeconds
+      timeoutSeconds
     });
     const debateResult = await debateSession.run(prompt);
     if (debateResult.outcome !== "failed" && debateResult.output) {
@@ -70337,7 +70832,8 @@ async function planDecomposeCommand(workdir, config2, options) {
         workdir,
         sessionRole: "decompose",
         featureName: options.feature,
-        storyId: options.storyId
+        storyId: options.storyId,
+        timeoutMs
       });
       rawResponse = typeof completeResult === "string" ? completeResult : completeResult.output;
     }
@@ -70347,7 +70843,8 @@ async function planDecomposeCommand(workdir, config2, options) {
       workdir,
       sessionRole: "decompose",
       featureName: options.feature,
-      storyId: options.storyId
+      storyId: options.storyId,
+      timeoutMs
     });
     rawResponse = typeof completeResult === "string" ? completeResult : completeResult.output;
   }
@@ -72990,6 +73487,10 @@ init_crash_recovery();
 init_story_context();
 async function runCompletionPhase(options) {
   const logger = getSafeLogger();
+  logger?.debug("execution", "Completion phase started", {
+    acceptanceEnabled: options.config.acceptance?.enabled,
+    isComplete: isComplete(options.prd)
+  });
   if (options.config.acceptance.enabled && isComplete(options.prd)) {
     const { runAcceptanceLoop: runAcceptanceLoop2 } = await Promise.resolve().then(() => (init_acceptance_loop(), exports_acceptance_loop));
     const acceptanceResult = await runAcceptanceLoop2({
@@ -73057,9 +73558,12 @@ async function runCompletionPhase(options) {
       formatterMode: options.formatterMode
     });
   }
+  logger?.debug("execution", "Completion phase \u2014 stopping heartbeat and writing exit summary");
   stopHeartbeat();
   await writeExitSummary(options.logFilePath, options.totalCost, options.iterations, options.storiesCompleted, durationMs);
+  logger?.debug("execution", "Completion phase \u2014 auto-committing dirty files");
   await autoCommitIfDirty(options.workdir, "run.complete", "run-summary", options.feature);
+  logger?.debug("execution", "Completion phase done \u2014 returning to runner");
   return {
     durationMs,
     runCompletedAt
@@ -73197,6 +73701,12 @@ async function runExecutionPhase(options, prd, pluginRegistry) {
   storiesCompleted = unifiedResult.storiesCompleted;
   totalCost = unifiedResult.totalCost;
   allStoryMetrics.push(...unifiedResult.allStoryMetrics);
+  logger?.debug("execution", "Execution phase complete \u2014 handing off to completion phase", {
+    exitReason: unifiedResult.exitReason,
+    iterations,
+    storiesCompleted,
+    totalCost
+  });
   return { prd, iterations, storiesCompleted, totalCost, allStoryMetrics };
 }
 
@@ -73355,15 +73865,20 @@ async function run(options) {
       durationMs
     };
   } finally {
+    const logger2 = getSafeLogger();
+    logger2?.debug("execution", "Runner finally block \u2014 starting cleanup");
     stopHeartbeat();
     cleanupCrashHandlers();
+    logger2?.debug("execution", "Runner finally \u2014 sweeping ACP sessions");
     await sweepFeatureSessions(workdir, feature).catch(() => {});
+    logger2?.debug("execution", "Runner finally \u2014 ACP sweep done");
     let branch = "";
     try {
       const { stdout, exitCode } = await gitWithTimeout(["branch", "--show-current"], workdir);
       if (exitCode === 0)
         branch = stdout.trim();
     } catch {}
+    logger2?.debug("execution", "Runner finally \u2014 running cleanupRun");
     const { cleanupRun: cleanupRun2 } = await Promise.resolve().then(() => (init_run_cleanup(), exports_run_cleanup));
     await cleanupRun2({
       runId,
@@ -73379,6 +73894,7 @@ async function run(options) {
       branch,
       version: NAX_VERSION
     });
+    logger2?.debug("execution", "Runner finally \u2014 cleanupRun done, run() returning");
   }
 }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nathapp/nax",
-  "version": "0.56.5",
+  "version": "0.57.1-canary.1",
   "description": "AI Coding Agent Orchestrator — loops until done",
   "type": "module",
   "bin": {