@nathapp/nax 0.50.3 → 0.51.2

package/src/pipeline/subscribers/events-writer.ts

@@ -1,135 +0,0 @@
-/**
- * Events Writer Subscriber
- *
- * Appends one JSON line per pipeline lifecycle event to
- * ~/.nax/events/<project>/events.jsonl. Provides a machine-readable
- * signal that nax exited gracefully (run:completed → event=on-complete),
- * fixing watchdog false crash reports.
- *
- * Design:
- * - Best-effort: all writes are wrapped in try/catch; never throws or blocks
- * - Directory is created on first write via mkdir recursive
- * - Returns UnsubscribeFn matching wireHooks/wireReporters pattern
- */
-
-import { appendFile, mkdir } from "node:fs/promises";
-import { homedir } from "node:os";
-import { basename, join } from "node:path";
-import { getSafeLogger } from "../../logger";
-import type { PipelineEventBus } from "../event-bus";
-import type { UnsubscribeFn } from "./hooks";
-
-interface EventLine {
-  ts: string;
-  event: string;
-  runId: string;
-  feature: string;
-  project: string;
-  storyId?: string;
-  data?: object;
-}
-
-/**
- * Wire events file writer to the pipeline event bus.
- *
- * Listens to run:started, story:started, story:completed, story:failed,
- * run:completed, run:paused and appends one JSONL entry per event.
- *
- * @param bus     - The pipeline event bus
- * @param feature - Feature name
- * @param runId   - Current run ID
- * @param workdir - Working directory (project name derived via basename)
- * @returns Unsubscribe function
- */
-export function wireEventsWriter(
-  bus: PipelineEventBus,
-  feature: string,
-  runId: string,
-  workdir: string,
-): UnsubscribeFn {
-  const logger = getSafeLogger();
-  const project = basename(workdir);
-  const eventsDir = join(homedir(), ".nax", "events", project);
-  const eventsFile = join(eventsDir, "events.jsonl");
-  let dirReady = false;
-
-  const write = (line: EventLine): void => {
-    (async () => {
-      try {
-        if (!dirReady) {
-          await mkdir(eventsDir, { recursive: true });
-          dirReady = true;
-        }
-        await appendFile(eventsFile, `${JSON.stringify(line)}\n`);
-      } catch (err) {
-        logger?.warn("events-writer", "Failed to write event line (non-fatal)", {
-          event: line.event,
-          error: String(err),
-        });
-      }
-    })();
-  };
-
-  const unsubs: UnsubscribeFn[] = [];
-
-  unsubs.push(
-    bus.on("run:started", (_ev) => {
-      write({ ts: new Date().toISOString(), event: "run:started", runId, feature, project });
-    }),
-  );
-
-  unsubs.push(
-    bus.on("story:started", (ev) => {
-      write({ ts: new Date().toISOString(), event: "story:started", runId, feature, project, storyId: ev.storyId });
-    }),
-  );
-
-  unsubs.push(
-    bus.on("story:completed", (ev) => {
-      write({ ts: new Date().toISOString(), event: "story:completed", runId, feature, project, storyId: ev.storyId });
-    }),
-  );
-
-  unsubs.push(
-    bus.on("story:decomposed", (ev) => {
-      write({
-        ts: new Date().toISOString(),
-        event: "story:decomposed",
-        runId,
-        feature,
-        project,
-        storyId: ev.storyId,
-        data: { subStoryCount: ev.subStoryCount },
-      });
-    }),
-  );
-
-  unsubs.push(
-    bus.on("story:failed", (ev) => {
-      write({ ts: new Date().toISOString(), event: "story:failed", runId, feature, project, storyId: ev.storyId });
-    }),
-  );
-
-  unsubs.push(
-    bus.on("run:completed", (_ev) => {
-      write({ ts: new Date().toISOString(), event: "on-complete", runId, feature, project });
-    }),
-  );
-
-  unsubs.push(
-    bus.on("run:paused", (ev) => {
-      write({
-        ts: new Date().toISOString(),
-        event: "run:paused",
-        runId,
-        feature,
-        project,
-        ...(ev.storyId !== undefined && { storyId: ev.storyId }),
-      });
-    }),
-  );
-
-  return () => {
-    for (const u of unsubs) u();
-  };
-}

package/src/pipeline/subscribers/hooks.ts

@@ -1,179 +0,0 @@
-// RE-ARCH: keep
-/**
- * Hooks Subscriber (ADR-005, Phase 3 US-P3-001)
- *
- * Maps pipeline events to nax lifecycle hooks (on-start, on-story-start,
- * on-story-complete, on-story-fail, on-pause, on-complete).
- *
- * Design:
- * - All hook calls are fire-and-forget (matching prior fireHook behavior)
- * - Errors in hooks are logged, never rethrown
- * - Returns unsubscribe function for cleanup
- */
-
-import { hookCtx } from "../../execution/story-context";
-import { type LoadedHooksConfig, fireHook } from "../../hooks";
-import { getSafeLogger } from "../../logger";
-import type { PipelineEventBus } from "../event-bus";
-
-export type UnsubscribeFn = () => void;
-
-/**
- * Wire pipeline lifecycle hooks to the event bus.
- *
- * @param bus       - The pipeline event bus
- * @param hooks     - Loaded hooks config (from nax.config)
- * @param workdir   - Working directory for hook script execution
- * @param feature   - Feature name (for hook context payload)
- * @returns Unsubscribe function (call to remove all subscriptions)
- */
-export function wireHooks(
-  bus: PipelineEventBus,
-  hooks: LoadedHooksConfig,
-  workdir: string,
-  feature: string,
-): UnsubscribeFn {
-  const logger = getSafeLogger();
-
-  const safe = (name: string, fn: () => Promise<void>) => {
-    fn().catch((err) => logger?.warn("hooks-subscriber", `Hook "${name}" failed`, { error: String(err) }));
-  };
-
-  const unsubs: UnsubscribeFn[] = [];
-
-  // run:started → on-start
-  unsubs.push(
-    bus.on("run:started", (ev) => {
-      safe("on-start", () => fireHook(hooks, "on-start", hookCtx(feature, { status: "running" }), workdir));
-    }),
-  );
-
-  // story:started → on-story-start
-  unsubs.push(
-    bus.on("story:started", (ev) => {
-      safe("on-story-start", () =>
-        fireHook(
-          hooks,
-          "on-story-start",
-          hookCtx(feature, { storyId: ev.storyId, model: ev.modelTier, agent: ev.agent }),
-          workdir,
-        ),
-      );
-    }),
-  );
-
-  // story:completed → on-story-complete
-  unsubs.push(
-    bus.on("story:completed", (ev) => {
-      safe("on-story-complete", () =>
-        fireHook(
-          hooks,
-          "on-story-complete",
-          hookCtx(feature, { storyId: ev.storyId, status: "passed", cost: ev.cost }),
-          workdir,
-        ),
-      );
-    }),
-  );
-
-  // story:decomposed → on-story-complete (status: "decomposed")
-  unsubs.push(
-    bus.on("story:decomposed", (ev) => {
-      safe("on-story-complete (decomposed)", () =>
-        fireHook(
-          hooks,
-          "on-story-complete",
-          hookCtx(feature, { storyId: ev.storyId, status: "decomposed", subStoryCount: ev.subStoryCount }),
-          workdir,
-        ),
-      );
-    }),
-  );
-
-  // story:failed → on-story-fail
-  unsubs.push(
-    bus.on("story:failed", (ev) => {
-      safe("on-story-fail", () =>
-        fireHook(
-          hooks,
-          "on-story-fail",
-          hookCtx(feature, { storyId: ev.storyId, status: "failed", reason: ev.reason }),
-          workdir,
-        ),
-      );
-    }),
-  );
-
-  // story:paused → on-pause
-  unsubs.push(
-    bus.on("story:paused", (ev) => {
-      safe("on-pause (story)", () =>
-        fireHook(
-          hooks,
-          "on-pause",
-          hookCtx(feature, { storyId: ev.storyId, reason: ev.reason, cost: ev.cost }),
-          workdir,
-        ),
-      );
-    }),
-  );
-
-  // run:paused → on-pause
-  unsubs.push(
-    bus.on("run:paused", (ev) => {
-      safe("on-pause (run)", () =>
-        fireHook(
-          hooks,
-          "on-pause",
-          hookCtx(feature, { storyId: ev.storyId, reason: ev.reason, cost: ev.cost }),
-          workdir,
-        ),
-      );
-    }),
-  );
-
-  // run:completed → on-complete
-  unsubs.push(
-    bus.on("run:completed", (ev) => {
-      safe("on-complete", () =>
-        fireHook(hooks, "on-complete", hookCtx(feature, { status: "complete", cost: ev.totalCost ?? 0 }), workdir),
-      );
-    }),
-  );
-
-  // run:resumed → on-resume
-  unsubs.push(
-    bus.on("run:resumed", (ev) => {
-      safe("on-resume", () => fireHook(hooks, "on-resume", hookCtx(feature, { status: "running" }), workdir));
-    }),
-  );
-
-  // story:completed → on-session-end (passed)
-  unsubs.push(
-    bus.on("story:completed", (ev) => {
-      safe("on-session-end (completed)", () =>
-        fireHook(hooks, "on-session-end", hookCtx(feature, { storyId: ev.storyId, status: "passed" }), workdir),
-      );
-    }),
-  );
-
-  // story:failed → on-session-end (failed)
-  unsubs.push(
-    bus.on("story:failed", (ev) => {
-      safe("on-session-end (failed)", () =>
-        fireHook(hooks, "on-session-end", hookCtx(feature, { storyId: ev.storyId, status: "failed" }), workdir),
-      );
-    }),
-  );
-
-  // run:errored → on-error
-  unsubs.push(
-    bus.on("run:errored", (ev) => {
-      safe("on-error", () => fireHook(hooks, "on-error", hookCtx(feature, { reason: ev.reason }), workdir));
-    }),
-  );
-
-  return () => {
-    for (const u of unsubs) u();
-  };
-}

package/src/pipeline/subscribers/interaction.ts

@@ -1,103 +0,0 @@
-// RE-ARCH: keep
-/**
- * Interaction Subscriber (ADR-005, Phase 3 US-P3-003)
- *
- * Maps pipeline events to interaction trigger calls.
- * Currently handles:
- *   - human-review:requested → executeTrigger("human-review")
- *
- * Future triggers (story-ambiguity, merge-conflict, etc.) can be added
- * by subscribing to the appropriate events.
- *
- * Design:
- * - Interaction triggers MAY block (await user response) — uses emitAsync where needed
- * - Errors are caught and logged; never rethrown to avoid blocking the pipeline
- * - Returns unsubscribe function for cleanup
- */
-
-import type { NaxConfig } from "../../config";
-import type { InteractionChain } from "../../interaction/chain";
-import { executeTrigger, isTriggerEnabled } from "../../interaction/triggers";
-import { getSafeLogger } from "../../logger";
-import type { PipelineEventBus, StoryFailedEvent } from "../event-bus";
-import type { UnsubscribeFn } from "./hooks";
-
-/**
- * Wire interaction triggers to the event bus.
- *
- * @param bus              - The pipeline event bus
- * @param interactionChain - The active interaction chain (may be null)
- * @param config           - Nax config (for isTriggerEnabled checks)
- * @returns Unsubscribe function
- */
-export function wireInteraction(
-  bus: PipelineEventBus,
-  interactionChain: InteractionChain | null | undefined,
-  config: NaxConfig,
-): UnsubscribeFn {
-  const logger = getSafeLogger();
-  const unsubs: UnsubscribeFn[] = [];
-
-  // human-review:requested → executeTrigger("human-review")
-  if (interactionChain && isTriggerEnabled("human-review", config)) {
-    unsubs.push(
-      bus.on("human-review:requested", (ev) => {
-        executeTrigger(
-          "human-review",
-          {
-            featureName: ev.feature ?? "",
-            storyId: ev.storyId,
-            iteration: ev.attempts ?? 0,
-            reason: ev.reason,
-          },
-          config,
-          interactionChain,
-        ).catch((err) => {
-          logger?.warn("interaction-subscriber", "human-review trigger failed", {
-            storyId: ev.storyId,
-            error: String(err),
-          });
-        });
-      }),
-    );
-  }
-
-  // story:failed (countsTowardEscalation=true) → executeTrigger("max-retries")
-  if (interactionChain && isTriggerEnabled("max-retries", config)) {
-    unsubs.push(
-      bus.on("story:failed", (ev: StoryFailedEvent) => {
-        if (!ev.countsTowardEscalation) {
-          return;
-        }
-
-        executeTrigger(
-          "max-retries",
-          {
-            featureName: ev.feature ?? "",
-            storyId: ev.storyId,
-            iteration: ev.attempts ?? 0,
-          },
-          config,
-          interactionChain,
-        )
-          .then((response) => {
-            if (response.action === "abort") {
-              logger?.warn("interaction-subscriber", "max-retries abort requested", {
-                storyId: ev.storyId,
-              });
-            }
-          })
-          .catch((err) => {
-            logger?.warn("interaction-subscriber", "max-retries trigger failed", {
-              storyId: ev.storyId,
-              error: String(err),
-            });
-          });
-      }),
-    );
-  }
-
-  return () => {
-    for (const u of unsubs) u();
-  };
-}

package/src/pipeline/subscribers/registry.ts

@@ -1,73 +0,0 @@
-/**
- * Registry Writer Subscriber
- *
- * Creates ~/.nax/runs/<project>-<feature>-<runId>/meta.json on run:started.
- * Provides a persistent record of each run with paths for status and events.
- *
- * Design:
- * - Best-effort: all writes wrapped in try/catch; never throws or blocks
- * - Directory created on first write via mkdir recursive
- * - Written once on run:started, never updated
- * - Returns UnsubscribeFn matching wireHooks/wireEventsWriter pattern
- */
-
-import { mkdir, writeFile } from "node:fs/promises";
-import { homedir } from "node:os";
-import { basename, join } from "node:path";
-import { getSafeLogger } from "../../logger";
-import type { PipelineEventBus } from "../event-bus";
-import type { UnsubscribeFn } from "./hooks";
-
-export interface MetaJson {
-  runId: string;
-  project: string;
-  feature: string;
-  workdir: string;
-  statusPath: string;
-  eventsDir: string;
-  registeredAt: string;
-}
-
-/**
- * Wire registry writer to the pipeline event bus.
- *
- * Listens to run:started and writes meta.json to
- * ~/.nax/runs/<project>-<feature>-<runId>/meta.json.
- *
- * @param bus     - The pipeline event bus
- * @param feature - Feature name
- * @param runId   - Current run ID
- * @param workdir - Working directory (project name derived via basename)
- * @returns Unsubscribe function
- */
-export function wireRegistry(bus: PipelineEventBus, feature: string, runId: string, workdir: string): UnsubscribeFn {
-  const logger = getSafeLogger();
-  const project = basename(workdir);
-  const runDir = join(homedir(), ".nax", "runs", `${project}-${feature}-${runId}`);
-  const metaFile = join(runDir, "meta.json");
-
-  const unsub = bus.on("run:started", (_ev) => {
-    (async () => {
-      try {
-        await mkdir(runDir, { recursive: true });
-        const meta: MetaJson = {
-          runId,
-          project,
-          feature,
-          workdir,
-          statusPath: join(workdir, "nax", "features", feature, "status.json"),
-          eventsDir: join(workdir, "nax", "features", feature, "runs"),
-          registeredAt: new Date().toISOString(),
-        };
-        await writeFile(metaFile, JSON.stringify(meta, null, 2));
-      } catch (err) {
-        logger?.warn("registry-writer", "Failed to write meta.json (non-fatal)", {
-          path: metaFile,
-          error: String(err),
-        });
-      }
-    })();
-  });
-
-  return unsub;
-}

package/src/pipeline/subscribers/reporters.ts

@@ -1,174 +0,0 @@
-// RE-ARCH: keep
-/**
- * Reporters Subscriber (ADR-005, Phase 3 US-P3-002)
- *
- * Maps pipeline events to IReporter plugin methods
- * (onRunStart, onStoryComplete, onRunEnd).
- *
- * Design:
- * - Each reporter call is fire-and-forget
- * - Errors in individual reporters are caught and logged
- * - Returns unsubscribe function for cleanup
- */
-
-import { getSafeLogger } from "../../logger";
-import type { PluginRegistry } from "../../plugins";
-import type { PipelineEventBus } from "../event-bus";
-import type { UnsubscribeFn } from "./hooks";
-
-/**
- * Wire reporter plugin lifecycle events to the event bus.
- *
- * @param bus            - The pipeline event bus
- * @param pluginRegistry - Plugin registry exposing getReporters()
- * @param runId          - Current run ID (for reporter events)
- * @param startTime      - Run start timestamp in ms (for duration calculation)
- * @returns Unsubscribe function
- */
-export function wireReporters(
-  bus: PipelineEventBus,
-  pluginRegistry: PluginRegistry,
-  runId: string,
-  startTime: number,
-): UnsubscribeFn {
-  const logger = getSafeLogger();
-
-  const safe = (name: string, fn: () => Promise<void>) => {
-    fn().catch((err) => logger?.warn("reporters-subscriber", `Reporter "${name}" error`, { error: String(err) }));
-  };
-
-  const unsubs: UnsubscribeFn[] = [];
-
-  // run:started → reporter.onRunStart
-  unsubs.push(
-    bus.on("run:started", (ev) => {
-      safe("onRunStart", async () => {
-        const reporters = pluginRegistry.getReporters();
-        for (const r of reporters) {
-          if (r.onRunStart) {
-            try {
-              await r.onRunStart({
-                runId,
-                feature: ev.feature,
-                totalStories: ev.totalStories,
-                startTime: new Date(startTime).toISOString(),
-              });
-            } catch (err) {
-              logger?.warn("plugins", `Reporter '${r.name}' onRunStart failed`, { error: err });
-            }
-          }
-        }
-      });
-    }),
-  );
-
-  // story:completed → reporter.onStoryComplete(status: "completed")
-  unsubs.push(
-    bus.on("story:completed", (ev) => {
-      safe("onStoryComplete(completed)", async () => {
-        const reporters = pluginRegistry.getReporters();
-        for (const r of reporters) {
-          if (r.onStoryComplete) {
-            try {
-              await r.onStoryComplete({
-                runId,
-                storyId: ev.storyId,
-                status: "completed",
-                runElapsedMs: ev.runElapsedMs,
-                cost: ev.cost ?? 0,
-                tier: ev.modelTier ?? "balanced",
-                testStrategy: ev.testStrategy ?? "test-after",
-              });
-            } catch (err) {
-              logger?.warn("plugins", `Reporter '${r.name}' onStoryComplete failed`, { error: err });
-            }
-          }
-        }
-      });
-    }),
-  );
-
-  // story:failed → reporter.onStoryComplete(status: "failed")
-  unsubs.push(
-    bus.on("story:failed", (ev) => {
-      safe("onStoryComplete(failed)", async () => {
-        const reporters = pluginRegistry.getReporters();
-        for (const r of reporters) {
-          if (r.onStoryComplete) {
-            try {
-              await r.onStoryComplete({
-                runId,
-                storyId: ev.storyId,
-                status: "failed",
-                runElapsedMs: Date.now() - startTime,
-                cost: 0,
-                tier: "balanced",
-                testStrategy: "test-after",
-              });
-            } catch (err) {
-              logger?.warn("plugins", `Reporter '${r.name}' onStoryComplete failed`, { error: err });
-            }
-          }
-        }
-      });
-    }),
-  );
-
-  // story:paused → reporter.onStoryComplete(status: "paused")
-  unsubs.push(
-    bus.on("story:paused", (ev) => {
-      safe("onStoryComplete(paused)", async () => {
-        const reporters = pluginRegistry.getReporters();
-        for (const r of reporters) {
-          if (r.onStoryComplete) {
-            try {
-              await r.onStoryComplete({
-                runId,
-                storyId: ev.storyId,
-                status: "paused",
-                runElapsedMs: Date.now() - startTime,
-                cost: 0,
-                tier: "balanced",
-                testStrategy: "test-after",
-              });
-            } catch (err) {
-              logger?.warn("plugins", `Reporter '${r.name}' onStoryComplete failed`, { error: err });
-            }
-          }
-        }
-      });
-    }),
-  );
-
-  // run:completed → reporter.onRunEnd
-  unsubs.push(
-    bus.on("run:completed", (ev) => {
-      safe("onRunEnd", async () => {
-        const reporters = pluginRegistry.getReporters();
-        for (const r of reporters) {
-          if (r.onRunEnd) {
-            try {
-              await r.onRunEnd({
-                runId,
-                totalDurationMs: Date.now() - startTime,
-                totalCost: ev.totalCost ?? 0,
-                storySummary: {
-                  completed: ev.passedStories,
-                  failed: ev.failedStories,
-                  skipped: 0,
-                  paused: 0,
-                },
-              });
-            } catch (err) {
-              logger?.warn("plugins", `Reporter '${r.name}' onRunEnd failed`, { error: err });
-            }
-          }
-        }
-      });
-    }),
-  );
-
-  return () => {
-    for (const u of unsubs) u();
-  };
-}