@nathapp/nax 0.50.2 → 0.51.0

package/src/execution/lifecycle/run-regression.ts

@@ -1,305 +0,0 @@
-/**
- * Deferred Regression Gate
- *
- * Runs full test suite once after all stories complete, then attempts
- * targeted rectification per responsible story. Handles edge cases:
- * - Partial completion: only check stories marked passed
- * - Overlapping file changes: try last modified story first
- * - Unmapped tests: warn and mark all passed stories for re-verification
- */
-
-import type { NaxConfig } from "../../config";
-import { getSafeLogger } from "../../logger";
-import type { AgentGetFn } from "../../pipeline/types";
-import type { PRD, UserStory } from "../../prd";
-import { countStories } from "../../prd";
-import { hasCommitsForStory } from "../../utils/git";
-import { parseBunTestOutput } from "../../verification";
-import { runRectificationLoop } from "../../verification/rectification-loop";
-import { fullSuite } from "../../verification/runners";
-import { reverseMapTestToSource } from "../../verification/smart-runner";
-
-/**
- * Injectable dependencies for testing (avoids mock.module() which leaks in Bun 1.x).
- * @internal - test use only.
- */
-export const _regressionDeps = {
-  runVerification: fullSuite,
-  runRectificationLoop,
-  parseBunTestOutput,
-  reverseMapTestToSource,
-};
-
-export interface DeferredRegressionOptions {
-  config: NaxConfig;
-  prd: PRD;
-  workdir: string;
-  /** Protocol-aware agent resolver (ACP wiring). Falls back to static getAgent when absent. */
-  agentGetFn?: AgentGetFn;
-}
-
-export interface DeferredRegressionResult {
-  success: boolean;
-  failedTests: number;
-  passedTests: number;
-  rectificationAttempts: number;
-  affectedStories: string[];
-}
-
-/**
- * Map a test file to the story responsible for it via git log.
- *
- * Searches recent commits for story IDs in the format US-NNN.
- * Returns the first matching story ID, or undefined if not found.
- */
-async function findResponsibleStory(
-  testFile: string,
-  workdir: string,
-  passedStories: UserStory[],
-): Promise<UserStory | undefined> {
-  const logger = getSafeLogger();
-
-  // Try each passed story in reverse order (most recent first)
-  for (let i = passedStories.length - 1; i >= 0; i--) {
-    const story = passedStories[i];
-    const hasCommits = await hasCommitsForStory(workdir, story.id, 50);
-    if (hasCommits) {
-      logger?.info("regression", `Mapped test to story ${story.id}`, { testFile });
-      return story;
-    }
-  }
-
-  return undefined;
-}
-
-/**
- * Run deferred regression gate after all stories complete.
- *
- * Steps:
- * 1. Run full test suite
- * 2. If failures, reverse-map test files to source files to stories
- * 3. For each affected story, attempt targeted rectification
- * 4. Re-run full suite to confirm fixes
- * 5. Return results with affected story list
- */
-export async function runDeferredRegression(options: DeferredRegressionOptions): Promise<DeferredRegressionResult> {
-  const logger = getSafeLogger();
-  const { config, prd, workdir, agentGetFn } = options;
-
-  // Check if regression gate is deferred
-  const regressionMode = config.execution.regressionGate?.mode ?? "deferred";
-  if (regressionMode === "disabled") {
-    logger?.info("regression", "Deferred regression gate disabled");
-    return {
-      success: true,
-      failedTests: 0,
-      passedTests: 0,
-      rectificationAttempts: 0,
-      affectedStories: [],
-    };
-  }
-
-  if (regressionMode !== "deferred") {
-    logger?.info("regression", "Regression gate mode is not deferred, skipping");
-    return {
-      success: true,
-      failedTests: 0,
-      passedTests: 0,
-      rectificationAttempts: 0,
-      affectedStories: [],
-    };
-  }
-
-  const testCommand = config.quality.commands.test ?? "bun test";
-  const timeoutSeconds = config.execution.regressionGate?.timeoutSeconds ?? 120;
-  const maxRectificationAttempts = config.execution.regressionGate?.maxRectificationAttempts ?? 2;
-
-  // Only check stories that have been marked as passed
-  const counts = countStories(prd);
-  const passedStories = prd.userStories.filter((s) => s.status === "passed");
-
-  if (passedStories.length === 0) {
-    logger?.info("regression", "No passed stories to verify (partial completion)");
-    return {
-      success: true,
-      failedTests: 0,
-      passedTests: 0,
-      rectificationAttempts: 0,
-      affectedStories: [],
-    };
-  }
-
-  logger?.info("regression", "Running deferred full-suite regression gate", {
-    totalStories: counts.total,
-    passedStories: passedStories.length,
-  });
-
-  // Step 1: Run full test suite
-  const fullSuiteResult = await _regressionDeps.runVerification({
-    workdir: workdir,
-    command: testCommand,
-    timeoutSeconds,
-    forceExit: config.quality.forceExit,
-    detectOpenHandles: config.quality.detectOpenHandles,
-    detectOpenHandlesRetries: config.quality.detectOpenHandlesRetries,
-    timeoutRetryCount: 0,
-    gracePeriodMs: config.quality.gracePeriodMs,
-    drainTimeoutMs: config.quality.drainTimeoutMs,
-    shell: config.quality.shell,
-    stripEnvVars: config.quality.stripEnvVars,
-  });
-
-  if (fullSuiteResult.success) {
-    logger?.info("regression", "Full suite passed");
-    return {
-      success: true,
-      failedTests: 0,
-      passedTests: fullSuiteResult.passCount ?? 0,
-      rectificationAttempts: 0,
-      affectedStories: [],
-    };
-  }
-
-  // Handle timeout
-  const acceptOnTimeout = config.execution.regressionGate?.acceptOnTimeout ?? true;
-  if (fullSuiteResult.status === "TIMEOUT" && acceptOnTimeout) {
-    logger?.warn("regression", "Full-suite regression gate timed out (accepted as pass)");
-    return {
-      success: true,
-      failedTests: 0,
-      passedTests: 0,
-      rectificationAttempts: 0,
-      affectedStories: [],
-    };
-  }
-
-  if (!fullSuiteResult.output) {
-    logger?.error("regression", "Full suite failed with no output");
-    return {
-      success: false,
-      failedTests: fullSuiteResult.failCount ?? 0,
-      passedTests: fullSuiteResult.passCount ?? 0,
-      rectificationAttempts: 0,
-      affectedStories: [],
-    };
-  }
-
-  // Step 2: Parse failures and map to source files to stories
-  const testSummary = _regressionDeps.parseBunTestOutput(fullSuiteResult.output);
-  const affectedStories = new Set<string>();
-  const affectedStoriesObjs = new Map<string, UserStory>();
-
-  logger?.warn("regression", "Regression detected", {
-    failedTests: testSummary.failed,
-    passedTests: testSummary.passed,
-  });
-
-  // Extract test file paths from failures
-  const testFilesInFailures = new Set<string>();
-  for (const failure of testSummary.failures) {
-    if (failure.file) {
-      testFilesInFailures.add(failure.file);
-    }
-  }
-
-  if (testFilesInFailures.size === 0) {
-    logger?.warn("regression", "No test files found in failures (unmapped)");
-    // Mark all passed stories for re-verification
-    for (const story of passedStories) {
-      affectedStories.add(story.id);
-      affectedStoriesObjs.set(story.id, story);
-    }
-  } else {
-    // Map test files to source files to stories
-    const testFilesArray = Array.from(testFilesInFailures);
-    const sourceFilesArray = _regressionDeps.reverseMapTestToSource(testFilesArray, workdir);
-
-    logger?.info("regression", "Mapped test files to source files", {
-      testFiles: testFilesArray.length,
-      sourceFiles: sourceFilesArray.length,
-    });
-
-    for (const testFile of testFilesArray) {
-      const responsibleStory = await findResponsibleStory(testFile, workdir, passedStories);
-      if (responsibleStory) {
-        affectedStories.add(responsibleStory.id);
-        affectedStoriesObjs.set(responsibleStory.id, responsibleStory);
-      } else {
-        logger?.warn("regression", "Could not map test file to story", { testFile });
-      }
-    }
-  }
-
-  if (affectedStories.size === 0) {
-    logger?.warn("regression", "No stories could be mapped to failures");
-    return {
-      success: false,
-      failedTests: testSummary.failed,
-      passedTests: testSummary.passed,
-      rectificationAttempts: 0,
-      affectedStories: Array.from(affectedStories),
-    };
-  }
-
-  // Step 3: Attempt rectification per story
-  let rectificationAttempts = 0;
-  const affectedStoriesList = Array.from(affectedStoriesObjs.values());
-
-  for (const story of affectedStoriesList) {
-    for (let attempt = 0; attempt < maxRectificationAttempts; attempt++) {
-      rectificationAttempts++;
-
-      logger?.info("regression", `Rectifying story ${story.id} (attempt ${attempt + 1}/${maxRectificationAttempts})`);
-
-      const fixed = await _regressionDeps.runRectificationLoop({
-        config,
-        workdir,
-        story,
-        testCommand,
-        timeoutSeconds,
-        testOutput: fullSuiteResult.output,
-        promptPrefix: `# DEFERRED REGRESSION: Full-Suite Failures\n\nYour story ${story.id} broke tests in the full suite. Fix these regressions.`,
-        agentGetFn,
-      });
-
-      if (fixed) {
-        logger?.info("regression", `Story ${story.id} rectified successfully`);
-        break; // Move to next story
-      }
-    }
-  }
-
-  // Step 4: Re-run full suite to confirm
-  logger?.info("regression", "Re-running full suite after rectification");
-  const retryResult = await _regressionDeps.runVerification({
-    workdir: workdir,
-    command: testCommand,
-    timeoutSeconds,
-    forceExit: config.quality.forceExit,
-    detectOpenHandles: config.quality.detectOpenHandles,
-    detectOpenHandlesRetries: config.quality.detectOpenHandlesRetries,
-    timeoutRetryCount: 0,
-    gracePeriodMs: config.quality.gracePeriodMs,
-    drainTimeoutMs: config.quality.drainTimeoutMs,
-    shell: config.quality.shell,
-    stripEnvVars: config.quality.stripEnvVars,
-  });
-
-  const success = retryResult.success || (retryResult.status === "TIMEOUT" && acceptOnTimeout);
-
-  if (success) {
-    logger?.info("regression", "Deferred regression gate passed after rectification");
-  } else {
-    logger?.warn("regression", "Deferred regression gate still failing after rectification", {
-      remainingFailures: retryResult.failCount,
-    });
-  }
-
-  return {
-    success,
-    failedTests: retryResult.failCount ?? 0,
-    passedTests: retryResult.passCount ?? 0,
-    rectificationAttempts,
-    affectedStories: Array.from(affectedStories),
-  };
-}

package/src/execution/lifecycle/run-setup.ts

@@ -1,240 +0,0 @@
-/**
- * Run Setup — Initial Setup Logic
- *
- * Handles the initial setup phase before the main execution loop:
- * - Status writer initialization
- * - PID registry cleanup
- * - Crash handler installation
- * - Lock acquisition
- * - Plugin loading
- * - PRD loading
- * - Precheck validation
- * - Run initialization
- */
-
-import * as os from "node:os";
-import path from "node:path";
-import type { NaxConfig } from "../../config";
-import { LockAcquisitionError } from "../../errors";
-import type { LoadedHooksConfig } from "../../hooks";
-import { fireHook } from "../../hooks";
-import type { InteractionChain } from "../../interaction";
-import { initInteractionChain } from "../../interaction";
-import { getSafeLogger } from "../../logger";
-import { pipelineEventBus } from "../../pipeline/event-bus";
-import type { AgentGetFn } from "../../pipeline/types";
-import { loadPlugins } from "../../plugins/loader";
-import type { PluginRegistry } from "../../plugins/registry";
-import type { PRD } from "../../prd";
-import { loadPRD } from "../../prd";
-import { NAX_BUILD_INFO, NAX_COMMIT, NAX_VERSION } from "../../version";
-import { installCrashHandlers } from "../crash-recovery";
-import { acquireLock, hookCtx, releaseLock } from "../helpers";
-import { PidRegistry } from "../pid-registry";
-import { StatusWriter } from "../status-writer";
-
-export interface RunSetupOptions {
-  prdPath: string;
-  workdir: string;
-  config: NaxConfig;
-  hooks: LoadedHooksConfig;
-  feature: string;
-  featureDir?: string;
-  dryRun: boolean;
-  statusFile: string;
-  logFilePath?: string;
-  runId: string;
-  startedAt: string;
-  startTime: number;
-  skipPrecheck: boolean;
-  headless: boolean;
-  formatterMode: "quiet" | "normal" | "verbose" | "json";
-  getTotalCost: () => number;
-  getIterations: () => number;
-  // BUG-017: Additional getters for run.complete event on SIGTERM
-  getStoriesCompleted: () => number;
-  getTotalStories: () => number;
-  /** Protocol-aware agent resolver — passed from runner.ts registry */
-  agentGetFn?: AgentGetFn;
-}
-
-export interface RunSetupResult {
-  statusWriter: StatusWriter;
-  pidRegistry: PidRegistry;
-  cleanupCrashHandlers: () => void;
-  pluginRegistry: PluginRegistry;
-  prd: PRD;
-  storyCounts: {
-    total: number;
-    passed: number;
-    pending: number;
-    failed: number;
-  };
-  interactionChain: InteractionChain | null;
-}
-
-/**
- * Execute initial setup phase
- */
-export async function setupRun(options: RunSetupOptions): Promise<RunSetupResult> {
-  const logger = getSafeLogger();
-  const {
-    prdPath,
-    workdir,
-    config,
-    hooks,
-    feature,
-    dryRun,
-    statusFile,
-    logFilePath,
-    runId,
-    startedAt,
-    startTime,
-    skipPrecheck,
-    headless,
-    formatterMode,
-    getTotalCost,
-    getIterations,
-  } = options;
-
-  // ── Status writer (encapsulates status file state and write logic) ───────
-  const statusWriter = new StatusWriter(statusFile, config, {
-    runId,
-    feature,
-    startedAt,
-    dryRun,
-    startTimeMs: startTime,
-    pid: process.pid,
-  });
-
-  // ── PID registry for orphan process cleanup (BUG-002) ───────
-  const pidRegistry = new PidRegistry(workdir);
-
-  // Cleanup stale PIDs from previous crashed runs
-  await pidRegistry.cleanupStale();
-
-  // Install crash handlers for signal recovery (US-007, BUG-1+MEM-1 fix: pass getters, cleanup in finally)
-  const cleanupCrashHandlers = installCrashHandlers({
-    statusWriter,
-    getTotalCost,
-    getIterations,
-    jsonlFilePath: logFilePath,
-    pidRegistry,
-    // BUG-017: Pass context for run.complete event on SIGTERM
-    runId: options.runId,
-    feature: options.feature,
-    featureDir: options.featureDir,
-    getStartTime: () => options.startTime,
-    getTotalStories: options.getTotalStories,
-    getStoriesCompleted: options.getStoriesCompleted,
-    emitError: (reason: string) => {
-      pipelineEventBus.emit({ type: "run:errored", reason, feature: options.feature });
-    },
-    // Close open ACP sessions on SIGINT/SIGTERM so acpx processes don't stay alive
-    onShutdown: async () => {
-      const { sweepFeatureSessions } = await import("../../agents/acp/adapter");
-      await sweepFeatureSessions(workdir, feature).catch(() => {});
-    },
-  });
-
-  // Load PRD (before try block so it's accessible in finally for onRunEnd)
-  let prd = await loadPRD(prdPath);
-
-  // Initialize interaction chain (US-008) — do this BEFORE precheck so story size prompts can use it
-  const interactionChain = await initInteractionChain(config, headless);
-
-  // ── Prime StatusWriter with PRD so precheck-failed can be recorded ─────────
-  statusWriter.setPrd(prd);
-
-  // ── Run precheck validations (unless --skip-precheck) ──────────────────────
-  if (!skipPrecheck) {
-    const { runPrecheckValidation } = await import("./precheck-runner");
-    await runPrecheckValidation({
-      config,
-      prd,
-      workdir,
-      logFilePath,
-      statusWriter,
-      headless,
-      formatterMode,
-      interactionChain,
-      featureName: feature,
-    });
-  } else {
-    logger?.warn("precheck", "Precheck validations skipped (--skip-precheck)");
-  }
-
-  // Sweep stale ACP sessions from previous crashed runs (safety net)
-  const { sweepStaleFeatureSessions } = await import("../../agents/acp/adapter");
-  await sweepStaleFeatureSessions(workdir, feature).catch(() => {});
-
-  // Acquire lock to prevent concurrent execution
-  const lockAcquired = await acquireLock(workdir);
-  if (!lockAcquired) {
-    logger?.error("execution", "Another nax process is already running in this directory");
-    logger?.error("execution", "If you believe this is an error, remove nax.lock manually");
-    throw new LockAcquisitionError(workdir);
-  }
-
-  // Everything after lock acquisition is wrapped in try-catch to ensure
-  // the lock is released if any setup step fails (FIX-H16)
-  try {
-    // Load plugins (before try block so it's accessible in finally)
-    const globalPluginsDir = path.join(os.homedir(), ".nax", "plugins");
-    const projectPluginsDir = path.join(workdir, "nax", "plugins");
-    const configPlugins = config.plugins || [];
-    const pluginRegistry = await loadPlugins(
-      globalPluginsDir,
-      projectPluginsDir,
-      configPlugins,
-      workdir,
-      config.disabledPlugins,
-    );
-
-    // Log plugins loaded
-    logger?.info("plugins", `Loaded ${pluginRegistry.plugins.length} plugins`, {
-      plugins: pluginRegistry.plugins.map((p) => ({ name: p.name, version: p.version, provides: p.provides })),
-    });
-
-    // Log run start
-    const routingMode = config.routing.llm?.mode ?? "hybrid";
-    logger?.info("run.start", `Starting feature: ${feature} [nax ${NAX_BUILD_INFO}]`, {
-      runId,
-      feature,
-      workdir,
-      dryRun,
-      routingMode,
-      naxVersion: NAX_VERSION,
-      naxCommit: NAX_COMMIT,
-    });
-
-    // Fire on-start hook
-    await fireHook(hooks, "on-start", hookCtx(feature), workdir);
-
-    // Initialize run: check agent, reconcile state, validate limits
-    const { initializeRun } = await import("./run-initialization");
-    const initResult = await initializeRun({
-      config,
-      prdPath,
-      workdir,
-      dryRun,
-      agentGetFn: options.agentGetFn,
-    });
-    prd = initResult.prd;
-    const counts = initResult.storyCounts;
-
-    return {
-      statusWriter,
-      pidRegistry,
-      cleanupCrashHandlers,
-      pluginRegistry,
-      prd,
-      storyCounts: counts,
-      interactionChain,
-    };
-  } catch (error) {
-    // Release lock before re-throwing so the directory isn't permanently locked
-    await releaseLock(workdir);
-    throw error;
-  }
-}

package/src/execution/lifecycle/story-size-prompts.ts

@@ -1,123 +0,0 @@
-/**
- * Story Size Prompts (v0.16.0)
- *
- * Post-precheck interaction prompts for flagged stories.
- * Asks user to confirm (Approve/Skip/Abort) for each large story.
- * Integrates with interaction chain.
- */
-
-import type { InteractionChain } from "../../interaction/chain";
-import type { InteractionResponse } from "../../interaction/types";
-import { getSafeLogger } from "../../logger";
-import type { PRD } from "../../prd/types";
-import type { FlaggedStory } from "../../precheck/story-size-gate";
-
-/** Prompt result for a single story */
-export interface StoryPromptResult {
-  storyId: string;
-  action: "approve" | "skip" | "abort";
-}
-
-/** Summary of story size prompt results */
-export interface StorySizePromptSummary {
-  approved: string[];
-  skipped: string[];
-  aborted: boolean;
-}
-
-/**
- * Prompt user for each flagged story
- *
- * @param flaggedStories - Stories that exceeded size thresholds
- * @param prd - PRD instance (mutated: skips stories if user selects Skip)
- * @param chain - Interaction chain
- * @param featureName - Feature name for context
- * @returns Summary of user decisions
- */
-export async function promptForFlaggedStories(
-  flaggedStories: FlaggedStory[],
-  prd: PRD,
-  chain: InteractionChain,
-  featureName: string,
-): Promise<StorySizePromptSummary> {
-  const logger = getSafeLogger();
-  const summary: StorySizePromptSummary = {
-    approved: [],
-    skipped: [],
-    aborted: false,
-  };
-
-  for (const flagged of flaggedStories) {
-    logger?.info("precheck", `Story size gate: prompting for ${flagged.storyId}`, {
-      recommendation: flagged.recommendation,
-    });
-
-    const story = prd.userStories.find((s) => s.id === flagged.storyId);
-    if (!story) {
-      logger?.warn("precheck", `Story ${flagged.storyId} not found in PRD, skipping prompt`);
-      continue;
-    }
-
-    // Build detail message with signal breakdown
-    const signalDetails = [
-      `- Acceptance Criteria: ${flagged.signals.acCount.value} (threshold: ${flagged.signals.acCount.threshold}) ${flagged.signals.acCount.flagged ? "⚠" : "✓"}`,
-      `- Description Length: ${flagged.signals.descriptionLength.value} chars (threshold: ${flagged.signals.descriptionLength.threshold}) ${flagged.signals.descriptionLength.flagged ? "⚠" : "✓"}`,
-      `- Bullet Points: ${flagged.signals.bulletPoints.value} (threshold: ${flagged.signals.bulletPoints.threshold}) ${flagged.signals.bulletPoints.flagged ? "⚠" : "✓"}`,
-    ];
-
-    const detail = `${flagged.recommendation}\n\nSignal breakdown:\n${signalDetails.join("\n")}\n\nStory: ${story.title}`;
-
-    // Send interaction request
-    const requestId = `ix-${flagged.storyId}-size-gate`;
-    const response: InteractionResponse = await chain.prompt({
-      id: requestId,
-      type: "choose",
-      featureName,
-      storyId: flagged.storyId,
-      stage: "pre-flight",
-      summary: `Story ${flagged.storyId} exceeds size thresholds — proceed?`,
-      detail,
-      options: [
-        { key: "approve", label: "Approve", description: "Continue with this story despite size warnings" },
-        { key: "skip", label: "Skip", description: "Skip this story and continue with others" },
-        { key: "abort", label: "Abort", description: "Abort the entire run" },
-      ],
-      timeout: 600000, // 10 minutes
-      fallback: "escalate",
-      createdAt: Date.now(),
-    });
-
-    // Process response
-    switch (response.action) {
-      case "approve": {
-        summary.approved.push(flagged.storyId);
-        logger?.info("precheck", `User approved ${flagged.storyId} despite size warnings`);
-        break;
-      }
-      case "skip": {
-        summary.skipped.push(flagged.storyId);
-        story.status = "skipped";
-        logger?.info("precheck", `User skipped ${flagged.storyId} due to size warnings`);
-        break;
-      }
-      case "abort": {
-        summary.aborted = true;
-        logger?.warn("precheck", `User aborted run due to ${flagged.storyId} size warnings`);
-        throw new Error(`Run aborted by user: story ${flagged.storyId} exceeds size thresholds`);
-      }
-      default: {
-        logger?.warn("precheck", `Unknown action ${response.action} for ${flagged.storyId}, aborting`);
-        summary.aborted = true;
-        throw new Error(`Run aborted: unknown action ${response.action}`);
-      }
-    }
-  }
-
-  logger?.info("precheck", "Story size gate prompts complete", {
-    approved: summary.approved.length,
-    skipped: summary.skipped.length,
-    aborted: summary.aborted,
-  });
-
-  return summary;
-}