@nathapp/nax 0.45.0 → 0.46.0

package/src/pipeline/stages/acceptance.ts

@@ -27,6 +27,7 @@
 import path from "node:path";
 import { getLogger } from "../../logger";
 import { countStories } from "../../prd";
+import { logTestOutput } from "../../utils/log-test-output";
 import type { PipelineContext, PipelineStage, StageResult } from "../types";
 
 /**
@@ -163,10 +164,8 @@ export const acceptanceStage: PipelineStage = {
 
     // Non-zero exit but no AC failures parsed at all — test crashed (syntax error, import failure, etc.)
     if (failedACs.length === 0 && exitCode !== 0) {
-      logger.error("acceptance", "Tests errored with no AC failures parsed", {
-        exitCode,
-        output,
-      });
+      logger.error("acceptance", "Tests errored with no AC failures parsed", { exitCode });
+      logTestOutput(logger, "acceptance", output);
 
       ctx.acceptanceFailures = {
         failedACs: ["AC-ERROR"],
@@ -190,10 +189,8 @@ export const acceptanceStage: PipelineStage = {
         });
       }
 
-      logger.error("acceptance", "Acceptance tests failed", {
-        failedACs: actualFailures,
-        output,
-      });
+      logger.error("acceptance", "Acceptance tests failed", { failedACs: actualFailures });
+      logTestOutput(logger, "acceptance", output);
 
       // Store failed ACs and test output in context for fix generation
       ctx.acceptanceFailures = {

package/src/pipeline/stages/regression.ts

@@ -14,6 +14,7 @@
  */
 
 import { getLogger } from "../../logger";
+import { logTestOutput } from "../../utils/log-test-output";
 import { verificationOrchestrator } from "../../verification/orchestrator";
 import type { VerifyContext } from "../../verification/orchestrator-types";
 import { pipelineEventBus } from "../event-bus";
@@ -71,6 +72,7 @@ export const regressionStage: PipelineStage = {
       storyId: ctx.story.id,
       failCount: result.failCount,
     });
+    logTestOutput(logger, "regression", result.rawOutput, { storyId: ctx.story.id });
 
     pipelineEventBus.emit({
       type: "regression:detected",

package/src/pipeline/stages/verify.ts

@@ -11,6 +11,7 @@
 
 import type { SmartTestRunnerConfig } from "../../config/types";
 import { getLogger } from "../../logger";
+import { logTestOutput } from "../../utils/log-test-output";
 import { detectRuntimeCrash } from "../../verification/crash-detector";
 import type { VerifyStatus } from "../../verification/orchestrator-types";
 import { regression } from "../../verification/runners";
@@ -173,16 +174,10 @@ export const verifyStage: PipelineStage = {
         });
       }
 
-      // Log first few lines of output for context
-      // BUG-037: Changed from .slice(0, 10) to .slice(-20) to show failures, not prechecks
-      if (result.output && result.status !== "TIMEOUT") {
-        const outputLines = result.output.split("\n").slice(-20);
-        if (outputLines.length > 0) {
-          logger.debug("verify", "Test output preview", {
-            storyId: ctx.story.id,
-            output: outputLines.join("\n"),
-          });
-        }
+      // Log tail of output at debug level for context (ENH-001)
+      // BUG-037: Use .slice(-20) to show failures, not prechecks
+      if (result.status !== "TIMEOUT") {
+        logTestOutput(logger, "verify", result.output, { storyId: ctx.story.id });
       }
 
       return {

package/src/precheck/checks-agents.ts

@@ -5,7 +5,7 @@
  * and checks health status for each configured agent.
  */
 
-import { getAgentVersions } from "../agents/version-detection";
+import { getAgentVersions } from "../agents/shared/version-detection";
 import type { Check } from "./types";
 
 /**

package/src/utils/log-test-output.ts

@@ -0,0 +1,25 @@
+import type { Logger } from "../logger";
+
+/**
+ * Log test output consistently across all pipeline stages.
+ *
+ * Summary (exitCode, storyId) is logged at the caller's level (error/warn).
+ * Raw output is logged at debug level only — last `tailLines` lines.
+ *
+ * `storyId` is optional: works for per-story verify/acceptance AND for
+ * deferred runs (deferred acceptance, deferred regression) with no story context.
+ */
+export function logTestOutput(
+  logger: Logger | null | undefined,
+  stage: string,
+  output: string | undefined,
+  opts: { storyId?: string; tailLines?: number } = {},
+): void {
+  if (!logger || !output) return;
+  const tailLines = opts.tailLines ?? 20;
+  const lines = output.split("\n").slice(-tailLines).join("\n");
+  logger.debug(stage, "Test output (tail)", {
+    ...(opts.storyId !== undefined && { storyId: opts.storyId }),
+    output: lines,
+  });
+}