@nathapp/nax 0.34.0 → 0.35.0

package/src/tdd/rectification-gate.ts

@@ -162,6 +162,24 @@ async function runRectificationLoop(
       await cleanupProcessTree(rectifyResult.pid);
     }
 
+    if (rectifyResult.success) {
+      logger.info("tdd", "Rectification agent session complete", {
+        storyId: story.id,
+        attempt: rectificationState.attempt,
+        cost: rectifyResult.estimatedCost,
+      });
+    } else {
+      logger.warn("tdd", "Rectification agent session failed", {
+        storyId: story.id,
+        attempt: rectificationState.attempt,
+        exitCode: rectifyResult.exitCode,
+      });
+    }
+
+    // BUG-063: Auto-commit after rectification agent — prevents uncommitted changes
+    // from leaking into verifier/review stages. Same pattern as session-runner.ts.
+    await autoCommitIfDirty(workdir, "rectification", story.id, logger);
+
     const rectifyIsolation = lite ? undefined : await verifyImplementerIsolation(workdir, rectifyBeforeRef);
 
     if (rectifyIsolation && !rectifyIsolation.passed) {
@@ -191,6 +209,12 @@ async function runRectificationLoop(
       testSummary.failed = newTestSummary.failed;
       testSummary.passed = newTestSummary.passed;
     }
+
+    logger.warn("tdd", "Full suite still failing after rectification attempt", {
+      storyId: story.id,
+      attempt: rectificationState.attempt,
+      remainingFailures: rectificationState.currentFailures,
+    });
   }
 
   const finalFullSuite = await executeWithTimeout(testCmd, fullSuiteTimeout, undefined, { cwd: workdir });
@@ -207,3 +231,47 @@ async function runRectificationLoop(
   logger.info("tdd", "Full suite gate passed", { storyId: story.id });
   return true;
 }
+
+/**
+ * BUG-063: Auto-commit safety net for rectification agent sessions.
+ *
+ * Rectification runs agent.run() directly (not via runTddSession), so it
+ * needs its own auto-commit. Without this, uncommitted changes from
+ * rectification leak into verifier/review stages causing spurious failures.
+ */
+async function autoCommitIfDirty(
+  workdir: string,
+  role: string,
+  storyId: string,
+  logger: ReturnType<typeof getLogger>,
+): Promise<void> {
+  try {
+    const statusProc = Bun.spawn(["git", "status", "--porcelain"], {
+      cwd: workdir,
+      stdout: "pipe",
+      stderr: "pipe",
+    });
+    const statusOutput = await new Response(statusProc.stdout).text();
+    await statusProc.exited;
+
+    if (!statusOutput.trim()) return;
+
+    logger.warn("tdd", `Agent did not commit after ${role} session — auto-committing`, {
+      role,
+      storyId,
+      dirtyFiles: statusOutput.trim().split("\n").length,
+    });
+
+    const addProc = Bun.spawn(["git", "add", "-A"], { cwd: workdir, stdout: "pipe", stderr: "pipe" });
+    await addProc.exited;
+
+    const commitProc = Bun.spawn(["git", "commit", "-m", `chore(${storyId}): auto-commit after ${role} session`], {
+      cwd: workdir,
+      stdout: "pipe",
+      stderr: "pipe",
+    });
+    await commitProc.exited;
+  } catch {
+    // Silently ignore — auto-commit is best-effort
+  }
+}

package/src/tdd/session-runner.ts

@@ -129,6 +129,22 @@ export async function runTddSession(
     await cleanupProcessTree(result.pid);
   }
 
+  if (result.success) {
+    logger.info("tdd", `Session complete: ${role}`, {
+      role,
+      storyId: story.id,
+      durationMs: Date.now() - startTime,
+      cost: result.estimatedCost,
+    });
+  } else {
+    logger.warn("tdd", `Session failed: ${role}`, {
+      role,
+      storyId: story.id,
+      durationMs: Date.now() - startTime,
+      exitCode: result.exitCode,
+    });
+  }
+
   // BUG-058: Auto-commit if agent left uncommitted changes
   await autoCommitIfDirty(workdir, role, story.id);
 

package/src/tdd/verdict.ts

@@ -153,6 +153,7 @@ export async function readVerdict(workdir: string): Promise<VerifierVerdict | nu
     if (!isValidVerdict(parsed)) {
       logger.warn("tdd", "Verifier verdict file missing required fields — ignoring", {
         path: verdictPath,
+        content: JSON.stringify(parsed).slice(0, 500),
       });
       return null;
     }

package/src/verification/rectification-loop.ts

@@ -78,10 +78,17 @@ export async function runRectificationLoop(opts: RectificationLoopOptions): Prom
       dangerouslySkipPermissions: config.execution.dangerouslySkipPermissions,
     });
 
-    if (!agentResult.success) {
+    if (agentResult.success) {
+      logger?.info("rectification", `Agent ${label} session complete`, {
+        storyId: story.id,
+        attempt: rectificationState.attempt,
+        cost: agentResult.estimatedCost,
+      });
+    } else {
       logger?.warn("rectification", `Agent ${label} session failed`, {
         storyId: story.id,
         attempt: rectificationState.attempt,
+        exitCode: agentResult.exitCode,
       });
     }
 
@@ -116,6 +123,12 @@ export async function runRectificationLoop(opts: RectificationLoopOptions): Prom
       testSummary.failed = newTestSummary.failed;
       testSummary.passed = newTestSummary.passed;
     }
+
+    logger?.warn("rectification", `${label} still failing after attempt`, {
+      storyId: story.id,
+      attempt: rectificationState.attempt,
+      remainingFailures: rectificationState.currentFailures,
+    });
   }
 
   if (rectificationState.attempt >= rectificationConfig.maxRetries) {